dimgray is #696969
--gray-light-txt-color is #696969
now it use the value and can be themed
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ia4ce421aad99a2b9b45c7fce0a43b4d0b72d3a69
Instead of requiring that information in the query string of the loleaflet.html URL.
Change-Id: I8c41e87c7f561561adeb03ec34ce0c19fe9d7fa5
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Make it contain a proper empty JSON array if no trace objects have
been written to it.
Change-Id: Ided1992a822659561a909ac545536261b91adbac
Signed-off-by: Tor Lillqvist <tml@collabora.com>
It enables turning Trace Event recording on (and off again). The
option is passed down to the client through loleaflet.html, and to the
KIT processes. If the option is not used, the new JS functions that
send trace events to the server turn into no-ops to avoid wasting
bandwidth.
It is always on in a "make run".
Change-Id: Iafe1919ccba7c376137d3e0568b857e20780bbc8
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Fix a single line layout of small icons in the help tab
by promoting those buttons to bigtoolitem.
- Hopefully this change makes it easier to scan and detect
those actions, specially:
- Online Help
- Report an Issue
This change also improves the space efficient, giving more room
for upcoming buttons
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic9a709e4c36d2e42a95466f9f0899399142789ad
The activate() function assumes that the document
is loaded when the socket is connected.
This is not true until a status message arrives,
then a document layer is created.
If the document has an interactive dialog (i.e. Macro Warning)
the document formally is not loaded and it should not send
messages that will receive "nodocloaded error".
Change-Id: I01ceb156376712234ab4c12226d080446aa9279d
Signed-off-by: Henry Castro <hcastro@collabora.com>
It happens when reconnecting, a Macro Warning dialog is opened,
but the document is not loaded yet.
Change-Id: If98cf4d68ac8ef71d7c0ad3d8aa5151a77adbe4b
Signed-off-by: Henry Castro <hcastro@collabora.com>
because it is tunneled now as drawing on the canvas
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I76c7d218abf155b2bd835d9f74b46d02e2808bbc
wsd/ClientSession.cpp:411:31: error: object backing the pointer will be destroyed at the end of the full-expression [-Werror,-Wdangling-gsl]
const char* str = tokens[2].data();
^~~~~~~~~
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I67e4aa5f61e049ad13663dc1e11ae2bd67399bea
Center align tab titles (vertically) with display:flex
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Iaf876e786e8bc24dc6c03c412d12dc5e4700119c
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Kit initialization uses 'trace' for very early start, and then
switches to the configured trace level later on, so don't use
it this early.
Change-Id: I8e0333930b46e5ad25658d7eda12d7469bdfdd1e
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
We need a space after the prefix here to get past the
getForwardToken detection in the core; \n doesn't cut it.
Change-Id: I3f125d47586964ff844f0a89b04b8de866d01f8b
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
when two or more tests share the same document one or both the test are failing
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I638a76f8f98eff019a298bcafcbe89155442bcde
Add a function emitInstantTraceEvent() to leaflet that sends an
"Instant" Trace Event to the server for logging.
Add a function createAsyncTraceEvent() that creates an object that
records the timestamp of its creation and sends the 'b' event to the
server for logging, and when you call finish() on the object, sends
the corresponding 'e' event.
Finally, add a function createCompleteTraceEvent() that creates an
object for a "Complete" Trace Event that includes the end timestamp
*and* the duration. The event is sent to the server when you call
finish() on the object.
Loleaflet sends timestamps in the above messages from
performance.now(). To enable the server to turn those into absolute
timestamps, the loolclient message is amended to include the current
Date.now() and performance.now() values.
Note that the intent is that when generating Trace Event logs, the
server and the web browser run on the same machine, so there is no
wall-clock synchronisation issues between server and client.
Change-Id: Ie9e68b093b769cc942e1e1d17083febeb07ccf5e
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Also avoid generating abbreviations in various message handling loops
unless debugging is enabled.
Change-Id: I22f4929b0bfd4da36917db6882bb2f5f5be02780
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Avoiding default values for parameters makes the code easier to read.
Especially true for bool parameters. But sure, just a question of
taste.
Change-Id: I473f70bdfafe3a9ccfb325def8760d78fee7e9a6
Signed-off-by: Tor Lillqvist <tml@collabora.com>
problem:
every time running cypress test would change the properties,
in alphabetic order
this will make sure to avoid unintentional changes
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Id7b955ad2154ec6393a4cb9d115f369db25b5008
text, spreadsheet and presentation use branding colors
with this PR also drawing use the branding color
compare to yellow1 drawing use yellow0 for better contrast
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ie3e3862bdc868c060d631b677ebe014adbc76a38
As the notebookbar height was shrinked, the ScrollButton has to be shrinked also.
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I6d195a10d98e57ec43d74f58d3bb13ed33b7b62f
Thesaurus was removed from calc and impress/draw see issue #2129
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: If440bdf2c61aaac22811706cc440b9ccbe7a30d1
93bc5f6083 introduced a regression
in the Classic mode.
- Better target ui-combobox
- Use notebookbar class
- Simplify CSS declaration
Fixes: https://github.com/CollaboraOnline/online/issues/2088
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0ab1dee8a29408c58621297ba8eefc18db3c4fa9
- Fix problem introduced with d0253673a6
- Desktop was always without close button
- Add mobile specific class
- So we can style it apart from desktop
- So we can style it apart from mobile(other dialogs)
- Mobile: fix padding (remove for child element)
- So we can use more efficient the horizontal space
- Mobile: Dismiss button
- Make it full width
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Icb6a5a0a4191b39ecf76eaafac06e182430490d0
When toggling tile debugging in the Help>About, toggle Trace Event
recordning, too. Add a comment with an example of how to turn on
SAL_LOG overriding at the same place.
The following new messages from client to server are introduced:
traceeventrecording <start/stop>
Starts or stops comphelper::TraceEvent recording.
sallogoverride <string>
Overrides the SAL_LOG value, or stops overriding if no parameter
or parameter is "default".
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I8b56c28cd99d39115cd796c44e5051d934d21a1f
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Perhaps we should use the exact same code in both core and online? But
that would be a bit tedious as core needs to be cross-platform (and
thus we use things like osl_getSystemTime and osl_getProcessInfo in
its version) while online is Linux-only.
Also imporve the test for it.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I0bc9dca71dc4489bd1671e0dae1e582990a8f8b4
Compiled but not yet used.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I3b85696ca6076e42d16e710b49bfd37bac342ec8
Signed-off-by: Tor Lillqvist <tml@collabora.com>
It is (for now) produced (by the ProfileZone things in core) whenever
logging level is "trace". The Event Trace file pathname can be given
in the loolesd.xml file or on the loolwsd command line.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I6d5829121e71460a4600ee94d2ebf51043c8893f
with #2235 and the fix of the home tab height it's now possible to reduce the notebookbar height to 72px in height instead of 84px.
Sure there would be 68 px theoretical possible, but the additional 4px in height are good for the home tab.
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Id28bcc63db142d235986cb5449d750808b684c4f
- Use something more specific to documentation, instead of product icon
- Fixes#2172
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idace492f776a635398c704c8ab78e13a6ceefede
