This fixes the initial blink of the dropdown with '0' in there and
considerably simplifies the code.
Change-Id: Id2ca81ba4c06f417ae102f1ce60cae767e1c62cf
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91206
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
The avoidance of the busy loop also avoided setting the events; so the
list of users was always showing 0 because it never got the add/remove
events.
Change-Id: I397f30ceb6f0ab305fc01b9ef1183925f30d529d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91154
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
When the WOPI does not contain the HideUserList, or when there is no
WOPI involved, we should show the list.
Makes the condititon slightly more readable too I hope.
Change-Id: I801df07e6bcae9362c36182ac88e503fbcd29513
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91153
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
"+" button for adding sheets aligned
sheets name aligned to center
Change-Id: Ie180ba668172ed4853bc43e49a1c143c56ef80ad
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89607
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Avoids needing to wait for a notification - if it ever comes.
Change-Id: I3d7118fa4682ebfe908dee11cdd123aafc68bd89
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91150
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
If you don't want protocol logging by default in debugging builds
then either poke loolwsd.xml:
<protocol type="bool" descr="Enable minimal client-site JS protocol logging from the start">false</protocol>
Or - configure with --disable-debug and --disable-debug-protocol.
Also remove redundant and unused co-ordinate parameters to the
message queue, and logging.
Change-Id: I489e32ef4758a6f0ef35c8d8d322a402a3e268e6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91096
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
cypress test framework has a problem with some
specific hashes (for example: 769e98018) and it
do not pass these values to the test code, which
make all test fail with 404 error.
Change-Id: I385b1621de25fdf90e6169bdff25eaf3c18cf81e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91101
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
On some platforms like Raspbian Buster, loolwsd need to be linked to the atomic helper library.
Change-Id: I0a8b921d85d499040b2e65d480116cbcb14b5089
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91102
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
While the original this.options was undefined, replacing it causes
a regression.
This commit partially reverts e82878d45b.
Change-Id: I92a4338ca3bb04ed1e36664b2eaed4b7a23c7183
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91097
Tested-by: Aron Budea <aron.budea@collabora.com>
Reviewed-by: Aron Budea <aron.budea@collabora.com>
If we show the mobilw wizard instantly after the mobile
wizard toolbar button is pushed, then mobile wizard will
be an empty bottom panel with an undefined content. It's
better to show the content, only after we get the
sidebar content from core.
For example, if the hamburger menu was displayed in the
bottom panel previously then we will see a white screen
first when we push the mobile wizard toolbar button. This
white screen is the background layout of the mobile wizard.
It looks wierd and also makes testing hard since we have
some wierd dummy HTML structures.
Change-Id: I852bce1ca1460b2210229bec294a249a47523099
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91062
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Add checking up the stack to detect when we have clean queues
and buffers so we can exit fast.
Change-Id: I82c3843f816bbe869094c21f070774e6d034ac65
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90358
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Not deleting each other's jails mails all the difference.
For now parallelize in smaller groups; some of the tests are
quite heavy resource-wise.
Change-Id: I04e5cdf66ba20cbd4f9f05b9d630141814eb3801
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90982
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
they were currently opening tunneled dialogs. Some if not all already have icon so if in the future we can enable this via mobilewizard the icon should fall right into place.
Change-Id: I3badd8dcb850add6e5969a7cc38d6dc72250872e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91060
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
No idea why they were in Control.Toolbar.js.
Change-Id: I18ab812317b4bfb71d0c63a4cb2283d4fbaa3b54
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91087
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
This fixes an odd focus-stealing bug that resulted
in the text being typed backward (characters were
added towards the left).
To reproduce, select a cell with text, click into
the Formula-Bar. Immediately the focus is stolen
by the document (the cell), which is annoying.
Next, if the cursor is actually inserted in the
middle of the text, new characters are added to
the left of the cursor!
After fixing the above issues, it turned out
that simply moving the mouse into the document
stole the focus from the Formula-Bar (actually,
the Formula-Bar lost the focus but the document
doesn't get it).
A related change is that the mouse-leave logic
for the sidebar should not be applied to other
dialogs, so now we only handle that event for
the sidebar.
Change-Id: I8ed3f6b08e99e9379e1bfe51f34f5d2f6ed22483
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91085
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
The git hashes now show up in the Settings app, without having to run
the Collabora Office app, open a document, and check the About dialog.
The core git hash is taken from the core build directory's
instdir/program/setuprc.
Also, drop the fairly pointless lone Finnish localisation of the
Settings strings.
Change-Id: I56631f8facde017ed99038209c55f516386eab99
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91073
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
The less special-case code/logic/UI, the better the world is.
It had weird unintended side effects anyway. (In the iOS app, which
was the only place where it was used.) For instance, in a spreadsheet
document on iPhone, after loading the document, the normal "mobile
wizard" style context menu did not appear, no matter how long you
pressed a selected cell. But if you first got the context toolbar to
show up once, and after that selected some cell and long-pressed it,
the mobile wizard style context menu did appear, just as when using
web-based Online on the same device.
Note that despite that the code in Control.ContextToolbar.js was used
only in the iOS app (L.control.contextToolbar() was called only if
window.ThisIsTheiOSApp), the file did contain code for non-iOS, too.
Change-Id: Icdbfc7e71f77539c1bcb5ac8cf6984375297a4bd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91055
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
The commit in question breaks clicking into the Formula-Bar.
With that commit, the Formula-Bar doesn't take focus upon clicking
most of the time, and only rarely does so (possibly depending on
the precise location of the click).
This reverts commit b906c6985a.
Change-Id: I2ff6b531b479c265935cbc44af4d2cbbaa7c418b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91050
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
I suggest we introduce this convention for such assertions.
Feel free to modify the message syntax. The idea is that if you notice
some code block you think will never be executed, add a comment and a
console.log with a message in this syntax. If somebody then later sees
that logging appear after all, they can add/modify a comment describing
what is actually going on.
Change-Id: I76302e414d78912b6d20ba149c69d00d995613c6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91048
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
This is to facilitate searching for a formula,
which is shown as a list via the Mobile Wizard.
Change-Id: If4ae2dfbce1c9cf153354d1c3a2ff7a8f4af3ea2
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91020
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
We only need to expose a couple of helpers
to test the keyboard and clipboard, which
are not possible to test via the UI.
This patch reduces the surface area of
exposed code to testing, to avoid misuse.
The only needed helpers should be made
available, and they are read-only functions,
so there is no risk of changing the internal
state from test code.
Change-Id: Id4a1800e3d3b9364754a18fb11f61df612e56490
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90991
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
This logging just made it harder to see any temporary logging you add
while debugging a problem. When you need the socket traffix logging,
it is trivial to un-comment these two logging calls again.
Change-Id: Ia8fde2c7b841f6b112784cb1c2618a35fddc0f8e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91003
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
menu is open and the quarter circle became a ellipse. Fix for these.
Change-Id: I0e31f702bc006c2e87705d1d63e3fa939270d5ca
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90923
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
They weren't even used consistenly instead of the literals 'INCOMING'
and 'OUTGOING'.
Change-Id: I70da22df669f8eaa5943b460e5b12b3cf100ca8e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91002
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I37b2ca41824e8d0aed7ff03cddb32b1c4ce2949f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90981
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Don't bother with different local names for the window.mode.isMobile()
etc functions. Don't bother storing return values from then in local
variables.
Change-Id: I0bb5b57683ab8007ebb30f8d37213489dcdbdd6b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90977
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
This will turn into the HYPERLINK message and make it work to click
them in the mobile apps, too.
Change-Id: Ibf1829a16887db2a6797c08996bd52882b54a657
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90935
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
LOOLWebSocket is used only for tests and a few tools anyway.
Change-Id: I18e04efc2fb3a4cc075f7cefa4ebd0d10fbdb3df
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90974
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Potentially cleaning up jails used by other WSD's breaks parallel
unit testing quite badly.
Change-Id: I159b87cc36648beb40eea0e363f924eefdf6ebca
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90942
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
