The other code in this function carefully checks before indexing the
tokens vexctor. We have already stored the integer from tokens[1] (if
it exists) in winId. So use that in one more place instead of
tokens[1] for consistency.
Change-Id: I2bc09b3e44e0549a94469d7569f724df17a113b3
Signed-off-by: Tor Lillqvist <tml@collabora.com>
we first create it without any content so foce the correct size
to correctly calculate position
Change-Id: I08d6a4c8ec42d5515ddd11cec508cb222d4c6ec8
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
This implements HTTP/1.1 per RFC 7230, partially.
Unit-tests are provided with documentation on usage.
This is desgined to serve as the http implementation
throughout loolwsd, for both synchronous and
asynchronous requests.
Change-Id: Iaf1b8c5fcb8cec032445e27c9f70d2fb807aa4dc
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Change-Id: If97eb79bd697fe2e2b9cb86cbc1643e5890bf626
Signed-off-by: mert <mert.tumer@collabora.com>
Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
We restrict insert/delete/duplicate page (slide) only to
presentations, but they also work the in the same way for
drawings. This changes the restrictions to also take drawings
into account for this actions.
Change-Id: Ia9a3627d2144a6813f341ab8a8287743abad475a
Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Currently the presentation and drawing menu entries use the same
definition, but as drawings are different with different terms,
it is best to separate the presentation and drawing entires
instead of handling the exceptions all the time.
Change-Id: I078eb4ebb5014a04614d20363042b3cd75e9a36d
Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Separate the toolbar from presentation and remove icons that are
valid for presentation only.
Change-Id: I0dd74f396326b838c9a65352978a771bdb5da13d
Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
It fixes a hang related to retries. It might be useful
in our case too. I've seen hangs on Jenkins, which might be
related.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I8320f9b38c59074d2b5dd3d7b0cad0c5828b0849
It crashes if the mobile wizard is closed before exiting
chart editing mode.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I47143543220aaebf474e1d1aa560c7df2c2a14f5
This method needs to be called with having the correct view activated.
It caused a crash in writer/simultaneous_typing multi-user cypress test.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I57dd58a635ce7ea127200a6a3f0cadc8c0861aaf
Crash trace:
at NewClass.getViewColor (/src/map/Map.js:702:33)
at NewClass._onUpdateCellViewCursor (/src/layer/tile/TileLayer.js:1466:55)
at NewClass._onCellViewCursorMsg (/src/layer/tile/TileLayer.js:1450:8)
at NewClass._onMessage (/src/layer/tile/TileLayer.js:710:9)
at NewClass._onMessage (/src/layer/tile/CalcTileLayer.js:394:37)
at NewClass._onMessage (/src/core/Socket.js:916:24)
Caught by calc/sheet_operations multi-user test.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I56b686e8d9f27a407f1fef54808e4f65c99173f0
With chrome tests sometimes fail on starting
the chrome binary.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Id5c6af71efad8622b3885b8904f2ef3ede82d631
We are drawing things from different files onto the same canvas.
CanvasSectionContainer is organising them. When they are too many, it is difficult to know about sections' important properties.
CanvasSectionProps keeps sections maintainable.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I9e81104c30f30a47c02625ce9d6716a98958317c
Bugs related to ordering of sections are fixed.
addSection and createSection functions are separated.
contextMenu event is added.
Sections' drawing orders are updated for future uses.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I89127c97ad7b7dac4b293c4108c44cb6c4427134
by resetting the isLocated flag for each section.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I0ad41f20219afd8b90050bd43223843ca280587d
Sections which are not yet expanded via locateSections() can interfere
with the hitLeft() and hitTop() for sections of same z-index depending
on order of addition. So lets skip the sections for computing hitLeft()
and hitTop(). This also avoids redoing locateSections() for all sections
everytime a new section is added.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I7595f5b5cfaa61d8fcfe177edd4c605d3fb7b122
when there are no freeze-panes active.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: Id5b651d4b1e76cd14b725d125f813d93ed031ff8
I don't recall if simply ifdeffing is the proper way to bypass UnitKit
stuff (that I don't understand) for the mobile apps, but at least it
helps.
Signed-off-by: Tor Lillqvist <tml@iki.fi>
Change-Id: I85d477e4ee7d11c597d95a9b0b42af7e5f7ad122
We had an issue with loading two views to the same document
at the same time.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I8b1ba92eca5e59bfa50cbcd637f1076d5e15c664
