Commit graph

6368 commits

Author SHA1 Message Date
Ashod Nakashian
7c2c0062e3 wsd: always avoid saving readonly files
Otherwise saving is bound to fail, causing other
errors, which is nonsensical since there is nothing
to save to begin with.

Change-Id: Icb65a4a3b277b3175aadbe5107b294b24a399e7b
Reviewed-on: https://gerrit.libreoffice.org/50148
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2018-02-23 16:55:02 +01:00
Ashod Nakashian
5befd0803a wsd: improved wopi info parsing
Better logging during wopi info parsing,
especially upon failures.
Refactored the code from Storage.cpp into
JsonUtil.hpp.
Minor optimizations.

Add unit-tests for the parsing logic.

Change-Id: Ifebc3f6b7030a6c7b3b399786633f6b5e8737478
Reviewed-on: https://gerrit.libreoffice.org/49927
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2018-02-23 16:54:39 +01:00
Ashod Nakashian
71f4597059 wsd: WebSocket state is a property of the socket
This resolves the erroneous warnings of pinging
on a non-upgraded (i.e. HTTP) socket.

This was due to the fact that we moved the socket
from one SocketHandlerInterface to a WebSocketHandler
after upgrading and since the WSState was a property
of the handler, the WebSocketHandler didn't know
that the socket had already been upgraded.

Also other cosmetics and cleanups.

Change-Id: I1a88edef750117ed551d23245e49380371561422
Reviewed-on: https://gerrit.libreoffice.org/49911
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2018-02-23 16:42:22 +01:00
Samuel Mehrbrodt
224660a0ba Add launch URIs for Calc and Impress too (for debug builds)
Change-Id: I66ea097c7f8d0ea72a74ecb62abbdf63e50f3058
Reviewed-on: https://gerrit.libreoffice.org/50190
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-23 09:57:59 +01:00
Samuel Mehrbrodt
543cec6546 Add example documents for Impress and Calc
Change-Id: I54980b7224f2fab6883720c58c6aa377b0ec9339
Reviewed-on: https://gerrit.libreoffice.org/50189
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-23 09:57:49 +01:00
Samuel Mehrbrodt
cabe0a750a Only show warning if limit is exceeded
not when it is reached

Change-Id: I802f839e49f4c8ed9e423b093e7306b5480a1812
Reviewed-on: https://gerrit.libreoffice.org/50188
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-23 09:17:12 +01:00
Samuel Mehrbrodt
5176d9d4c0 Notify new user too about low disk / limit reached
Change-Id: I150baaa5cf2b1162505324102afc038fd19b3bb6
Reviewed-on: https://gerrit.libreoffice.org/50186
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-23 09:17:04 +01:00
Samuel Mehrbrodt
37e7e95304 NPM Shrinkwrap: Upgrade to new format (v5)
Should be backwards compatible with npm 2,3 and 4

Change-Id: Ie40f39af4b6fb618916df33d9cdd2fc62e4bc592
Reviewed-on: https://gerrit.libreoffice.org/50191
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2018-02-22 16:51:03 +01:00
Samuel Mehrbrodt
08ee839562 Improve message displayed when limit reached
Change-Id: I659d3e5156bc4ae8e6b30a7fd9f9957dd1a868ec
Reviewed-on: https://gerrit.libreoffice.org/50179
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2018-02-22 16:37:42 +01:00
Samuel Mehrbrodt
deecd0e0d8 Add some right margin for info msgs
Change-Id: I037b8dd42fa8dafb1686284e9241a32f4068ff75
Reviewed-on: https://gerrit.libreoffice.org/50185
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-22 15:46:33 +01:00
Samuel Mehrbrodt
4c9872188f Add non-obtrusive notification method (infobar-alike)
This reuses the vex dialogs and pushes notifications to the bottom right area.
Converted the limit reached notification to this new type.

Change-Id: I20f0c1202eecde028e70156f02ba31497ef2f9b9
2018-02-22 14:28:09 +01:00
Samuel Mehrbrodt
542c87451c Improve about dialog
Don't wrap other block elements in <p>, some cleanups

Change-Id: I42fcff615cb5e67d413b065aa72cce5d42aa19c9
Reviewed-on: https://gerrit.libreoffice.org/50161
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-22 11:22:27 +01:00
Samuel Mehrbrodt
96292dc873 Only apply hard limit when configured with support key
In other case, show the warning to all users (instead of just the last one)
and link to our get professional help page.

Change-Id: Id443ba6427acd4c05f7e0e2ce86025acfb553265
Reviewed-on: https://gerrit.libreoffice.org/49673
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2018-02-22 11:14:34 +01:00
Andras Timar
239d5a09a3 remove src/control/Control.MetricInput.js from list of localizable files, because it was deleted
Change-Id: I1583c81aef924c7f61b6b1722666c5fd1137e418
2018-02-21 23:07:52 +01:00
Pranav Kant
fc4d6aeeb9 ime: Don't eat space
Encode/decode so that ' ' as payload of compositionupdate event doesn't
get lost.

Change-Id: Ia31abe85f1cf19f8f286c9069097bdc72297e664
2018-02-21 21:29:50 +05:30
Pranav Kant
12612d459b Let's not use any personal names
Change-Id: If25e0e93906008b8e04cfde9b77c9c78247643e1
2018-02-21 20:09:38 +05:30
Andras Timar
209e34a155 loleaflet: add Tools - AutoCorrect - While Typing toggle menu item to Writer
Change-Id: Id5dfb0b99834beddd927d67167f3be5a417e138f
Reviewed-on: https://gerrit.libreoffice.org/50069
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-21 08:45:05 +01:00
Andras Timar
4adacbdaa6 remove deleted robots.txt from rpm spec file
Change-Id: Ic1d872f2e92dee64ef23d012b4cd50ad2931664a
2018-02-21 00:01:23 +01:00
Pranav Kant
77a8f5b2e7 Fix double handling of ctrl key
Regressed from 1e91799663

Thanks Aron for bisecting.

Change-Id: Ida2a62d74440083e747903562a0c9e6a5a550eb1
2018-02-20 12:45:46 +05:30
Henry Castro
c0119f51ad loleaflet: transfer to clipboard if the range of html is selected
Change-Id: I6e804dcd3114596fb0041943b53cf00442af428d
2018-02-19 15:46:41 -04:00
Henry Castro
64e6cf189c loleaflet: remove MetricInput dialog
Change-Id: I64dbd732caac575cc15e0b0b1fb5762c2678fe76
2018-02-19 15:17:13 -04:00
Marco Cecchetti
3b3197e477 calc: header entry border was not shown at certain zoom levels
Change-Id: I531ad3a06e208fcafa4ca8243e2b54fffcd8449e
Reviewed-on: https://gerrit.libreoffice.org/49975
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-19 20:00:11 +01:00
Andras Timar
82ff8db904 tdf#113361 Add Insert - (Hyper)Link menu to Impress
Change-Id: I28914507c4604398524b0fea98af9bca818e9834
Reviewed-on: https://gerrit.libreoffice.org/49885
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-19 18:16:46 +01:00
Andras Timar
dde84d1706 wsd: encode '#' character in file name
Change-Id: I4d10f38c9025f18a0d0f0f5599892b436b9d002c
Reviewed-on: https://gerrit.libreoffice.org/49919
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-19 18:15:42 +01:00
Andras Timar
6a914ecbb9 tdf#115595 open editable documents with upper case or mixed case file extensions in edit mode
Change-Id: I6ea60926ce0ec4d1323080ffec5152d2bbeefc31
Reviewed-on: https://gerrit.libreoffice.org/49867
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-19 18:15:01 +01:00
Henry Castro
0cec977fcd loleaflet: add "Insert Fields" menu
Field
	Page Number
	Page Count
	Date
	Time
	Title
	Author
	Subject

Change-Id: I4360372312abab04c34411bdca317b59c93141c4
2018-02-16 10:32:38 -04:00
Andras Timar
0b382f879b Allow preload of nl dictionary by default
Change-Id: Id6410fa4febdd778f511e0bdcc4324ad0c2fdf43
2018-02-16 11:07:21 +01:00
Andras Timar
88ea0a56c7 loleaflet: Updated Slovenian translation
Change-Id: I51eb459a1f85b5be77fe8c74c069c370135bb5cd
2018-02-16 10:26:30 +01:00
Andras Timar
7e99607e31 loleaflet: updated UI pot file 2018-02-15 22:33:49 +01:00
Andras Timar
ba669bbe7f loleaflet: fix Insert Header and Footer menu 2018-02-15 22:00:07 +01:00
Andras Timar
8aa4a5145c wsd: handle request for robots.txt
Change-Id: Ib82db2ee8c878e6a61b62b49ceaeb72e2d05718d
Reviewed-on: https://gerrit.libreoffice.org/49819
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-15 15:45:09 +01:00
Pranav Kant
49bbe4367f Don't shift when hovering; increase input width
Change-Id: I454ecf9ac92ff7f80c97d4ff94fb9770ce5f1b64
2018-02-15 15:07:41 +05:30
Pranav Kant
11673e589d loleaflet: Hide items from correct toolbar
Change-Id: I3020f01d693ad2f99202f8a99a7efb9eadc25158
2018-02-15 15:07:41 +05:30
Andras Timar
68b17446a0 Updated LibreOfficeKit headers
Change-Id: I6da94250d81d1f62d8f2191660b37b960033f11c
2018-02-15 10:08:47 +01:00
Samuel Mehrbrodt
591a0b5fed Improve explanation for support key in configure
Change-Id: Ifd2fef9ff6b15e04e75bfecc478c3ac63efc84f5
Reviewed-on: https://gerrit.libreoffice.org/49672
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-15 09:16:18 +01:00
Aron Budea
1cfe416559 loleaflet: add download as RTF option
Change-Id: Id258461ff49bcc6d6a0b1e4df826c184e769c5e1
Reviewed-on: https://gerrit.libreoffice.org/49787
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2018-02-15 07:47:58 +01:00
Pranav Kant
c470116012 Fix some buttons doesn't show up in mobile mode
Change-Id: I25ceecc56e2dae9a0b31e038412c7b74447c391f
2018-02-15 11:55:40 +05:30
Pranav Kant
199b582e06 Use real input element for user input instead of canvas
This allows moving the IME candidate window according to where the
cursor in the lok dialog is.

Change-Id: Icf17f1fc1d3f6af619c8e0037c32109d2b4721fc
2018-02-14 23:50:51 +05:30
Pranav Kant
6d4f02ac2a Adapt to IME API changes; better reuse of Map's key handler
Change-Id: I670243ea155ac698c694531d3fc16a574f418bf4
2018-02-14 23:50:51 +05:30
Andras Timar
baa3e09bde Typo: remove -> remote
Change-Id: I6214f569d6a0302c5a5a69a18150122a371e0d03
2018-02-14 12:29:50 +01:00
Pranav Kant
98312d6a09 Fix space not working with IME
Change-Id: Ie84abacca1f387373e1b6feda3f7e2975f772392
2018-02-13 22:36:14 +05:30
Pranav Kant
463fc60440 loolconfig: set-raw-config -> set
Change-Id: I7821bcf7bf8a6b8247e824d18b1d9f29b8db8851
2018-02-13 12:33:01 +05:30
Ashod Nakashian
b834545e79 kit: makeRenderParams now static
Change-Id: I1c79991a73044a91ed9f8389e23ccffd8b2bcbce
Reviewed-on: https://gerrit.libreoffice.org/49572
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2018-02-11 22:17:02 +01:00
Ashod Nakashian
88619a323f wsd: reduce memory load only when the footprint changes
Update the network interval when updating the memory interval,
since we currently don't support changing the network interval.
Also make the default memory and network interval twice
that of the cpu interval explicitly.

Reduce logging noise a bit without losing information.

And some const-correctness and other cleanups.

Change-Id: I313fb2882675f560091e5113dbdcbdef269828e2
Reviewed-on: https://gerrit.libreoffice.org/49571
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2018-02-11 22:16:50 +01:00
Ashod Nakashian
2562d8919a ut: log the test name for easier traceability
Change-Id: Icbcbb36857b748c2ac2d0d36a5c4c23609f5453a
Reviewed-on: https://gerrit.libreoffice.org/49568
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2018-02-11 19:22:14 +01:00
Ashod Nakashian
7be98efd93 ut: log timestamp to track timeouts better
And improve the logging support in unit-tests to
help troubleshoot issues faster and more accurately.
Also makes the code more readable (hopefully).

Change-Id: I4f8aafb5245e2f774b03231591a74544f9ec84aa
Reviewed-on: https://gerrit.libreoffice.org/48645
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2018-02-11 19:21:15 +01:00
Ashod Nakashian
31130989ed ut: fix HTTPWSTest::testLoadTortureODP
Change-Id: Ibe3bd98c1cd68da962cc8d93b837597fb7167f45
Reviewed-on: https://gerrit.libreoffice.org/48644
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2018-02-11 19:18:38 +01:00
Henry Castro
341c9dcc96 loleaflet: copy text of the annotation element to clipboard
Change-Id: I8675b3752656afc1ba79d614d2f1fe3e7d98f600
2018-02-10 14:40:54 -04:00
Michael Meeks
d2f23dd8c2 Helpful error on non-matched WOPI host.
Change-Id: Ib752148be0acbf15cd8b737b71414313d05f6aca
2018-02-10 17:12:40 +01:00
Andras Timar
7f3e6e96b2 fix variable replacement in string
Change-Id: Id99f1e04c508678e0acfc040511e327910e04772
Reviewed-on: https://gerrit.libreoffice.org/49496
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-09 15:17:58 +01:00