Commit graph

712 commits

Author SHA1 Message Date
Darshan-upadhyay1110
7db8d225ff Add access-key functionality to open userlist.
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I7787aaa11e673f8701b9b94f85ce225c254e2ac6
2023-08-31 12:03:15 +03:00
Darshan-upadhyay1110
48007ccfe2 Fix: Mobile => insert list is misaligned #7137
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I6b82e30dc1a6a77c347963ec9d6e7cb81a86ee37
2023-08-31 14:26:06 +05:30
Rash419
f87230761d mobile-wizard: fix textarea remains white in darkmode
- also fixes the misalignment in cool-annotation-table

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I58db4c6918c3a36a230c6f9317ddf39c3361bb24
2023-08-31 14:20:53 +05:30
Pedro Pinto Silva
6ed9065bb5 Navigator: fix active element style on dark mode
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7f7e2d48eedf0f204acefadccb36764f553d65f5
2023-08-28 21:52:51 +02:00
Skyler Grey
2e07fcb1a3 Fix 'manage changes' dialog expanding infinitely
A regression in change ID I8551242fc2b987f00c67088caa0ed07ee8526a72
caused the manage changes dialog to continue expanding when new elements
were added, no matter how big it got. This would cause you to be unable
to see all the changes when there were a lot of them because you could
not scroll through the list. This patch fixes the scrolling, without
making the list area very small again.

Change-Id: Ib29fb161522773ea9893b7bc21d06aab19b74c52
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
2023-08-22 19:04:29 +02:00
Szymon Kłos
ac8440fea7 jsdialog: add minimal size for treeview
Without it in calc -> insert -> chart treeview
for chart type selection was invisible / 0px width

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iaf28c4860adcd00591a638fa10838fe8719bee23
2023-08-16 09:16:51 +02:00
Rash419
639068e3fe impress: remove unused mobile-slide-sorter
- to show previews we use slide-sorter element
  and presentation-controls-wrapper as container

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Iaed0892779d5016a565d556955305317129edea4
2023-08-16 11:29:54 +05:30
Shehr Bano
e6a06eae1c FIX #7037: JSDialog: label vs textarea vs input field inconsistent paddings
Signed-off-by: Shehr Bano <shehr.bano@collabora.com>
Change-Id: I53494733c47b35d59133979c456665b4174e393c
2023-08-11 12:15:19 +02:00
Shehr Bano
1428888afc Writer: Fix to issue #6977, extends vertical space of ui-treeview in Manage Changes
Signed-off-by: Shehr Bano <shehr.bano@collabora.com>
Change-Id: I8551242fc2b987f00c67088caa0ed07ee8526a72
2023-08-03 18:37:58 +02:00
Pedro Pinto Silva
218583ce22 Tablet: Hide document file name input field
The input field is already being hidden for mobile. For Tablet and
with the increased amount of UI elements on the top bar best to hide
it also. Renaming the document is a quite rare used action when
compared to any of the other top bar actions (switching tabs, open
sidebar etc). Better to hide the #document-name-input when on tablets
instead of trying to fit everything (and end up obstructing tabs for example)

Tablet user can always:
- Use the integration (already used to do many other file manipulations) to rename the file
- Use the in-app Save as can still be used to save a copy of the current
document with a different name

----

Possible future improvements would be to add the possibility to rename
the file when using a tablet:
- Add menu entry and tabbed view button
  - Control.Menubar.js something like {name: _('Rename Document'), id: 'renamedocumentbtn'}
  - Control.NotebookbarWriter.js add bigtoolitem Rename Document
- Maybe in Control.UIManager.js add a renameDocumentBtn function that
  - Creates a JSDialog with document-name-input element + Cancel btn +
  OK btn
  - Ideally that input element would re-use the functionality from L.control.documentNameInput() -> Control.DocumentNameInput.js

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I968e806a4a9e0018b38b87fc249a57e5af099c78
2023-08-01 09:26:35 +02:00
codewithvk
8b5df0c4b3 Fix : Menubutton should have disabled state styling different
Signed-off-by: codewithvk <vivekpatel7202@gmail.com>
Change-Id: I1cd97503e0d3ca4333b11552ca3571093cf10bfe
2023-07-27 12:25:26 +02:00
Darshan-upadhyay1110
2ac7183e44 Add Left or right arrow on a tab label should switch tabs
- accessibility key features
    - focus on tab when press `Alt`.
    - move back and forth tab focus by ArrowLeft and ArrowRight
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Id8c8e2a8bcb57c90e0762dd3916b851fff8e0a6f
2023-07-26 10:24:13 +02:00
Pedro Pinto Silva
5aa5703885 Fixes #6946 and all unstyled kbd elements
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I09583d7c27cffc0f5b9722de1925977089bf832b
2023-07-24 16:30:02 +02:00
Pedro Pinto Silva
0e22c2a744 refactor: Toolbar down icons: remove unnecessary !important rule
If we set the initial backgrounds without `!important` then there is
no need to use `!important` for dark-mode (since we are already using
a more specific targe via data-them attribute)

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I600629dfc0485edac6ff725f6278de1501e1c9a7
2023-07-19 16:02:12 +02:00
Pedro Pinto Silva
cfece73517 Don't add outline to ShowInfoModal that have no buttons
Large Clipboard  and document idle modals were being set with tabindex
0 allowing for manual user focus plus were being focused dynamically
for each instance:
    - Transfer all that (just once) to showinfomodal instead for the
    cases where we have buttons
        - This in turn sets the things to the parent (dialog itself)
	and not the subcontianer
        - Set tabIndex with negative value so, it only allows focus via
    code
    - This fixes the weird outline (focus) that sometimes would appear
    on sub containers of that dialog instances

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If40192e05c4b0e25e2ce71bc612ab64fc54a29ec
2023-07-18 17:32:10 +02:00
Darshan-upadhyay1110
fd630d427f Fix Spell checker js Dialog
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Idc0800eaa4ab751601bd34bba6c2e9cfef38de4d
2023-07-18 15:42:35 +02:00
Pedro Pinto Silva
7f2e5df037 Calc: fix document background. It should be white.
With c04c065edc we start to dynamically
set the canvas background. The problem is that for Calc cells do not
have intrinsically a background and thus what we end up to see as the
document background color is actually the canvas color.
	 - Make sure that when we are in presence of calc we set the
	 canvas color (clearColor) with the value coming from
	 documentBackgroundColor
	 - To make it clear: create a new CSS variable to be used as
	 background-document

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4c456e4aeea233609ee58684d967984dd8afd63a
2023-07-18 15:01:25 +02:00
Andreas-Kainz
b6c26bee91 Mobile sidebar header layout #6861
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
Change-Id: I8c10857b0ca7e166b5f9364db9ea2a01e5acfffa
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
2023-07-17 10:20:52 +02:00
Darshan-upadhyay1110
ddef0ef881 Fixed Spellcheck dialog size
Set Minimal width for suggestions list
Added some padding for spell check text box for more readability

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I0fa5bb60ece88e4107408448a17378b526020784
2023-07-14 14:32:22 +02:00
Andreas-Kainz
e90586a098 DarkMode border icons use dark fr0x icons #4592
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
Change-Id: Ia09efa8530e04f571af4b2e1e7599215746be2df
2023-07-12 11:20:44 +02:00
Andreas-Kainz
f84105072b DarkMode checkboxes will be themed
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
Change-Id: I0ffd594ba3e897a36c2caa8a5fe9aace9e04a63d
2023-07-12 10:06:00 +02:00
Szymon Kłos
9187ae99d7 Center IFrameDialog using CSS
instead of using hardcoded pixel distance...

affects eg. feedback dialog which was impossible to
access in very small windows due to position outside window

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I2a85defcd2aabf1bdb8ec88d70b6e6a873dec75f
2023-07-11 10:19:40 +02:00
Pranam Lashkari
f56694ef96 scroll: avoid selecting elements while dragging scroll bar
problem:
In safari and gnome web when you scroll using scroll bar,
DOM elements on the slidebar and documents would get selected

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I222d246148d5d84a5c0b3cfdb1890350f428e696
2023-07-10 23:48:00 +07:00
Pedro Pinto Silva
2948e5206e Gray out empty treeview
So user understands the component is empty.
We cannot add disabled attribute here because we have some cases such
as pivot table where the initial state is empty.

Note:
Ideally we would distinguish from static and dynamic
treeview (static=read only list VS dynamic=list you can remove and add
items). Only after this distinction we can properly add disabled
attribute to the static one

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ide4fb7589b5be611975de4a704b458bb626be0e0
2023-07-06 10:59:15 +02:00
Darshan-upadhyay1110
31bf98adb1 Fix odd looking textarea width.
Fixed hyper link textarea dialog box's width
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Ica7977c8d334bbb8bcb3bfd3c8aca8d4876c0571
2023-07-05 08:31:29 +02:00
Szymon Kłos
beb0a9689a Element #formulaInput no longer exists
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I72b16bfe0c3e25844c25e8297a428d7790b48ba0
2023-07-02 18:55:12 -04:00
Szymon Kłos
c94be3e5f8 formulabar: use IME with new contenteditable
It converts textarea into contenteditable div.
Input is handled by TextInput.js used for document
and already in the past for formulabar. Replaces
usage of keyevents which are not triggered with
eg. Japanese.

Fixes also #6737
Fixes on mobile #6767 requires: https://gerrit.libreoffice.org/c/core/+/153717

New widget consists of text layer with visible content
and cursor layer with selections and cursor. When clicked
it focuses TextInput.js field for typing.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ieb7cf148a5aba80ab790e0b53c3a5ba27f166b73
2023-07-02 18:55:12 -04:00
Szymon Kłos
3372ea093c color palette: add palette selector
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ie09715afbdbc50d783d6e50ce27dac2e2a06596a
2023-06-27 15:12:56 +02:00
Gökay Şatır
3e40f3fbe4 Add functionality for notebookbar accessibility keys.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I97476d05559444fe895cd6bf4e040f43350a6706
2023-06-23 20:06:35 +03:00
Pranam Lashkari
08a7a5b206 jsdialog: fixed dialog content being cut off
i.e: theme dialog(format->theme)

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I9a09d52cd2c0d95cfae18ae12995761985d8111d
2023-06-23 18:16:26 +02:00
Pedro Pinto Silva
378f96433a Dialog: don't ignore label's padding (ui-text)
Before this 8a0c8c44a7 was not being
applied furthermore better to specifically set this to only affect
labels within dialog content (since jsdialog class is also in many
other places such as sidebar and widgets)

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic1cb825d6c70858a4c49123243866eaf0a6a8e50
2023-06-23 12:56:55 +02:00
Pedro Pinto Silva
8a0c8c44a7 JSDialog: Add missing padding for ui-text labels
This way they:
- Align to checkbox
- And have additional padding in places such as Format > Paragraph
Line spacing 's dropdown is glued to "of" label

This also fixes one task from https://github.com/CollaboraOnline/online/issues/6647

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I53e66602dffbc96db39449cbda53d433a9dd12d8
2023-06-20 11:29:32 +02:00
codewithvk
3e287a5968 Fix: Annotations, comments on hover
Change-Id: I3a1e9473cabc9df2b33e3b99168f9698d1beb86c
Signed-off-by: codewithvk <vivekpatel7202@gmail.com>
2023-06-16 14:01:37 +02:00
Pranam Lashkari
1eb8b9c63f impress: arrange slide/hide show menu entries better
added slide hide/show option in presentation bar
rearranged icons to align them with core UI

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ic4b121ab5d9ab21d8f48e68bb07e51a31442586e
2023-06-16 10:48:54 +02:00
Pranam Lashkari
17b50868ea impress: introduce slide hiding/showing in presentation
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: If91726a1a66e1679b58603e496a5b90cde5f0b5b
2023-06-13 18:29:28 +07:00
Pedro Pinto Silva
f96db1526c Calc: border style popup: can't read "More..." btn
this width was set but never used w2ui img rules have been overriding it

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I86a7d8b16313204fcacdabcad8f604ca5c1dce40
2023-06-12 13:27:41 +02:00
Pedro Pinto Silva
7d0a312525 Calc: border style: icons, do not override bg img
Before, we needed this white background.
Now, we don't.
- After HTML and dialog rework the background is inherit from the
wui overlay and the images are set directly to the td elements using
bg img

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic6b802f4fd5bac66e975800b929c53ca571158dd
2023-06-12 13:27:41 +02:00
Pedro Pinto Silva
38f77dfc0c Snackbar: should not inherit generic modalpopup rules
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I200fc569b8d8c6492eb94b72b94d998b334b39db
2023-06-12 13:13:44 +02:00
Pedro Pinto Silva
64315f510a Don't apply duplicated border + shadow to all modalpopups
Better to make it more generic so it not only includes:
Busypopup: c26bed9
About dialog: bed76f1
but also any other similar dialog (warning dialogs, e.g.: copy/paste etc)

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If56e36d5429472f255d94bfaa087a32309903257
2023-06-12 13:13:44 +02:00
Pedro Pinto Silva
5cc813b453 Calc: conditional formatting: icons, do not override bg img
Before, we needed this white background.
Now, we don't.
  - After HTML and dialog rework the background is inherit from the
  wui overlay and the images are set directly to the td elements using
  bg img

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I30826e17c502b0369fd337699d93f648d41846aa
2023-06-12 13:09:25 +02:00
Darshan-upadhyay1110
ecb1d6fd0d 23.05: Dark Mode - Texts on Comments dialog on Dark mode is not visible during edit
Add color property for annotation-textarea to get correct font color in comment box.
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I74d5e83641982acc1b0b328c707c09d06d68c56d
2023-06-12 11:27:34 +02:00
Pedro Pinto Silva
53b94c7f0c Navigator: for now let's not communicate that is possible to drag
Since we have disable the functionality until it works as expected

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0a99680d79ffb44a653c32edb25aafded35c7712
2023-06-10 09:02:25 +02:00
Pedro Pinto Silva
c26bed969f Busypopup: don't inherit duplicated styles and fix label
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If37fb7cc924fc9d1b8bf1a86708d4382e9639f8f
2023-06-09 12:24:00 +02:00
Pedro Pinto Silva
bed92fccf7 Mobile: Fix busypopup label alignment
Tested using:
`map.fire('blockUI', {message: 'Saving document, please wait...'});`

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4e1bd87d512287fd346964a5b81a7b79df1ed78a
2023-06-09 12:24:00 +02:00
Pedro Pinto Silva
a3f4858f67 Mobile: popups should not have height: 100%;
Otherwise they (their contents) will not be scrollable

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idf121b6164dbb43a473e07e2ca70962bedb10ebb
2023-06-09 12:24:00 +02:00
Gülşah Köse
89ee7239ee Dark mode: make readable the links in About dialog
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I64bc99145943e98a6548d682917a120c0d8a33f4
2023-06-08 15:24:11 +02:00
Pedro Pinto Silva
45f400c7a5 Dark mode: add select state for buttons
Do not re-use light mode values.
Increase color contrast

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I514d4be5468dd3df50ab5256b64d0a22e659ad97
2023-06-08 14:44:50 +02:00
Pedro Pinto Silva
a1860a1463 Dark mode: lc_morebutton.svg: Increate container brightness
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6e371a9777215db482b89c05b07acdf06a15c44a
2023-06-08 13:53:57 +02:00
Pedro Pinto Silva
468ca99820 Navigator: Fix and improve the selected item
- Categories (listview with icon) get highlight but not indicator
  - So it's understandable that they can be dragged
- Categories: change cursor so user understands that they can be grabbed
- All other treeview (even exapandable) get highlight and indicator
  - To help user's orientation

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I8c275c81503787c60c4527a3cee63be8323686ef
2023-06-08 11:58:14 +02:00
Pedro Pinto Silva
09511d5116 Start navigator from the top
This is a follow up on the revert f4f95b2 since the scroll logic depends on the
absolute position

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I5659701c2236dc89f764f45008e6e92c47a3f101
2023-06-08 11:58:14 +02:00