Commit graph

14833 commits

Author SHA1 Message Date
Pedro Pinto Silva
7e12749e55 Text import (csv imports): add missing icon lc_fromrow
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0a82908c5ec3262fe1b0637389c90461a4a87c2b
2021-04-27 11:30:41 +02:00
Dennis Francis
991a5a14c7 fix: header draws with old size after resize + mousemove
Fix: clear the cached "entry" with old size after a drag has ended.

Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I73840e380dc808c5805588947d774984def288d0
2021-04-27 11:57:24 +05:30
Dennis Francis
46781aa313 avoid flicker of header resize handle on resize
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I5c3373fee44b21e40a3b5da7c554fb30b096a342
2021-04-27 11:57:24 +05:30
Dennis Francis
8f5ac693a7 fix: header resize line not updating on scroll
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: If10d884cb7b24289cb1e4c8e8996f526e6fe4cbe
2021-04-27 11:57:24 +05:30
Dennis Francis
1886c8984f gridsection: fix flicker on typing with freeze-panes
When the request is to paint a specific area and pane, do just that and
avoid painting other panes. The calls to onDrawArea() are specfic to a
pane intersecting with a tile from tile-section painting.

Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I3f74e38fe8a1535e980f8b05ee8d6fdd98cf55f5
2021-04-27 11:56:46 +05:30
Dennis Francis
fc1f0aee1a freezepanes: avoid drawing the same tile multiple times
This can happen when a tile is visible in more than one pane. This was
not a problem before we introduced client side background and grid
rendering but now it is.

Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I8dd448f9d89358a71bafd4cffe431a251076a206
2021-04-27 11:56:46 +05:30
Dennis Francis
10665f70ec let the section container do the draw ordering
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: Ifd1bc9e9a3efbab53ff4616d11c405fcc41449b8
2021-04-27 11:56:46 +05:30
Dennis Francis
2a1f4a4baa fix reference/autofill selection redraw on removal
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I8b6c8dc14093125acbbfc362afb52e0c4c865e2c
2021-04-27 11:56:46 +05:30
Pedro Pinto Silva
85b21d715f Notebookbar: Styles preview: Fix inconsistency, less borders
Had too many different border styles (parent with dashed border,
different colors used in different places, and not making use of
css vars)

- Less decorative css styles
- Decrease distinction between Styles preview and whole notebookbar
  (more at home with the surroundings)
- Use shadows to differentiate states
  - add vendor prefix
	- add border-collapse: separate; for ie

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I77188f414b7d539f8ea6631016b5def8dcf90034
2021-04-27 08:22:46 +02:00
Pedro Pinto Silva
a5757282f5 Fix RGB within CSS vars
CSS Var with RGB value goes inside of of `rgb()` and not the other
way around

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I1401309c00d91160e757f4fdca0b00ea74763911
2021-04-27 08:21:56 +02:00
merttumer
68697eba55 Fix Rotation moves the center away on calc
For calc, gridoffset must be taken into account
when calculating the center point of the shape
otherwise the coordinates will not match with
core

Signed-off-by: merttumer <mert.tumer@collabora.com>
Change-Id: Ie1003d52f233a79e5b1640c2cf7a095a7315a749
2021-04-26 20:26:18 -07:00
merttumer
6b3149b022 Fix glitches of shape handlers on show/hide
Wrong positioning etc.

Signed-off-by: merttumer <mert.tumer@collabora.com>
Change-Id: Ie636b4d056faf0cb5204a1a8cda7a98d7ea2e681
2021-04-26 20:19:20 -07:00
merttumer
e609d27a67 android: Request ODF conversion for text files on Android
Also now txt files can be opened and edited.

Signed-off-by: merttumer <mert.tumer@collabora.com>
Change-Id: Id7b57c219a2e8eaa46153cd3ae4b91dcb9352eab
2021-04-26 20:19:02 -07:00
andreas kainz
4023a118c3 Notebookbar Draw Tab update #2007
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I5018bfcf5925ce5026a3d4069cb4bb096921742c
2021-04-27 00:49:52 +02:00
Szymon Kłos
5c6b214725 Show menu with download options in readonly on tablets
When notebookbar is activated but user is in readonly mode
show the simple menubar with download and view options
instead of empty bar on the top

Change-Id: I49ac7f8d7d8691761a15fd767f278e23ea228b50
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-26 18:05:07 +02:00
andreas kainz
23dc1b2aaf Fix insert line and shape icon #2152
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I327dc32c22ee156a967fea3c6012d6bd0b677482
2021-04-26 17:43:41 +02:00
Szymon Kłos
308eb1375d formulabar: send resizewindow only if size changed
On every sidebar refresh the onResize from Map is called
triggering showCalcInputBar. resizewindow message should be
sent only if sidebar changed the size.

Change-Id: I8b5cd9412e886ef7573a8283c7ee79be63c915b4
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-26 17:14:56 +02:00
Szymon Kłos
b50bb64bf7 formulabar: avoid setting width to 0
This prevents us from invisible formulabar on app load

Change-Id: If002208c3704d05c139c75a6dadf2572caeef90b
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-26 17:14:56 +02:00
andreas kainz
b1865b2b59 Colibre icon theme update to correct colors and forms
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ie2dbf0c41760b5f3ec0b94cbd342c3a6dda513d5
2021-04-26 16:26:09 +02:00
Miklos Vajna
a5566baa03 Add version of std::atoi() that needs no extra allocation
std::atoi() assumes a null-terminated string and our strings are not
always null-terminated. So add a version that takes a length parameter,
this way we don't have to copy strings around.

Also switch to this in http::StatusLine::parse().

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I449b356c1b9948c562434618596e8e3b38656088
2021-04-26 16:22:27 +02:00
andreas kainz
8a7278f94b Colibre Icons update insertgraphic #2151
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I065c1f73e53364a0facf7b251631df986698ef89
2021-04-26 15:49:53 +02:00
Jan Holesovsky
3463c2ecad Revert "fix #1285 remove elipsis ... from NB strings"
This reverts commit a41ab8ff35.

Change-Id: I320ef28b2a9672059f1b10ac3f6ba135861cac8f
Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2021-04-26 18:33:06 +05:30
andreas kainz
961b771ecb Notebookbar writer calc remove grow-shrink subgroup
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I0a4ac6ce73856d7f322e9cbf8fa52b7ad4aa81f4
2021-04-26 08:18:03 +02:00
andreas kainz
e6c233769e Notebookbar impress - draw home tab update
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ifccb641a45d985d46c8938d5e0c495ce9a396d2b
2021-04-26 08:15:57 +02:00
andreas kainz
926686b87c Notebookbar Calc sync tab arrangement wit writer/impress
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Iac79dde47846584509637551018fa2eb5630620f
2021-04-25 23:46:01 +02:00
andreas kainz
34b8dee385 update colibre filter icons
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I573ec838432b861e9648fdc169e8ba9e5dba28b2
2021-04-25 08:19:32 +02:00
andreas kainz
4d356ad99c Update Colibre icons
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I3cb2da96c096b69fd1b945398b31c180f3ed6845
2021-04-25 08:18:50 +02:00
Andreas_K
902442d4e7 Notebookbar Writer/Impress Table Contextual Tab update
- Property get the first item
- ParaRightToLeft was removed, already in Home Tab
- Rearranged of NumberFormatDecimal items

Signed-off-by: Andreas_K <andreas_k@abwesend.de>
Change-Id: I78969e46ba94f300d26ab2f6413657a65b537832
2021-04-25 01:50:20 +02:00
Andreas_K
584e139bbd Notebookbar Calc Sheet and Data Tab update #2007
Update the structure of the Insert Notebookbar Tab for all apps.

### general sections:
1. as there are not that much commands and it's very difficult to arrange them into 3 item groups, all commans are bigtoolitems

### Calc Insert Tab
Define and Manage commands moved from Data Sheet to Insert Sheet, section Hyperlink
- Now the group is similar to LibreOffice Insert Tab

### Calc Sheet Tab
Group/UnGroup Hide/Show Details moved to Data Tab
- Now the group is similar to LibreOffice Data Tab
- Commands are at the Menubar also in Data Section

### Calc Data Tab
- Pivot Table + Refresh/Delete Section was removed cause it's already in Insert Tab and Data Tab has a lot of content, so no need for duplicated content at the very left area
- Sort section has the same layout than all other sections
- Autofilter section layout is similar to all other sections
- Group section was moved from sheet tab and as Remove Outline is an command for Group, it was added
- Recalculate, Validity and Goal Seek get into one section. Recalculate and Validity area already into one section in the menubar.
Finaly the Data Tab has a similar command layout with bigtoolitem and toolitems.

Signed-off-by: Andreas_K <andreas_k@abwesend.de>
2021-04-25 00:47:58 +02:00
Andreas_K
d267e7cccb fix
it was late, but therefore there are tests good for

Signed-off-by: Andreas_K <andreas_k@abwesend.de>
2021-04-24 09:41:29 +02:00
Andreas_K
04ddf179be Notebookbar Format Tab update #2007
Update the structure of the Insert Notebookbar Tab for all apps.

### general sections:
1. as there are not that much commands and it's very difficult to arrange them into 3 item groups, all commans are bigtoolitems

### writer:
- writer use the most format commands
- start with tiny and get bigger
- character, paragrapn, page, line / area / position
- as Lists and Bullets and Numbering are related to Paragraph they are next to Paragraph
- As Columns and Sections are related to pages or part of a page, the commands are related to Page Style

### calc
- Character, Format
- Paragraph
- Page
- Cell and Conditionals (calc related only)
- Line / Area / Position

### Impress
- Character
- Paragraph with Bullets
- Page
- Line / Area / Position

Signed-off-by: Andreas_K <andreas_k@abwesend.de>
2021-04-24 09:41:29 +02:00
Andreas_K
17d49e1a31 Notebookbar Writer Reference Tab update #2007
Update the structure of the Writer Reference Notebookbar Tab

Use the JSON Layout from #2007

### Writer:
- Move Bibliography Entry to Cross-Reference / Bookmark section
- Remove commands that are not available
2021-04-24 01:17:33 +02:00
Andreas_K
a1bf84f80d Notebookbar Writer Layout Tab update #2007
Update the structure of the Writer Layout Notebookbar Tab

Use the JSON Layout from #2007

- Page Dialog is the most importend command, so it's the first one (before last one). In LibreOffice it's the last command, cause there are dropdown menues for aspect/ratio, size, ... which are not available for cool. So have the dialogue is ok but as bigtoolitem
- Title Page and Watermark switch to bigtoolitem, cause there are not that much commands in the Layout tab
- Wrap, Object Align and Forward/Back Object use the layout from the context Draw tab so it's everywhere the same layout.

Signed-off-by: Andreas_K <andreas_k@abwesend.de>
2021-04-24 01:05:29 +02:00
Miklos Vajna
9afe974848 Add a fuzzer for http::Response::readData()
And remove the httpheader one, which is not useful, since it uses Poco
for the actual parsing, it did not find anything. (If we switch away
from Poco there in the future, it's easy enough to restore it.)

Also fix some problems found by the fuzzer.

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I254247c46ecc78c9c3e75aac4f10c441b0e10fb3
2021-04-23 17:54:36 +02:00
Michael Meeks
e26fac4665 Use the accepted socket, not the listening one.
Change-Id: Iecaa90f4c3030b5b2e20bb0e33ef9b75717bb578
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2021-04-23 16:36:38 +01:00
Andreas_K
f12990a7be Notebookbar Insert Tab update #2007
Update the structure of the Insert Notebookbar Tab for all apps.

### general sections:
1. section: app specific
2. section: Image/Table/Chartbigtoolitem will be the most used item depending on the app
3+4. section: Hyperlink and Field values
5. section: Textbox Shapes + *new* inkl. Fontwork and Line
6. section: Headers Symbol and Comment

### writer:
- Fontwork move to Textbox/Shape section
- Line move to Textbox/Shape Section
- Formating Mark + Symbol + Comment are a new Section (Formating Mark is bigtoolitem hardcoded)

### calc:
- Fontwork move to Textbox/Shape section same with Line
- Header and Footer + Symbol and Comment are is a new section

### impress/draw:
- Fontwork move to Textbox/Shape section same with Line
- Header and Footer + Symbol and Comment are is a new section

Signed-off-by: Andreas_K <andreas_k@abwesend.de>
2021-04-23 17:25:20 +02:00
Andreas_K
3dc12fe6e5 Rename BasicShapes string #2111
- improve labeling: Basic Shapes command open all shapes not just basic shapes
- shorter strings are more space efficient

Signed-off-by: Andreas_K <andreas_k@abwesend.de>
2021-04-23 15:33:30 +02:00
Miklos Vajna
1195e07d15 StatusLine::parse: limit size of allocated string
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Idba8ad8a8905b0d03e2015de5df5c7c7f145ffc5
2021-04-23 15:32:21 +02:00
Miklos Vajna
da11acd8c5 StatusLine::parse: handle non-null-terminated buffer with std::atoi()
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I51033bc4d3f97f5ae93abce1b5f19ef6a8b296d8
2021-04-23 15:32:21 +02:00
Miklos Vajna
415a834813 StatusLine::parse: only feed integers to std::atoi()
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I7591fd14fbdc7c1210ac8141cb78854e3f20fffd
2021-04-23 15:32:21 +02:00
Miklos Vajna
9e331465d9 clang-format: turn off BreakBeforeBinaryOperators
Improve readability by not suggesting changes like:

-                    if (JsonUtil::findJSONValue(object, "Url", url) &&
-                        JsonUtil::findJSONValue(object, "Name", filename))
+                    if (JsonUtil::findJSONValue(object, "Url", url)
+                        && JsonUtil::findJSONValue(object, "Name", filename))

Note that clang-format is never enforced (we never re-format existing
code), but your editor may respect it for new code.

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Id6679220f83b77a4c63ca9a9429052535c75939a
2021-04-23 09:51:06 +02:00
Miklos Vajna
80c6562e59 Add a fuzzer for http::StatusLine::parse()
And fix an unhandled std::length_error it found.

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I571cdd71caeda84820f2c64088966936637ce2bf
2021-04-23 09:02:21 +02:00
Andreas_K
647e2bbdd2 NB File Tabs SaveAs Label similar between apps
Signed-off-by: Andreas_K <andreas_k@abwesend.de>
Change-Id: I0b38c1a92c008a6e6356ac81db29d6439ffb7fef
2021-04-23 07:51:52 +02:00
Andreas_K
faf91d27e5 NB File Tabs SaveAs Label similar between apps
Signed-off-by: Andreas_K <andreas_k@abwesend.de>
Change-Id: I0b38c1a92c008a6e6356ac81db29d6439ffb7fef
2021-04-23 00:19:23 +02:00
Andreas_K
769c0dca4b NB Calc update Home Tab
Signed-off-by: Andreas_K <andreas_k@abwesend.de>
Change-Id: Icfcae2e856f0724395eef35e861826062e4f5d24
2021-04-22 22:47:33 +02:00
Andreas_K
850a657a30 fix #2095 NB File Tab update at all apps
Signed-off-by: Andreas_K <andreas_k@abwesend.de>
Change-Id: Ie83f7339cba5919868351cddf6989369760438de
2021-04-22 22:46:55 +02:00
Pedro Pinto Silva
e38fd07aff Style Paste special dialog and fix html structure
- improve normal paste html structure
- style special pasting
- make sure we are using consistent font size across the board

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I9a0942ce086c9c96082ef79aa0450c4aab7daf35
2021-04-22 19:03:03 +02:00
Miklos Vajna
f720e280bf Add an initial libfuzzer based fuzzer for http::Header::parse()
Run the actual fuzzer like this:

./httpheader_fuzzer -max_len=16384 fuzzer/httpheader-data/

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I91afe44a632826cc15bd1c338bcc5234582e9674
2021-04-22 15:56:58 +02:00
Aron Budea
201a021c3d loolkitconfig: introduce config to show Non-printing Characters #2
Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: I38af64c049e92965507f50df84d3955ba188eba2
2021-04-22 15:05:42 +02:00
Szymon Kłos
b13e7e45d2 notebookbar: delay for message if not initialized
Change-Id: I4ae4bc666320a6791cebd0da687ca79f3d5d6c83
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-22 12:42:27 +02:00