Commit graph

15108 commits

Author SHA1 Message Date
andreas kainz
77a122b88a Notebookbar Draw use branding color yellow0
text, spreadsheet and presentation use branding colors
with this PR also drawing use the branding color
compare to yellow1 drawing use yellow0 for better contrast

Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ie3e3862bdc868c060d631b677ebe014adbc76a38
2021-05-05 00:58:11 +02:00
andreas kainz
6eba1e6fc1 Notebookbar ScrollButtons height shrink to 72px
As the notebookbar height was shrinked, the ScrollButton has to be shrinked also.

Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I6d195a10d98e57ec43d74f58d3bb13ed33b7b62f
2021-05-05 00:45:53 +02:00
andreas kainz
df2e0a9d51 Thesaurus work only in writer #2129
Thesaurus was removed from calc and impress/draw see issue #2129

Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: If440bdf2c61aaac22811706cc440b9ccbe7a30d1
2021-05-04 23:48:18 +02:00
Aron Budea
9bf17cd902 Fix build with --disable-ssl
After 358b30a682.

Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: I53ab88b240bde8fcd09dd916cf156dc251452b26
2021-05-04 23:35:21 +02:00
Henry Castro
4e7fadb2b5 wsd: revisit log messages LOOLWSD.cpp
LOG_FTL = abnormal, crash, denied service
LOG_ERR = load, save, session, connection, wrong parameters
other cases LOG_WRN, LOG_INF

Change-Id: I80e8ee0de2b6858ec8e1c27276eb2058acdb2970
Signed-off-by: Henry Castro <hcastro@collabora.com>
2021-05-04 10:44:01 -04:00
Gleb Popov
53e1c0250b Use Util::getThreadId() instead of Linux system call.
Signed-off-by: Gleb Popov <6yearold@gmail.com>
Change-Id: I5cab82f0d869cc9f2ea97ac9320d8f4bbf466c37
2021-05-04 15:40:50 +01:00
Pedro Pinto Silva
1699a97736 Classic: select: do not change element's height
93bc5f6083 introduced a regression
in the Classic mode.

- Better target ui-combobox
	- Use notebookbar class
	- Simplify CSS declaration

Fixes: https://github.com/CollaboraOnline/online/issues/2088

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0ab1dee8a29408c58621297ba8eefc18db3c4fa9
2021-05-04 15:04:44 +02:00
Tor Lillqvist
fd1910c727 The Chrome format is called Trace Events, not Event Trace
Change-Id: I2515182d9369c3a25727dce0d3790e79de891bff
Signed-off-by: Tor Lillqvist <tml@collabora.com>
2021-05-04 15:12:14 +03:00
Andras Timar
3c1767b290 LOKit's installation path does not contain version number any more
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: If3ae865f1d19ccba2a13c4c31faa7aff8274d34b
2021-05-04 13:14:15 +02:00
Andras Timar
0ab307c8db New versioning scheme: 21.05.x
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I9f27b549225604ee10bbef8670bd77db73f24ccf
2021-05-04 13:14:15 +02:00
Michael Meeks
aeb10dbbb0 Remove obsolete client-side leaflet grid-lines layer.
Change-Id: I290563263d5926f19173a6197ca6697f21334859
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2021-05-04 13:02:19 +05:30
Pedro Pinto Silva
4e477e1589 Welcome dialog: do not mix desktop and mobile plus styling
- Fix problem introduced with d0253673a6
  - Desktop was always without close button

- Add mobile specific class
  - So we can style it apart from desktop
  - So we can style it apart from mobile(other dialogs)

- Mobile: fix padding (remove for child element)
  - So we can use more efficient the horizontal space

- Mobile: Dismiss button
  - Make it full width

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Icb6a5a0a4191b39ecf76eaafac06e182430490d0
2021-05-04 07:58:21 +02:00
Tor Lillqvist
eb9c580c36 Introduce ways to toggle and tweak core Trace Event recording and logging
When toggling tile debugging in the Help>About, toggle Trace Event
recordning, too. Add a comment with an example of how to turn on
SAL_LOG overriding at the same place.

The following new messages from client to server are introduced:

traceeventrecording <start/stop>

    Starts or stops comphelper::TraceEvent recording.

sallogoverride <string>

    Overrides the SAL_LOG value, or stops overriding if no parameter
    or parameter is "default".

Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I8b56c28cd99d39115cd796c44e5051d934d21a1f
Signed-off-by: Tor Lillqvist <tml@collabora.com>
2021-05-03 16:09:35 +03:00
Tor Lillqvist
9ef32a3e38 Similar improvements to the ProfileZone here as to that in core
Perhaps we should use the exact same code in both core and online? But
that would be a bit tedious as core needs to be cross-platform (and
thus we use things like osl_getSystemTime and osl_getProcessInfo in
its version) while online is Linux-only.

Also imporve the test for it.

Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I0bc9dca71dc4489bd1671e0dae1e582990a8f8b4
2021-05-03 16:09:35 +03:00
Tor Lillqvist
e7ed4e11cf Add a ProfileZone implementation here, too
Compiled but not yet used.

Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I3b85696ca6076e42d16e710b49bfd37bac342ec8
Signed-off-by: Tor Lillqvist <tml@collabora.com>
2021-05-03 16:09:35 +03:00
Tor Lillqvist
be476d23b3 Produce a Chrome Event Trace file
It is (for now) produced (by the ProfileZone things in core) whenever
logging level is "trace". The Event Trace file pathname can be given
in the loolesd.xml file or on the loolwsd command line.

Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I6d5829121e71460a4600ee94d2ebf51043c8893f
2021-05-03 16:09:35 +03:00
andreas kainz
b5e3fc49b1 Notebookbar height 72px instead of 84px #2088
with #2235 and the fix of the home tab height it's now possible to reduce the notebookbar height to 72px in height instead of 84px.
Sure there would be 68 px theoretical possible, but the additional 4px in height are good for the home tab.

Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Id28bcc63db142d235986cb5449d750808b684c4f
2021-05-03 13:30:26 +02:00
Pedro Pinto Silva
0b6237934d Docs: use better favicon
- Use something more specific to documentation, instead of product icon
- Fixes #2172

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idace492f776a635398c704c8ab78e13a6ceefede
2021-05-03 13:19:02 +02:00
Gökay Şatır
4529184367 Read Only Mode: Allow changing selected part with PageUp & PageDown keys.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ifb2451c627e984063efe6d6d17b2c8e76231e1d0
2021-05-03 14:08:19 +03:00
Rash419
d0253673a6 fix:added dismiss button in welcome page dialog
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ia1b5c7316d20e14d9537281274c9ebd0b8f58ae7
2021-05-03 11:52:26 +02:00
merttumer
d7adc0e6b1 android: Fix intent.GetType() is null for the opened doc
When a document is opened inside the app's document list
intent.getType becomes null. In this case we can retrive the
correct mimeType from contentResolver. This is needed especially
for csv files, because ".csv" is needed to be added to the temp file name
for lok to recognize it correctly. Otherwise it will be treated as
text file.

Signed-off-by: merttumer <mert.tumer@collabora.com>
Change-Id: I61b853cf7ba9b648bf4ae8c54fd8b10d5754cf4c
2021-05-03 02:00:40 -07:00
Dennis Francis
95dfcba621 fix: Other user's caret is shown when adding new sheet
Don't crash if marker object is not defined for a view.

Conflicts:
	loleaflet/src/layer/tile/TileLayer.js

Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: If8f13da684ebf4028bff888c9edf4bac3ab359bf
(cherry picked from commit 99985b91b2cb45a3d013be0a2d2d40f33829dca9)
2021-05-03 14:15:52 +05:30
Dennis Francis
38cb5409ec fix: unnecessary view centering when editcursor is already in view
Make sure the we have the latest cursor before we attempt view
centering. Core sends 'cursorvisible' before any new 'invalidatecursor'
so the handler of 'cursorvisible' should not attempt view centering with
the previous cursor position and it should only after the new
coordinates with 'invalidatecursor' has arrived.

Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: Ib8db1166b1a928ddf20f849572360fdef30c13d4
2021-05-03 14:04:19 +05:30
Dennis Francis
ab1a4a46d1 fix: mometary view jump to A1 on autocomplete
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: Ifec9d3eb8a7578ba8d2244815f80774c4d6540d7
2021-05-03 14:04:19 +05:30
merttumer
2ab9db01d0 Implemented uniform scaling for shapes with Shift key
Signed-off-by: merttumer <mert.tumer@collabora.com>
Change-Id: Idafe2aa33f45225e704a617da34b5ef28f707d1f
2021-05-03 01:28:45 -07:00
Michael Weghorn
1000dab3e1 tdf#129833 android: Move reading file to separate thread
Signed-off-by: merttumer <mert.tumer@collabora.com>
Change-Id: I53e9b13fd737af66a6715d1385eeff6b0b0795c1
2021-05-03 01:01:56 -07:00
merttumer
df4745a2da android: Hide progress dialog on initial mobilewizard pop up
Text import dialog is displayed on initial document load
so we need to hide progressbar after that in order to
interact with the ui

Signed-off-by: merttumer <mert.tumer@collabora.com>
Change-Id: I840bfea9d078260751622cbb09d256153821ff0e
2021-05-03 00:11:04 -07:00
Aron Budea
41cf147bec cypress: update cypress-select-tests: 1.5.9 -> 1.7.0.
Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: I5181d78d73a88d1faaf1419a8315b44e034f5c97
2021-05-03 08:41:12 +02:00
merttumer
ce17789411 Hide the progressbar after the initial JS Dialog
When we display JS Dialog before the document is loaded
We should hide the progressbar. Spinning should be until the
1st user interaction.

Signed-off-by: merttumer <mert.tumer@collabora.com>
Change-Id: Iad8bf56d9bcc57e106e76a961ba72490a74b26c0
2021-05-02 23:39:41 -07:00
merttumer
5742acd87c android: Fix build fail and crash on doc load
Signed-off-by: merttumer <mert.tumer@collabora.com>
Change-Id: Id998e2bdf7051d54784543015c7d34c0bdd64543
2021-05-02 21:47:37 -07:00
Ashod Nakashian
5f739b265e wsd: test: include fixup
GCC 6.3 isn't happy otherwise.

Change-Id: Ie95bfa6208d25eda14d6a0bf4264cf23beae9394
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-05-02 22:35:39 -04:00
Ashod Nakashian
cb26329ae4 wsd: test: add the seconds suffix to the output
Change-Id: Ia5d30882224dce22dff66a34f79b25d25cc64348
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-05-02 22:35:39 -04:00
Ashod Nakashian
e5ce46ca82 wsd: test: log the fake wopi response
Change-Id: I4fa1dc8c6b318ba330eab47f76accd0ca2e0e867
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-05-02 22:35:39 -04:00
Ashod Nakashian
20eb076977 wsd: test: safe header reader
Change-Id: I932c9be5152e9317da6af746f7f56d96898c9b5b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-05-02 22:35:39 -04:00
Ashod Nakashian
c251cbe0a1 wsd: test: log UnitHosting activity
Change-Id: Ifdf5a11a97e9e29483a32fe3271442b309a4eadd
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-05-02 22:35:39 -04:00
Ashod Nakashian
a0549fd7cc wsd: http: simplify http::get
Change-Id: Id94d2e7340b393bd4a42f5108621f16b46a0ee9b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-05-02 22:35:39 -04:00
Ashod Nakashian
117db770cd wsd: http: add isConnected getter to http::Session
Change-Id: Iad12f00f9ced434d4e1493aba03be98a3cd7f2ab
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-05-02 22:35:39 -04:00
Ashod Nakashian
ea12aa7635 wsd: http: braces always on new line
Seems like this was a bug in clang-format
that is fixed in clang-12.

Change-Id: I8144179d2b290f5d875af41dbd44dedcf4152639
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-05-02 22:35:39 -04:00
Ashod Nakashian
5c84542c7d wsd: test: log poco exceptions
While Poco::Exception inherits from std::exception,
it's what() member returns simply the name of the
exception, which is hardly useful without the message.
Therefore, we are forced to log it's displayText()
member for the full error message.

Change-Id: I650614a9b4b3bb1b2e31841c37250a2a069e6b77
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-05-02 22:35:39 -04:00
Ashod Nakashian
68912b264e wsd: test: assertPutFileRequest returns the http response
This is optional, but when provided it's what the caller will
get, so that a given test can simulate different responses
from the WOPI-like host.

Change-Id: Iba5513174dc94757be09640d3fdb08b46af4a960
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-05-02 22:35:39 -04:00
Ashod Nakashian
a3db633489 wsd: test: use http objects instead of manual strings
Change-Id: Ic6d478c8de4075383006be452564e213f03bb4bb
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-05-02 22:35:39 -04:00
Ashod Nakashian
0dbecddb3a wsd: http: simplify sending response and shutting down the socket
Change-Id: Id4e32c8eb79458d060767a7a5ac26476e2f84331
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-05-02 22:35:39 -04:00
Ashod Nakashian
a21120412e wsd: explanation comment
Change-Id: I5104db5d20049132f88ca15a713bb3c17fb2d32d
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-05-02 22:35:39 -04:00
Ashod Nakashian
e0b5cddffc wsd: shared_ptr can dereference directly
Change-Id: Ie958c2c79da0b3ffa19de0c633e486a390240409
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-05-02 22:35:39 -04:00
Ashod Nakashian
eabdd43d37 wsd: fix signed/unsigned mismatch
Change-Id: Id72f1b3a01a8690e2a8a89c0dc12dd823cb7096c
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-05-02 22:35:39 -04:00
Ashod Nakashian
dc5ca2738e wsd: http: simplify appending to Buffer
Instead of supporting char appending,
we now support appending literal strings
with size capturing. This covers both
single- and multi-character appending
without the need for an explicit size.

Change-Id: Iee2c20b7aa2cdb6863c88e91cd770205719c2ba6
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
(cherry picked from commit 96e3e88a014960a5249fc83a5b2f3b785ac8737d)
2021-05-02 22:35:39 -04:00
Ashod Nakashian
858a4aa398 wsd: test: UnitBase takes the test name from derived classes
Change-Id: Id3c7b35ee03cbade44effffeedfbdd65c015612d
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
(cherry picked from commit 714ae5d0314a60a498d5d4800882ed704988dfb8)
2021-05-02 22:35:39 -04:00
Ashod Nakashian
4e7b0b10fe wsd: simplify assertion
Change-Id: I2cac7543fa20a39deba447e67e9c9cdb08cd3572
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
(cherry picked from commit 7188d4013a8bf00379610ec1b0a610c555674a2d)
2021-05-02 22:35:39 -04:00
Ashod Nakashian
406310834a wsd: test: http::Header parsing tests
Change-Id: I4b399c7ccd3559b8efed2d1e911a3d2d5e869f35
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
(cherry picked from commit 152b5e6363989ac4889127f64844d22496fa5d2a)
2021-05-02 22:35:39 -04:00
Michael Meeks
502a5511ec Tile load slurping.
The browsers - unfortunately appear to round-robin the asynchronous
unload of an individual tile - which causes a _tileReady callback
with updating the canvas.

This means that we re-render the canvas (at whatever speed) for each
tile we load - guarenteeing a nice animated effect of loading tiles
one by one, and refreshing the view: not so cool.

So - instead, as per WebSocket messages, slurp them - and then
refresh the view in one shot after 1ms; since it is fairly bogus
to convert a base64 encoded URL image to a real image asynchronously
anyway, this gives some nice results eg.

TileLayer.js:2464 Slurp tiles 34
TileLayer.js:2464 Slurp tiles 25
TileLayer.js:2464 Slurp tiles 53
TileLayer.js:2464 Slurp tiles 5
TileLayer.js:2464 Slurp tiles 3

It also significantly improves pageing down in calc, and presumably
a number of other operations.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ib2a7daf8aa35835edd78dc5da187b0cb76b76ac3
2021-05-02 12:15:54 +03:00