Don't confuse between tile object and the tile image element.
Assign the tile object to tile array correctly and update the tile image
using the tileCache.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I014cc47c7b6e4086384a66158fb8eb2534714b99
So that the core message ordering is maintained (by enforcing a single
queue).
Conflicts:
loleaflet/src/control/Control.LokDialog.js
loleaflet/src/core/Socket.js
loleaflet/src/layer/tile/CanvasTileLayer.js
loleaflet/src/layer/tile/TileLayer.js
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I6ba0d3ed13f4c9b08461dd7ae046106aeaaa4c50
Only dirty the canvasContainer on scrolling so that there is no double
repainting in resumeDrawing() call.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I135c1dd096b50caa3f2ea5d45f6fae3832a10013
Send the canvas container into a paused state just before a batch of
queued messages are going to be executed. During this state the
container dirties itself for every requestRedraw() call. After all
messages in the current slurp batch is executed, resume rendering
starting with a re-render if necessary based on dirty flag.
Conflicts:
loleaflet/src/core/Socket.js
loleaflet/src/layer/tile/CanvasSectionContainer.ts
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: Ice5347aac78f4f19642b96edb929836b15c55599
update cell styles for calc
remove styles for writer, cause there is a preview already
Signed-off-by: Andreas-Kainz <kainz.a@gmail.com>
Change-Id: I1267a1ca704327d7ce4025acc2c5ec5593fab6a4
Note that the C++ ProfileZone class here in Online is totally separate
from the comphelper::ProfileZone in core (which is now derived from
the more generic comphelper::TraceEvent class there).
Also note that this is work in progress and I know that there isn't
any code yet to write out the collected information from this C++
ProfileZone stuff here in Online. Which is why we don't actually have
any ProfileZone variables yet sprinkled through the code. That is
upcoming.
And finally, note that the Trace Event stuff in loleaflet also is
unrelated.
Change-Id: I8765d6dbc1d5108d9d1042781644cbee2419cd9d
Signed-off-by: Tor Lillqvist <tml@collabora.com>
move loleaflet.css .root color varaibles into a separate color-palette.css file so all var colors are at a dedicated file and branding is easier.
Signed-off-by: Andreas-Kainz <kainz.a@gmail.com>
Change-Id: I6fe879fbb09e2d5170c028820974bdda0466805d
and enabled cypress test mobile/writer/annotation_spec.js
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: If72e6f98acf5fcad1202332fa6521d7ad0e35e83
added id field in table option of menubar and moved _refreshRowColumnHeaders to canvastilelayer from calctilelayer
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ia2e492cb6edcd65ba2444da34795fe367b25e887
By default all Statusbar icons use blue1-txt-primary-color
instead of use green0-txt-primary-color, yellow0-txt-primary-color and orange1-txt-primary-color hue-rotate svg filter was used.
-> Simplify codebase
Signed-off-by: Andreas-Kainz <kainz.a@gmail.com>
Change-Id: I5f675c25b4711c2ecc2c04612b3a95682dc17ad9
writer mimetype use the style from the 16px icon not from 32px one, so there is only one color, like it is for calc, impress and draw.
calc, impress and draw mime use the LibreOffice branding colors
better alignment of document icon to finaly fix#2407
Signed-off-by: Andreas-Kainz <kainz.a@gmail.com>
Change-Id: Ieb9e5f01f4ff7c3fdecb6443e43d789233a57399
The intent is that it should no longer be necessary to do the
JavaScript part on a Linux machine. For the configury and "make" part,
mostly just some minor portability issues had to be handled:
(But it is still possible to do it the old way, too. This is mostly to
not have to bother with installing Node.js on the CI macOS machine
now.)
The readlink command on macOS has no -f option. But that use of
readlink is not necessary anyway in a tree for building a mobile app,
so bypass.
The find command on macOS always requires at least one directory name.
So when $(CUSTOM_ICONS_DIRECTORY) is empty the "find
$(CUSTOM_ICONS_DIRECTORY) -name '*.*'" command produced an annoying
error message. Handle that in a trivial way.
The echo command in /bin/sh on macOS does not have the -n option. Use
the more portable printf command instead.
To then configure and run the make (before you can do the actual build
in Xcode9, you need have Node.js installed. Personally I just
downloaded the macOS Node.js binary tarball and unpacked into
/opt/node so that /opt/node/bin/node and /opt/node/bin/npm are the
relevant executables.
You will also need to add the lxml and polib Python modules to your
user Python module library with pip3, as in "pip3 install --user lxml"
and "pip3 install --user polib".
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I263a318181125fa37ac174fa36cb0e44e56a6607
Sure Cut, Copy and Clone, Clear are two separate groups cause Clone and Clear are related to other stuff, but have them within one group, mean also icon only and that was the idea behind.
Cut, Copy symbols are very well know, so a label isn't needed from a usability point of view.
Have icons + label mean always that string translations will change the UI and Home tab has ordinary more content. However on the home tab there should be commands/icons which are well know only, so home tab without labels will improve a unified home tab on all languages.
Signed-off-by: Andreas-Kainz <kainz.a@gmail.com>
Change-Id: I1c20091f616f5aac57bc802b30db629c9bacd66c
Shortcuts icons fit better 16px size and are all blue maybe in the future they will get an filter
Alignment of the icons were increase
Signed-off-by: Andreas-Kainz <kainz.a@gmail.com>
Change-Id: Ic6cd842b83bdbb4e4b79025afab9dd4bfabe98c6
As Fullscreen mode can be very usefull #2416 to save space, I suggest to add Fullscreen command to the Shortcut bar at writer, calc and draw. So also the number of items in the shortcut bar is always the same.
Signed-off-by: Andreas-Kainz <kainz.a@gmail.com>
Change-Id: I5f37c8d1f9a42527372abcf99bac14b0f539c663
As the tab hover effect used an defined color and the plan is to use var colors, I implement another hover style for tabs.
Hover on notebookbar tabs show a 2px bottom line in primary-color depend on the app and the tab label color switch also to primary-color. The layout follow the cool color vars and look very consistent.
Signed-off-by: Andreas-Kainz <kainz.a@gmail.com>
Change-Id: Ia8da2472f7feee97c198c14a9cb059a257168b3e
problems fixed:
tooltip not shown
button status not shown
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I5a5fb0bac7ec79ccdcd540f1b6ae608bf460a7ff
problem:
Jquery tooltip uses title property for tooltip content
this tooltip property is also applied to all the child element,
if they do not have their own title
resulting into false tooltips in many cases
fixes#2171
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I2e9d61f98d9cf4e96ae720cc660278f8bf0c6df8
problem:
in some cases comments were not hidden
where specifying which part's comment to hide
i.e: when we add new sheet it is not possible to know which was previous sheet
so couldn't hide the comments from previous sheet after adding new sheet
in such cases hide all the comments
later showAnnotations handles which comments to show
fixes#2197
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I6f260f87fadfd371b095784538473e8c728c95e3
With an 1px gray-color outline it's better visible where the mouse is hover an command.
When the user hover over an selected command it's also better visible.
Signed-off-by: Andreas-Kainz <kainz.a@gmail.com>
Change-Id: I993888bd81a9f18f6d1746a42c9db4f165055e41
Reuse existent font to set a different label for applystyle command.
- Avoid duplicates (icon value-string value-string > )
- Fixes layout breakage (no space)
- Set it as "translatable" string
- Translation needs to be updated
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I2d10c772a15fcb36a7169d77ff72cb5e5f6f7ed1
Add mime type icon under document-header according to document type
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I42e80886919372a842a1d0fecf40b4a9557b5376
Default cypress view is too small, scroll first and then
attempt clicking in the bullet icon. This fixes failing tests
on this spec. No need to skip the test anymore.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idffbfec94f94c784b03815c21ece0b8d38a8ba0e
updated the instructions to setup online in kubernetes
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ic01d94d095eac9dba54a09351eabcbc6ba83c16b
File tab:
- add repair command
Layout tab:
- add FullScreen, Reset zoom, ZoomMinus, ZoomPlus
- add Sidebar and other view related commands like Show Ruler and Show Status Bar
Signed-off-by: Andreas-Kainz <kainz.a@gmail.com>
Change-Id: I8fa709848244c28fe8f7534a5431e07e213ae458
Impress:
- Review Tab add commands similar to calc and LibreOffice Impress
- Layout Tab has commands from LibreOffice Layout tab and some Sidebar View tab
Draw:
- Review Tab was used from Impress
- Layout Tab is similar to Impress without Sidebar commands that aren't usefull for Draw
issue #2384
Signed-off-by: Andreas-Kainz <kainz.a@gmail.com>
Change-Id: I63145763ea599228a654b5970cfc792ddfbf37cd
by remove the defined heigt, the dynamic (full) height will be used.
Signed-off-by: Andreas-Kainz <kainz.a@gmail.com>
Change-Id: I31d868c7e3a5232f994794af3393fc91ef2f14cc
add --white-bg-color so that there will be also a dark notebookbar background possible
use as much var as possible. some values are still fixed, but when I don't know where the color was used, I didn't change anything.
Signed-off-by: Andreas-Kainz <kainz.a@gmail.com>
Change-Id: I1e7f95021e687329560b5df1d0fd17bf0d391d0a
Include the first (text) line of the message as an arg of the Trace Event.
Change-Id: Ib1c97a5bcd359fd75380383be4d273f93c694daa
Signed-off-by: Tor Lillqvist <tml@collabora.com>
