Firefox and IE browser fails to get access to
execute actions from parent windows when insert
image from cloud storage.
Change-Id: I3abfc6ecdf28f4c44bbc154af4a77f4c013c1001
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93169
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
It's not an actual regression, but using clickFormulaBar()
method to move the cursor to a specific position is not
stable it seems.
Change-Id: I9abd470fd1f0f753181f3550df3b41384fa166dc
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93258
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Before this the dialogs (in mobile) like 'autofilter/validation list' were
not centered horizontally and looked awkward. However as for vertical
positioning, it is correctly glued to the top of the map as said in
the comments.
Change-Id: I2f31075742ac8f40b3fd4d4016dbfef635b5f805
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93238
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
There is no need to have a 'maxHeight' for the icon as we don't mirror
the core's button anymore. The height of the icon follows the cell height,
and lets make the width follow it too, so that the icon is nicely
scaled with zoom (the icon used has a 1:1 aspect ratio).
Change-Id: I175ad98f6a1306fabd003eee7fda9652f5835995
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93211
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
Before this, the dropdown marker icon was just trying to mirror the
exact shape and position of the validity list button in core.
It is a lot easier just to have the js icon according to our
styling and in its click handler, sent '.uno:DataSelect' command to
core. It saves us the trouble of mirroring the core's button which
apparently is not zoom adjusted. With non-default dpiscale, it takes
more effort to mirror it exactly.
Change-Id: Ibe15293e9052dfacf01be94ed4950d1842e46c4b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93210
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
With the recent mobile detection related changes having
mobile and dekstop tests running in parallel make the build
fail.
A related commit:
255d24ba8f
Change-Id: I69929b5dbd37298e27409d247a651c79f6dbe33f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93222
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
This was completely removed in commit
db176ee45b from good reasons - it is
really bad to have that in the config file, the Online and Core versions
are tightly coupled.
Having said that, the possibility to override still has its use cases,
so let's introduce a command line switch for those who need it & know
what they are doing.
Change-Id: I76875f7c7a174fbc16985299eb968a41814b7962
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93196
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
This is the new default - do as we're told by the client.
The old setting is left to allow users to force SSL if they are
concerned that they may receive unhelpful URLs.
Change-Id: Idea83aacea6826a8f37264e34d49c7550efe6d27
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93179
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
remove metadata
Change-Id: I7800ea5c26f2b063cdf3aa4487ed09e302e1a1b0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93152
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I1be6516d32c0afb8d78bef087648c1cd11e4a1c8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93148
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
- make sure slidesorter and controls have the same bg (that has been reset on mobilewizard.css)
- Hide scroll Rail when there is no scrollable content in the slidesorter
- Add border to distinguish between slidesorter and #map(via box-shadow so it doesn't affect element's width)
- Add top border (that has been reset on mobilewizard.css)
Change-Id: I4314da758026bf7a374e29dcd5adce8f21631319
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93001
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
When the formula bar has focus, the user needs to click twice on the
grid in order to have the document get focus.
Change-Id: I743aae7294c1fd6f0bf6abfbfcfcbfa1a41c70a5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92124
Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
This patch provides some improvements for the single input line case:
- start selection handle is visible only if the current visible line
is the first selected line
- end selection handle is visible only if the current visible line is
the last selected line
- by dragging the selection handles is possible to switch to
previous/next line
Change-Id: I168163306420d57d7d074682f7a8c3303a79da82
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92123
Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
This patch enables the ability to move to the previous or next line by
panning when the cell content is more than a single line and the input
bar is a not expanded.
Change-Id: I5e5035d17dbbc62f9ce83ec86e5037fafc2cac24
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92122
Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
The sum and equal buttons has been removed from the formula bar.
Now, in the mobile case, the accept/cancel buttons are shown in place
of undo/redo buttons when the formula input bar gets focus.
Change-Id: I378059396df3566d5bf3c83b2defa99fc669054d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89454
Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
This patch allows the lok core to know about the device form facor of
the client requesting the creation of a new view, immediately instead
of a later time.
When a request for a new view is sent a 'deviceFormFactor' parameter
is appended to the message.
This parameter can have one of the following values: 'desktop',
'tablet','mobile' and is forwarded to the lok core.
Change-Id: I21739ddb8c43c960164b3c625e4cf0a80f4616a4
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92691
Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
