Don't count dropdowns to the number of opened dialogs.
Use special type to indicate that "dialog" is a dropdown.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I38fa3c303d24601fc76606b994b7398f12dc7d38
w2menu in our version doesn't have submenus...
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I788a214c71ed880fdbc51dc026f00b82549c3361
but entries have to be max-content to not wrap,
only main container has no width set to be automatically
resized to the needs
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I0dc2487b56700b1cc87f5f7ce1fcda8e91855269
problem:
rename dialog sometimes flickered in Firefox
it flickered when the button label was clicked,
it made the event bubble and triggered the click event multiple times.
trying to open dialog when already opened makes it flicker intentionally
fixes: #7479
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I290c905ac321650bd7979495c78de7d66f188ffd
override error messages
- send App_LoadingStatus msg with Intialized status once map is
initialized so that integrator can start to send postmessages
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I96e0c1471cbabe15b0e61711defe15f4e5298ab3
This removes the unused requestloksession command
and all references to it, including protocol documentation.
Signed-off-by: Areg Nakashian <ss4crifice@gmail.com>
Change-Id: I8c410460a5f500f724996fbcbf8f9650028daaf9
This is of course for testing locally and as a demo.
This expects the wasm build browser/dist to be located
inside at browser/dist/wasm (which currently is done
manually).
Change-Id: I285177b4f08591cffe772acba531cf1a3434178b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
The problem occurs when accessibility is disabled
Exactly when the editable area is not empty and the cursor inside the
editable area is at the end.
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Ia69e0f56233497e91babf9e33080701e1f1adad2
Get_User_State postmessage is used to query user status.
If user is active or idle and how many seconds ago there
was registered last activity.
{
State: 'idle',
Elapsed: 2.3
}
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I354c329b48d61df380455ce3c4a4732e78b138ab
We send User_Idle when user become idle, but there was no
similar message when user become active again.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If0fe48456dc5ba24357bde792254c11c14517170
we replace comboboxes on mobile with listboxes
but when we will want to use that widget again
we need to implement missing actions
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iabf9506bbb13c67a0caf9aee31d24c1d0732a657
so it correctly opens list of entries in goLevelDown
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I8c071908f4aa8ed9e47720dabfbb4060c495fbb6
Previously we reloaded sidebar or notebookbar on theme change because
we wanted to load icons to match new colors. This change makes
icons aware of theme change so they automatically switch the URL.
Reload of notebookbar or sidebar is not needed then.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iae0faa904e386765abebbdb8cc6cf3a156605706
in case of list view without levels we don't need
margin in first cell
detect that based on presence of aria-level property
use width: max-content to be sure we don't wrap entries
if not needed
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ica98e90dffd1e2b7330eb962cfc8141fa6fe01a1
Use pure CSS to make margins for different levels.
Inspired by: https://www.w3.org/WAI/ARIA/apg/patterns/treegrid/examples/treegrid-1/#ex_label
- reuse arrow from tree view and expander widget
- center verticaly entries in the tree grid / list view
- add pointer cursor for expander arrow
- do not allow to sort tree grid - it makes no sense
Tree grid is a kind of table with headers but rows can be expanded
and have subentries with different "level" in the tree
It can be tested in Writer -> Review -> Manage Changes
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I4d0719a35cf852127378525153eb5b1e5d9961a7
To avoid 2 scrollbars in this dialog better to set a max-height to
this element so it never surpasses the main dialog height
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I939fd5fa3cafb3fcc0721aa2864b262535f622a7
This fixes regression introduce in: Fix Spell checker js Dialog
- fd630d427f
By reading the code, it seems there was a fix for the spelling
suggestion (that comes as an image from core). It fixed the width,
before that the image was being resized to fit the parent's width.
- This fix still works but it ended up affecting any other
.ui-scrollwindow (that is not .formulabar)
- which means that (for **any** text content) the content will not
wrap at all even if it causes overflows and it will occupy
only as much space as it needs and not the full parent's
width.
- Affected dialogs: Sort dialog's ui-scrollwindow was occupying
only enough space to display its contents, leaving a big white
space on the side
The present commit applies the max-content (that should never be
applied to text) solely when we have drawing-area child
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iaf461663508a70a6a599cbe3e9411026b54531f0
This fixes side effect from commit a1b2091ae6
JSDialog: Dialogs shouldn't be taller than viewport
As mentioned in the above commit, we seemed to have children that are
always bigger than the parent even if there is no elements to be
displayed and to fix that we enforce in multiple places the overflow
hidden: afbf052bb5
- Ideally we wouldn't do this and just let the web browser
figure out if a scroll bar is needed or not. However this
would be a quite risky thing to do without enough testing...so
Best to ensure that other dialogs that have hidden items in the
DOM don't get scrollbars. Examples:
- Writer -> Format -> Character
- Calc -> Data -> Validity
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia2625bd7e45214aa43ae96e95a149e0f78c9cd7c
Not sure if all of them can be used now, but these 5 i tested:
insertion, deletion, cut, paste, format
Signed-off-by: Attila Szűcs <attila.szucs@collabora.com>
Change-Id: I4a6c974817d58455f01f106232c9baa66fe9d58c
If postmessage to insert custom button will arrive
early before we initialized notebookbar it could
fail in insertion into compact mode toolbar due to
not existing toolbar.
This prevents us from that error. It will be not added
at the time of postmessage execution
but we remember all the custom buttons in special
array, so when UI will be initialized it will be added there.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I07d86db49a50be70b0c091a66cf5e4be049211ce
Without that integrator doesn't know what happened.
We were silently ignoring messages.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I897a95b343a1b436745816ccbef7656f30981112
With this fix, user can open a new commen popup without closing a previous new comment popup.
Without this, a new comment section lingers at the background and new comment command fails until user refreshes page.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: If7f151eb11d3f5d26dae2ca6331eb5dc0dfd9881
- Condition modified for getPrecision.
- it was not handling the cases for dot value less then 0.
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I740f86e9477656d371ba3b8793bff99671444d7c
- jsdialog requires to create in the handler single root node
with id of the widget
- remove old style update by _refreshSidebar
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I8ce6e832b2d27d25f54e9bf636572b8c97d3a7c1
queryselectorall('something').queryselectorall('something else') fails.
^ This JS error is fixed.
Also we don't have specific images for German help page. So we removed the "de" from that language list.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I69b56e8f4bd2b92835c4aca9c2284750f3df9455
for font selector and font size...
this makes us sure we initialize everything in Impress and Draw
too in case of reconnect
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I67ee15f470fa43965f6fbd91ae45cd330ea449aa
problem:
earlier restriction/lock status was sent to kit via browser,
now client session send this status directily to the kit.
this design will require less communication between server and browser
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I6b830f30fb326a5e6637e345250893cbba101de6
TypeError was noticed where container was undefined.
This was case where snackbar was closed.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Id465723e01bc2cec2e20056103a918e53abf6d09
problem:
this caused problem in autosaved comments,
when comment list is empty autosaved comments may be closed when focus is lost
partial fix: #7421
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I1fc2d087828ce44495001f97b5323dffb8adb2ef
Also add a check for failed attempts of new comments.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I50a9981cf51475d6008e936e6e28573156a8383a
Set up accessible text through aria-description for describing how to
enable accessibility support for text content when it is disabled.
The description is reported by the screen reader on document load and
on explicit request to read current text content.
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I439b7703c15d3b38c39181d27c11da438834c414
we emit lots of warnings which are not important
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I59027c4d848a98ba3d9e8f4a3feafd3fcb62dec2
to make main JSDialogBuilder shorter and easier to read.
And move handler to mobile builder as control exists only
on mobile.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I9a14c7050711658638d22f0fd7b47e038b5952a1
Don't allow dialogs to grow taller than the web browser's viewport
instead,
- Set (for dialog's content) a max of 90% of the View height and subtract the dialog's
header. This way the header with the close button stays always visible
- Set overflow accordingly so it can be scrollable
- Needs to have !important because it seems we need by default
"overflow: hidden;" set to every ".jsdialog-container
.lokdialog.ui-dialog-content.ui-widget-content"
- introduced in afbf052bb5
possibly due to hidden elements that are part of DOM
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I61a2a41d8b1198fe00b939427cde43d247dc08bb
This is still occurring also in Firefox 118.
Anyway it seems to never occur on Windows.
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I0e5c643912f2276c60bdba1b2ad1ed801785193f
Some of the options seems to not working on mobile app
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I934e446dfeeab46f26e95898522cb0b7c1cc64a2
detect if video is able to play via checking if any frames are decoded,
in other cases(i.e: file not found or corrupted file) check for the errors in source and video
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I22bfc836a98ec0eb2caa58b89332b2531d69d18f
This commit fixes videos rendering in the wrong place on Safari (and all
iOS browsers). Note that it will still need the server fixes contained
in https://github.com/CollaboraOnline/online/pull/7367 for Safari to
play video
To reproduce, load a document with an mp4 video in Safari (this may also
work with other formats, but we know of unrelated bugs with non-mp4
videos) and click on the place where the video should be.
Before this commit, you will see a white rectangle where the video
should appear. After this commit, you will see the video. If you have
this commit but not #7367 you will see a play button with a "broken
video" strikethrough. In non-Safari/iOS browsers you will see the video
both before and after this commit.
This commit does not include detection for the upcoming Layer-Based SVG
engine <https://wpewebkit.org/blog/05-new-svg-engine.html>. This means
that this commit will *break* video if this is enabled in Safari debug
mode. If this commit is merged as-is we need to make a followup to fix
this as soon as possible or we will end up with a similar-but-opposite
bug when that flag is toggled on by default.
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I205e692e7027ad917bd6f29aa96b0ac70a4c9e04
