strepsirrhini/libreoffice-online
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
4040 commits 1 branch 0 tags 244 MiB
Commit graph

4040 commits

This branch
This branch
All branches
Author SHA1 Message Date
Ashod Nakashian
871a67bd98 loolwsd: avoid side bookkeeping 
Change-Id: I7ad2cbf45c07173447c4e80dcf06f0155de904e9
Reviewed-on: https://gerrit.libreoffice.org/30554
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-11-04 05:22:07 +00:00
Ashod Nakashian
d17d148880 loolwsd: logging improvements 
Change-Id: If291bf20ae59085f2120d4c92a26de6ccddbc98a
Reviewed-on: https://gerrit.libreoffice.org/30553
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-11-04 05:17:57 +00:00
Ashod Nakashian
b6fae38f17 loolwsd: simplified createSession 
Change-Id: I2ebb37cae61d9625731b48ea6b9ce31646ad3e42
Reviewed-on: https://gerrit.libreoffice.org/30552
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-11-04 05:13:49 +00:00
Ashod Nakashian
61488cce78 loolwsd: move child communication logging 
...and simplify the message (new line not needed).

Change-Id: Ic304d39e444b13c140e16dbe232c2cb03659ff99
Reviewed-on: https://gerrit.libreoffice.org/30551
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-11-04 05:11:43 +00:00
Ashod Nakashian
84fb2d43fb loolwsd: warn if sessions remain by ~DocumentBroker 
Change-Id: I03be11b02af7560f934b138e86f8857fd9870a60
Reviewed-on: https://gerrit.libreoffice.org/30550
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-11-04 05:04:47 +00:00
Ashod Nakashian
159f055a89 loolwsd: Storage logs updated 
Change-Id: I1e78371d03c6d5734e60fb843e9f0e9d15db6fa7
Reviewed-on: https://gerrit.libreoffice.org/30549
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-11-04 05:04:20 +00:00
Ashod Nakashian
b9b69e9534 loolwsd: rename LOG_XXX internal variable to minimize conflicts 
Change-Id: I82e98b38a0ac6a5e821148f213aa1b15827e23df
Reviewed-on: https://gerrit.libreoffice.org/30548
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-11-04 05:02:05 +00:00
Ashod Nakashian
4a74d49780 loolwsd: logs updated 
Change-Id: I87ad4979c789ec1933ecdf39bd81dabce95ef9bb
Reviewed-on: https://gerrit.libreoffice.org/30547
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-11-04 05:01:32 +00:00
Andras Timar
f96ef2c4f3 loleaflet: page orientation in Writer's Format menu 2016-11-03 19:40:27 +01:00
Michael Meeks
59d28fdeba Help->About can point to the log more helpfully than the commit. 2016-11-02 14:38:58 +00:00
Ashod Nakashian
f02b98b432 loolwsd: use new log macros in LOOLSession 
Change-Id: Ia971d4ef3b67fe289b58c6d2b1f27d6e6454a56f
Reviewed-on: https://gerrit.libreoffice.org/30495
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-11-02 13:23:17 +00:00
Ashod Nakashian
0402256390 Log file and line number using the LOG_XXX macro 
Change-Id: Ie157daab8b1f52aba22e87ef07b14e571cc59771
Reviewed-on: https://gerrit.libreoffice.org/30494
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-11-02 13:22:25 +00:00
Ashod Nakashian
74ad4fb529 loolwsd: log large message transmission 
Change-Id: I68d7cb7cf69c45c8050d8202f51f6160bb050587
Reviewed-on: https://gerrit.libreoffice.org/30493
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-11-02 13:22:09 +00:00
Ashod Nakashian
05d4234208 loolwsd: more efficient client message forwarding 
Change-Id: I10f880059380599cf0187064e1009bef5fa693b1
Reviewed-on: https://gerrit.libreoffice.org/30492
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-11-02 13:21:44 +00:00
Ashod Nakashian
254005af74 loolwsd: log only abbreviated messages 
Change-Id: Ic5780b6d3c00445888568ee43c6f5fb453e5b0df
Reviewed-on: https://gerrit.libreoffice.org/30491
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-11-02 13:21:18 +00:00
Ashod Nakashian
5656c12713 loolwsd: cap abbraviated message length 
Change-Id: Idddfd55ae9a9fe8c2ae0c78e416d541529adaa66
Reviewed-on: https://gerrit.libreoffice.org/30490
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-11-02 13:20:49 +00:00
Andras Timar
469dc3e8ea %debug_package is only needed on SUSE, on CentOS it's defined already 2016-11-02 11:01:00 +01:00
Michael Meeks
a28b3d0d7e Disable port re-use for internal unit-tests, so we find a free socket. 2016-11-02 07:59:59 +00:00
Michael Meeks
e48f9d7557 loolwsd: remove assertion that sessions are cleaned up nicely. 2016-11-02 01:23:00 +00:00
Michael Meeks
5e9b582ed4 loolwsd: avoid ordering issues with atexit handlers. 
Otherwise Admin::instance() has been destroyed by the time we're
cleaning up the DocumentBrokers resulting in FMRs etc.
 2016-11-02 00:46:17 +00:00
Michael Meeks
da76cffc0d loolwsd: Better fix for 'Address already in use' vs. 86383d40db 2016-11-02 00:42:56 +00:00
Michael Meeks
2b9ae4b263 DocumentBroker - hold mutex while iterating over _sessions. 2016-11-01 23:38:25 +00:00
Michael Meeks
4b0ebe4948 Slide thumbnailing / canceltiles fix. 
Avoid canceltiles on in-flight message queue in loolkit potentially
overlooked in 97adaf935b
 2016-11-01 22:50:48 +00:00
László Németh
f7f55dede5 loolwsd: set debuginfo packaging 2016-11-01 22:47:45 +01:00
Andras Timar
ac86cdf764 typo fix 2016-11-01 22:35:18 +01:00
Henry Castro
09cb79affd fix typo 2016-11-01 09:37:50 -04:00
Ashod Nakashian
e08503e275 loolwsd: save and replay doc state changes 
Document state changes come in with the same
event ID. We need to store them in a separate
map (also renamed the old 'states' map to 'events').

All important events are now replayed correctly and traced.

Change-Id: I52346b0d252730ba5cedb091b14898479c2a52c5
Reviewed-on: https://gerrit.libreoffice.org/30466
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-11-01 13:26:49 +00:00
Ashod Nakashian
56b1f22498 loolwsd: replay state change events when re-activating a client 
Change-Id: Id2181c8426712320a9fffacd7d8d350f1476580a
Reviewed-on: https://gerrit.libreoffice.org/30465
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-11-01 13:00:30 +00:00
Andras Timar
e7355553cc loleaflet: update translations from Pootle 2016-11-01 12:39:54 +01:00
Pranav Kant
86383d40db loolwsd: Tentative fix for 'Address already in use' 2016-11-01 10:25:29 +01:00
Henry Castro
2c5cbe6555 loleaflet: row/column highlighting to reflect the cell cursor 2016-10-31 21:37:27 -04:00
Andras Timar
760c1e732a loleaflet: hide zoom controls for spreadsheets 2016-10-31 18:39:32 +01:00
Marco Cecchetti
8c522c44d1 loleaflet: print dialog: it seems that this magic hack is no more needed 
Change-Id: I5dc3af5d8c70b381638f82de14ea47b1627237b9
 2016-10-31 17:45:22 +01:00
Andras Timar
cbff583462 loleaflet: add link to git hash 2016-10-31 17:24:31 +01:00
Tor Lillqvist
be22779c21 Assertion failures are for developers to read 
'_sessions.empty()' does not need a verbal explanation. We don't do
those in other assertions in the same file anyway.

(Also, I dislike the use of exclamation marks, especially in contexts
that by themselves already are alerts, like in assertion failure
messages. Exposure to LibreOffice source code with its style (in some
neighbourhoods) of multiple exclamation marks, even, in comments,
makes you like that. Exclamation marks makes your comments or messages
look like check-out tabloid headlines.)
 2016-10-31 18:06:40 +02:00
Andras Timar
d589618bc1 disable zoom for Calc 2016-10-31 14:45:04 +01:00
Andras Timar
513d963b57 loleaflet: add Format - Page size to Writer menu 2016-10-31 13:27:02 +01:00
Ashod Nakashian
4ba5bedf6a loolwsd: explicitly scope DocumentBroker mutex 
Change-Id: I64629774ec745f47e7376231a3ca569bcbfffaac
Reviewed-on: https://gerrit.libreoffice.org/30424
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-10-31 06:10:57 +00:00
Ashod Nakashian
4186149f5b loolwsd: some logs converted to new form 
Change-Id: I7d478ff2fc5715c3f612bf57f98aa2ce454ed4ed
Reviewed-on: https://gerrit.libreoffice.org/30423
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-10-31 06:10:17 +00:00
Ashod Nakashian
8be8311eaa loolwsd: new logging macros with lower overhead 
Change-Id: I6889af4dd18692877469e8b24671aaf4649055e5
Reviewed-on: https://gerrit.libreoffice.org/30422
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-10-31 06:09:59 +00:00
Ashod Nakashian
90c60d9931 loolwsd: more efficient stream logging 
Change-Id: I6596f87be4d36d2857c40b88864099c6cb5ab5b0
Reviewed-on: https://gerrit.libreoffice.org/30421
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-10-31 06:09:17 +00:00
Ashod Nakashian
b14961ffaf loolwsd: logging cleanup 
Streaming to string can now be disabled when
the not needed to reduce overhead.

Change-Id: I95e5a700776bd9f05b0d969703fc471401dfea3b
Reviewed-on: https://gerrit.libreoffice.org/30420
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-10-31 06:08:46 +00:00
Ashod Nakashian
c8eb2ba612 loolwsd: cleanup tile response handling 
Change-Id: I34b76b463c05e3479d1fd1516906c9a75282c753
Reviewed-on: https://gerrit.libreoffice.org/30419
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-10-31 06:08:01 +00:00
Ashod Nakashian
c96c13f014 loolwsd: expect no sessions when destroying DocumentBroker 
Change-Id: Ib8244cd8ae6449a07eb010fba4b26ec5bad09162
Reviewed-on: https://gerrit.libreoffice.org/30418
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-10-31 06:07:10 +00:00
Ashod Nakashian
ce785b6432 loolwsd: convert int to string before adding to literal 
Change-Id: Ia3352589aa894b38892f98fedc93926f063dce72
Reviewed-on: https://gerrit.libreoffice.org/30417
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-10-31 06:06:55 +00:00
Ashod Nakashian
773c15f710 loolwsd: consistent formatting 
With the help of clang-format.
For reference, the following command was used,
but not all changes were commited:

clang-format-3.9 -style='{BasedOnStyle: WebKit,
 AlignAfterOpenBracket: Align,
 AlwaysBreakAfterReturnType: None,
 BreakBeforeBraces: Allman,
 DerivePointerAlignment: 'true',
 ExperimentalAutoDetectBinPacking: 'true',
 IndentWrappedFunctionNames: 'true',
 UseTab: Never}'

Change-Id: I0f7490c7ee38aeefeefcf9d5d4c3dab380cd63b8
Reviewed-on: https://gerrit.libreoffice.org/30416
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-10-31 06:06:35 +00:00
Ashod Nakashian
d694e00e8e loolwsd: admin cleanups 
String stream is overkill for a single string concatination,
even with int-to-string conversion.

Avoid unnecessary noise when no subscribers exist and
cleanup dead subscribers on notify failure correctly.

Change-Id: Iaad3281e29089e3be6c40c58ae2ec93097665777
Reviewed-on: https://gerrit.libreoffice.org/30415
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-10-31 06:05:04 +00:00
Ashod Nakashian
82ca247aea loolwsd: updated calc_render.xls with more shapes and test marks 
Change-Id: Ic78d872901266f204f3528313108a357685305de
Reviewed-on: https://gerrit.libreoffice.org/30414
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-10-31 06:04:14 +00:00
Ashod Nakashian
3e1e3e788a loolwsd: remove outdated comment 
...and enable a fragile and broken rendering
test into a warning until a the rendering is
more stable/fixed.

Change-Id: Id6ed596ddb64d94af2d4b7d49c8f185ac6a8b4ff
Reviewed-on: https://gerrit.libreoffice.org/30413
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-10-31 06:04:04 +00:00
Ashod Nakashian
fb8d89589b loleaflet: fire addview and removeview events last 
This fixes regression to the hackish fix done
in b26f2f2738 -
loleaflet: prevent the zoomlevel from changing on connect/disconnect

Change-Id: I09c899546d0d8bfbe4c274b0774fd30008cbcfa5
Reviewed-on: https://gerrit.libreoffice.org/30400
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-10-30 16:51:10 +00:00