Commit graph

10672 commits

Author SHA1 Message Date
Jan Holesovsky
876854d3eb android: Add support for EPUB, but disable it for the moment.
It needs support in the core that is currently missing...

Change-Id: I417172bca0c7d32dfda0a11bd8a9894ec33d72fa
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90653
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-03-18 00:35:00 +01:00
Dennis Francis
01f152ad98 Let Hammer for scroll-container listen for 'swipe' too
and delegate it to L.Map.TouchGesture's swipe handlers
which does 'ergonomic' scrolling (added in
7338e3d818). With this we get
better/smoother swipe response when the swipe starts at the
right edge of the sheet (where the scroll widgets are).

This is a follow-up improvement of :

commit 0ca8e3b639
Author: Dennis Francis <dennis.francis@collabora.com>
Date:   Fri Feb 14 18:11:37 2020 +0530

    Lets have Hammer pan listeners on scroll-container...

Change-Id: Ib5260f540434ae6af649102a1f6d6eae57e4659e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89728
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-03-17 23:30:39 +01:00
Pranam Lashkari
dd6256d93c leaflet: use "To Background" and "To Foreground" only in Writer's context menus
These options had to be removed from Calc, because sending shape to background
created multiple copies of the shape (a bug in tiled rendering?) and it was
not possible to select the shape in the backround and to bring it again to
foreground.

Change-Id: I8293ca857978e2b0b2574a9f3b420407e35c82f2
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90675
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-03-17 23:03:29 +01:00
Ashod Nakashian
b2ec95dcfd cypress: new impress editing tests
Single- and double-click starts editing
text-boxes in Impress. Single-clicking works
only on text, not in the white-space.

Merges an existing test with a new one to
minimize redundancy where there is overlap.

Improved helpers to minimize duplication
and update a single place when there are changes
to the common operations/checks.

ESLint version set to 6 to support the inline
closure syntax that 5 doesn't support. This is
only used for tests, so perhaps we should have
a different ESLint config for leaflet to avoid
breaking IE11, which is pre-6.

Change-Id: I14ee65b18e310f4ff6b93ce81580b3d6aba0fa03
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90360
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-03-17 22:53:11 +01:00
Pranam Lashkari
b470fdbd3f leaflet: "to Foreground" option enabled
In context menu of shape -> arrange -> to foreground

This option allows user to put shape infront of the text

Change-Id: Ifb8690d8f9aae92dc15b6bb643222113b1755a3c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90672
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-03-17 22:01:59 +01:00
Pranam Lashkari
2d619ab10b leaflet: "to Background" option enabled
In context menu of shape -> arrange -> to background

This option allows user to put shape behind the text

Change-Id: I2af69dc9198de8aee087f5893b84dca92aecc03b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90670
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-03-17 22:01:40 +01:00
Tor Lillqvist
603f964361 Add more entries to mobileBlackList
Specifically, for the context menu you get when you have selected one
bar of data in a chart, those items that would open a tunneled dialog.

Change-Id: I5406018b63233e7e936494a956ace3dfcdce310d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90660
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-03-17 19:56:52 +01:00
Tor Lillqvist
2d703c9460 Add some UNO commands that bring up tunneled dialogs to the mobileBlackList
Will do this in batches. These are the menu items that showed up in
the context menu for the "internal" chart in a chart object (when you
have selected the chart and "opened" it, so that the rest of the sheet
is darkened). (Unclear about terminology here, the terms in quotes are
ad-hoc.)

Change-Id: I138f992e1b9cc0b4e31a2c0b64bea2e9c160ce4f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90609
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-03-17 19:53:27 +01:00
Tamás Zolnai
29aa5e15d2 cypress: calc-mobile: add tests for spellchecking menu.
Change-Id: If0c1af21c69b49452ccdc24e3c908396a045e03d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90615
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-17 18:23:10 +01:00
Tamás Zolnai
8fb24f51f4 cypress: mobile: disable this unstable test.
Testing focus is hard in general. Easy to hit race contiditions
when focus behaves inconsistently.

Change-Id: Ib16789d5a9875e8041785ba353b7ab8f7c82a7a7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90658
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-17 17:36:04 +01:00
Pedro Pinto Silva
7a1b261ccb Anchor and wrap: Add missing icons and create some for anchor options
Change-Id: Ib57a926ea6597d8d8bdd26f9abf1e3d43f4afdf3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90606
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-03-17 12:37:23 +01:00
Tamás Zolnai
d534dc9c03 cypress: mobile: this TODO is solved already.
Change-Id: I88f0579efaa135ba987d6c40750c173004152e97
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90614
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-17 12:36:40 +01:00
Tor Lillqvist
89268f5bf3 Non-semantic change for clarity, and related comments
Let's keep the mobileBlackList elements in the same order as they
appear in the whitelist arrays above.

Change-Id: I4abb64b14be212985e45e0c0845b0c7a3ac16ced
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90608
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-03-17 12:24:59 +01:00
Miklos Vajna
338a9c5f1d libfuzzer: fix build
After commit e924625cc1 (re-factor: Socket
/ WebSocketHandler., 2020-03-06).

Change-Id: I2c109c26791efa03f54773a3623bcce57b0fb5e6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90603
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-03-17 10:34:40 +01:00
Jan Holesovsky
805806826b android: Dismiss the progress directly in finishWithProgress().
Otherwise sometimes we get a warning that a view remained open.

Change-Id: If24d2b8895e79fb2991f9948944b409309783059
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90586
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-03-17 09:29:18 +01:00
Tamás Zolnai
ed70636427 Enable spellchecking context menu items for Impress/Calc.
Change-Id: I0684130d3d90b4c8ba4b3dea2c912549456e8420
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90590
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-16 20:27:35 +01:00
Jan Holesovsky
da9897f725 android: Use "wt" mode even for Export As.
And use a real tempfile for that when I'm touching this code.

Change-Id: Iad6ea41b9e9c6459f66f1dee0258092ead1b8de5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90587
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-03-16 19:42:06 +01:00
Jan Holesovsky
67757fac7e android: Fix file corruption.
The problem was that when we were uploading back to the content Uri and
the length was shorter than the original content, the file remained as
long as before the save - which then was detected as corrupted file upon
further load.

Change-Id: Ica09a64739dbf7933d5722149134e461ae79bd80
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90585
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-03-16 19:40:31 +01:00
Jan Holesovsky
56632cc1c9 android: Cosmetic improvements to the content Uri download / upload.
Change-Id: I290211e0024dfc86c1f57314bbef00f7117928bd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90584
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-03-16 19:40:09 +01:00
Jan Holesovsky
b10113158e android: Dismiss the progress dialog on error too.
Change-Id: Ib88e98769bb59134ca90268a6a177459023aa842
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90583
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-03-16 19:38:16 +01:00
Michael Meeks
4d9d769d95 Expose disk space and session checks via LOOLWSD class.
Change-Id: I7b135d325147694cc33946b34a29ab96b2e2b918
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90577
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-03-16 19:36:42 +01:00
Pedro Pinto Silva
6b4539f40e Mobile: Impress: mobileWizard: Table properties: Add id to table design and add respective icon
Change-Id: I73ab3844fe0fbf8cb8178cb46e850ff5d3eb37c0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90579
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-03-16 18:29:49 +01:00
mert
c34ca443b2 mobile: fix hyperlink popup does not disappear.
popups dont disapper on impress also other types of documents
when tapping on graphics

Change-Id: I3b6c64f3347e6ea6aa52c9568bec3233b748d932
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90555
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-03-16 18:09:20 +01:00
Pedro Pinto Silva
3e9a853000 Mobile: Calc: mobilewizard: chart: add missing icons
Change-Id: Ib5120276a27a713497c246e832575ea42b97efb0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90572
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-03-16 16:30:45 +01:00
Henry Castro
4ea1b49376 loleaflet: makefile: do not execute javascript to get admin files
Change-Id: I84f3128499f038691abc762adec50c32f103b9f9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90448
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-03-16 16:12:00 +01:00
mert
2462bf7a19 hyperlink popup clean up
hyperlink popups shouldnt contain href for links
also we shouldnt show popup for internal links
core must handle it

Change-Id: Ice5535890a6c45cea7a3d9f70b21ad5f9e66f2eb
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89550
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-03-16 15:57:57 +01:00
Dennis Francis
98258da718 Scroll to last tab when a new sheet is inserted
Before the patch on inserting a new sheet using '+' button
in a spreadsheet with lots of sheets, the scroll position remains
unchanged. With this change, it scrolls to the newly inserted tab
at the end.

Change-Id: Iaa343aac51636043ab4629a847e2315e5076c4ab
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90159
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-03-16 15:55:30 +01:00
mert
10c695cfbb android: fix crash on removed/renamed file on recent files
Change-Id: Iedeaba896ecca17c0c7e5c038b1c370b72484c68
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90290
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Mert Tümer <mert.tumer@collabora.com>
2020-03-16 15:50:05 +01:00
Muhammet Kara
9374a28835 Jump view to cursor on switching tab
Change-Id: I76baf85858b46ba23ad6b6dd01d8716027cc43f2
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90548
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-03-16 13:39:55 +01:00
Pedro Pinto Silva
669f5d38cd Mobile: Writer: Hamburger menu: add new epub icon to download options
Change-Id: Idbef68f6c3f8908dc3f2f38a8e91d441b0f6a4b7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90559
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-03-16 12:55:23 +01:00
Pedro Pinto Silva
7f2556deb6 Desktop: Vex-bottom-right-corner: Fix missing z-index and
remove duplicated rule

Change-Id: I502aea7c7fb012a4464444ae415738a6c90b1306
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90414
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-03-16 12:54:56 +01:00
Andras Timar
370392d71e add missing test/lokassert.hpp to dist tarball
Change-Id: I13bc2926cad6483b1cef7ddd6547d45b8705b185
2020-03-16 12:37:43 +01:00
Tamás Zolnai
4c57f43d60 cypress: mobile: skip this unstable test.
Change-Id: Ie9f78fd2bc50bd153a490271322236b2c5a3bf6d
2020-03-16 12:31:38 +01:00
Pedro Pinto Silva
7918f69a24 Mobile: Calc: Hamburger menu: sheet and submenus: add icons
- Remove default gray elements for submenus
- Fix some icon sizes from 32 pc to 24 px
- Add new delete icons
- Add icon for data > group outline etc

Change-Id: I62e234d995fc6e875c5344715661dfd3202ef6a6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90557
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-03-16 12:22:00 +01:00
Miklos Vajna
cd42700054 Rework the somewhat odd sendTextMessage() interface
It took both an std::string and a length. Take a char* and a length
instead.

Change-Id: Id37dfa67fe1baae09b69819680848a0a8a1d80ed
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90552
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-16 11:55:19 +01:00
Tamás Zolnai
7b4bf196d2 Revert "cypress: mobile: reenable a focus related test."
This reverts commit 584e707ddb.
2020-03-16 10:29:30 +01:00
Jan Holesovsky
829ddbdbf3 android: Make the app movable to the SD card.
Change-Id: Ib5bfe6e4a403efa3e0ec294dadcfad6f410b6b1b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90484
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-03-16 09:52:02 +01:00
Jan Holesovsky
05198a9723 android: Re-introduce Settings in the Navigation menu.
Contains only the ability to turn on the chrome://inspect debugging even
in the production builds.

Change-Id: I2acc4a13851ed8140cb5b95712a684a56f29dfa2
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90485
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-03-16 09:51:27 +01:00
Weblate
99d4fbac6c Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Change-Id: I74be346a40c0caebaa54fe66bfc685a3346c63ae
Translation: LibreOffice Online/loleaflet-help
Translate-URL: https://weblate.documentfoundation.org/projects/libo_online/loleaflet-help/

update translations

LibreOffice Online/loleaflet-ui (Polish)
Currently translated at 100.0% (290 of 290 strings)

Change-Id: I0b7596960473e3aa8550c6d69759cebd166939f2

update translations

LibreOffice Online/loleaflet-ui (Dutch)
Currently translated at 100.0% (290 of 290 strings)

Change-Id: I01234465d4fe95f33aadc1b3d5dcb6039a975003

update translations

LibreOffice Online/loleaflet-ui (Hungarian)
Currently translated at 100.0% (290 of 290 strings)

Change-Id: I804ea591a3d0905907d12300f6051b66d2e1c8f1

update translations

LibreOffice Online/loleaflet-ui (Czech)
Currently translated at 100.0% (290 of 290 strings)

Change-Id: I1c65977d7cedf1613a165fba97a7041b5cf6eb7f

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Change-Id: I84833ae41c016834ef4973d18aca6621d0a12971
Translation: LibreOffice Online/loleaflet-ui
Translate-URL: https://weblate.documentfoundation.org/projects/libo_online/loleaflet-ui/
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90529
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-03-15 23:01:33 +01:00
Andras Timar
6c6521c264 help: Apply suggestions from Mihail Balabanov and Steen Rønnow from Weblate
Change-Id: I896237ae28a841058deae57a3ba70c9248cfee40
2020-03-15 22:16:47 +01:00
Andras Timar
09d29b6544 Add some missing Spanish strings
Change-Id: Ia1ecbc88765b93f0214d0c65430cdcbf588a1d59
2020-03-15 16:24:25 +01:00
Andras Timar
02af60acbf make 'Insert Shape' mobile menu localizable and update pot files
Change-Id: Id4a1769a82138c01a8728b74fb18dbf49779fb59
2020-03-15 16:11:22 +01:00
Weblate
45de9be194 update translations
LibreOffice Online/loleaflet-help (Czech)
Currently translated at 100.0% (416 of 416 strings)

Change-Id: Ie4a36ecb8159813d94a25c98ece15c9de0484268

update translations

LibreOffice Online/ios (Croatian)
Currently translated at 100.0% (4 of 4 strings)

Change-Id: I9dd3b601762f36d86f791f35b5d633012051ca37

update translations

LibreOffice Online/loleaflet-help (Croatian)
Currently translated at 67.3% (280 of 416 strings)

Change-Id: I020781b8f5620ecf192ed0cd7051ee0e9155d761

update translations

LibreOffice Online/loleaflet-ui (Croatian)
Currently translated at 100.0% (288 of 288 strings)

Change-Id: I4108d1a3cecb66108d83009843be673df1610de8

update translations

LibreOffice Online/loleaflet-help (Catalan)
Currently translated at 73.3% (305 of 416 strings)

Change-Id: I22aa3bee069ac632e000a3a51145f8615f0fa91d

update translations

LibreOffice Online/loleaflet-help (Catalan)
Currently translated at 73.1% (304 of 416 strings)

Change-Id: Ic7f5d2a78ddd1fe601160774b04e695fb776be6b

update translations

LibreOffice Online/loleaflet-help (Catalan)
Currently translated at 72.6% (302 of 416 strings)

Change-Id: I353eda16929898b8fc616b023da9a89d58981cd3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90424
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-03-15 16:10:29 +01:00
Ashod Nakashian
13c18f4b0f leaflet: cleanup document type checking
Change-Id: Ifa7761c1a1ebfe35e82f497a386a1b8fcac67b99
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90361
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-03-15 05:19:11 +01:00
Andras Timar
a66083de9b Try to delete language information from templates...
... in order to have languages agnostic templates.
fo:language="en" fo:language="US" was removed from styles.xml

Change-Id: I680809d33cb902fc447ea5393d7f8dad3d83cbfc
2020-03-14 22:29:17 +01:00
Tamás Zolnai
8c6bc949da cypress: better parallel build detection.
Now it works both with '-j' and with '-j <number>'.

Change-Id: I41ebace6fd799f103ce557a8cf8419fea786faca
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90496
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-14 22:04:32 +01:00
Ashod Nakashian
82560d9657 wsd: test assertion macros
Because the new-style tests are intrustive,
the exception that CppUnit throws on assertion
failures is caught and processed with the
application logic, which is far from ideal,
because it's very difficult to find the
cause of failure.

What we'd like is a way to control what happens
when an test assertion fails, such that we can
properly log/print the failure, and even break
in the debugger.

The new macros allow us to control the behavior
at compile-time and have added flexibility.
For now, they log an assertion failure before
invoking the CPPUNIT macro, and support a
compile-time directive to assert, which is
useful for breaking in the debugger.

Change-Id: If464ba246e3ec747f31496a4215cb73ef735dfaf
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87625
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-03-14 15:45:00 +01:00
Ashod Nakashian
1339b36575 wsd: define Log::shutdown for Mobile to avoid special casing at call sites
Change-Id: I9125df562c96b3671cb47200a36aae145cf29259
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90423
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-03-14 14:23:27 +01:00
Tamás Zolnai
8638c87af7 cypress: mobile: simplify selectAllMobile() in writer_helper.js.
Change-Id: Icd889564b6191ad0f50008b989b06ecaf94d35e5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90488
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-14 12:46:10 +01:00
Tamás Zolnai
f9cec18eda cypress: improve afterAll() method.
We need to actually wait, until the admin console displays the info
coming from loolwsd. We also need to check only for the test document
that the current test file is using. In parallel build, more jobs
are using the same loolwsd.

Change-Id: Ia85cf711f33c748cdbed8602a532fb590fe26b25
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90474
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-03-13 17:43:39 +01:00