Commit graph

10672 commits

Author SHA1 Message Date
Andras Timar
fdc05239af Remove hardcoded tab name Sheet1 from iOS spreadsheet template
Change-Id: I0916e968b33395cf682bf4ddc313c959526e7adf
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89171
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-21 11:34:21 +01:00
Tamás Zolnai
542b4b69d6 css-media: Remove 'screen' condition with invalid syntax.
It should be 'screen and ...', but since the other rules don't have
this additional screen condition, I just remove it.

Change-Id: Idabf28fbee303e19f1a5f5c75f3eb5e7387ac3fa
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89170
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-21 11:27:32 +01:00
Henry Castro
5bc28a9d30 loleafet: ignore the paste event when a vex dialog...
has the focus

Change-Id: Ib6eece050c7b962087d229cf484c8873a214d359
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89159
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-02-21 00:49:29 +01:00
Henry Castro
c537bea938 loleaflet: import Autolinker.js library
The file was imported from node_modules/autolinker/dist/Autolinker.js
the main reason is to analyze the source code, debug and patch
if necessary

To get the source code from npm repository

	make libs

Change-Id: I3eea7cc6e8d61623398d77ed74e751ccd861252b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89150
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-02-21 00:49:04 +01:00
Michael Meeks
a529784788 mobile: hide impress indent paragraph properties.
Users confused between outline and indent settings.

Change-Id: I693e41d4d456e47f53d7f6392cde9bec6b038029
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89149
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-02-20 18:42:30 +01:00
Henry Castro
87ff57fe5b loleaflet: import json2.js library
The file was imported from node_modules/json-js/json2.js
the main reason is to analyze the source code, debug and patch
if necessary

To get the source code from npm repository

	make libs

Change-Id: I7d80646704b368f6961c75f1dabaabecde2527e6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89146
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-02-20 18:32:48 +01:00
Miklos Vajna
d8e6fa411c fuzzer: fix this up so it works again
After fixing this single assertion failure, the

./loolwsd_fuzzer --config-file=loolwsd.xml --o:storage.filesystem[@allow]=true --o:logging.level=fatal

invocation works. (It does not really fuzz anything, but it's a single
unpriviliged process at least.)

Change-Id: I45f877e5eb023e3ddfc96a7373c6300e4bb77962
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89115
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-20 18:03:10 +01:00
Henry Castro
a75c8f3e71 loleaflet: import select2.js library
The file was imported fromnode_modules/select2/dist/js/select2.js
the main reason is to analyze the source code, debug and patch
if necessary

To get the source code from npm repository

	make libs

Change-Id: Ibe0fd718d1dd6157d463a304c56fd6475821a0eb
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89110
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-02-20 17:37:14 +01:00
Tamás Zolnai
f6a5b90612 cypress: remove obsolete comment.
Change-Id: I9d8293ed27cb756325ffde48f3bcf37f390a1651
2020-02-20 17:10:24 +01:00
Tamás Zolnai
389720d948 cypress: mobile: make mobile wizard navigation more stable.
When we open a new panel in the mobile wizard the new
content appears after a short animation.
I suspect that this animation makes tests to fail sometimes
with 'detached from DOM' error. Waiting the end of the animation
seems help on this issue.

Change-Id: Ie9cc322ff9bd9a6287b4d57126e6afab91a98713
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89107
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-20 17:08:05 +01:00
Aron Budea
c5f7a503f6 Revert "tdf#121457 Move "Fullscreen Presentation" to "Slideshow" menu"
This reverts commit 52775325f5.

Slide Show menu had a single item, and Slide menu only had a few.
Revert in favor of saving on menu width for now.

Change-Id: I81f0f96849e3eeaf571611d059325d72b85ec334
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89040
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Aron Budea <aron.budea@collabora.com>
2020-02-20 15:03:00 +01:00
Jan Holesovsky
bd3aba415d android shell: Avoid deadlock when saving to Nextcloud.
The actual saving to Nextcloud takes time, so what happened was that the
LOOLWSD instance managed to tear down itself, new one was created, and
only after that the onPause() was called - which then tried to send the
"save ...", but there was nothing that could actually receive that.

Change-Id: I3c503461dc7d7e9c2e784911931ddc36b382cc5e
2020-02-20 14:53:06 +01:00
Jan Holesovsky
49272da0a6 android shell: Simplify the loading & saving of the document.
Change-Id: Ib759adfbddec9f254bf9c9e2ba8a6bba08033cce
2020-02-20 14:53:06 +01:00
Jan Holesovsky
b2faff47f1 android shell: Create new file using the appropriate Intent too.
Instead of a home-grown input dialog.

Change-Id: I04e9f2fe2a093301d7702faf9a454d05494a3ee4
2020-02-20 14:53:06 +01:00
Jan Holesovsky
cd75360469 android shell: Keep the order of the recent files.
Change-Id: I1b8a60126228cc59cd3d308f44244b3ee3db7413
2020-02-20 14:53:06 +01:00
Jan Holesovsky
d87caa2920 android shell: Center text under the icons for better look.
Change-Id: Ib9a466290558577105f87ba0eab038931b093789
2020-02-20 14:53:06 +01:00
Jan Holesovsky
b00c6b105b android shell: Switch between grid and list directly on the main screen.
Change-Id: I668bacc0206af7f72a434296806c9149a6edda9e
2020-02-20 14:53:06 +01:00
Jan Holesovsky
d6e37728d5 android shell: Kill the document browsing functionality.
Change-Id: I9dd0e448818bfebf6efd7b544487f881ae2de8ab
2020-02-20 14:53:06 +01:00
Jan Holesovsky
cdea4cdd08 android shell: Move some functionality to the Recent files.
* Bigger icons for the recent files.
* Possibility to switch to list view (which displays file sizes).

Change-Id: I5c0f3b4670d7e3f2acb2935adb6be1b78553c5ea
2020-02-20 14:53:06 +01:00
Jan Holesovsky
dca9151fe3 android shell: Make the recent documents work again.
Change-Id: Iae7523184ec7aa9c85c5cf833f63b5423774e5d1
2020-02-20 14:53:06 +01:00
Jan Holesovsky
bdcf644fbd android shell: No need for the Nextcloud lib any more.
Change-Id: Ifdf8ae09d2350aa56d7f139bfbdf3db88eedba67
2020-02-20 14:53:06 +01:00
Jan Holesovsky
2a52d768dd android shell: Remove the 'storage framework', we have content providers.
Needs further work to make the recend documents + list of local files
work again.

Change-Id: I2562ef2b35e5c8ed9ab71149b6b7180b40e61de9
2020-02-20 14:53:06 +01:00
Jan Holesovsky
d458c09628 android shell: Make it possible to open documents from content providers.
This way, we can open & edit document directly from Nextcloud / Google
drive / anything that implements content providers...

Change-Id: Ibea308966d275c7449bc5f2e298abfc023a4ec2d
2020-02-20 14:53:06 +01:00
Jan Holesovsky
2b4781f4a8 android shell: Add the folder icon to toolbar, hide the rest to the menu.
Change-Id: Idfccb2766c6aae633a51bab218a229b7dd67c440
2020-02-20 14:53:06 +01:00
Henry Castro
05d433b500 loleaflet: import vex.combined.js library
The file was imported from node_modules/vex-js/dist/js/vex.combined.js
the main reason is to analyze the source code, debug and patch
if necessary

To get the source code from npm repository

    make libs

Change-Id: I59e466e925d43bf4c599305898c656f69ec195d9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89099
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-02-20 14:51:54 +01:00
Marco Marinello
fdba30ea4d Add more flags to docker compilation
Signed-off-by: Marco Marinello <marinello@libreoffice.org>
Change-Id: Ib5a49613ed36eec0d8ab8178b13e302cd5d8da4e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89080
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-20 14:07:30 +01:00
Tamás Zolnai
7810825e6b cypress: mobile: make paragraph panel related tests more stable.
Change-Id: I6d6d9e8f2f6d14406327ae074f1e82e411f508cc
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89091
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-20 13:41:29 +01:00
Henry Castro
5cc7ba2d77 loleaflet: import sanitize-url.js library
The file was imported from node_modules/@braintree/sanitize-url/index.js
the main reason is to analyze the source code, debug and patch
if necessary

To obtain the source code from npm repository

make libs

To bundle the file sanitize-url.js

browserify braintree-sanitize-url/index.js --standalone sanitizeUrl > sanitize-url.js

Change-Id: I7869a1349648ae1f8f2194859ebb398b1a73733e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89055
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-02-20 13:20:44 +01:00
Tamás Zolnai
c211ce95e2 cypress: mobile: enable some shape related test which are stable now.
First issue was rendering the mobile wizard twice by
opening. I added a workaround for this issue:
20b5825ce5

The second issue was with the animation when moving
one level down in the mobile wizard. Checking the next
level content makes these tests more stable.

Change-Id: I3f3c90e5975747f833e9560140cabb6c310dfe57
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89087
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-20 13:14:38 +01:00
Tamás Zolnai
be9333bf5b cypress: try harder to kill loolwsd server.
pkill uses SIGTERM signal by default, which is good because
using that makes loolwsd to clean up things before shut down.
For example it removes the pid file.
However, when loolwsd stuck for any reason, then SIGTERM might
not be effective. In this case use SIGKILL.

Change-Id: I3ed4bd24d6e73169b4d04dd7c9b4ac03bee8fdd1
2020-02-20 13:13:52 +01:00
Tamás Zolnai
bde5059f19 cypress: mobile: update test title.
Change-Id: I01751b3f3f25391fd6d846e133dc4fc3e5ff84df
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89076
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-20 12:00:18 +01:00
Tamás Zolnai
9eaecc1b06 cypress: mobile: Fix-up hidden style items test.
Without waiting for the mobile wizard to be opened
the not exist check will allways pass no matter
whether the items are actually hidden or not.
First we need an indicator that the mobile wizard
is opened and then we can check whether the removed
styles items are not there.

Change-Id: I00c1aaf6e11351cf8714be3ed6d5b9d2ff000324
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89074
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-20 10:19:38 +01:00
Andras Timar
2863305788 We need also share/gallery for the Android app for inserting some shapes defined there
Change-Id: I8fcbc78c17753607351580b97f931f3a2c59a091
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89072
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-20 09:05:10 +01:00
Tamás Zolnai
eb4f5abf52 cypress: kill only our own loolwsd process.
Change-Id: I9c6f71571183c7583bd3c4c122c3c3e2c04696ea
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89070
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-20 05:45:25 +01:00
Tamás Zolnai
39150fca06 cypress: better way to generate allowed port numbers.
Change-Id: I1900df07f1fe76d39a35ab8cab0d62c0c53a35f9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89069
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-20 05:44:57 +01:00
Michael Meeks
c07f45e4e5 wizard: hide styleupdate as well as stylenew.
Also hide calc style panel for now: incomplete.

Change-Id: I46fee97f5d029860a12e5f7215d830091c5f9bf0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89068
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-02-20 05:21:51 +01:00
Michael Meeks
6197b25959 mend removal of adjacent jsdialog wizard items by name.
Change-Id: Id91a58cde7581d23aeb82a95f26a1c0e1352e411
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89067
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-02-20 05:03:16 +01:00
Tamás Zolnai
16578f0353 cypress: mobile: Disable spellchecking tests for now.
There is no an obvious reason for this issue and also
I can't reproduce this issue locally.

Change-Id: I6860fa878ebafd9deab92b2662c352a99ab85b52
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89071
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-20 05:02:22 +01:00
Aron Budea
dff1d32624 Default redlining_as_comments config to false
For better performance, many comment boxes reduce performance in
browser.

Change-Id: If041c3d147ee7512d90f41a4a1bfe7a1ff8646a9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89065
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2020-02-20 04:59:07 +01:00
Tamás Zolnai
eb53dd5a8c cypress: Always search for an available port number.
Change-Id: Ibfb80d43cd7f7d4c8cab8e3621bebfc2201d4b2d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89066
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-20 04:49:38 +01:00
Tamás Zolnai
20b5825ce5 cypress: mobile: Avoid render the same mobile wizard twice.
We get the sidebar's content twice when we open
the mobile wizard. It makes some tests to fail
randomly. I have no idea whether this causes other
issue or not. So let's use it only for cypress now.

Change-Id: I8a43b493934aaebfa52aa230ded228ac4b9bd064
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89025
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-19 22:20:09 +01:00
mert
d21a13e76e Fix slide-sorter behaves like desktop on larger screen phones
Change-Id: Ief2a5278b901970378a84dc4a2f528f885e1cd06
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88093
Tested-by: Henry Castro <hcastro@collabora.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-02-19 18:11:22 +01:00
Pedro Pinto Silva
843717485a mobileWizard: remove unnecessary paddings (fixed overflow)
Change-Id: I16e239bc132d779e63d60229472103720eec7500
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89051
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-02-19 17:44:58 +01:00
Henry Castro
8ce1846e5e loleaflet: import l10n.js library
The file was imported from node_modules/l10n-for-node/l10n.js,
the main reason is to analyze the source code, debug and patch
if necessary

To obtain the source code from npm repository

make libs

Change-Id: I7bd4d400c504f57a94566e187c6d26361aed8bd0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89043
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-02-19 17:32:10 +01:00
Pedro Pinto Silva
28f076d694 Mobile: mobileWizard: Add hover/active state to spinners and Fix horizontal overflow
Change-Id: I4b3b6cd6f8fe99d7de5987dfea0013639bad946a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89042
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-02-19 16:28:17 +01:00
Andras Timar
207075f82c localize the buttons on 'Rename sheet' dialog
Change-Id: I6470deb2cfa93d59ebb612d223bb2829a6cea75e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89026
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-19 16:04:48 +01:00
Mike Kaganski
098c0a5752 Check that absolute URI is passed to addWopiProof
Change-Id: I28385f330064645dc2c30a3c3180df2a297b2e53
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89021
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-19 15:35:26 +01:00
Pedro Pinto Silva
f439771c3d mobileWizard: make currency icon monochrome to follow the same style the other present options
Change-Id: Iae20c5b924e400d548e5fb1985b7d60d854db9d6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89027
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-02-19 15:31:36 +01:00
Tor Lillqvist
624b42d58a Hackaround for on-screen keyboard problem
We want to be able to force the on-screen keyboard to be displayed
(when there is no external hardware keyboard) from our JavaScript.

Change-Id: I0678d84ca941a03316ffb68cfd9c3e93a6ea7e57
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89023
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-02-19 15:17:56 +01:00
Pedro Pinto Silva
6070fd1277 Mobile: Vex: primary button: follow the same style as the button in the mobileWizard
Change-Id: I7502de057122843d040ef1469c40815ce19e7178
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89022
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-02-19 15:12:35 +01:00