Commit graph

14227 commits

Author SHA1 Message Date
Ashod Nakashian
89a587a695 wsd: always set the Fin bit for WS frames
Change-Id: I60f676fb5022ee1b2740f5cc6974595f3e86d039
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-03-08 22:49:53 -05:00
Ashod Nakashian
a533627b5a wsd: test: improved logging
Change-Id: Iac80450cd88997572727ffe30e0b26737df96f46
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-03-08 22:49:53 -05:00
Ashod Nakashian
8178a7be9f wsd: test: log the length in decimal instead of hex
Change-Id: I4abaa903a529e2e6a99af5e0056883c084c1e9ea
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-03-08 22:49:53 -05:00
Ashod Nakashian
05ec2a68d6 wsd: copy strings only when needed
Change-Id: Ia63d5f9526bbcd295a9a5d18990a4f1ab744a5b2
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-03-08 22:49:53 -05:00
Ashod Nakashian
af454178ae wsd: avoid unnecessary string copies
Change-Id: I61d50fa2bd1c7e9fc673eb58c9ba85127d6e4883
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-03-08 22:49:53 -05:00
Ashod Nakashian
c740603d14 wsd: simplify dequeue to do more outside the lock
Change-Id: Id27739401e2083e481f120f306418733a3e3563f
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-03-08 22:49:53 -05:00
Ashod Nakashian
43eaf4d8df wsd: test: better exception handling in UnitCopyPaste
invokeWSDTest is called in an exception-safe scope
and logs errors before failing tests. No need to
have the same logic here.

Also improve the exception handling and reporting
in the fetchClipboardAssert helper.

Change-Id: I306aedc3f50f93bf8a5448f1d098e5ce884ceb37
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-03-08 22:49:53 -05:00
Ashod Nakashian
74d019e716 wsd: cosmetic
Change-Id: I98d16305d461f5b081756d4a5c518d3616483538
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-03-08 22:49:53 -05:00
Ashod Nakashian
1837fb7fa1 wsd: avoid using shared_ptr copies
Change-Id: I5ee6e1cf56d984e0cb5407c556d53fc736cdb794
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-03-08 22:49:53 -05:00
Ashod Nakashian
6f59004e5c wsd: remove unused time_point argument from drainQueue
Change-Id: Ib6c48ab63ab09205e90968c6d455848e2d24f3e4
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-03-08 22:49:53 -05:00
Ashod Nakashian
a7aeea33cf wsd: cosmetic
Change-Id: I4885e91a3fdf0f1cd5caf79e7a41a289dde42150
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-03-08 22:49:53 -05:00
Ashod Nakashian
3f5e9d5922 wsd: terminate Kit when disconnected while loading
When loading hasn't completed yet, DocBroker can't
simply send a message to Kit that the session is
disconnected, because there would be no UI or
handlers for events if that were the only session.

Of course letting the document load, only to close
it, is also less than helpful to resource consumption.

Here, we recognize this case and simply terminate the
loading by killing the Kit process altogether to
avoid any potential hangs or resource wastage.

Change-Id: Ia72de715cc6238831c244444bb47b417b9b1e1a4
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-03-08 22:17:42 -05:00
Michael Meeks
07885e2f2b copy/paste dialogs: stop propagation to avoid confusing the document.
Previously a 'click' on 'start download' - also resulted in a pair
of mouse down/up events getting sent to the map, the TileLayer, and
thus the core - resetting the object selection during the download,
and causing nasty issues in the second 'Confirm copy to clipboard'
which had a different & random selection depending what was under
that popup.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I7f6510494500dd36beb232e4720a66f2d9e09f27
2021-03-08 22:16:22 +00:00
Tamás Zolnai
ea5983e957 cypress: remove this redundant logging.
cy.visit() logs this URI anyway.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Idbab1d0cd8cc0f9f0b62b194fb7f1a526c8b9f97
2021-03-08 19:08:25 +01:00
Tamás Zolnai
e034866430 cypress: make: spec can be optional here.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I98448dbb8710ea869618b341b251a0f8657386da
2021-03-08 19:08:25 +01:00
Szymon Kłos
864b761684 jsdialog: don't scroll whole page
scrollIntoView scrolled whole page inside iframe
when selection in the fontwork dialog was changed

Change-Id: I40f59c1821d1327aaf6ce910e07587f0dcb5af31
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-03-08 17:40:24 +01:00
Henry Castro
fe3135e49c jsdialog: fix line breaks for 'multiline' control
Change-Id: Id3213519a9224ee0287b5dfdd0251230e4c5f00e
Signed-off-by: Henry Castro <hcastro@collabora.com>
2021-03-08 16:32:12 +01:00
Szymon Kłos
486152f400 notebookbar: draw file tab
show only .odg and .pdf formats in file tab

Change-Id: If95d871d0ec546569a3ccb0334b9acbd971a9f86
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-03-08 16:24:23 +01:00
Pedro Pinto Silva
a00e20ad50 Vex input field: ensure box-sizing
to avoid padding affecting otter size anywhere

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I45122bbb27d37de3bfb15f201c10a4888f2ff5c2
2021-03-08 14:41:56 +01:00
Pedro Pinto Silva
c9ff69c2f5 Mobile: Fontwork: Shape: Fix alignment and make it more dynamic..
- center main div
- set minimum size for children in %
- make sure everything is centered

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iab199dca2a4907ca7292cc8b56cf6535b3013c0d
2021-03-08 14:41:56 +01:00
Pedro Pinto Silva
52d2b02297 Mobile: Fontwork: treat 'Same Letter Heights' as a main btn
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I20f44fb6b653073226cfe13be0b3c70bdfd77ba2
2021-03-08 14:41:56 +01:00
Tor Lillqvist
e20db7c18b Guard against JS error when there is no "children" in the notebookbar JSON
I saw that happening now and then when experimenting with the Insert >
Comment functionnality in the iOS app. The message in those cases
seemed to be 'jsdialog: { "id": "0", "jsontype": "notebookbar",
"action": "close" }'.

Change-Id: Ia8e07f849f88bb46cedd95f7c38534232c388efe
Signed-off-by: Tor Lillqvist <tml@collabora.com>
2021-03-08 14:36:09 +02:00
Tor Lillqvist
e142d26a2f Don't use CollaboraOnlineWebViewKeyboardManager after all
Unclear whether it is actually useful or not any longer. Quite
possibly cross-platform changes in the JavaScript since
CollaboraOnlineWebViewKeyboardManager was introduced have fixed the
problems that it was solving.

Fixes https://github.com/CollaboraOnline/online/issues/1432

Change-Id: Ifa000d0a7d0a3dc87527536719063b368266f038
Signed-off-by: Tor Lillqvist <tml@collabora.com>
2021-03-08 14:00:38 +02:00
Szymon Kłos
0d2578a66d notebookbar: border style dropdown
Change-Id: I3cc064410fad613984c8e2e531b0e77f2810adaf
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-03-08 10:19:06 +01:00
Miklos Vajna
d35a5f963e android: de_document -> the_document
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Ic85297eb112def4a9197116177c857db910459cf
2021-03-08 10:11:59 +01:00
mert
0e00c3af98 android: Fix typo on onBackpressed
Change-Id: Ic9b6765ec4d881091cc3b72b7e693b93fa598426
Signed-off-by: mert <mert.tumer@collabora.com>
2021-03-08 12:07:38 +03:00
mert
c6e4b260da Hide presentation button for Draw
Change-Id: Iaef6f2a405e0e55b082e303447fa9377a0ec96d0
Signed-off-by: mert <mert.tumer@collabora.com>
2021-03-08 11:19:21 +03:00
mert
dda2550eb4 Draw: Display Presentationbar for Insert/Duplicate/Delete Pages
We have these on the Top toolbar but in notebookbar case
We have only insert and duplicate options and they are
located in Insert tab. So deletion is not possible
with notebookbar. This patch re-enables presentationbar
with the correct hints of these items according to the doctype

Change-Id: I885b6353bce82232cfdfb5577f8cfbee16b219c7
Signed-off-by: mert <mert.tumer@collabora.com>
2021-03-08 11:19:21 +03:00
mert
1546799bfe Fix Slide Sorter does not update on Draw
Change-Id: Id8612ebbcb725b3c03ff6c2262c48c0f42544754
Signed-off-by: mert <mert.tumer@collabora.com>
2021-03-08 11:19:09 +03:00
mert
87a82105c6 android: Fix crash when could not load the document
Change-Id: Ie08fcf77560ff285b7f9a94253439e551a08aefb
Signed-off-by: mert <mert.tumer@collabora.com>
2021-03-08 11:14:48 +03:00
Szymon Kłos
74cc7d0278 Don't show blinking cursor when no focus on document
Change-Id: I6dd2ba0a88eff71870dc608ba6d961c9d0f7a67f
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-03-08 07:34:51 +01:00
Andras Timar
f939aef0ba typo fix
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ib43f1112170ca4d66e8127644e22e3f7c17f10e4
2021-03-07 20:25:32 +01:00
Pranam Lashkari
2482fde532 leaflet: cursor: avoid first character not updating cursor position
problem:
In the android keyboard when you try to erase in an empty area
and then enter some character,
The first character will likely travel with the cursor,
And that is caused because after entering the first character
cursor position is never updated by keyboard (I know it is strange)
so here we manually correct the position

steps to reproduce:
1. type "=sum" in formula bar or an empty odt (or even just "=s" is okay)
2. now tap on backspace for total character +1 times (in this case 5 or 3 times)
3. now type "=s" it will become "s="
but this can be reproduced with any special characters (i.e: }, + etc...)

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I9cc00e5d50d21384155b16b60318090e4de70ac2
2021-03-06 15:43:34 +00:00
Ashod Nakashian
f8c1857447 wsd: reduce jail size
Change-Id: I9fd1c76aff9c97b800c6b7b6154beb9c596170fb
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-03-06 08:52:50 +00:00
Michael Meeks
ea4d208636 calc: double click on sheet tab to rename.
Change-Id: I13833ac5c6292dbf1b7589ae390125ae02be4e05
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2021-03-06 08:51:22 +00:00
Michael Meeks
6307f1ee3d Allow jwt token expiry to be configurable.
Change-Id: Ifd2b078adfa3106765f5b54c0397e04ab66fc804
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2021-03-05 18:33:09 +00:00
Szymon Kłos
4d8c4451bb Don't allow to switch ui mode on mobile
Changing ui mode on mobile causes problems eg. after save as
or reloading the document.
We don't support notebookbar on mobile also

Change-Id: Iaa8d80dbdd139833c0505354be870f33b4f95413
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-03-05 15:19:43 +01:00
Tamás Zolnai
cfc0f73f91 cypress: php-proxy: make sure that the preferred port is available.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I62c707c1b36e026f0f90a7109b040437acd34d26
2021-03-05 13:11:24 +01:00
Andras Timar
dc12fc8c11 add Vietnamese l10n
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ie8958f58422f6553ba15230c2fbc80ea25962d4b
2021-03-05 12:39:05 +01:00
doanmanhduy75
d382fbeab8 Translated using Weblate (Vietnamese)
Currently translated at 10.9% (46 of 420 strings)

Co-authored-by: doanmanhduy75 <duydm3@viettel.com.vn>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/vi/
Translation: Collabora Online/Help
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Iafeb4d834693ede480af59f64c0b1aef6606da7f
2021-03-05 12:36:39 +01:00
Nguyen Trung Kien
2d6553e0c2 Translated using Weblate (Vietnamese)
Currently translated at 10.9% (46 of 420 strings)

Co-authored-by: Nguyen Trung Kien <ntk2111997@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/vi/
Translation: Collabora Online/Help
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I871d931e8de3d4ea2178289236ab934d81fa0259
2021-03-05 12:36:39 +01:00
doanmanhduy75
c8daf683d4 Translated using Weblate (Vietnamese)
Currently translated at 18.3% (77 of 420 strings)

Co-authored-by: doanmanhduy75 <duydm3@viettel.com.vn>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/vi/
Translation: Collabora Online/Help
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I4097b7582a3322a47d878be78522830fc4f3c7c6
2021-03-05 12:36:39 +01:00
Nguyen Trung Kien
ed9fe45163 Translated using Weblate (Vietnamese)
Currently translated at 18.3% (77 of 420 strings)

Co-authored-by: Nguyen Trung Kien <ntk2111997@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/vi/
Translation: Collabora Online/Help
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Iacd6665cd1df7f10341435826c71f9d8419d2122
2021-03-05 12:36:39 +01:00
doanmanhduy75
e6c10c8e04 Translated using Weblate (Vietnamese)
Currently translated at 18.3% (77 of 420 strings)

Co-authored-by: doanmanhduy75 <duydm3@viettel.com.vn>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/vi/
Translation: Collabora Online/Help
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ic60a17d0dd121e4f294eb5bc16c2834f47f15c58
2021-03-05 12:36:39 +01:00
Nguyen Trung Kien
d58168dc50 Translated using Weblate (Vietnamese)
Currently translated at 18.3% (77 of 420 strings)

Co-authored-by: Nguyen Trung Kien <ntk2111997@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/vi/
Translation: Collabora Online/Help
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I27fbee1f367b28af463e9f33300555e1575282f2
2021-03-05 12:36:39 +01:00
Adolfo Jayme Barrientos
4bada4810b Translated using Weblate (Spanish)
Currently translated at 100.0% (107 of 107 strings)

Translated using Weblate (Asturian)

Currently translated at 70.5% (12 of 17 strings)

Co-authored-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-app/es/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-lib/ast/
Translation: Collabora Online/Android app
Translation: Collabora Online/Android lib
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ie7470f5b0a2dfc092d03fdb9651dea801036dace
2021-03-05 12:36:39 +01:00
J. Lavoie
571be0aa07 Translated using Weblate (French)
Currently translated at 99.5% (418 of 420 strings)

Translated using Weblate (French)

Currently translated at 100.0% (370 of 370 strings)

Co-authored-by: J. Lavoie <j.lavoie@net-c.ca>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/fr/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/fr/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I8f7e2d396ba6a62dbb4cf781f5e18994e8c22f9e
2021-03-05 12:36:39 +01:00
phlostically
1c8a985a2e Translated using Weblate (Esperanto)
Currently translated at 100.0% (17 of 17 strings)

Translated using Weblate (Esperanto)

Currently translated at 100.0% (420 of 420 strings)

Translated using Weblate (Esperanto)

Currently translated at 100.0% (370 of 370 strings)

Co-authored-by: phlostically <phlostically@mailinator.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-lib/eo/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/eo/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/eo/
Translation: Collabora Online/Android lib
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Iadc8027f5da2da9dd49467490b723e5da4254639
2021-03-05 12:36:39 +01:00
doanmanhduy75
5b3a82d6a7 Translated using Weblate (Vietnamese)
Currently translated at 18.0% (76 of 420 strings)

Co-authored-by: doanmanhduy75 <duydm3@viettel.com.vn>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/vi/
Translation: Collabora Online/Help
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ia3b9af938c6c7067f1dee73832f277cdae920d3d
2021-03-05 12:36:39 +01:00
Nguyen Trung Kien
d857c2da08 Translated using Weblate (Vietnamese)
Currently translated at 18.0% (76 of 420 strings)

Co-authored-by: Nguyen Trung Kien <ntk2111997@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/vi/
Translation: Collabora Online/Help
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I8de400f1bcd24ec10a9f023fa67b1aabf886a670
2021-03-05 12:36:39 +01:00