Does not need to be a badge in this particular case since it's above
a physical primary button; also make it completely white to be consistent
with the button's theme.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I8c85fbe33d1b3897f0fddd44dd7a5d0517f92e93
Changes to mobilewizard (not mobilewizard.menuwizard)
- Present locker as a floating badge
- Add shadow to communicate that it's different from the button
underneath and that it's clickable
- Locker and the icon underneath shouldn't be confused
- Make that difference clear
- Change position to it is more deliberated abode the icon but not
centered, so to not cover the feature
- Alight to top left since there are many icons using accent elements
on the top and bottom right
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idf19ddb3965efefdafd4d4be042bc7e47022208c
With latest changes on positions, Vex on mobile needs now to be set
to fix and additional rules are now not needed. Inherit from main
CSS file.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I2b67c0990d625d84077f0114ab198c9fe704a88a
- Distinguish menuwizard from normal mobilewizard
- Avoid using percentages so we are sure where the things are being
positioned
- When on mobilewizard (not menuwizard) avoid showind two lockers
- Also do not replace icons, let them be and add additional locker
so the user can still see which feature is supposed to be unlocked
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4d3d5f331162d16c63cf5cad667f0d5fab4dd9bc
When on mobile do not rely on background position and instead add
img element so we can properly resize it and adjust it:
- Less in your face
- To not disturb or overshadow the actual active elements
When on Classic mode:
- Hamburger items: Use smaller lockers so to do not get in the way
of reading the actual item label
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I46218254a975b3a70d1e4c03eb1795d87f3861c9
specifically more focus on the top toolbar in classic mode
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I33eebe79addebe3acfcea4d20912cc31b759ffce
- Fixes map z-index so annotation can be have higher z-index
- Now map and due to the latest changes introduced in:
8ca57fad3344f6da1b42158944bf9903f0ac528b we cannot use
container's border-top as our bezel divider
- Elements such as annotation need to go under
- So Fix toolbar-wrapper to use bottom border
- Notebookbar: Fix toolbar-wrapper background-Color which
was being set as transparent and thus elements passing under
were being visible
- Ruler: fix cropped ruler (was not going full width)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I8778619da43c51d1994dbb12d1112d4f1d42ff43
Depends on: https://gerrit.libreoffice.org/c/core/+/116265
Fixes checkbutton (Use separators) position by placing it
before divider label ('separatoroptions') thus, improving readability. User
can now see it clearly that all those separator options are related
and hierarchically under a main option: #toseparatedby.checkbutton.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I97b133e3e873a76ca75290728adaf1a45c9bcece
- Make it thicker
- Make it visible by default
- Hide it only when there is nothing to scroll
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ibffead10c09eda979ef8d3d2201173aca3553503
Do not show radio buttons in this case since we have images
for each option (radio images and textorient options images
were overlapping ) also fix width and add hover state
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7e3d8ef4da400024137d0c9207c67807ded281c5
Use the topLevel flag to keep us safe, and avoid problems when
constructing too.
Change-Id: Ifba6f0204dac359b0b028b3295a7227576b03dd6
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Some bigtoolitem icons (namely About) were being skewed and others
were being set at a smaller size to what they were supposed to have.
Fix it by adding height value
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I5ec375358e9dcf46a6b8b17570bea78963e188c8
a) removed event firing for catching tile messages
- injected socket onmessage function and made a middleware instead
- the middleware can catch any socket messages
b) Replaced "fake sleep" and while loop for keystroke messages
with setInterval function.
c) disabled processing incoming messages for multiple views
- Optimizing the front end for JSDOM seems to be hopeless.
the benchmark numbers for JSDOM and Real browser does not match
and most of the time are unrelevant. In most cases where JSDOM is
slower take almost no time for Real browser. These cases will not
make real experience smoother if somehow fixed. In addition,
rendering hundereds of socket messages makes nodejs use 100% of the cpu
and benchmarking the loolwsd or loolforkit properly becomes impossible
since nodejs cannnot handle messages in time and send keystroke messages
with respecting the interval.
- This way we can only focus on the backend performance and find the
problems that "mesh the keyboard" events produce.
d) Recording stats will now count the num of socket messages received
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: If7d11ecea00ca175463a5d3b8bbe7c29a4b6b32e
- Inherit common styles across mobile and desktop
- Set Different padding between Desktop and mobile
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iae158c83eb693ea5a77cb0e532f7db8a80567130
No need to have lengthily message on mobile in this case
since we already have the action button that clear
communicates that a action is needed from the user side
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I508fb348ef8037501e7f23db518f1477216e3c5d
with example of usage: replaced alert when server was reconeccted
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia0f72b118a6ad7c7072bae41f452cc1a70b9aa84
Snackbar element is intended to replace all w2ui .lock
dialog (alerts) with or without button
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iad836d0dc094be01ad265492eaacf0a8dbf8a06d
- Reduce icon size
- Fix alignment
- Use specific icon (also used in core) as dialog triggers
Simplify expanders ("title bars") by removing icons based on uno command
(that trigger dialogs) so to:
- Avoid user confusion between those icons and the similar icons from
within the group
- Improve information hierarchy (dialog triggers icons should not be at
the same level as the other action within the sidebar)
- Use a common symbol (same icon) to communicate "Open dialog to see
more actions"
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib060dda2ba1584ce4e0ac132617a4b2900df42d7
We emit lots of 'keyup' events that don't match any keydown
event like this:
OUTGOING: textinput id=0 text=a
OUTGOING: textinput id=0 text=l
OUTGOING: key type=up char=0 key=517
OUTGOING: key type=up char=0 key=523
since we emit a textinput instead. So just emit events
when we have modifiers, or already sent an input event.
Change-Id: I0f86438d093497668bb5b749ff63ecd87d9b7636
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Return proper HTTP code when disconnecting and log
to make the communication more effective.
Change-Id: I4da9d5a7fe4c09d6fcd44b1f31b439180d7012bd
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
+ this will allow to perform internal paste
+ will inform user when trying to paste outside app that copying is
disabled
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I92d1a69bb6ea55703a419fa15461d98125a59b09
When async save was started but we want to stop DocumentBroker
- we shouldn't kill the socket which listens to save result.
Because when we kill socket we will destroy DocumentBroker
before saving is completed, this allows for a minimal time
to connect again to the document and receive old content
from the WOPI storage. When we wait for async save result
we will keep DocumentBroker alive and next session can be
connected and receive correct content.
fixes: https://github.com/CollaboraOnline/online/issues/2747
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I5505a5ccc1f3d6928c723bddfea16bf5c5798d1e
From our API description:
DisableCopy
Disables copying from the document in libreoffice online backend.
Pasting into the document would still be possible.
Change-Id: I1f7e272ad3b04208b534eff990fed895951b4751
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
