Commit graph

14741 commits

Author SHA1 Message Date
Michael Meeks
92af50e4b9 Initialize SSL un-conditionally.
Even if we use http:// locally via a tunnel the new outgoing socket
code needs SSL initialized to connect securely to remote servers.

Change-Id: If64a3838267182757591a8026097bf08d9ba732f
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2021-04-15 16:39:45 +02:00
Gabriel Masei
609d5563f0 loleaflet: translate hyperlink toolbar button uno command to id
This fixes hyperlink button enabling issue when dynamically changing UI mode to classic.

Signed-off-by: Gabriel Masei <gabriel.masei@1and1.ro>
Change-Id: Ib4494e71c8cedf0818c946abea75e52e1b5ca7ad
2021-04-15 14:12:51 +02:00
Andras Timar
1d3c553e51 cosmetics: tab to space
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ib0d019a79f3739080bb5fdd78bfbcb39b6ee2c0a
2021-04-15 11:31:43 +02:00
Pedro Pinto Silva
5e29b66d4b Fixes #2003 (show paste icon)
Revert c28c6b2c3c

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic63e50fe5c87dea2dc7998a99e739b41e65cad1d
2021-04-15 10:46:38 +02:00
Pranam Lashkari
9eee4ea296 loolkitconfig: introduce config to show Non-printing Characters
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ia28fdcf76a899a6844d367bc6fb81e289abc12f6
2021-04-14 22:45:17 +05:30
Marco Cecchetti
3317f6fe3e cypress tests for fullscreen presentation
Set up support for performing end-to-end tests on the fullscreen
presentation.

Added 2 tests:

1 - check text fields (slide number, slide name) are correct for the
current slide

2 - check the background for current slide is referenced correctly

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: If8d3cda49254a910aa0c5d2d672834aa5b029e0b
2021-04-14 15:02:48 +02:00
Rash419
4551482451 cypress: added tests for comment switching in desktop impress
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I0cd13c2555274e243ac60cceec0b3e00d2d929ef
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
2021-04-14 16:17:11 +05:30
Szymon Kłos
2c82014662 notebookbar: no label for sorting in data tab
Change-Id: I512478b8c29de374b640fdf44f65d65c49b53d2f
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-13 15:00:59 +02:00
Szymon Kłos
b96f73c461 notebookbar: reorganize sheet and data tabs
there was no space in the data tab with some languages

Change-Id: Iaf3105a57b30dbdfc275a6a4a4a5eede0d817c33
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-13 15:00:59 +02:00
Szymon Kłos
01c0e5af69 notebookbar: handle Get_Export_Formats wopi post message
Change-Id: I051826dc50d261e00d084a6ac625ce7cb6f55b1d
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-13 15:00:59 +02:00
Szymon Kłos
d8a7d97248 notebookbar: fix alignment in review,format tab
Change-Id: I25f16b730665b329c444b5b0a7504be8403c1c23
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-13 15:00:59 +02:00
Szymon Kłos
a11ad434ee notebookbar: make line spacing smaller
Change-Id: I45c2d2e9d4dafd28e490b7d2b0f50c99a57b2f66
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-13 15:00:59 +02:00
Tor Lillqvist
6778cb439c Add the 'Delete' context menu entry in browser on tablet, too
And not just for browser in mobile phone or mobile app. This is
apparently what we want. See
https://github.com/CollaboraOnline/online/issues/1751 .

Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I7cc89889899f20286913a1d2136b40dd6930d996
2021-04-13 13:24:45 +03:00
Pranam Lashkari
d3d049d88b leaflet: Removed impress download options from drawing doc
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I282aeaa171081b60633720b4619e0b0f250b501a
2021-04-13 00:21:52 +05:30
Pedro Pinto Silva
2f1eb41842 Writer: Improve table controls (markers)
- Do not use big rectangles as markers
  - it hides surrounding content
	- too intrusive (since it appears every time we select a table)
- Use smaller discreeter elements WHILE maintaining the existing
  active zone size (so it's still easy to click it, no need to be precise)
- Add missing hover status
  - Create new SVG plus add rounded corners
- Treat column and row marker as different elements
  - Use one generic class + add another for each type (element modifier)
	- So we can target each one and have a nice center line
	no matter the disposition (vertical, horizontal)

note: motivated by the reported issue:
https://github.com/CollaboraOnline/online/issues/1297

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4d997864e99582f74411a12c33381a926fd47a05
2021-04-12 17:48:22 +02:00
Ashod Nakashian
37e6ed0a51 wsd: test: dump clipboard state in test to the log
Change-Id: I337703d899ef6e85a9a0960d4cce8c174fc2f2f6
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-12 09:06:38 -04:00
Ashod Nakashian
be17696903 wsd: log the buffer size in WebSocketHandler::sendFrame
Change-Id: Ifb8121d9e27c9d6159af3578852e44c35b6f6e0c
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-12 09:06:38 -04:00
Ashod Nakashian
bf64465b4e wsd: test: killpoco in tile cache test
Change-Id: I0ad05b5b496c8b184b3bc4bd9c7b9e7167e26fc3
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-12 09:06:38 -04:00
Ashod Nakashian
ad52aea7ba wsd: test: killpoco in crashtest
Change-Id: Iad87dcb6c25271df75a5b397bb94bb1aecfc7d38
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-12 09:06:38 -04:00
Ashod Nakashian
4333845728 wsd: test: killpoco in httpwstest
Change-Id: Ief228862d882ae96650708e30442693cc127f0c9
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-12 09:06:38 -04:00
Ashod Nakashian
0bf5f97b15 wsd: override getPollEvents in WebSocketSession
Change-Id: I3f59e60f74830998739ae03ff1979a784b9cc8fe
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-12 09:06:38 -04:00
Pranam Lashkari
24cbf59d2c leaflet: enable comments for PDF in mobile
in addition, allow users to work with comments in read only mode
wizard z index increased to avoid mobile-edit-button overlapping it

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ie80f9a808d0234f6c58b768fa27673c9fe50b122
2021-04-12 17:16:16 +05:30
Gökay Şatır
dbb1cd1403 Scroll Section: Adjust scroll bar durations.
Variables are added into initialization for easy management.
Duration is adjusted.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ic53a159d708a5f8b0121ec264b229da0141333fa
2021-04-12 14:20:27 +03:00
Pranam Lashkari
ab2eea12cb leaflet: scroll to comments on pressing annotation buttons
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I40a820b932d3891dee9a32d319a4426e77e301d8
2021-04-12 12:24:58 +02:00
Gökay Şatır
696d6c63b1 Server restart follow up. Don't refresh the page if file name is different.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I4174dade3ff334687b485264ed8480ec3509cc4a
2021-04-12 13:04:01 +03:00
Ashod Nakashian
0b6eec8234 wsd: test: killpoco in httpwstest
Change-Id: Ief228862d882ae96650708e30442693cc127f0c9
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-11 18:43:36 -04:00
Ashod Nakashian
92fa2fd081 wsd: test: improved UnitLoad test
Change-Id: I231b20793f4bb10f7560d0d59e345021062567c0
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-11 18:43:36 -04:00
Ashod Nakashian
0fb4cd8bb7 wsd: trap disconnection in WebSocketSession
Change-Id: I519a24d72c3eb8e249450e9a49def077ecf0dc10
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-11 18:43:36 -04:00
Ashod Nakashian
60344a0052 wsd: support asyncronous shutdown of WebSocketSession
Change-Id: I4c50c718388ae8c790d2e2bb1e3d4db93e92aee5
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-11 18:43:36 -04:00
Ashod Nakashian
7b28fe2d41 wsd: improved WebSocketSession
Change-Id: If3c92b59ae6303079bd544e29cb995ac3e0d6742
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-11 18:43:36 -04:00
Ashod Nakashian
7a997afb5a wsd: test: WebSocketSession helper
Change-Id: I472282af94797ac59c6752bfd784c72012bec84f
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-11 18:43:36 -04:00
Ashod Nakashian
da28578087 wsd: test: fixup helpers
Change-Id: I0ab30977bc7bf6556665c41a92d7dd586d519e50
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-11 18:43:36 -04:00
Ashod Nakashian
ce99632081 wsd: std::move better than copy-from-ref
Change-Id: I7062ed9adf71099b3c54cbbb9784a582bde23715
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-11 18:43:36 -04:00
Ashod Nakashian
2c21fce9fe wsd: use Socket::eraseFirstInputBytes for a cleaner interface
Change-Id: Ife2a740cdc79f1c908e111ba3572b4e0777054b9
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-11 18:43:36 -04:00
Ashod Nakashian
b35a269378 wsd: always include port in the Host header
Change-Id: Iab7680462eac68cf9c4fc1dde6be19e3985bd580
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-11 18:43:36 -04:00
Ashod Nakashian
849b744896 wsd: test: more parallel test execution and simpler Makefile
Change-Id: Ieacbfe9bedd90a7b1f55dac84d3fdffa22918e1b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-11 10:04:01 -04:00
Gökay Şatır
c82d614d16 SectionContainer: Remove extra "interactable" check.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I296343dbf24e2daf5131d537d8d87496c0b51842
2021-04-11 16:28:45 +03:00
Gökay Şatır
1b4575483a AutoFillMarkerSection: Fix for splitter point.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I4fb19a52c94fea6c3da13367cc427df3e2ca9cae
2021-04-11 16:28:31 +03:00
Gökay Şatır
2a9ff2e25f CanvasSectionContainer: Update test div upon setting section position.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I99a9ca533293bb520449e12ff92074aec13b28ee
2021-04-11 16:28:31 +03:00
Gökay Şatır
55ec901333 CanvasSectionContainer: Add showSectionProperty.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ic9b5636ca6da661d4bb00f35e66764e926cbaef8
2021-04-11 16:28:31 +03:00
Gökay Şatır
1ce3ac86e3 Autofillmarker: Follow up-2.
Set cursor style.
Fix bug related to split panes.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Id469f74077f8897227c84da6821c14d0fa87d269
2021-04-11 16:28:31 +03:00
Gökay Şatır
e5a7962147 CanvasSectionContainer: Add document object feature.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I20023403a2f693cdf0670eb92b5d3d1ee362f415
2021-04-11 16:28:31 +03:00
Gökay Şatır
a6b9d71c22 ScrollSection: Remove unnecessary assignments.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ic1257df185d94524f7d6fe4a53cfb949700ba57c
2021-04-11 16:17:25 +03:00
Ashod Nakashian
bd67b25872 wsd: SocketPoll::poll overloaded for deadline time
This makes it simpler to call poll repeatedly
within a given timeout, by first calculating
the deadline and passing it to poll to handle
the math.

Change-Id: I7a9311286ec368c853de40f10523b7b98c8f8106
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-11 01:05:20 -04:00
Ashod Nakashian
cff7841e65 wsd: test: log more in UnitHTTP
Change-Id: I6418ed43a177ecbf702ce388df749274ac290460
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-11 01:05:20 -04:00
Ashod Nakashian
0a73175764 wsd: reduce string copies
Change-Id: Ib38d7ebf1e66680779720cc1ce4d9bd07f9cab0a
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-11 01:05:20 -04:00
Ashod Nakashian
935448424f make: build test after JS and WSD
Change-Id: Ifb073e31fedf67f96a877e9d3284bd4fae80c255
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-11 01:05:20 -04:00
Ashod Nakashian
374f278228 wsd: WebSocketSession isSecure() -> secure()
Change-Id: I3d15414e0527b6651f5e8bce172e15e646003144
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-11 01:05:20 -04:00
Ashod Nakashian
786e07addf wsd: test: improve 500 GET test
This fixes a rare race-condition and thereby
improved the reliability of this test.

Change-Id: If308c6e28cd7de7a70adbfd99f6f6623ff990e5d
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-11 01:05:20 -04:00
Ashod Nakashian
d6e2e641a2 wsd: make single-argument ctor explicit
Change-Id: I0adb3f73a92bbe5dedcf3d2c67b2935c13af5de0
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-11 01:05:20 -04:00