Commit graph

3508 commits

Author SHA1 Message Date
Tor Lillqvist
941f400e71 Minor comment fix 2016-09-16 12:03:57 +03:00
Tor Lillqvist
9d03ff2946 No need to include ChildSession.hpp here 2016-09-16 11:25:06 +03:00
Tor Lillqvist
4799bcc73e Clarify comments about the meaning of the three LOOLSession subclasses
Be careful in using the definite article for classes that are
instantiated as singletons in a process, and otherwise an indefinite
article. Also mention in which process objects of the type in question
exist.
2016-09-16 11:24:35 +03:00
Tor Lillqvist
9d17637488 Fix comment 2016-09-16 11:24:12 +03:00
Henry Castro
f1b54a3f57 loleaflet: add border color to L.Popup 2016-09-15 17:21:33 -04:00
Henry Castro
9ef5eaee88 loolwsd: ignore .dirstamp 2016-09-15 16:05:34 -04:00
Henry Castro
4d6fadfc0b loolwsd: test: simplify each view 2016-09-15 16:00:02 -04:00
Tor Lillqvist
d170a0c774 Remove some ASCII art 2016-09-15 21:32:35 +03:00
Tor Lillqvist
4197bc5881 Don't hide errors behind a bogus default
If TDOC is not defined, this is broken. Defining it as "" in that case
won't fix anything. Use abs_top_srcdir to be less dependent on what
the cwd is when the code runs.
2016-09-15 21:32:35 +03:00
Henry Castro
a97d6f5449 loolwsd: test: graphic view selection 2016-09-15 14:14:49 -04:00
Jan Holesovsky
a6f70aad79 bccu#2005 follow-up: Another place where we need the dummy document broker.
I think this is another potential race condition...
2016-09-15 17:48:01 +02:00
Jan Holesovsky
10392f9ba6 Decrease the level of indentation. 2016-09-15 17:22:28 +02:00
Jan Holesovsky
d1e0b978d6 bccu#2005 follow-up: If the document appearead in the meantime, finish early. 2016-09-15 16:36:29 +02:00
Pranav Kant
912281bd20 loleaflet: dos2unix this new file from upstream Leaflet
Change-Id: I87000cc481dc9b8880d80606b16cd4151d572be1
2016-09-15 19:25:10 +05:30
Marco Cecchetti
80153826db Revert "loolwsd: we use callbacks latch for not missing messages sent very early"
This reverts commit ed983f17cb.

Conflicts:
	loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKit.h

Change-Id: Ia85b4d9223e9918dd33a66b8d6aeb0c3a1516a3c
Reviewed-on: https://gerrit.libreoffice.org/28904
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-09-15 13:23:39 +00:00
Jan Holesovsky
27bed804d5 bccu#2005: Make sure we don't create 2 jails for the same document.
When 2 users opened the document at the very same time, it happened that new
jails / instances were created for the document twice.

As a solution, insert a dummy (marked to destroy) document into the map of
DocumentBrokers, which will lead into synchronization between the two
instances.

[I suppose the synchronization did not work previously either, as emplace()
does not seem to modify the value when the key is already in the map.]
2016-09-15 12:50:26 +02:00
Miklos Vajna
27220aea39 test helpers: avoid unnecessary copies
Change-Id: I014cedcc10078ce03d1f4f3ae9403b6282b7dcac
2016-09-15 10:33:26 +02:00
Henry Castro
7cb35bff63 loleaflet: view name bind to popup 2016-09-14 19:30:26 -04:00
Henry Castro
44c3d5dfde loleaflet: add Path.Popup 2016-09-14 19:23:41 -04:00
Ashod Nakashian
c01629ab2a loolwsd: only prioritize tile messages and not tilecombine
Change-Id: Ia292e5b499dd4409dc3a672e4d5360c868d6c71f
2016-09-14 23:20:12 +01:00
Ashod Nakashian
ad6d77cd3b loolwsd: remove cursor of unloading views
Change-Id: I4281a5aa101f034007aa227bb18b14eeba806ea0
2016-09-14 23:19:56 +01:00
Ashod Nakashian
2db1db06c7 loolwsd: queue -> tileQueue
Change-Id: If61de6807fa7f52a703fe45948df911fe162f69a
2016-09-14 23:19:45 +01:00
Ashod Nakashian
ece87da287 loolwsd: tile prioritization per view cursor
Change-Id: I1410b64982ac2db04e5a47d744a95b8d2eab5f7e
2016-09-14 23:19:38 +01:00
Michael Meeks
787ee1d2d2 Revert "loolwsd: don't combine tiles by row to allow for better culling"
This breaks combine-tiles very significantly, viewing images
in documents with this appears to show each tile scaling and
rendering individually.

This reverts commit 99d0ee2ac1.
2016-09-14 22:15:43 +01:00
Pranav Kant
8bd7d83bdc loleaflet: Handle multiview text selections for part documents
Change-Id: I56425cde49b2b3b319204d7172f4ec4080b5bed1
2016-09-15 00:12:17 +05:30
Pranav Kant
4b18ca3772 loleaflet: Remove unused code
Change-Id: Ieb12e03b68eaacb99acb9853d02191c165f5b70c
2016-09-14 20:07:48 +05:30
Miklos Vajna
a652a013aa LOOLStress: unused using declaration
Change-Id: If20c38a4575074e7ca30069115002aadd1a1847f
2016-09-14 09:20:55 +02:00
Henry Castro
f85e6cfad9 loleaflet: simplify iteration view 2016-09-13 17:26:41 -04:00
Henry Castro
663f47b858 loleaflet: update graphic markers
LayerGroup handle internal list
Map handle internal list
TileLayer handle internal list

Reduce internal list
2016-09-13 16:24:35 -04:00
Miklos Vajna
74a29c4ee4 MessageQueue: avoid allocation of unnecessary temporary strings
Change-Id: I9162407020d84d0c92c9d1c6dfab806c67f3b873
2016-09-13 08:41:51 +02:00
Tor Lillqvist
c56888159a Update to match core master
Just two small comment and whitespace changes.
2016-09-12 13:09:08 +03:00
Miklos Vajna
6006e22001 LOOLKit: use std::move() in Document ctor
Change-Id: I25aeb5285465385858180747f441a69b858c4fe6
2016-09-12 08:15:37 +02:00
Marco Cecchetti
ed983f17cb loolwsd: we use callbacks latch for not missing messages sent very early
- lok::Document::setCallbackLatch: used on doument loading for
set/unset the latch

- now cell cursors of other views are correctly notified to the new
view
2016-09-10 21:28:11 +02:00
Marco Cecchetti
edc1302f16 Revert "loolwsd: we use callbacks latch for not missing messages sent very early"
This reverts commit f2106157f3.
2016-09-10 20:51:59 +02:00
Marco Cecchetti
f2106157f3 loolwsd: we use callbacks latch for not missing messages sent very early
- lok::Document::setCallbackLatch: used by a child session for
set/unset the latch

- lok::Document::registerCallback has a new boolean parameter used for
setting the latch state just before the callback is actually
registered for a (new) view

- now cell cursors of other views are correctly notified to the new
view
2016-09-09 22:23:51 +02:00
Henry Castro
46a314206b loleaflet: avoid undefined variables when map not loaded 2016-09-08 16:48:56 -04:00
Henry Castro
e9f3fd4e56 loolwsd: test: cell view cursor 2016-09-08 12:16:51 -04:00
Henry Castro
878fff5ebb loleaflet: fix part not taken into account for cell cursors 2016-09-08 12:11:07 -04:00
Henry Castro
f751d36c8f loolwsd: test: view cursor visible 2016-09-08 10:27:42 -04:00
Pranav Kant
d2bf039d59 loleaflet: Implement object/image multiple view selections
Change-Id: Ifc2d6f95fa48a947fc043bf48d582ab549fa6172
2016-09-07 21:47:11 +02:00
Pranav Kant
33a5c4bc70 Fix comment
Change-Id: Ib43bcc7378590e71b98856c11218fd99ad90d32d
2016-09-07 21:47:11 +02:00
Henry Castro
d4d764cee5 loolwsd: test: invalidate view cursor 2016-09-07 12:21:34 -04:00
Henry Castro
a666c01c03 loleaflet: fix part not taken into account for cursors
Also refactor cursor marker
2016-09-07 12:18:14 -04:00
Pranav Kant
1b0088ab69 loolwsd: Comments
Change-Id: Ia4e91f18d695ac2249fa1139afbcb5b3f65f87ba
2016-09-07 11:37:12 +02:00
Pranav Kant
3f421be4da loolwsd: Code reuse, and don't send 'remview' message to inactive clients
Use the existing function notifyOtherSessions() to broadcast the
message.

The function also takes care of sending this message only to
active clients.

Change-Id: I98d40429de17463167a67cb10ba59381a0cbc525
2016-09-07 09:20:37 +02:00
Pranav Kant
9edb1c2994 loolwsd: Don't send addview notification to inactive clients
Change-Id: I4771e4bf12057fdc7099e9433d3b7dc2198cb265
2016-09-07 09:20:37 +02:00
Tor Lillqvist
c4733fd4d2 Revert "Mention --without-system-nss"
That is the default anyway.

This reverts commit 894b0a11b0.
2016-09-02 15:15:40 +03:00
Tor Lillqvist
894b0a11b0 Mention --without-system-nss 2016-09-02 15:08:49 +03:00
Ashod Nakashian
99d0ee2ac1 loolwsd: don't combine tiles by row to allow for better culling
Change-Id: I30c0a9caad51bd77360a97c9f5899742385ccc27
Reviewed-on: https://gerrit.libreoffice.org/28615
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-09-02 11:30:42 +00:00
Ashod Nakashian
2663f9b63f loolwsd: replace old tile requests with more recent ones
A new queue with own thread now processes tile requests
so we have a chance to cull backlogged tile requests
that have since been invalidated.

This reduces load on the server significantly, especially
with multiple view at different zoom levels, and very fast
typing.

Change-Id: I6599939cd363dc71c30187f40d542aa37260dc56
Reviewed-on: https://gerrit.libreoffice.org/28607
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-09-01 20:47:10 +00:00