My local run failed in this test, because scrolling to the right just
twice resulted in a partially clicked toolbar item, so:
cy.cGet('#Home-container .unospan-CharmapControl').click();
failed. Force the clicking so a half-visible toolbar item also gets the
click.
An alternative would be to add a 3rd click if scrolling to the right is
still possible, but that looks less clean.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I4caa3dc79df1bbbd5bd0c7e88ef1baea8ae4b17e
Given the surrounding debug we should be able infer the same
state from its absence.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Id20de40f67ed52dc5535585aec9b5888131d6324
Move Typer and Randomize User Settings to "Functionality" menu
Rename main toggle to "Enable"
Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: I75709124f835c46ae741c4d51e14ed0b868528ae
Should save time in CI for simple JS errors.
Change-Id: Ib7e1ab68795cab12f8f5ec461cfed6e84986f440
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
WhiteBoxTests.cpp:660:10: error: 'updateActivityHeader' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
void updateActivityHeader() const
^
../kit/ChildSession.hpp:89:18: note: overridden virtual function is here
virtual void updateActivityHeader() const = 0;
^
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I12f21fd9fbe0ba77d2196bfcd1cbdb5ef07e5d06
To address the lack of visual feedback during the delayed saving of document titles, a loading bar has been introduced below the document name/title input field. This provides users with a clear indication of the ongoing save operation. Additionally, the delay that previously occurred after entering a new document name and pressing Enter has been eliminated, streamlining the save process.
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
Change-Id: I9c5a41f999d02dcfaa24e7925029499cf310b2e0
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
This resolves the following Python warning.
unocommands.py:319: SyntaxWarning: invalid escape sequence '\('
f.write('''};
Also make sure the output depends on the script
Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: I11f1e028c9c132f4afc66f9b5a6137b478f00774
Cue up some basic state for being signal safe dumped on crash/abort.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ibc6713aef2a0e7b878b178b05f0e13c8d40b47fc
Also move its declaration to the top of the class section with other
class members.
Signed-off-by: Méven Car <meven.car@collabora.com>
Change-Id: I506423078423074171ab00efb6f2d3fab0c68796
This is an issue if we use encoded and decoded WOPISrc for the
same document when using load balancers like HAProxy. It should
be always encoded.
What we did:
cool.html:
http://haproxy.local:9980/browser/2a43eb3236/cool.html?WOPISrc=http%3A%2F%2Fsomewopisrcfileaddress&title=title
ws:
ws://haproxy.local:9980/cool/http%3A%2F%2Fsomewopisrcfileaddress/ws?WOPISrc=http://somewopisrcfileaddress&compat=/ws
These 2 were redirected to different nodes when balancing
was done based on WOPISrc
This is regression from commit a722687c11
browser: simplify getParameterByName
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I17f0c4551404cece0bb995205459f2b38e860795
The mount-point must exist already, since
we always mount read-only. There is no
directory to create, but the subsequent
chmod always fails, since the mounted
directory is read-only. Since we started
warning when chmod fails recently,
6208b37a32,
these previously-silent failures became
noisy.
Change-Id: I9efaa89182c016e9a7a5d36cc3da5bfa7ee599c2
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This enables our own logging (much faster)
out of the experimental flag and enables
permanently.
Not for backporting.
Change-Id: I15161ff4f82a2e298942f81f35aea305bb06f683
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
so remove one in favor of the other
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I47778f7bce24f0687565aa179b7a3bbea9d95120
Curently, the exportpdf command hangs in the android app. A fix is in
progress, but as a stopgap solution disabling the command will avoid
people getting stuck
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: Ied74c3f1fa57356542f3f71e1becbae81f5af7fc
This moves the clipboard resque logic earlier to
make sure it is cached before the Kit process
exits.
By putting the clipboard-fetching command before
the save-before-exit, we should get the clipboard
in most-all cases. There are still edge-cases
that can slip through, but they should be much
less frequent, and they will require much more
involved logic (tbd).
Change-Id: I0eff95c28524002a6131fa0a57ef8e09ae21ca59
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Remove most calls to cy.wait(), reduce and comment the rest.
Stub waitUntilIdle and clickOnIdle
Fix many failing tests
Reduce total cypress runtime by 45%
Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: I62ddfdcbc3ab107654459ebece2d325eca0c6156
problem:
drag selection starting from the first row or column would result in first col or row being unselected.
It was caused by index being 0 resulting in condition being false
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I3619f52ccc7fdb2883af547f1c907c07ef27ddf9
It seems when users are unknown we can get a different JSON bject:
Object { ViewId: "8", UserName: "Unknown", Color: 13013504, … }
This is then flagged and set as a different (from the identified
avatars) html element in createAvatar from Control.UserList.js
Better to fix the alignment via CSS
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I94fee62ae14bb47c6f989b4e0bb147f8ffc9ff39
This button does nothing (Sidebar: Style: dialog button [square with arrow])
- There is no paragraph style dialog in calc
- The style sidebar pane visible on core side is not implemented in
online
Better to hide it for now.
Fixes https://github.com/CollaboraOnline/online/issues/8135
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I62db3ec6466782a9dc2cb89deffec8023851de2d
To avoid the following warning in C++20:
error: implicit capture of ‘this’ via ‘[=]’ is deprecated in C++20 [-Werror=deprecated]
Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: I8b195d675ddc87fa6b16f7240a046fac9a7769e1
Avoid using LOG_TRC etc. during static initializers before logging
is setup:
#0 0x00007ffff7362183 in std::string::size() const () from /lib64/libstdc++.so.6
#1 0x00000000007d1acc in std::operator==<char> (__lhs="", __rhs=<error reading variable: Cannot access memory at address 0xffffffffffffffe8>)
at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/basic_string.h:3586
#2 0x00000000008fdc04 in Poco::Logger::unsafeGet (name="") at src/Logger.cpp:289
#3 0x00000000008fdb81 in Poco::Logger::get (name="") at src/Logger.cpp:280
#4 0x000000000066a30f in Log::logger () at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/new_allocator.h:90
#5 0x0000000000692f8e in Util::rng::getBytes (length=16) at ../common/Util.cpp:122
#6 0x0000000000693312 in Util::rng::getSeed () at ../common/Util.cpp:91
#7 0x000000000044f987 in __static_initialization_and_destruction_0 (__initialize_p=1, __priority=65535) at ../common/Log.hpp:87
Change-Id: I6a32a0d3f50a8e769994737d4c09befe11599b4e
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
And improve quality of low-grade random numbers significantly.
_rd.entropy() ? is not your friend.
Change-Id: I477557245949334bec517cdeae653c7452ed2049
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Helps us to catch un-necessary invalidations more precisely.
Change-Id: If5d681c025252e9e860e744945b33b68047524d9
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
