Commit graph

13179 commits

Author SHA1 Message Date
Andras Timar
95a7020155 remove untranslated welcome files
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ia947b2509a65d98535bd7c15894f6a7151b61207
2020-11-25 16:58:09 +01:00
Yunusemre Şentürk
e20e65d91a Android: Change target SDK version 28 -> 29
Signed-off-by: Yunusemre Şentürk <yunusemre@collabora.com>
Change-Id: Iad612e973ffb4a8851c6d0e657ff124a32b42828
2020-11-25 07:27:30 +01:00
Andras Timar
19f9492883 loolwsd-systemplate-setup requires cpio
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I427b834336019d11186ede1dc70ede777dc80e11
2020-11-25 07:26:44 +01:00
Pranam Lashkari
fcbc35eb7a leaflet: use crosshair cursor for autofill marker in calc
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ib6980d284d5f1b22337320271106cad0bd0744d2
2020-11-24 16:18:27 +01:00
Pranam Lashkari
47e142e278 leaflet: fixed menu entries being overlapped by menubar
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I38f8b6db97ca91901657b1738a87b4e40c2083a4
2020-11-24 15:24:51 +01:00
Thais Vieira
29588ee18b impress/cypress: add tests for highlight color.
Signed-off-by: Thais Vieira <thais.vieira@collabora.com>
Change-Id: I074c397ad6fe68a0841dc71c8465b760ac644eb7
2020-11-24 14:20:13 +01:00
Szymon Kłos
992a0bc8f3 autofilter: use last position if new not set
Change-Id: Ic564ab88f46d521227cb375b0c8d394a3ed77d5d
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-24 13:01:16 +01:00
Szymon Kłos
f60acb87b8 autofilter: support submenu for custom sort
Change-Id: I824c209d645c215db7435c0925dcb0e340c47fa3
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-24 13:01:16 +01:00
Szymon Kłos
63e3ea0de4 jsdialog: make dialog draggable
Change-Id: I8c59f021a9039844ff6c6a534dd0c5c205e75f4c
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-24 13:01:16 +01:00
Szymon Kłos
681247f8ab jsdialog: handle dialog close using titlebar button
Change-Id: I66fd092ed6bad688671a0205e866dc82d6968415
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-24 13:01:16 +01:00
Szymon Kłos
db9390d2d9 jsdialog: drag and drop support for treeview
Change-Id: I077037986b4c527254b85ab7169e088042f197d7
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-24 13:01:16 +01:00
Szymon Kłos
0a92464615 jsdialog: implement frame widget for desktop
Change-Id: Ib42b33f0c44585f756bf141c09293348fcaa786d
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-24 13:01:16 +01:00
Szymon Kłos
b6ef56e822 jsdialog: implemented expander widget
Change-Id: Ic790195a28b47d1ac8aca6082a0d133d3e548992
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-24 13:01:16 +01:00
Szymon Kłos
a6d8a19830 jsdialog: build also empty treelistbox
Change-Id: I1d00e057a29c2374f83af6cb6edfcfd93a5e701f
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-24 13:01:16 +01:00
Szymon Kłos
4fa83a4761 jsdialog: create container for desktop dialogs
Change-Id: I68bc6f5afeccdf2642e117d59ac17fe5e83e5824
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-24 13:01:16 +01:00
Szymon Kłos
2bd82fe0a6 autofilter: position according to calc input bar
Change-Id: I0bbfd2a925982c6759be95f9322e30776ceecd74
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-24 13:01:16 +01:00
Szymon Kłos
984d8ac954 jsdialog: use placeholder for edit fields
Change-Id: I7b38aadada3942e046969325a903ca283477d476
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-24 13:01:16 +01:00
Szymon Kłos
0cace5161f jsdialog: implement treeview widget
Change-Id: I8eaebf2090dc1da1849ef6e64712ef9f23c2a6b0
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-24 13:01:16 +01:00
Szymon Kłos
7b82f9a9b4 jsdialog: handle autofilter dropdown
Change-Id: Ib47185359526f030a80aa9f7d7f9ef6e2ab93b34
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-24 13:01:16 +01:00
Michael Meeks
5fb3a7d8bd Remove obsolete locking and conditions around MessageQueue
Should no longer be needed since the unipoll transition.

Change-Id: Ie534cad7da0cfa54099175a86bc28dd16c738890
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2020-11-24 12:32:45 +01:00
Pedro Silva
5f1b5b518b Toolbar-down: zoom select flip arrow when opened
Signed-off-by: Pedro Silva <pedro.silva@collabora.com>
Change-Id: Iac717395eb7012815b2bd9b5448ad40ced76d471
2020-11-24 12:13:19 +01:00
Pedro Silva
9adb5095c7 Toolbar-down: fix Selectors inconsistencies, make arrows react (flip)
Signed-off-by: Pedro Silva <pedro.silva@collabora.com>
Change-Id: Ie42c11a4a63d4e9f467b65ee71a9178f695d4479
2020-11-24 11:21:23 +01:00
Ashod Nakashian
d4857b603b wsd: cleanup temp incoming directories after use
The temporary directories created for convert-to
and insertfile are used only once and should be
cleaned up to avoid clutter.

We also de-poco the temp directory creation as
it doesn't add value and do a bit of cleanup.

Change-Id: Ie1fd5b4749788ff4407f2cc886d405258f65f97a
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-11-23 21:29:34 -05:00
Ashod Nakashian
fad4222a2a wsd: move convert-to docs into the jail
We now download the convert-to files into the
child-root/tmp directory and then move it into
the jail that will convert it. This way ownership
and cleanup become contained within our child-root
and jail subsystems. This reduces the chances of
leaking convert-to files and simplifies the design.

In addition, we avoid an extra file copy and improve
the security of the convert-to API.

Change-Id: I450c24d0d0dc0da447c8072b0701c3b48d07c81b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-11-23 21:29:34 -05:00
Thais Vieira
51649f3699 impress/cypress-test: added test for font color.
Signed-off-by: Thais Vieira <thais.vieira@collabora.com>
Change-Id: Iea532287eec0f55ba09d45298f2f904753088ba6
2020-11-23 15:44:16 +01:00
Andras Timar
75947daccc docker: RHEL8: Install cpio (missing dependency needed by loolwsd-systemplate-setup)
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I0224e3bcabf84fb44e5ec9937bd0e765f5a64324
2020-11-23 15:22:28 +01:00
Szymon Kłos
476038d4ea Make notebookbar tabs pannable on tablets
Change-Id: I319c4bc613adcf7d00a8c51e51cfa55ede25c7ec
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-23 14:42:29 +01:00
Szymon Kłos
8bacb93ed6 Reload annotations after idle/reconnect
Change-Id: If124eced58e012720f26030dd27b8f432a9b9081
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-23 14:42:29 +01:00
Szymon Kłos
30904ec859 clipboard: use input fields if active
Change-Id: Ic6c84681d79af936c3f2e9d0ca983ecbb100e6fb
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-23 14:42:29 +01:00
Szymon Kłos
dedcde3217 Prevent flickering on annotation switch use
When scroll down button was used the view was jumping
on every use what caused flickering.

Change-Id: I16de0e9d01c9d025977edc6affc16de4bd098b49
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-23 14:42:29 +01:00
Szymon Kłos
86c16392b8 Accept changes tracking entries in context menu
Change-Id: Ic7700f32ab93e0150ad2242dd178a767c9e1d109
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-23 14:42:29 +01:00
Szymon Kłos
c6515621a9 notebookbar: add conditional formatting submenu
Change-Id: Ife366608c5605f96995e95a12352e4e70d4b04bb
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-23 14:42:29 +01:00
Ashod Nakashian
f60753a951 wsd: misc cleanup
Change-Id: Ief6cbc40ef2f7d98b0b76477109332676dab45b2
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-11-22 22:26:36 -05:00
Ashod Nakashian
f665816812 wsd: getTempFilePath -> getTempFileCopyPath
These helpers are for testing only. They should
ideally be moved to the test helpers, but because
of dependency on the FileDeleter in FileUtil they
remain in FileUtil.

Change-Id: I93c7e08823edec8f6a53419f0a6596f3255f23f9
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-11-22 22:26:36 -05:00
Ashod Nakashian
3724ab4e35 wsd: centralize temporary directory helpers in FileUtil
Change-Id: I9b55d0b8d4c55a68af4baa7e638627de6c73b64d
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-11-22 22:26:36 -05:00
Andras Timar
93870d7e08 typo in docker/README
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I134187c8f88aa115796d850be2c6d9b0e29bc8a1
2020-11-22 22:41:42 +01:00
Andras Timar
06623247f0 typo in docker/README
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ib9305de89421540f6341d96318f639dde100b69b
2020-11-22 22:40:02 +01:00
Andras Timar
34b8ff08f6 Docker bits
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I4b4d8f9d6ccb8648d5d75e6abff751d1b37e8773
2020-11-22 22:19:34 +01:00
Ashod Nakashian
054ab5f61f wsd: specialize thread ID serialization
On non-Linux systems we should default to std:🧵:id
which needs to be serialized using ostream interface.

While Util::getThreadId does specialize for Linux, the
code using it doesn't always handle the different return
types.

While std:🧵:id is the standard interface to the
thread ID, using such abstraction has proven to be costly
when converting the thread ID on each and every log via
ostringstream (due to the cost of memory allocation).
In practice Linux is the primary and so far only platform,
so the getThreadId is optimized for it. Other systems
can either use the default std:🧵:id, or can also
specialize as necessary.

Change-Id: I91cf279a8fdff12636a534957db5069dee51bd65
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-11-21 19:49:46 -05:00
Gleb Popov
854065200c Do not try to convert std:🧵:id to integer value.
This is not allowed by the standard and libc++ is more stricter than libstdc++ on that matter.

Luckily, the conversion is used to turn it into a string, so just use stringstream to convert the thread::id directly.

Signed-off-by: Gleb Popov <6yearold@gmail.com>
Change-Id: Iea1a844a086b7fe7ed4703fd06e1d538d5d0bc43
2020-11-21 19:49:46 -05:00
Andras Timar
3f81bfd987 Add /var/log (default log path) to ReadWritePaths of loolwsd.service (fixes GH #739)
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I47e8a0983fd74656739498bf02bad117e821cfbf
2020-11-20 20:19:43 +01:00
Tor Lillqvist
82287c2ad2 Ignore pan gestures while selection handle is being dragged
Fixes https://github.com/CollaboraOnline/online/issues/398 .

Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I7ce26a45f2487ad18351ff382283b5c5167985c6
2020-11-20 18:21:28 +02:00
Tor Lillqvist
0407b86a17 Avoid on-screen keyboard never returning if dismissed explicitly
Fixes https://github.com/CollaboraOnline/online/issues/505 .

Change-Id: I4f42d716ad3e7455f5117f8031924536c6100bb3
Signed-off-by: Tor Lillqvist <tml@collabora.com>
2020-11-20 18:21:28 +02:00
Pedro Pinto Silva
c804625b52 StatusBar: InsertMode: differentiate between insert and overwrite mode
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I602b78823d45e8ce13f641515669a70016c8c88f
2020-11-20 16:44:45 +01:00
Andras Timar
4b29a54803 loolmount requires cap_sys_admin
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ic7df285bacc684af4167c8f2301118341e859d0f
2020-11-20 09:20:16 +01:00
Tamás Zolnai
01813eceec cyperss: php-proxy: Undo / Repair test passes now.
Change-Id: I17293ecc2f1490855cc1a217776b8c853c8c974c
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-11-19 13:47:24 +01:00
Tamás Zolnai
db1584c664 cypress: avoid unintentional resizing.
We use simple cy.click() on mobile, we might
get a better result to use a different way for
tap on document in the future.

Change-Id: I4b0c6989aaf105ae79be930ffc54898414efb92a
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-11-19 13:47:24 +01:00
Tamás Zolnai
50df517e65 cypress: NC: these log configs are not necessary anymore.
Change-Id: Iafa7f6f415d336b8b281bd7df528ec4baf2ec2a4
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-11-19 13:47:24 +01:00
Ashod Nakashian
1f24489db6 wsd: retry jail cleanup if it fails
It is possible for the jail directory cleanup
to fail, if there are still references to at
least one file in the jail. In those cases we
keep the jail path around so we can retry the
next time we cleanup a jail. This reduces
the chance of leaking jails until restarting
the service.

Change-Id: If6116ef598afc91063de71c66870bd6426a971ba
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-11-19 10:12:38 +00:00
Ashod Nakashian
3382dad05c wsd: const correctness and string ctor instead of literal
Change-Id: Id6b9ca28b09d11344d47099a2244e189afe14841
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-11-19 10:12:38 +00:00