Counter-intuitively, our retina scaling pixel multiplier is a
different integer multiplier than L.Util.dpiScaleFactor() in many
cases, being either 1 or 2.
Change-Id: I18078eca80b86216751738368d9885151a41dde2
The problem was that in CalcGridLine.onUpdate the integer costants
Number.MAX_SAFE_INTEGER and Number.MIN_SAFE_INTEGER were used.
Unfortunately such constants are not supported by IE11.
Change-Id: I0a0fba0c1eaa922b925168c16d3afd395c0d38f0
Based on information from UNO ViewRowColumnHeaders messages, this draws
the grid lines with Leaflet's SVG polylines, in a background pane.
To prevent visual glitches on touchscreens, this also reverts parts of
26aad36771ebd5a304b763912184acd2ea26dfdf - that introduced a regression
that prevented 'dragend' events from being fired when inertia-dragging.
Instead, inertia drag is disabled in the L.Map constructor.
[ Miklos: cherry-pick these early as they prevent automatic merging. ]
Change-Id: I86c68214822a0a2c2f8ced82ccf5a6c201e2cf04
We need to force the document size recounting in Impress, because the
document size actually "changes" there on zoom: The annotations are in
absolute pixels, so when you zoom out, it is as if the absolute-sized
annotations grew larger, so we have to extend the document size,
otherwise they are cut off.
But triggering the document size change too early leads to the
sideeffect that the layer with the cursor and the tiles grid get out of
sync.
Let's do the same as in writer - react on the 'updatemaxbounds' event,
and force resize from there.
Change-Id: If84ddf3597be0383ff6ae2271e6ba6ae3bbd5210
Reviewed-on: https://gerrit.libreoffice.org/82604
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
For an array, memset(array, ...) and memset(&array, ...) do the same
thing - but given that there has to be the sizeof(array), the former
is probably more readable / obvious here.
Change-Id: I7e329cb1dcabb564e26857b0c7d9f88431bb4ede
Reviewed-on: https://gerrit.libreoffice.org/82601
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Miklos Vajna <vmiklos@collabora.com>
mobile:impress:mobilewizard:hide scroll-x
Change-Id: I3faa5cc983e50dcfbd85b7e3e21edc6b9652300d
Reviewed-on: https://gerrit.libreoffice.org/82605
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
It is not a good UX to change names of items in the menu - we have a
different mean of indicating that the master page view is active: the
tick in the menu.
Change-Id: I53486847b3929d990de6e398df96b04b943998e6
Reviewed-on: https://gerrit.libreoffice.org/82498
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
This simplifies lots of logic, making it trivial to get good row/column
header alignment at any zoom. Ultimately TWIPS were highly misleading
'print-twips', and in that state are ~impossible to map to pixels
accurately unless all data is present back to the origin
(which was not provided previously).
This requires the equivalent patch on master.
Change-Id: I110f6f646e2b52bec4584c193c640df6b41100f8
removed use of Poco::StringTokenizer from the wsd directory using LOOLProtocol::tokenize and std::vecor<std::string>
Change-Id: Ic50b4d4d71d4ffd005aacf6aef0ed2bfde66d40d
Reviewed-on: https://gerrit.libreoffice.org/82569
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
removed use of Poco::StringTokenizer from the tools directory using LOOLProtocol::tokenize and std::vecor<std::string>
Change-Id: I0673e658fd35cbdc7425a99f1dcea0b54923f52c
Reviewed-on: https://gerrit.libreoffice.org/82568
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
removed use of Poco::StringTokenizer from the test directory using LOOLProtocol::tokenize and std::vecor<std::string>
Change-Id: I20fc2e0ef0d0d8fc959fee7972aa095f2581c181
Reviewed-on: https://gerrit.libreoffice.org/82565
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
This was originally moved in commit
b97789eb76 (Convert paste testcase to a
new-style one, 2019-10-18), then
194db8ed45 (test: improve stability of a
number of tests, 2019-10-12) restored a duplicate of this, probably due
to a mismerge.
Change-Id: Ie76266ddb85c58bb2370640025b91af980656908
ChildProcess instances log in the dtor, and this can
happen after the log subsystem has been destroyed,
because the order of destruction is undefined.
NewChildren is destroyed in exit, at which point
we have no control over the log subsystem.
To avoid this inversion of order, we clear
the NewChildren container before exiting.
Change-Id: I7b1bac3123fd7917616c11ab9674534c9222fff1
Reviewed-on: https://gerrit.libreoffice.org/82533
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
mobile:impress: mobilewizard: hide horizontal scrollbar (was showing up in landscape mode)
mobile:impress: mobilewizard: adjust position when in landscape mode
Change-Id: I95e9b84a7b85bbafe1d0f510210a6cb840be9b12
Reviewed-on: https://gerrit.libreoffice.org/82512
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
- hide scroll elements (left, right)
- make it scrollable
- hide scrollbar (webkit, firefox, ie)
- tested on real devices (do not report/test based on desktop responsive mode. it's dubious)
Change-Id: I1dc509b36d4d16c3872561e8301d76ae708a286b
Reviewed-on: https://gerrit.libreoffice.org/82496
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I9a920de2436422c32a60a20084cfe668199acaca
Reviewed-on: https://gerrit.libreoffice.org/82487
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I8182f5945cddc56f9432c47e24c91434f550e82c
Reviewed-on: https://gerrit.libreoffice.org/82424
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Assuming that the test has to be adapted, and it's not like it caught
real badness.
Change-Id: Id0e6bc134aefdeb46d281ae6b2a5fbc9ae70e8a4
Reviewed-on: https://gerrit.libreoffice.org/82414
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Miklos Vajna <vmiklos@collabora.com>
Copied over from core, replaced 'core' strings
with 'online', and removed 'testfeature'
Change-Id: Iae18ebc97b6851dbe61e5b089fa479dd740e2a8a
Reviewed-on: https://gerrit.libreoffice.org/82356
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
It turns out that the std::filesystem is still not part of the NDK:
https://github.com/android/ndk/issues/609
The NDK has the header - but not the c++fs library yet :-(
Change-Id: Ic7003f71cd4730b2f34138adea3b09fe92fdbb4a
Reviewed-on: https://gerrit.libreoffice.org/82336
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
Adds possibility to tokenize using a regex easily.
Change-Id: Ie327d4faabec330c76d4cadb1d14bbe1527d332f
Reviewed-on: https://gerrit.libreoffice.org/82333
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
Particularly those used on Android...
Change-Id: I47bf9692f5e99ba30140d698558472201168a198
Reviewed-on: https://gerrit.libreoffice.org/82302
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
