Was moved before the poll in my
75438baa70.
Change-Id: I0ec99c0c1433d2e5d631720f003905cbd18206aa
Reviewed-on: https://gerrit.libreoffice.org/63052
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
It would just be ignored later anyway, and produce the warning "WRN
Dropping empty tilecombine response".
Change-Id: I6d92367262dc306369f2ca6c2e1964b5d151acc1
Reviewed-on: https://gerrit.libreoffice.org/63013
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
That "name" will be passed as the xauthor parameter in a message like:
child-01b9 load url=file:///.../x.odt?permission=edit jail=file:///.../x.odt xjail=file:///.../x.odt authorid=localhost1 xauthorid=localhost1 author=Local%20Host%20#1 xauthor=Local Host #1 readonly=0 lang=en-US
and that is parsed into space-separated tokens. Which leads to warning
messages like:
WRN Unexpected doc options token [Host]. Skipping.| common/Session.cpp:94
WRN Unexpected doc options token [#1]. Skipping.| common/Session.cpp:94
So use "LocalHost#0" etc instead.
Change-Id: I01ce8c4fb8309a7a9d3395e4fd874e469475d44c
Possibly we should make LOG_ERR and worse on iOS also do a NSLog()
call, to get such messages into the log the system collects?
Change-Id: Ie3be490966da9133286440c1de90b72befba773a
Sadly, it did not work as expected. Even if the LibreOffice core
source that are mentioned in project.pbxproh, and referred to using
the losrcdir-symlink, did show up in Xcode, setting breakpoints in
them did not work. A pathname to such a source file would include
"losrcdir-symlink" which woul not match the pathname actually compiled
in the corresponding binary. Or something like that. So we are back at
requiring manual editing of the LO core source directory path in
project.pbxproj.
This commit reverts part of 5f2a6f6aa3.
Change-Id: I15fb7363e287fdf4942ac9d362a7151202d0ee9d
But... sadly I now notice that the clever symlink trick from yesterday
doesn't actually work fully. Source files from core, present in the
project file as pathnames that go through the losrcdir-symlink
symbolic link, do show up in Xcode. But if I set a breakpoint in such
a file, it doesn't work.
(Xcode uses the pathname to the source file that includes the symlink
in it when recording the breakpoint, but the object file as compiled
contains its real path. So Xcode (or lldb) doesn't understand that
they are the same file. Or something.)
Being able to set breakpoints in these files in advance is the very
reason why I want them to be present in the Xcode project. Sigh...
Probably I will revert the symlink magic commit at least partially,
and go back to manually editing the project.pbsproj file to point to
the actual real paths of the core source files.
Change-Id: I2f7983cb95b65135ebf2d87b42614b35c902f986
On Linux, you use it just to process the JS bits, for copying them
over to the Mac where you build the app. (Because setting up npm and
whatnot on my Mac, from unknown 3rd parties, with unknown side
effects, semed a bit scary.)
It seems to work to add this only as an element under
CFBundleDocumentTypes, without adding anything under
UTExportedTypeDeclarations or UTImportedTypeDeclarations. Or is that
just because my iPad happens to have some other app installed that
already as associated the .xls extension with the UTI (as under
LSItemContentType) of "com.microsoft.excel.xls"? Or is that a
system-declared one? Sigh, I wish I understood this stuff
completely... or that I could find some up-to-date good documentation.
Hmm,
https://developer.apple.com/library/archive/documentation/Miscellaneous/Reference/UTIRef/Articles/System-DeclaredUniformTypeIdentifiers.html
does say that com.microsoft.excel.xls indeed is a system-declared one.
Change-Id: Ibf807b12a2d44077fd983cbb37d00e83b47b45b9
Since some days, you need to run the configure script in a tree where
you are going to build the iOS app anyway (to set the app's
user-visible name). Use the configure script to set up a couple of
symbolic links pointing to the LibreOffice core source and build
directories and the Poco installation. Use those symbolic links in the
project file.
Also, now a vendor-specific app icon set can be given with the
--with-iosapp-appicon option.
Change-Id: Ib936388a4cc680bd97ca6ef95a91e3296ab04d18
I got a crash report from SwDocShell::Edit. Let's see if adding those
source files to the Xcode project (but not to be compiled by Xcode)
means that Xcode will be able to show the actual crash location based
on such a report. (At least for crashes in the code that Xcode itself
compiles, I assume it works perfectly. But LibreOffice core code is
not built by Xcode.)
Change-Id: I1b6bf34e35a0e5652081a6dca40ba04312fbe20b
Added it to UTImportedTypeDeclarations, seemed to work. Not sure what
document types should be in UTImportedTypeDeclarations and what in
UTExportedTypeDeclarations. The documentation for document type
association is sadly rather vague.
I remember that some month ago I had horrible problems with this stuff
(see 26323fb92b), but now adding xlsx
went without a hitch. Not sure if I was just lucky, or whether iOS
12.1 has some bug fix related to this...
Change-Id: I75483719bd20496e8b44f935c788455148655a88
