This is a temprorary patch until we can properly
migrate the verification code to openSSL 3.x.
Change-Id: I676ae3b5a1e0d27ef1d253dba2275f7de5fc08ff
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
If I have used a path with symlinks in it when changing directory to
my build directory, what gets put in config.status as ac_pwd is that
path, not a realpath version. That then propagates to
ac_abs_to_builddir and to SYSTEMPLATE_PATH, which is what Makefile.am
passes for the --o:sys_template_path option to coolwsd.
To be on the safe side, do the tmpfonts dance both for the systemplate
path that might include symlinks and for one that has been realpathed.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I7575120090986e6207497c5ce740aedd6075e48f
we preserve original reason,
so setting default reason means always using default reason
and ignoring any other reason
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I837a13a129aa759a319406affc6e89425bf31361
This also makes us sure we are in sync due to
single point of knowledge about UI Mode
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ifefeee90666db7c341da52a7190ef09749b8e3ab
This avoids the runtime overhead of strrchr used
in logged filenames on iOS, which is unnecessary
on string literals, and adds unit-tests.
We also strip leading './' and '../' in other builds.
Change-Id: I56ec722d1400fad9165eb046d1bd8d4438241ca3
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Normally these kind of button wouldn't need a tooltip but:
1. Doesn't hurt to add it
2. It helps the user with understanding what that btn does:
- The button doesn't remove the current opened document
- The button doesn't save and close
- The button closes the document
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I45e63c4c7f42d314743702e6ff50b777527c4367
All NB items ids have EachWordCapitalized and are successfully target by
users/partners/users to change image for example, and expect them to be
have EachWordCapitalized:
- Notebookbar: Make rev-history -> Rev-History so it also can be
- Classic: Id remains "rev-history" in the case integrator rely on that
specific lowercase id
- Allow rev-history and Rev-History when checking id (Menubar.js)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7a5a31f78713fe43e1855021652500d0306c5ac4
All NB items ids have EachWordCapitalized and are successfully target by
users/partners/users to change image for example, and expect them to be
have EachWordCapitalized:
- Notebookbar: Make saveas -> SaveAs so it also can be
- Classic: Id remains "saveas" in the case integrator rely on that
specific lowercase id
- Allow saveas and SaveAs when checking id (Menubar.js)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia92a442eadb34c4b4ae374e54835d7866f70df7a
context: https://archive.org/download/repair-doc-close-misaligned/repair-doc-close-misaligned.png
line-height, if the hard-coded px is needed, then it should be the
same value as the width and height so not 28px but 32px
as it's the values used in a.leaflet-popup-close-button.
But better to just rely on the unitless value that line-height can
accept then it will fit whatever the font-size and width the anchor has:
- Fix it by letting the web browsers align the content for us. Web
browser multiplies our number by the font-size value (1 times font-size)
, so no need to depend on specific px values for that.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4145231241a9acc540c684971e3bde46adb2304b
The commit message of this commit was correct but it seems I end up not
git adding the latest change which obviously is not initial but 1.
This reverts commit c80d4ca62e.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I999e7e51ee36e4c162cc8d0a15bc9850fdd9c1fd
context: https://archive.org/download/repair-doc-close-misaligned/repair-doc-close-misaligned.png
line-height, if the hard-coded px is needed, then it should be the
same value as the width and height so not 28px but 32px
as it's the values used in a.leaflet-popup-close-button.
But better to just rely on the unitless value that line-height can
accept then it will fit whatever the font-size and width the anchor has:
- Fix it by letting the web browsers align the content for us. Web
browser multiplies our number by the font-size value (1 times font-size)
, so no need to depend on specific px values for that.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4145231241a9acc540c684971e3bde46adb2304b
if right clicked on already selected row/column range,
don't reselect the right clicked row/column
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I718a0a727913c38bc506fd2b808fba8feaebb0c8
starting with co-22.05 core we don't need old
autofilter code as it is now unified with popups
handled in Control.JSDialog.js
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I613d76950c9c9d727be958607d25793a3a69c28a
Context:
Repair document on the Notebookbar is currently always a small item
https://archive.org/download/repairdoc-writer-smallitem/repairdoc-writer-smallitem.png
,it should be a bigtooltiem when the extra additional/optional item
Sign document is not available:
- Set it to small item and vertically stacked when hasSigning is true
- Set it to bigmenubartoolitem when hasSigning is false
Note: Make use of the newly added bigmenubartoolitem in
8d149d31db
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I26a8e1b721bf2550127eff1ccfdc44ab4876db52
this will allow us to avoid doubled messaged
and ugly bugs, setting selection in JS works as
async call and it's hard to not trigger own handler...
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ibeae30c04374116776413b19ebd8efca043e9c0e
this patch handles formulabar generated with jsdialogs
for core version which supports that (>=co-22.05)
- jsdialog formulabar is implemented in Control.FormulaBarJSDialog.js
it does translation so instead of drawingarea we got input field,
later it sends events with modified type so core doesn't know about
any change in widget type
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I690409ec2e83e803ed9dfe3544e68b6521ae768d
This will allow us to improve code sharing between jsdialogs
and menubar / toolbars.
In the future could be used instead of special buttons which trigger
actions from menubar in jsdialog (what creates temp Menubar instance...).
in jsdialogs toolitem which will trigger shared action from map.dispatch
is a type 'customtoolitem'
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If528e8eb142b76d24cb9145cb265a505e7e9a5df
so we will not have problem with updates not catching
widgets with modified name - not needed not
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ifa29d3971120482c3dae4ede3db5bcf31ea1af95
example: toolitem without uno command but id
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I198fa3838e714251936de90f11e1d8d857025eef
- we need to create all widgets
- later we receive update events...
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I766f28e012c7b9ce3cb33478cdc3e55cd44eaa83
- symbols are standard images for buttons
- are shown as images: "symbol_<SYMBOL_NAME>.svg"
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I034c07ad299376837f65726f7ec1bceabb50ba01
Since we have the ability to quarantine documents,
we should save to disk even (or especially) when
we don't have a storage instance. This way we
can at least recover the document.
Although it's not clear when we will not have
a storage instance, if at all, separating saving
from the storage state is reasonable.
Change-Id: Ifa51ed3229424b567df8218b201ef914226db947
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
