fuzzers use the code as a library, so we don't produce binaries like
coolwsd in such a config, leading to:
Failed to set capabilities on file `coolforkit' (No such file or directory)
when building from scratch.
Just disable setcap in the fuzzers case, it's fine to not have these
binaries.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I178ec7d8fa4d582e5d7289764a6ce2227c049205
- added a new menu button 'form' in classic and tab button in notebookbar for content control
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ibe06667de39199fd2541fa70ced3ff879274366d
we should do the same for other modifiers: shift, alt
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I75933194aee82589c787c8c31cc47b66e96e2066
Avoid std::vector and its peculiarities, also store the crc so
that we get the perf. win from it.
Change-Id: If39ab01b5b987d707d1712076ae9a5beb32b36c2
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
problem solved:
some times when cell cursor is moved using keyboard,
comments were not unselected,
which caused problems when copying cell which contains comment.
i.e: comments were pasted inside the cell as plain text
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I318c850c25956d210ef9acfa631a689a4d1a71c6
The DocumentBroker dtor adds a callback:
#0 SocketPoll::addCallback(std::function<void ()> const&) (this=0x377dce0 <Admin::instance()::admin>, fn=...) at ./net/Socket.hpp:773
#1 0x0000000000947db5 in Admin::rmDoc (this=<optimized out>, docKey=...) at wsd/Admin.cpp:544
#2 0x0000000000bb8192 in DocumentBroker::~DocumentBroker (this=0x61900000e690) at wsd/DocumentBroker.cpp:579
So even if the fuzzer called Admin::instance().poll() on shutdown, there
was one more callback inserted to the list later, leading to OOM in the
long run.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I0832d839b098407fa9e8aadb6f84388a85d62323
We have many fewer full tiles to compress - so we can
trade a bit of space for some speed. Really should use zstd.
Change-Id: I7c310608173c924f175154bf6f7abb43d5e6f08d
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
This added begin and end mark to the popup so we can detect
we are leaving the popup and we should close.
This prevents us from blocking the whole UI by focusing
map and typing before popup was closed.
Also close popup when server confirmed it should be closed.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I1a290e27dd7a14eca2cd3bb8368fee27255f51a8
Before the expander button was detached from input this in turn was:
- Making it hard to understand what that button will do
- Affecting the overall look and feel of the formulabar (different border-radius etc)
Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: Id17742aae8b09acd3bdcbffd05fe17181492322d
Add expand toggle class to parent and use it to align unotoolbuttons
Before, there was no way to know if the input was expanded or not by just looking at container
or any parent. thus, no way to fix alignments per MultiLine status
Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: Idddefc32812a3aab29ddb72c4d09bacd43b03287
some unotoolbutton was being set with the same same size as it's img child
- There is not need to do this only for :not(.has-dropdown)
- Make sure img has correct size, let parent element to adapt, no need to
single out this case
Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I1c3734a81cb01a0d15604a2b88148a0f883a59d1
Formula input window (textarea) had different height from address input
- Set it at the same height as seen in toolbar.css:211
Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: Id0fc3dfb0335183050eedc00036b85dbafe2d0b4
Avoid using percentages when we can already use the grow property
(it avoids different results across browsers)
Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I262cfdf5d72313296620e3e522bfa97ab2b00ca5
In order to get the list users and identify if it
is a guest user to not show the welcome dialog.
Change-Id: I439f46dcfd3ea5b307059952f98f49a387158e24
Signed-off-by: Henry Castro <hcastro@collabora.com>
Reset document info on idle
resetting document info will force to use new status of the document
problem:
reconnecting after idle, user could not type anything in document,
this was due to some properties were to set assuming they existed from last session (i.e: clientzoom)
resetting document info will force to use new status message and set all the properties again correctly
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ibcf395eee3a4e0b99413de0178331d42a1354253
We have around ~8k smaps lines for each process, polled regularly.
Change-Id: I7e78b17e52aeaec55fa17c5192a940aa9e44b045
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Don't use strings coming from uno commands as they include
"Insert":
1. There is no need to say that these actions will "Insert", they
are already in the Insert tab
2. All other actions do not have Insert so it would be not consistent
3. On top of that with Insert in each icon the labels look quite long
Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I286e95187d5df08cdf2d71bd99f3b77a17ef12ad
Cleanup some debugging, distinguish wsd/viewport delta fetches from
client-side tilecombines.
Update tests for deltas where they are expected.
Change-Id: I3dca09e4ceb094abf03db2aed2618f19351f3e28
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
We concatenate several deflated streams back to back, and need to
decompress and apply each one by one.
Change-Id: Ic31f0eae27906f7817a877c98f4cd1e5ca4ee7f3
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Squashed from feature/deltas-expanded.
TileCache changes:
+ add montonic sequence (wid) numbers to TileData
+ account for sizes of TileData with multiple blobs
+ simplify saving and notifying of tiles
Sends updates (via appendChanges) based on the sequence the
right mix of keyframes and/or deltas required as a single
message, and parse and apply those on the JS side.
We continue to use PNG for slide previews and dialogs,
but remove PngCache - used by document tiles only.
Annotates delta: properly as a binary package for the websocket.
Distinguishes between deltas and keyframes we get from
the Kit based on an initial un-compressed prefix
character which we then discard.
kit can be forced to render a keyframe by oldWid=0
Track invalidity on tiles themselves - to keep the keyframe around.
We need to be able to track that a tile is invalid, and so subscribe
to the updated version as/when it is ready - but we also want to
store the keyframe underneath any deltas.
force rendering of a keyframe for an empty slot in the TileCache.
force tile sequence to be zero for combinedtiles - so the client can
always request standalone tiles with explicit combinedtiles, or tile
requests.
move Blob to Common.hpp
use zero size for un-changed tiles.
remove obsolete render-id, and color deltas in debug mode.
cleanup unit tests for non-png tile results.
Change-Id: I987f84ac4e58004758a243c233b19a6f0d60f8c2
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
It seems at least some storage hosts report disk-full
errors via 413. This logic of handling 413 error as
disk-full was introduced in
f8e0b8c11e.
Here we handle 413 as it is defined, as Entity Too Large.
Change-Id: I61297c2fab9de663643336a6eba47949f82d1737
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This enables code that was protected with
EnableExperimental in the socket logic (and one
case in DocBroker). These changes are now deemed
safe to enable permanently.
Change-Id: Ie62f5d7bd281ade90f38d654b51b104b8d1f14bc
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Read the print ranges for the current sheet from
LOK_CALLBACK_PRINT_RANGES message and draw dashed grid lines for the
rows/columns bordering the range.
Caveats:
* Desktop calc does not draw print ranges on document load if there are
print ranges set previously on save. Cool also has the same behaviour.
* If there are multiple print ranges in the same sheet desktop calc does
not show any dashed lines indicating the ranges. Cool also adopts this
behaviour for now.
* Styling of the dashed lines was not investigated much for writing this
patch hence it uses the same drawing style as normal grids.
Signed-off-by: Dennis Francis <dennisfrancis.in@gmail.com>
Change-Id: I318b679a232f2a6834d6e23278b24a9a96b70194
(cherry picked from commit eb94d9a864a37499e21dbd064e78e40fc20b2415)
Signed-off-by: Dennis Francis <dennisfrancis.in@gmail.com>
Change-Id: Ia136c0675dbba51a53424916910219e8330764ac
(cherry picked from commit 817a4cd3f1f219a0d9caba129cbb3eca4fe31514)
after the jumbo sheet patch selecting entire row and merging all the cells becomes costly and cypress timeouts
therefore select first 100 cells and test the merging functionality
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I8568bbdbabdccc55c2938f886619a1d178ae7d22
A problem since c6561a99d8 (wsd: test:
correctly stop SocketPoll in UnitTimeout, 2022-04-21), the trouble was
that calling UnitWSD::returnValue() from UnitTimeout::returnValue()
deletes the 'this' pointer, so we need to copy the interesting data
members to the stack before calling the base.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I86583ae516e2b2f367fbf5cb2a9401cc21f1b1cf
