Commit graph

9028 commits

Author SHA1 Message Date
Pedro
a4e965d433 Add important rules to 2nd level ul entries that were not being used
Change-Id: Iccab82a2c73759107f5630ece8ad530be938346f
Reviewed-on: https://gerrit.libreoffice.org/80138
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-07 09:57:09 +02:00
Pedro
bf983a22bd Add aditional space to tb_actionbar_item_mobile_wizard icon as its neighbors
Change-Id: I783184e20486be42ee878c9887670b58f4d74996
Reviewed-on: https://gerrit.libreoffice.org/80210
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-06 22:07:01 +02:00
Pedro
b156d80107 Increase icon element's width
Change-Id: Ic11cbf02513f7c9052bec26f5a56d354219ef24a
Reviewed-on: https://gerrit.libreoffice.org/80134
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-06 22:06:26 +02:00
Pedro
0d20263151 Fix main-nav position, space out icons and remove document-header that appeats in the menu when in edit mode
Change-Id: I8d20cc424c30a302c36daa4952c39e12d1b74f80
Reviewed-on: https://gerrit.libreoffice.org/80132
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-06 22:04:01 +02:00
Pedro
3b92083ba1 Remove toolbar divider(break) in calc
Change-Id: Ic342aef8a4d4797d8d38531348387508a65bda76
Reviewed-on: https://gerrit.libreoffice.org/80181
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-06 21:55:39 +02:00
Szymon Kłos
3294ae90b0 jsdialogs: remove border around icons
Change-Id: I293377b8ffe3b3ddd18cf9c25b6f19bc96d9c65f
2019-10-06 21:53:41 +02:00
Tamás Zolnai
7b469564bb mobile-wizard: Update toolbar buttons by closing
Change-Id: I72b276e9cf0e54522d755eea156d5044a77166e2
2019-10-05 19:08:10 +02:00
Tamás Zolnai
ea9eb2525d insertion-mobile-wizard: Add a title for the main menu (e.g. "Insert")
Change-Id: I498f474d731d87591e33f2db1b7c9b52b7dafa47
2019-10-05 18:47:40 +02:00
Tamás Zolnai
33e5e7977a insertion-mobile-wizard: Align the sub menu arrow correctly
Change-Id: If0952435dc058d2cada04f4c6c5351d3c9aeaa91
2019-10-05 18:44:39 +02:00
Tamás Zolnai
ca51f56ebe mobile-wizard: Convert Insert menu to a mobile wizard like widget
* Added a toolbar button to open this insertion mobile wizard.
* Added a method to convert 'Insert' menu for mobile wizard code.
* Added callbacks for menu types items to JSDialogBuilder.
* Since the menus are not dialogs it would be good to create
a separate JSMenuBuilder class for the added code. I'll do that
later.

Change-Id: Ie68e13ae46dde7bc36c2465785628135623436da
2019-10-05 17:40:51 +02:00
Pedro
f164ac194f Mobile wizard: add icon for insertion toolbar button.
Change-Id: Iaaaa437fc7bf304f7bf473bb6d77c3f969a31f85
2019-10-05 17:39:59 +02:00
Tor Lillqvist
bf5ca0b1fc tdf#127942: Make a slide that is being dragged (for re-ordering) the selected
Otherwise we would have to add a new message to to the protocol to
move an arbitrary part of a document. (Currently there only is the
'moveselectedclientparts' message.) Also a new API would be needed in
LibreOfficeKit to move an arbitrary part.

Change-Id: I3012982cb0c2bc18e55f47554be51958817f9015
Reviewed-on: https://gerrit.libreoffice.org/80214
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 71be6ce1ac3533df4cd04b8c01beef89888d5809)
2019-10-05 11:52:47 +03:00
Tor Lillqvist
0e49800418 tdf#127942: Avoid the WKWebView popup with "Share...", "Add to Photos" etc
Seems that setting allowsLinkPreview to NO for the WKWebView affects
this functionality, too. Was just an educated guess, and it worked!
Single-line fixes to what initially seems like a hard problem are the
best.

Change-Id: Ic88bf53b883d857338c0316188e079e6797a4d76
Reviewed-on: https://gerrit.libreoffice.org/80208
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit c7e38e6348a98c0a6fcaf20876c57cb01d56f4cc)
2019-10-05 11:41:18 +03:00
Tor Lillqvist
ef98d92cb9 tdf#127942: Make the slide preview image dropsite larger on larger displays
This makes it easier no notice when a dropsite becomes active.

Change-Id: Iabf529d4af814c0cd348b201b823dca4bcaa1bb5
Reviewed-on: https://gerrit.libreoffice.org/80203
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-10-05 11:40:45 +03:00
merttumer
efdc5dbc08 tdf#126205: Fix file format conversion on rename input
Change-Id: I342ed309dfc116389f91886f5e1fd7b6c49178ed
Signed-off-by: merttumer <mert.tumer@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/80137
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
2019-10-04 22:23:00 +02:00
Szymon Kłos
e4f2145899 jsdialogs: reduce space between buttons
Change-Id: I698f223da4383fad4b1afb482618949b96c2b7d9
2019-10-04 21:54:39 +02:00
Szymon Kłos
02ea937ea2 jsdialogs: turn combobox into explorable entry
Change-Id: Ic0ab3142afba387d67e80020033d94d225a9d8a8
Reviewed-on: https://gerrit.libreoffice.org/80280
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-04 21:50:10 +02:00
Szymon Kłos
afa6376aad jsdialogs: layout is horizontal now, unused code
Change-Id: I070385f3890e1760eefa988f019e2729aadc730b
Reviewed-on: https://gerrit.libreoffice.org/80279
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-04 21:50:01 +02:00
Szymon Kłos
f70a5c5e76 jsdialogs: remove unnecesary debug printout
Change-Id: Ide9ac65707a92beae287e73ba7123327d74325c1
Reviewed-on: https://gerrit.libreoffice.org/80278
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-04 21:49:53 +02:00
Szymon Kłos
a20b3e612e jsdialogs: turn uno buttons into icon+label style
Change-Id: I0d102638042af52d66228601df30059a9953c244
Reviewed-on: https://gerrit.libreoffice.org/80277
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-04 21:49:46 +02:00
Szymon Kłos
4bdfde8022 jsdialogs: don't create horizontal containers
Change-Id: Ida34fbc1150456afa99e88820c173358bca097b4
Reviewed-on: https://gerrit.libreoffice.org/80276
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-04 21:49:36 +02:00
Andras Timar
1a3fae81f8 loleaflet: updated pot file
Change-Id: I92f0f64e2e276a0455f956e27bd111ebc3efe036
2019-10-04 21:39:47 +02:00
Michael Meeks
0cf416e736 Spinner: accelerate the spin, and hold off showing the progress bar.
Ironically the progress bar makes people think something is slow.

Change-Id: I3fb85ba1a44cdb436159abe5448d71b666020c5c
2019-10-04 17:12:32 +01:00
Michael Meeks
b8326b9caa Remove unused method.
Change-Id: Ibf50ddb79058e9793b0437bc265e3d8a1c25fc7c
2019-10-04 17:12:32 +01:00
Pedro
1d21bb4ac2 mobile-wizard: Add icons and increase size between rows
Change-Id: I3d7d3db50fa1697f5225262929182290044fe8c3
Reviewed-on: https://gerrit.libreoffice.org/80235
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-04 17:16:51 +02:00
Michael Meeks
f062c73d40 correct mis-merge / calling _setupGestures incorrectly.
cf. 963beecaec

Change-Id: Icf0abde12cbb8e543c764126990b3036ad3a5a95
2019-10-04 14:42:39 +01:00
Henry Castro
c90a2ad13f loleaflet: mobile: do not add extra space for the scrollbar
Change-Id: I1b58611ed724e6cd7a0c6c0a93c02e283d0d1672
2019-10-04 14:31:10 +01:00
Tamás Zolnai
4c303f41dd Sidebar: controls without cursor should not pop-up keyboard...
when selected on mobile

In case of the sidebar we need to be careful about
grabbing the focus from the main window, because the
sidebar and the main document window are on the same
screen and so the user can interact with both at the
same time.
However on mobile the sidebar takes the whole screen
so we can grab the focus when the sidebar is visible
and give back the focus to the main window when the
sidebar becomes hidden again.

Change-Id: I6a8975b66d77399f99b803c9931fb668c1fd59a7
2019-10-04 14:31:10 +01:00
Tamás Zolnai
4e8a9a450e Dialogs: controls without cursor should not pop-up keyboard
when selected on mobile

Change-Id: Iee34ad4a878bacea1e11e754b41bf86734796b27
2019-10-04 14:31:10 +01:00
Michael Meeks
7e00878829 Remove redundant dontBlur.
Change-Id: I3ca8060f6e0ff4494b70b121b97c984aa681e65a
2019-10-04 14:31:10 +01:00
merttumer
5570787c70 Save document before rename for keeping changes
Change-Id: Iadd5a93f902f916e1db14c0cafe39b125b531f02
Signed-off-by: merttumer <mert.tumer@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/80136
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-04 15:06:57 +02:00
Szymon Kłos
97d3d5c273 jsdialogs: Hide objects if needed
Change-Id: Ic657f7d5668a0b38492fd4a29364e4e4b5b33976
Reviewed-on: https://gerrit.libreoffice.org/80206
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-04 13:47:48 +02:00
Szymon Kłos
e62a054e34 jsdialogs: use svg icons from online
Change-Id: Id90482b3afab722aaa5354e2359e201ac97e2d5d
Reviewed-on: https://gerrit.libreoffice.org/80201
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-04 12:24:43 +02:00
Szymon Kłos
a758eaf5a9 jsdialogs: add custom controls for font name and size
Change-Id: I2b54c66abf370629a2516496d53b47958bcf5a57
Reviewed-on: https://gerrit.libreoffice.org/80200
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-04 12:24:35 +02:00
Szymon Kłos
65ae51d1f3 jsdialogs: add ids for uno buttons
Change-Id: I31bc46c919e76ea329532244e38d2df2f69bc0e8
Reviewed-on: https://gerrit.libreoffice.org/80199
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-04 12:24:27 +02:00
Michael Meeks
5e7cac28fa belt & braces fix erroneous popup of limit dialog
The shared_ptr allows the DocumentBroker's and ConvertToBroker to linger
after they are removed from the list, making ConvertToBroker::getInstanceCount
potentially larger than the number of documents transiently. Fix this
with a dispose method called on list removal.
Also make the arithmetic signed, to avoid unfortunate wrapping.
Also when the limit is large, don't show a message whatever happens.

Change-Id: Id2571429de48ae75e851c3fdc49e24a02aaaf6e9
2019-10-04 11:01:45 +01:00
Szymon Kłos
c1e96bff45 Fix build, not existing Mobile.Input.js
Change-Id: If443850bad4fd40886e378e3f7ede1eb52bb69ea
Reviewed-on: https://gerrit.libreoffice.org/80139
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-04 11:43:15 +02:00
Michael Meeks
ca3591c2c3 Switch to new UI_Paste post-message.
Pass the message up the chain, instead of attempting to hit the top
for happier CSS protection.

Change-Id: Iccefc18d4fa2799e655a9c026e51f47d9e8670f8
2019-10-03 20:44:17 +01:00
Michael Meeks
03f5aab033 calc: forbid keyboard zoom to anything but 100% and 200%
Change-Id: I26c9297727cc6183ff6ad11b54ef9114491389bb
2019-10-03 19:26:02 +01:00
Marco Cecchetti
22b2c10088 loleaflet: disable triple tab on map when user opens the about dialog
It has been reported cases where having the triple tab event handler
enabled on map prevents the about dialog to receive the same event.

Change-Id: I73b81acde9372f464b302f479f7920b159d34931
2019-10-03 19:05:48 +01:00
Michael Meeks
9cb8785ae4 Use the right method to toggle debug layers on and off on tripple click.
Change-Id: Ibcfaf33eb0beb826aee8e9e60df4ad0017490423
2019-10-03 19:05:14 +01:00
Szymon Kłos
788485424b Enable debug mode on 3 taps in about dialog
Change-Id: I33c5ed240080e2827ec8d6d4581e073d05f73290
2019-10-03 19:05:10 +01:00
Michael Meeks
5e0e6006e3 Fatal exceptions need to take the kit process down.
Otherwise the Kit main-loop continues while its event processing thread
is dead, leaving the client stalled.

Change-Id: I7089ed5b5bd8499623624ffdb84c22cedd80cc7e
2019-10-03 18:52:29 +01:00
Tamás Zolnai
5f28613c48 mobile-wizard: Don't focus the document for mobile wizard toolbar button
It's not a good idea to trigger keyboard when we try to
open the mobile wizard.

Change-Id: Ib1dd4daf5689695992904c98ef597ba8d9caed75
2019-10-03 16:18:13 +02:00
Tamás Zolnai
2d63070796 mobile-wizard: Correctly close the mobile wizard by level up
We need to set window.mobileWizard to false and also need to
send a sidebar message to close the sidebar entirelly.

Change-Id: I897e63391a2aafd8a3f38f7ddb7b5bd14bb7a1cd
2019-10-03 16:11:12 +02:00
Henry Castro
974d02fcca loleaflet: mobile: fix the first typed character after opening the document
calling the function setSelectionRange is an implicit keyboard focus.
Only enable when the text area has the focus

Change-Id: Ic58abd3fc555ad9a0a08a01041f7aeb5367d271b
2019-10-03 14:50:17 +01:00
Henry Castro
e33fc02876 loleaflet: mobile: removes keyboard focus when the graphic is selected
Change-Id: Iced49475ebf9af5508059f5d6e223e99d1187649
2019-10-03 14:50:17 +01:00
Henry Castro
1240da475f loleaflet: mobile: hide the cursor marker when exists text selection
Change-Id: Ib0a5c74567e1a0a71c53d741aa6c44a09b6b0fe2
2019-10-03 14:50:17 +01:00
Michael Meeks
e39fb629b4 Remove obsolete and unhelpful method.
Fixes up 8440e286c merge.

Change-Id: I27f16d36d135feae10de6d1db732259f81afd1fc
2019-10-03 14:50:17 +01:00
Michael Meeks
2210fddb2d Remove unused code.
Change-Id: I7d75cd570411a3e9b596b853da9ebc77b703ee03
2019-10-03 14:50:17 +01:00