Fixes typing on Android using GBoard in Chrome
before this patch we didn't get any input due to
lack of keyCode, we need to use 'input' events
which are already handled in TextInput.js
This patch does that only for mobile case, later
we can try to unify it with desktop so we remove
our custom formulabar input even there.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I318840dee78ddf0f803af74236a6c880c3f09329
this error was shown on socket disconnect on mobile Chrome in older
phone
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I927880ce1848fd1d48776202679ee14a8858e065
The dot above the save icon was not scrolling together
with its parent:
- Make sure the little dot is always under a parent with
position set to relative
- Adjust top position due to that ^ change
- It also fixes for narrow window on desktop
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I5844400cd1a15fe5693bb2b0be880460d974eec1
Automatically generated .log folder relate to typescript
was not being ignored
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0fa8bcbe9e3a9eeae8f1549d6d073865d06eb41d
- adds two new options
1. localize the dialog
2. change upsell image shown in dialog using proxy handler
- provides all the settings using dynamic configuration
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I7e21c1b31c806c88bf54f891de40f02fa342168f
- Follow the same order, for generic menu entries:
- Toggle UI Mode; Show Ruler; Show Status Bar; Sidebar
- Make sure Reset Zoom and all UI toggles are present in all apps
(doc type) when using tablet
Note:
This commit does not change the following because I do agree with
remarks stated in 70f4f8b92e
- Zoom in and Zoom out entries are not needed in tablet
- Zoom also misbehaves, so better to have it out when on a tablet
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I06f1c025dba27ae65229c38406d646da75a59aa6
No need to have one item (Resolved Annotations toggle) surrounded by
separators.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie5e560122054fc5904e3b24f984aa682c758d373
Building upon 70f4f8b92e
, it makes sense but let's add back in the Reset zoom
and let's make sure all the other UI toggles are available
when using tablet ( otherwise user is not able to
toggle UI mode, ruler or status bar).
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I972a3f6f17306484a266dc3cfa2103540ca4761d
We shouldn't write to the socket outside the main thread ever or
we'll get memory corruption; cf. a number of suspicious traces
around this code.
Change-Id: Ibeb36fffbecce960012a55b3ab4fd40c9996ae68
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Now the tiles show up correctly in the iOS app again.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I2b1741ed9f5fc4e4df30cb67addfa45eb0d20b92
Before ed5569da30
we invoked handlePoll on all sockets in
each poll. But that's not true anymore.
Since i = _pollStartIndex; (line 432),
when we assigned previ = i; (line 451)
we made previ == _pollStartIndex, which
immediately broke the loop
while (previ != _pollStartIndex)
at line 438, causing handlePoll to be
called on one socket at a time (and
likely *not* the socket that had an event).
It's inefficient to poll and ignore the
result.
Now we do handle revents on multiple
sockets correctly and efficiently for
each ppoll() by going through all sockets
and handling based on whatever revents
gave us. We need to invoke the handler
of each socket to handle timeouts (i.e.
if we don't call the handler until
the socket gets an revent, we wouldn't
be able to support timeouts properly).
Notice that we still start at
a different socket each time (although
it's not entirely clear what advantage
that has, it's maintained all the same)
as the aforementioned patch does.
Change-Id: I9c0a482792aee7df5d44f4b63f173e574db36f97
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
We store each byte as one character, i.e. UTF-16 unit, in the string.
Yes, this is inefficient.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I75cc211d7a8da98a4e0e5b5b3d000e7ed66c271e
Requested by several users and partners - defaults to off/un-changed.
When set it allows optional disabling of welcome/feedback when used
in a homely environment.
Also bump default max doc/conneciton limits in configure to 10k.
Change-Id: I3c917901e02445d45f6f86b554d47a60aa4e575d
Signed-off-by: Henry Castro <hcastro@collabora.com>
Added the 'tzdata' package to Ubuntu-based Docker builds and the
'timezone' package to openSUSE builds, to allow Docker users to run
the containers with a custom timezone by passing a TZ env variable.
Signed-off-by: Tobia Conforto <tobia.conforto@gmail.com>
Change-Id: Idafd84dde3383b4801ff4b3ebb8ac1826fe49fcc
This is needed so 584aa5b8f6
is also applied on tabbed view.
Until now we were just adding that class when on compact view
(Control.TopToolbar.js)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I8c0ac3d909f64025f301651564b3c2b1ae130e1c
Instead of using URL parameter hash to direct all the users on same document to same server,
use stick-tables for it
original problem:
Problem was load balancer provided us with required persistence and balance both.
we directed traffic based on the url_param which means,
all the traffic with same url_param will go to same pod/server.
All the new values of url_param will be directed to different servers in round-robin way
this can be less efficient in a high traffic environment
solution:
this new method allows us to balance and manage persistence separately
so we can specify our desired algorithm for load balancing
and persistence is managed using stick-table
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I80d63a2fc33f796c4534d94fb8de1e44c62ee9e2
We now have USR2 signal that dumps the
stack-trace of each process. This is useful for
capturing the state of misbehaving instances.
COOLWSD forwards USR2 to forkit and the kits
so they dump their stacktraces too.
This patch does not change the behavior of USR1.
Specifically, unlike USR2, USR1 is not forwarded
from wsd to frk and the kits. Also unlike USR2,
USR1 dumps into stderr.
Change-Id: I1d82f678f30f430f627692cc42961b1928f69e11
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
SIGUSR2 can now be used to dump the
stacktrace of coolwsd, forkit, and the
kit processes.
Also, support writing signalLog to files.
Although we write to stderr, we normalize
the interface used for signal logging and
allow for writing to any file descriptor.
Change-Id: If6366bb6ddbd9f8863baca52e4f65ebb468dc1f1
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This replaces the hardcoded STDERR_FILENO
to allow for writing to any file, including
stdout or a redirection to disk, if needed.
Change-Id: I76f6461f46fd4bc035fcf643d01e60c2e3236894
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
In preparation to log to a file in the jail.
This will allow for including the log in the
log file, thus capturing all output from our
thread-group into the same log file.
Change-Id: Ia5c4ed35786d28f5d45f3065919d53f2c8492cb0
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This simplifies the signal handling setup.
Change-Id: Id121a9df45fc11bfdea627f9828e0b624b1b2284
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This is to ensure that libgcc is loaded and
backtrace is available during signal handling.
Change-Id: I5bb36b69401dbedf4c991ba7d60d2e806441a625
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This moves the shared_ptr copy to outside the
lock, as well as reducing logging inside it.
Change-Id: Iedde95b3fe60fc40bbd035a9d43a9b95af7efdcc
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Since the value of the loSubPath (i.e. the directory
name of lo within the jail) is a compile-time constant,
there is no reason to pass it around at runtime.
Change-Id: If7457ea7f3e3fe5c42215eed3ce1ce4c8f328f16
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This prepares the way to remove loSubPath
being passed around at runtime, which is
completely unnecessary.
Change-Id: I728629e3cb5eb079add4232543319b89a7dc4a2a
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This is an internal rename of identifiers.
Child-Root is the top-level, configurable, directory
that stores the jails and related directories/files.
A Jail, by contrast, is the directory that contains
the filesyste tree of a Kit process. That is, it's
the directory that is chroot-ed.
To distinguish the two, we shall use "jail" for
the chroot-ed directory, and "child-root" for the
top-level directory.
Change-Id: Ie38b1c350234b75ddd15beb1c6bcdd2e53a82af0
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Currently translated at 62.5% (286 of 457 strings)
Translated using Weblate (Russian)
Currently translated at 100.0% (462 of 462 strings)
Translated using Weblate (Russian)
Currently translated at 99.7% (461 of 462 strings)
Co-authored-by: Егор Ермаков <eg.ermakov2016@yandex.ru>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/ru/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ru/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I821ed266d54f8802e747aa5c558799851d93121e
Our plain text clipboard output generated additional newlines
at the beginning of every paragraph. To fix that we need
fix in core side which now fails due to expected bad format in cypress.
This is interim state where we accept both old and new format.
see for reference: https://gerrit.libreoffice.org/c/core/+/136893
lok: don't pretty print html for online
I2b17d62398d947fcf1d3fb1ed6005c3063d114f2
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia2d75c75f40dffbe08d1c77e09c2331db18734f4
