Use a dark solid background color - with a shadow (already existent)
- to stand out against content.
Make sure button is blue similar to test selection handles or some
icons etc. So it is visible at 1st sight what's the action
Remove unnecessary or duplicated rules
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I53a291f762c4ed40f5b39230fad8246fa280d050
It is not a normal dialog as in jsdialog or lodialog,
no need to add border
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib7a4d3d1a89f1c69df8e7a374d4283d48b66e42b
Avoid odd number by stop relying on a division by 2.
Instead, use the same already existent border radius.
-----
In the future if we end up deciding on something else,
we should probably create a new var for that and apply
it to all dialogs
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If0e53f0b2a965587c33156536f74fcc0a223a43a
Since the row height spinner is the 1st element in the row,
there is no need for margin.
Note: in the future wuld be good to have the spinner coming from the
builder with additional class or style when they are the first
element being positioned
Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I2396ab662fcb4a12762b4a6e2b38582f1df7c59b
Remove unnecessary rules targetting minimalrowheight and
minimalcolumnwidth. These rules were
1. Not being apply always (sometimes jsbuilder was
setting them with different id, e.g.: with suffix 1)
2. Even when apply this rules were forcing these two btns
to go up, looking like they are mere icon for the spinner.
This is wrong. They are buttons that trigger the set to the
minimal sizes of that particular row or columns
Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I53e81c69cdcc3aafd2ca5ab0f8e196d912b86608
Before this change the spinner were getting unnecessary additional
padding.
Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I43b8bffc8bacc13dfc633cee4cd8f7823834d402
Without initialization, gcc12 complains
that these values may be uninitialized at the
usage site (in the Kit API).
Change-Id: I06df9d69977b1f89bfa2e0a3ca7404c026b570ed
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Our plain text clipboard output generated additional newlines
at the beginning of every paragraph. To fix that we need
fix in core side which now fails due to expected bad format in cypress.
This is interim state where we accept both old and new format.
see for reference: https://gerrit.libreoffice.org/c/core/+/136893
lok: don't pretty print html for online
Change-Id: I2b17d62398d947fcf1d3fb1ed6005c3063d114f2
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I6adea1250bb4d54713e0a189b89930e82522a571
based on extra_params update the scheme and port when mapping domain->alias_groups
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ic5783112b8331407622f547a84d70ab2e1ba0c37
Adjust the drop-down dialog to the #map element
to show the correct position sent by the server.
Change-Id: I74a6d7402438241aae77a18699c3297d64b34098
Signed-off-by: Henry Castro <hcastro@collabora.com>
Our plain text clipboard output generated additional newlines
at the beginning of every paragraph. To fix that we need
fix in core side which now fails due to expected bad format in cypress.
This is interim state where we accept both old and new format.
see for reference: https://gerrit.libreoffice.org/c/core/+/136893
lok: don't pretty print html for online
Change-Id: I2b17d62398d947fcf1d3fb1ed6005c3063d114f2
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I70fa8be619a62709d6e5ada32b7a670f90d7b2bf
because we now support having regex in alias_groups.group.host
for more info: 45891d0ded
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ib8c16cd7db18719076d62347738e23bbefaa9204
Since we remove a bottom padding in the toolbar-wrapper
with 3d27de7eb14e77cb4f0a94685b474ec2c42d6229
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Icf272e5c29455868cd43cf494935401ec10229e0
This was affecting how we perceive padding around formulabar
- Making it look uneven (with more space at the bottom)
- Making toolbar-wrapper's bg visible at the bottom
Remove bottom padding when in presence of spreadsheet so to
avoid affecting the other apps
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Icce34ecb64781221428130f4a11420b5546003ad
Using unitless values will be automatically
multiply by the element's font size
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ice4b56c5da7e47aae83347c1bf6b6ac377a51518
Make sure every element between item address parent and the
item address itself is place at the top
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib883f6659788f4ec42ae6d953fa2d857038fc815
- Set heights to even numbers so we don't end up with uneven
surrounding vertical spaces
- Remove individual top margins (margin-block-start) from btns
- Instead fix underlying issue with formulabar
- Fix text-area padding inconsistencies between being expanded
and collapsed. Problem: text area becomes taller, ending up
occupying the top and bottom white space left from its parent
- Leverage new css class added to the main parent #formulabar
and add vertical padding so text-area forces parent to increase
in size
- Remove sub parent's (#tb_formulabar_item_formula)
individual top padding
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I380af6cf70c0e879224329fbf9093e0778a38d8d
Avoid setting elements, located on the edges, with margin
in the hopes we get an overall padding:
- Remove it
- Add instead a true padding to the main parent
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie1690c9cc3c58f59387cb6aa73df20d42f5cc1fb
When editing formulabar using keyboard - try to use shift + arrow
to make selection from the end in backward direction.
This patch makes it possible (visible).
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I48073214545892d98be097b38c60251ff95082f3
eg. Chrome setups selection only if element has focus
it prevents us from stealing focus by formulabar when
switching cells
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I46cbd4d04615478a95a36dd8bcda22d732e74d3e
check infobar data when the server send
the user info data.
Change-Id: I0ba1da488f9b3d03dc7e3f42cea718273e6939b1
Signed-off-by: Henry Castro <hcastro@collabora.com>
if there is no more paragraphs: exit the loop
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I7075ff5454e1ddcc11155867f835e85117bdea15
Improve performance by not looking up endIdx that may be over the end
of the range. Ensure we still have valid data for the pieces we do
know about.
Playing with a complex 1m row spreadsheet and re-sizing rows by
typing multi-line text into them would provoke row header problems
otherwise.
Change-Id: I5a110137e6d26e2c4b272210cf41883abb02c3af
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
When we use API call InsertButton and we add custom buttons
we want to keep them when we switch between compact/tabbed view.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If03520f52422ac41aa40432f068e5bc011ed2596
use sendContentControlEvent to set picture instead of InsertGraphic uno command
since InsertGraphic is not allowed for a protected content control (like picture),
only sendContentControlEvent();
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I5f70919d995c51456056a8be2aa1e596df7bedc2
and thus avoid cropping it altogether
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If959c617c6036daa353dc8185668aeb99d515497
Before not only it was not vertically aligned but it was difficult
to read
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I3790d51f4a90dd9bdb5158cfa16ed92de1ebfca5
Set it to 24px, fix stroke and make it a path
- Result same size, smaller visual indicator
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic41b7a1d8e798998ea9399cd68c9fc6b46e73725
Decrease number of visual differences between the two while
by using similar style. Add border radius already in use
in other components such as drop-down menus.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I09b51f0817d35641cfc7d028e281ae3ba362a663
The rules found in toolbar-mobile.css seem to no longer be needed
in any shape or form on desktop (even on FF). Remove file and
insert those changes within device-mobile (so it is loaded only
when on mobile)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I58a3d52fc6313a8e32916fa2b5dd4796dd1c1cef
And make them less "shouting" by default
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I69306cbe6107ce1f7306291fe55d7f54f7fdfe8b
- Make it clear that it is a menu button
- Remove extra space between triangle and image
- Fix icon size, before it was overshadowing the function icon
- Redo icon, so it is more legible, less tall and less flimsy
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I95c635b9a39aaa4dd470372018c63c9f45385b25
this patch relies on core change
https://gerrit.libreoffice.org/c/core/+/136811
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: Id9fa7273631f93914afa870e2c1148a9aa01c2e7
ported from:
PR: https://github.com/CollaboraOnline/online/pull/4976
In cases when the button text is too long
or when using CO in, for example, DE language and when
the length of the parent dialog was not enough the btns
would not stack up, instead that would overlap. This would
make reading those btns impossible.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I801ea330db21add35d0a81466a1fba9501a61899
Apparently this is an issue for proxy.php.
Change-Id: I18090f17f22fe3145e7fa2364992a34a7e722f1b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
And dump the saving timeout in the state dump.
Change-Id: If203d5434ee17f646009ee241b8484ca597840ad
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
