The twips coordinates sent by core in CommentsPos message are already
correct w.r.t zoom level (See ScModelObj::getPostItsPos() in core.git).
In addition these values are view specific (each client user).
Change-Id: I18c2971f34362de0eba5181f9dbe3e662c223575
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86986
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
ignoring the segv can lead to not making progress, while churning debug.
Change-Id: I97af266cec3feefe2dcbd9adb8dbf4b13a4d69bd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87002
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
- Use shadow instead of background gradient in order to have more granular control over the result (multiple shadows)
- [Toolbar]: decrease indicators width to 0; [MobileWizard]: decrease indicators height to 0
- ^ to avoid mistaps. We now have larger "gradients" with 0 space from the element which allows any elmente that is underneath to be tappable
Change-Id: Ie329ed4e85d7342ab9cdc90f89cfdc8663e73da7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86979
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
So that they are in-process, which means it's easier to debug when they
fail.
Change-Id: I164b97be0bc487a02d4b2a872b9c0e40791056cd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86951
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
This reverts parts of commit da455c486a.
Unfinished; also stream size calculation cannot have worked.
Change-Id: I39635fe5165b82dd36095d58cfefff4920ce3a35
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86845
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
- it appears to show the user that there is hidden content and that is possible to scroll/swipe
- it disappears once the mobile-wizard-content reaches the end
Change-Id: I93c039fb614cd28e0d40b63a3b5a744d730f5dbe
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86865
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
This fixes this scenario:
* tap into the (routed) formula input bar
* write 'abc'
* tap a different cell in the sheet
=> not possible to write in the cell in the sheet any more, only
possible to enter text via the formula input bar.
Change-Id: Ib45bd660605bc0fc4bcf4f9b1aef258fd82e98d8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86924
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
As we changed the clipboard to be synchronous now, it's not needed
to execute copy/cut/paste actions in a separate thread anymore.
Also change WebView message interception, so we can execute
actions after a we send WebView a message. This is needed when
we copy/cut something and need to push the content to the android
clipboard and clipboard file.
Change-Id: I08b6ee55ca8bd7b958d348e257c19395ea39ac80
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86882
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
In andorid app, we just supported html or text to be copied between
applications (inside the document the copy/paste is handeled by
the core). The biggest problem with this is that copying between
documents doesn't work or works just as good as our HTML support
is. With this change, we get all the clipboard content after copy
and serialize it to a file into the cache and if we then paste in
another document, we read the content of the file and paste
without any loss of fidelity.
Change-Id: I3501045ff2e815a7e2f8c6ecce5255511c256ca6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86833
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Such used to be fired by Map, but that was removed some time ago.
So kill the attempt to use it on iOS, it must be dead code.
Change-Id: Ic4af8394c0f059f4a06a1c6d371890863f250696
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86863
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Show it in the same text input field that is used in the WOPI-like
case. Make the text input field non-editable and not even focusable.
Show the file name as it should be displayed to the user. I.e. reverse
two layers of URL encoding. At least for the iOS app this is
necessary.
Change-Id: Ifc3c8c0907178ecb419f3108ffc558a05a16313d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86840
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Set the iframe's src in a script so we can pass on a filename cleanly.
add a postMessage: sample URI at the end of 'make run'
Move some of the more obvious pieces into framed.doc.html.
Change-Id: I2bd8215f083bcb16369421ed88acb198808c1fdb
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86787
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Ironically our attempts to double-check message origin against our
parent was blowing a security exception.
Instead send the list of origins we will accept from WSD, and
check them ourselves (as well as the browser check).
Why make it so hard to check that a postMessage comes from an
ancestor frame ?
Change-Id: I1311be3e1d68a31cfdc96b45a5eb5dd7f26e7ea9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86788
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Alexandru Vlăduţu <alexandru.vladutu@1and1.ro>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Without this, we were closing the document, which was very annoying.
Change-Id: I1e841da28c92c0e01284c2d7e2d4dbc6762bfffd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86779
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
- account for moz vs webkit intricacies
- account for newest spreadsheet formula implementation
Change-Id: If5ae4159bf5b5cea82771b085f8e7e90f97e0804
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86760
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
- it was causing improper behaviour when multiselecting
- there is always a cell (svg path) that is been set always with diferent stroke color even when multiple cells are selected and so CSS shouldn't be modified but instead, probably, JS bits
Change-Id: Ie8f11f14f5ffc958f646332c7fe2bc810b34d808
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86755
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
if unwanted, this menu item can be hidden with branding.css
#menu-report-an-issue {
display: none;
}
Change-Id: Ic3fc3a74e8bea0b68ced542423c6068b150f647b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86632
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
- which increases legibility even when there is a checked element underneath
- also decreases its width so the element that is partially under is still interactive without the need to swipe it first
Change-Id: I54fe3e3d0bd699246f76c77e929b3c4a250e0b82
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86691
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
long press event in thumbnail previews in Impress
Change-Id: Ib0661b906882b87d68833c96ce3f535bd3fccbec
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86568
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
It is complicated to debug 5 event listener attached to an element,
let's use one event listener.
Change-Id: I9de1f1707f95f07a49358c8e7580ad232edd4389
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86567
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
Avoid mobile's extraordinary IM work for now; encouraging the core
to tolerate a number of backspace characters is a tad tough for now.
Change-Id: Id3cad6ad12384440ee613e88741c395c2d742683
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86589
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Hopefully it can be re-used for a single-tab view now.
adapt to new panel naming re-using the UNO methods - cf.
related core commit.
Change-Id: I1312d3571ccb7cf3561f1661f73f860c56f002a4
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86572
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Avoid lots of indirection and complexity based on the new,
simplified sidebar JSON hierarchy from the core.
Change-Id: I73d5c6af30d40e9a430e0f3df3b78b620f425e39
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86510
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Possibly a good idea for Android, too? See bug report for description
of what this fixes.
Change-Id: I6b70f431ced09044756c2edc3fcc2542428b62e1
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86484
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
So that they are in-process, which means it's easier to debug when they fail.
Change-Id: Icb3d7a7d0ffa7371eb3056b5de7144137c0acb8a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86463
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
rm -rf of the assets was newly introduced, done after copying the
templates to their place. So missing templates => crash; fixed.
Change-Id: I53d243b4f44c2c38843336e38e603ae0bd4b3c89
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86449
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
