Commit graph

10088 commits

Author SHA1 Message Date
Tamás Zolnai
b06ec9c71b cypress: let's have these two commands in separate lines.
Change-Id: Idf7856518121ca2ce84a9eb8f77b6f596a21ca18
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87156
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-01-21 18:47:02 +01:00
Tamás Zolnai
8081afc8e0 eslint: Enable "semi" rule as an error.
This checks whether all statements end with a semicolon.
We already use this rule in the code, so I enable to check
this rule by eslint to keep the code consistent.

Change-Id: I5ea46376d2b6fb488224d4d69e4d117139763a8c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87154
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-01-21 18:32:33 +01:00
Miklos Vajna
a6af954b62 wsd: fix a typo in JWTAuth::cleanup()
Change-Id: I2c88403de12e2011746964b05a0c7e239dcbfd1b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87151
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-21 17:39:09 +01:00
Tamás Zolnai
c782c033b0 cypress: Use a better wait method for loolwsd server
Use the wait-on npm module for this.

Change-Id: I602f95aa79d46cf7b55bcc598e612bbc5342c52b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87150
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-01-21 17:37:28 +01:00
Pedro Pinto Silva
298f4297c2 Mobile: MobileWizard: swipe/scroll indicator: improve scroll detection for different exceptions
Change-Id: I2f3661b2eaafc8d8facb186e92738818431483e4
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87153
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-01-21 17:14:46 +01:00
Tamás Zolnai
7da6ea8404 cypress: mobile: Fix 'Close mobile wizard by context wizard' test case
It needs a better indicator that the mobile wizard actually opened
with the right content.

Change-Id: If1d146a6b02b2b5f79e1ac627dbec4fc43906f43
2020-01-21 16:13:01 +01:00
Tamás Zolnai
8f498034a2 cypress: Update README with instructions how to run one test case.
Change-Id: Ib6e80f92d64565471f30abc89b3ed4a1bbcebb20
(cherry picked from commit e11c0f8efa8a873eb699873613e86395d7e23200)
2020-01-21 16:13:01 +01:00
Tamás Zolnai
423f2eb0db cypress: Don't run cypress test for top level make check for now.
Change-Id: I06c724e82b3717e36a7a4550118baba3aac1a7f6
(cherry picked from commit b48ac5933c4b8671e8ba68c9f9d50216ff4dd620)
2020-01-21 16:13:01 +01:00
Tamás Zolnai
e82719b99e cypress: mobile: Add some tests about the state of mobile wizard.
Change-Id: I38869d7fcc03690610a19c7803a596cfebf75c7a
2020-01-21 16:13:01 +01:00
Tamás Zolnai
76c01fbe82 cypress: mobile: Fix mobile wizard id.
Change-Id: I171f98705e894f5a73afd7c92b489620f3bec4ac
2020-01-21 16:13:01 +01:00
Tamás Zolnai
abac31d4fe cypress: Remove obsolete scripts.
These were replaced by make commands.

Change-Id: I98978b52801b44a36c09388cf5eb3ed5a09326c3
2020-01-21 16:13:01 +01:00
Tamás Zolnai
58d99a8f61 cypress: mobile: add some examples for testing focus.
Change-Id: I63267bdd1d4b4db0d30da78c61b82c5d7d5535dc
2020-01-21 16:13:01 +01:00
Tamás Zolnai
d5f698acd5 cypress: Don't run npm install unconditionally.
Change-Id: I51ff6e7706075d15c213617fede89088499226ed
2020-01-21 16:13:01 +01:00
Tamás Zolnai
a410b54c47 cypress: Introduce more make rules to make easier to run tests.
Change-Id: Ic8ae881864ae931fe6abed73a6a6086d6e0e591d
2020-01-21 16:13:01 +01:00
Tamás Zolnai
545f3f9431 cypress: Introduce make rules for running group of tests.
It can handle dependencies and can use environment
variables.

Change-Id: Ib386cb7019d85b3dbd6c28417b3a481944b18aca
2020-01-21 16:13:01 +01:00
Tamás Zolnai
d413d55f91 cypress: Use eslint to check coding conventions during build.
Use loleaflet's config file to have the same
conventions under cypress_test folder too.
Update test code to pass esling check.

Change-Id: Iade932e6d3cd8941b5fc0897c56c68d2493f0dce
2020-01-21 16:13:01 +01:00
Tamás Zolnai
d614865b46 cypress: Move general cypress options to cypress.json
Change-Id: Iad6263f31ec9ef813424e4aab673c2ade1f7f3e5
2020-01-21 16:13:01 +01:00
Tamás Zolnai
eb47f78824 cypress: Move plugins folder out of cypress subfolder
Change-Id: Ia3a9a58b7f7e5e64c1e2f4211b75a33bbbb00c0e
2020-01-21 16:13:01 +01:00
Tamás Zolnai
aab8b4ada6 cypress: Always create a copy of the test document.
Before test execution. So the modifications won't
change the test documents.

Change-Id: I1b04fe96e8182033d44aeeaa3a7632dd81031a05
2020-01-21 16:13:01 +01:00
Tamás Zolnai
c5478b7a66 cypress: Use env variable to get file path.
Instead of a hard coded one. Also create new
test documents for cypress tests.

Change-Id: I5f9b2c6914669f77742e1a011d736bbf18c54877
2020-01-21 16:13:01 +01:00
Tamás Zolnai
20e5295ddd cypress: Make sure loolwsd is killed after make check.
Even if ony of the tests fails.

Change-Id: I18e7daff854fd51d4ba374d9d537ba76e171269c
2020-01-21 16:13:01 +01:00
Tamás Zolnai
66eb121856 cypress: Running make check locally works better then cyrun.
Change-Id: Ifcbefa925b3b46e7955cd3cfb107b105f053cf59
2020-01-21 16:13:01 +01:00
Tamás Zolnai
96c9e57894 cypress: mobile: Add some tests about pushing toolbar items.
Change-Id: I2b40dbee18fa04fbece4f4da0630e3ac619e0968
2020-01-21 16:13:01 +01:00
Tamás Zolnai
740267611f cypress: Update README about test execution.
Change-Id: I6c7b7fd8c77f89289630a06f9dbaf94ae5082aa8
2020-01-21 16:13:01 +01:00
Tamás Zolnai
11ef897266 cypress: Added a better wait method for document load.
Change-Id: I482df38159009f5583ad7ed9f676e09a350bb0a8
2020-01-21 16:13:01 +01:00
Tamás Zolnai
66d89d749f cypress: Run tests only if HAVE_LO_PATH is set.
Change-Id: I7d3103aa787f5bb1ed28a477276f2a656a915737
2020-01-21 16:13:01 +01:00
Tamás Zolnai
893a3df57b cypress: Add package-lock.json to gitignore
Change-Id: I3ec64262a50e6edf6116f5b7c546ee3a84d4d449
2020-01-21 16:13:01 +01:00
Tamás Zolnai
f2444df726 cypress: Add some commands to make easier to run tests.
Change-Id: I9428522717d3912ca20374a1efb1c61999ffc77f
2020-01-21 16:13:01 +01:00
Tamás Zolnai
d3dd01eb1b cypress: mobile: Add more tests for toolbar.
Change-Id: I144982a796e2e1c5178bdefa27575a0cfe47439b
2020-01-21 16:13:01 +01:00
Tamás Zolnai
524bbb3398 cypress: Initial integration of cypress test framework.
Change-Id: Ibf300b33d32ce3e7f1affbaf0a59364ddb618b56
2020-01-21 16:13:01 +01:00
Michael Meeks
f0bfe402fd test: forcibly serialize more
Change-Id: I2fd370c5bdd440e3be2c065f9b834ffa4e7f856b
2020-01-21 15:07:54 +00:00
Michael Meeks
50deb943bd test: simplify and remove obsolete /proc grokking code.
Change-Id: I482c56dd76067019d83196aa305d14703e25bb44
2020-01-21 15:07:54 +00:00
Michael Meeks
9126a641a9 test: switch to using ClientPortNumber to allow parallelism.
Change-Id: Ifef3bce1b217605000300b240ea74df4d264e0df
2020-01-21 15:07:54 +00:00
Michael Meeks
43d0de1234 test: serialize tests for now.
Change-Id: I6309976f324a66a57baf4678e49c0c1e09b9dc48
2020-01-21 15:07:54 +00:00
Michael Meeks
e844b89d6c test: simplify the timeout logic.
Change-Id: I0c253629b983f2813237536e6e2c6d04d5b97dd1
2020-01-21 15:07:54 +00:00
Michael Meeks
8f91659ae0 test: dung out redundant LOOL_TEST_CLIENT_PORT.
And cleanup other related oddities.

Change-Id: I2d179a2ece6a8553e10e406ad4e5da08a2ff58e5
2020-01-21 15:07:54 +00:00
Michael Meeks
9dfac6dab1 test: switch to parallel tests based on Unit framework.
Increase a few timeouts, bin old-style standalone unit tests,
fix a number of bugs.

Change-Id: Ia3d59466ecb9a9443807ba3445d04dd5f77e3dba
2020-01-21 15:07:54 +00:00
Michael Meeks
0599db3576 copyFile: de-poco-ize and handle EINTR and short writes.
Change-Id: I2046881c786a9f31f45c53f282de9ddd9a9cebcf
2020-01-21 15:07:54 +00:00
Michael Meeks
c187f414c5 kit: show the correct documentLoad URL when a template is used.
Change-Id: Ib9b3ac3e166dfbece8c7212fc239d517ce1c0bba
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87140
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-21 16:07:31 +01:00
Michael Meeks
b97ad1645a Clobber gio in the configuration.
Otherwise activation fails for http:// or https:// since the core
mis-identifies the (disabled via core: 1c081112714e) gio provider
still and won't load via the ucpdav1 provider.

Change-Id: I66a58da3f94a4479729a3e39ed5070e4a05dcf69
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87141
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-21 15:06:17 +01:00
Michael Meeks
aadf5af77b reduce verbosity of FileServer trace logging.
Change-Id: I5a57e91742be504bcb2e51b45f6890420e52bb91
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87134
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-21 14:39:21 +01:00
Jan Holesovsky
1c0fb25e90 android: When the cell cursor moves, focus the document.
This particularly happens when the user has entered something into the
formula input bar - after hitting Enter, the focus should return to the
sheet.

This is consistent with the desktop LibreOffece, where hitting Enter in
the formula input bar returns focus to the sheet too.

Change-Id: I020e008022e958f471d0cb31a8de986f576ba704
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86984
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-21 12:43:17 +01:00
Alexandru Vlăduţu
91175c854a tdf#130103: loleaflet fix save from menu for spreadsheets
When editing a cell in a spreadsheet, if you don't focus on another
element before clicking 'Save' in the menu, it won't actually save the
last edited cell. This is different from the 'save' toolbar icon, which
actually saves it.

Change-Id: I5bb7551ce9fad28f3108bee8a7a44735e01f9d93
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87119
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-01-21 11:34:12 +01:00
Tor Lillqvist
ebaca16c4f tdf#128509: Make the column and row headers tappable on touch devices
After you have sleected a table on a text document in the iOS (and
Android) app, you are supposed to be able to tap the "header"
rectangle that is painted for each column and row, in order to select
the whole of that column or row. But this worked only in web-based
Online with a desktop browser, for clicking it with a mouse.

Was much more complicated than expected. But now it seems to work. One
needs to use Marker instead of Rectangle.

Change-Id: I4f701c70dd4edce6a3edb6fcf9feffa7b7969a8c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87079
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-01-21 10:26:58 +01:00
Michael Meeks
09bb16ad78 util: for process thread count - ignore '.' and '..' in /proc/self/tasks
Change-Id: Ieec6eaac475b4e318578cfc0d93c36e2395e6f19
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87097
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-20 22:04:40 +01:00
Pranam Lashkari
e7f527b070 Mobile wizard: Sheet tab context menu conversion
Sheet tab context menu converted to mobile wizard for mobile devices
bugfix: prevented mobile wizard to appear in readonly mode
which allowed sheets editing in readonly mode

Change-Id: I64c9437d2171b0518aa3c08f06d8d65fb3d302af
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86507
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-01-20 17:54:44 +01:00
Weblate
081ce41e50 update translations
LibreOffice Online/android-app (Asturian)
Currently translated at 38.4% (38 of 99 strings)

Change-Id: I8e041ba673955f00b4ff5ffa6c3813b25c670cdf

update translations

LibreOffice Online/android-app (Catalan)
Currently translated at 98.0% (96 of 98 strings)

Change-Id: I33985ea09845c154626cd0cb45d78e1818ac2e9b

update translations

LibreOffice Online/loleaflet-help (Dutch)
Currently translated at 48.3% (201 of 416 strings)

Change-Id: I4b3e98671b2ef20b0ca806d131458a004ece3a3c

update translations

LibreOffice Online/loleaflet-help (Basque)
Currently translated at 90.1% (375 of 416 strings)

Change-Id: I2b16c6e90b2a3344bace7653614b2a7fd6e5c802

update translations

LibreOffice Online/loleaflet-ui (Basque)
Currently translated at 100.0% (283 of 283 strings)

Change-Id: I883b9548eb1efe3af7a2e40393ebf735f33a677d

update translations

LibreOffice Online/loleaflet-ui (Esperanto)
Currently translated at 63.3% (179 of 283 strings)

Change-Id: I847eb27ce7f1971295e9ed274b5028e627b923b6

update translations

LibreOffice Online/loleaflet-ui (Catalan)
Currently translated at 97.9% (277 of 283 strings)

Change-Id: I3be1b00a13d067390fa190da4fccc952da5076b4

update translations

LibreOffice Online/loleaflet-ui (Asturian)
Currently translated at 33.9% (96 of 283 strings)

Change-Id: I8808049c8f058b62af323033725c7311bc1e2be5

update translations

LibreOffice Online/loleaflet-help (Catalan)
Currently translated at 65.9% (274 of 416 strings)

Change-Id: I1ae5c4d3cddd11a83d9254686182fc00d1b801d9

update translations

LibreOffice Online/loleaflet-help (Italian)
Currently translated at 100.0% (416 of 416 strings)

Change-Id: I6651eb476655443b236ae8e9f934828f760a4b3e

update translations

LibreOffice Online/loleaflet-help (French)
Currently translated at 71.2% (296 of 416 strings)

Change-Id: I68629ed044bd30c854d823caf70df954912fdc63

update translations

LibreOffice Online/loleaflet-help (Basque)
Currently translated at 85.3% (355 of 416 strings)

Change-Id: I624ea006ffafe977983dc823622222c903a17be2

update translations

LibreOffice Online/loleaflet-help (Spanish)
Currently translated at 99.8% (415 of 416 strings)

Change-Id: Ib8ba3e6397fcd396c8d01fbfba48db91bee39238

update translations

LibreOffice Online/loleaflet-help (Catalan)
Currently translated at 65.4% (272 of 416 strings)

Change-Id: I364c39de59a4b3a4cb705a9f0eff76aa94e247e4

update translations

LibreOffice Online/loleaflet-ui (Catalan)
Currently translated at 97.5% (276 of 283 strings)

Change-Id: Ied8ff70562b4d98e181662e1e60496ef2b5bf4c7

update translations

LibreOffice Online/loleaflet-ui (Bulgarian)
Currently translated at 100.0% (283 of 283 strings)

Change-Id: I0f777f6dc44538153b5b7bd5a4f731e0e5110f66

update translations

LibreOffice Online/loleaflet-help (French)
Currently translated at 71.2% (296 of 416 strings)

Change-Id: I4b759612e69377768f5e165c4bc8daaf8f1e177c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86990
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-01-20 11:55:27 +01:00
Miklos Vajna
2c9e1319d9 Fix a -Werror,-Wrange-loop-analysis warning
wsd/Storage.cpp:451:21: error: loop variable 'header' of type 'const std::pair<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> >' creates a copy from type 'const std::pair<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> >' [-Werror,-Wrange-loop-analysis]

Change-Id: I90a57333b0807f3457d5b1082097426a3bf9678d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87055
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-20 10:08:09 +01:00
Michael Meeks
e6a3364e93 Move file url anonymization down from LOOLWSD into FileUtil.
Change-Id: I415c73b10621d5c7c942367bbf38a3bbd9bf8f27
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87024
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-18 20:05:35 +01:00
Michael Meeks
8cca6dcac8 Cleanup JWTAuth token before shutdown.
valgrind had some exciting double-free action on unclean shutdown.

Change-Id: Id7dd3d8ff60387ae51521bd2c74e4d6bcc30ff2e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87025
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-18 19:26:10 +01:00