Commit graph

7099 commits

Author SHA1 Message Date
Andras Timar
b2272c5924 drop ssl configs, we want the simplest case, which is nossl
Change-Id: I788690cb3361b50a6db33f1c87b236b59b94821b
2018-10-27 14:47:45 +02:00
Andras Timar
20e918b732 service_root is advanced setting, forget it for now in sample configs
Change-Id: I181faaff1eff0d27fa09032f75c03f288b7cad1f
2018-10-27 14:47:45 +02:00
Tor Lillqvist
2d2e3cf531 Take path to document to edit on the command line
Sure, could add more and more options to specify what LibreOffice
installation to run against, etc, like gtktiledviewer. That is not a
priority though, this is just a very basic testbed for now.
2018-10-26 11:53:49 +03:00
Tor Lillqvist
81f56d6d78 SCNR: Avoid forward declarations, just move the functions before their use 2018-10-26 10:47:57 +03:00
Tor Lillqvist
f7ebab8902 Use Poco to convert from pathname to URI
(Yesterday I talked about GLib in a commit message, I meant Poco of
course, for this source file. It's gtk/mobile.cpp that uses GTK+.)
2018-10-26 10:22:33 +03:00
Miklos Vajna
5167cf9f58 StreamSocket: make members private
Only a single member needed a setter, otherwise getters were enough.
2018-10-26 09:07:30 +02:00
Tamás Zolnai
bf2dcdc01f Have a better log for convert-to denial
Change-Id: I5c8d367b3f82d47a45df8c298e39515bc89f7b0d
2018-10-25 22:25:34 +02:00
Tor Lillqvist
9360beb97f hello-world.odt does not exist out of the box
Need to copy from hello.odt, like the Makefile.am does when you 'make
run'.
2018-10-25 22:30:11 +03:00
Tor Lillqvist
a4b4f6bf36 Fix fakeSocketAvailableDataLength() when peer socket is closed
Also bin a few lines of unnecessary code.
2018-10-25 21:57:44 +03:00
Tor Lillqvist
8bc97c0f9e Adapt after 4724aa0cf7 2018-10-25 21:33:57 +03:00
Tor Lillqvist
16a805e290 Fix some memory management foo 2018-10-25 21:28:13 +03:00
Miklos Vajna
4724aa0cf7 Socket: do what the TODO says
Drop the list of friends and just add getters for the relevant
members.
2018-10-25 16:39:02 +02:00
Tor Lillqvist
3b901020d2 Actually it's enough to pass instdir as the 2nd parameter to lok_init_2()
The "/user" will be tacked on by core code anyway. We don't need two
levels of "/user".
2018-10-25 16:02:45 +03:00
Tor Lillqvist
76ff3d5c2a The 2nd parameter to lok_init_2 should be a URL
Sure, there is some GLib API I could use to properly convert from a
pathname to a file: URL. But I am lazy, and this is not an end-user
program.
2018-10-25 16:02:45 +03:00
Tamás Zolnai
b4b0e9c6d4 Handle X-Forwarded-For with more secure
Check all pariticipating IPs to be allowed to use convert-to
functionality. In a simple use case it means the reverse-proxy's
and the actual client's IP.

Change-Id: I4ef9cb14a1c3003cba6c66f6e99d5b54b2c3b2b8
2018-10-25 10:48:52 +02:00
Tor Lillqvist
1e97cfc2d2 tdf#120438: Don't handle a lone "alt" modifier in any special way
It is likely a Mac browser client simply accessing a "special
character" on their keyboard. (Or an iOS browser client using a
physical keyboard.) Like alt+8 to get '[' on a Swedish/Finnish Apple
keyboard, or alt+shift+2 to get '€' on a US English Apple keyboard.

Change-Id: I94b49d64db87324ff2a5cd5f50226d3c537b68e6
Reviewed-on: https://gerrit.libreoffice.org/62315
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2018-10-25 10:06:30 +02:00
Tamás Zolnai
18eb134384 Need to use clientHost here
Change-Id: I170e1d24e1a71749c3262c01a83251c6c157f6eb
2018-10-24 13:09:11 +02:00
Tamás Zolnai
318f0629bb Handle X-Forwarded-For header for convert-to feature
Extract the client IP from the X-Forwarded-For value
and use that one to allow / deny the usage of convert-to
feature.

Change-Id: I363c0931df5a0538236cae12f943fffd65086ee6
2018-10-24 12:50:03 +02:00
Tor Lillqvist
fb33a3d607 Minor edits
Change-Id: Ie392c6e5d5ba6c9f39c6786f48f4457d2478f23b
2018-10-24 12:44:47 +03:00
Tor Lillqvist
3f970778dd Add an initial README for the iOS app
Change-Id: Iad1d6f829b127243d6344f61f97e2cd3a417caf7
2018-10-24 12:07:55 +03:00
Tor Lillqvist
cf545b0b2f Revert "Make tapping once pop up the keyboard on a mobile device (at least an iOS one)"
Nah, that fixes one thing but breaks another. After the change that is
reverted, the on-screen keyboard pops up too often, also when you just
want to pan around in the document.

Let's see how hard it will be to make the on-screen keyboard pop up
only when actually wanted (after a single quick tap, and after
selecting a word with a double-tap, IIUC) and never otherwise.

This reverts commit c69a19ec30.
2018-10-24 11:40:49 +03:00
Miklos Vajna
22fac18fcd WebSocket: make members private
All of them were protected, but only _socket was used actually. Add a
protected setter/getter for that field.
2018-10-24 09:36:13 +02:00
Tor Lillqvist
5750b17988 Minor improvements 2018-10-23 22:13:23 +03:00
Tor Lillqvist
decf78ff2e Buffer an unlimited (eek, scary) number of messages per fake socket
Matches the behaviour of real sockets in a real Online server better.
Seems to get rid of the occasional hang problem.

I had already some time ago suspected that such a change would fix
that problem, but unfortunately my first attempt missed one crucial
detail, so it didn't, and I spent days looking for other ways to fix
the problem instead, in vain.

Probably I should add some sanity limit on the number of buffered
messages, though... But if such a sanity limit then would be hit, most
likely much else is totally broken already anyway.

Change-Id: Ice43057814ee5abd85b2935ffaa91765845a515a
2018-10-23 15:23:01 +03:00
Tor Lillqvist
60a3733859 Add also some .hpp files for easier breakpointing
Change-Id: I8cb92c80f21bb2b3390e786d44c3621ff5836466
2018-10-23 15:19:10 +03:00
Tor Lillqvist
5b13757d4a Remove obsolete comment
"-1" was changed to "all" (the meaning of which is more obvious) over
a year ago.

Change-Id: I929cff2b35c7493efeb523bf30b6967b983bc068
2018-10-23 13:20:53 +03:00
Tor Lillqvist
8194e2e1e7 Define LOOLWSD_CONFIGDIR also for Release
Change-Id: I41ce6a499d7dc8b76a0c1f8d91ca81008c5474af
2018-10-23 13:20:43 +03:00
Tor Lillqvist
8266582cc4 ICU version has been bumped
Change-Id: I135f989dcd65c3aeb5d12dc4f14839cb1e30f6ec
2018-10-22 23:24:21 +03:00
Andras Timar
470960e607 adapth paths to new source layout
Change-Id: I26b99f697f8481783714d45793f49dd818164d60
2018-10-21 21:22:04 +02:00
Andras Timar
03d184438e typo: streingIds -> stringIds
Change-Id: If68d5ddb26eb8a9b1b1c9b13db3819972753aa28
2018-10-21 21:08:37 +02:00
Andras Timar
244b27170e untranslated.py - a helper script to list untranslated strings for a given language
Change-Id: I44d5102fbe3ca319d5a4671a91957353c5357cda
2018-10-21 21:07:59 +02:00
Andras Timar
e444e3f197 adapth path to new source layout
Change-Id: I5cec0534119fce64bf9409a1f8fd382c259bbb95
2018-10-21 20:37:28 +02:00
Henry Castro
c0643e1421 loleaflet: mobile: move button (hamburger/x icon)
Change-Id: If552c5f77cb56818f6762b77f34498eabc267d1a
2018-10-21 12:53:16 -04:00
Tamás Zolnai
4ff506425f Enable convert-to test
Change-Id: I7c2bf333bb4bcb803cd926bfb1d669f89d100615
2018-10-20 13:41:43 +02:00
Tamás Zolnai
bb50c9e0cd Enable convert-to features for wopi hosts
Change-Id: I994be7087247215b09d117df18b661906d941266
2018-10-20 13:26:38 +02:00
Tamás Zolnai
ec65ecd0f1 Revert "Revert "Enable convert-to features for wopi hosts""
This reverts commit 343ba48d27.
2018-10-20 12:57:53 +02:00
Tamás Zolnai
343ba48d27 Revert "Enable convert-to features for wopi hosts"
This reverts commit 8dd28ed664.
2018-10-20 12:55:55 +02:00
Tamás Zolnai
683cedb17a Delta test: avoid dumping out useless data
Change-Id: I05bbd05b3ee1e0a5b0687b7b6c981938a1493946
2018-10-19 18:15:22 +02:00
Tamás Zolnai
8dd28ed664 Enable convert-to features for wopi hosts
Change-Id: I8aa37c61f3df5356fb7a14d93cda6279e7ec3cf1
2018-10-19 18:15:22 +02:00
Tamás Zolnai
0bb8b7c7a8 Add /hosting/capabilities endpoint to advertise online features
Add an entry to discovery.xml with the urlsrc where capabilities end
point can be found. Use json format to send back the feature list.

Change-Id: I390a53d956d53ca79e5a8090aead7f4131ec4ca0
2018-10-19 18:15:22 +02:00
Tor Lillqvist
d6d0c3e8a3 As far as I see, no getPollEvents() implementation will ever return negative
In 1c7f94045a that introduced
DelaySocket, its getPollEvents() could indeed return -1, but that was
removed later.

Change-Id: Ie3a7e01b7b9a7517d97f6ed3cc6d96bdb3313969
Reviewed-on: https://gerrit.libreoffice.org/61990
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2018-10-19 13:41:18 +02:00
Tor Lillqvist
c6c6e8cc46 In fakeSocketConnect() log also the fd the corresponding accept returned 2018-10-19 02:03:32 +03:00
Tor Lillqvist
b7a42bd9d1 Add a FIXME 2018-10-19 02:02:54 +03:00
Andras Timar
c3c18a2fa9 adapth path to new source layout
Change-Id: Ibf532933c999400979bc2a0623622d3428b6a8c2
2018-10-18 16:42:45 +02:00
Tor Lillqvist
c69a19ec30 Make tapping once pop up the keyboard on a mobile device (at least an iOS one)
This fixes both the case of a normal Online instance being accessed
from a mobile device (at least Safari on an iPad), and the iOS app
being developed. The same problem was seen on both. Which isn't
surprising, as as it's the same Webkit software running the same
webpage and JavaScript.

I hope this change does not have some unintended annoying other
consequence.

Change-Id: I7ada39f1adbb9a1ac560493d926530968aa44133
2018-10-18 17:09:03 +03:00
Andras Timar
e0af51791b typo: ration -> ratio
Change-Id: I1c3a57b4c2f4d5c8daf3faca497ccbfa7f79ef33
2018-10-18 15:24:38 +02:00
Andras Timar
d6cac1b4a2 core dependency: libXrender 2018-10-18 15:16:05 +02:00
Ashod Nakashian
0bf78a3ce7 wsd: fix saveas test
It didn't expect the trailing xfilename which
is used for anonymization.

Change-Id: I169253c567583f43ce870bbf5dfcebee9c94cd1d
2018-10-17 19:29:08 -04:00
Tor Lillqvist
0c998539f3 Typo 2018-10-17 23:50:15 +03:00
Tor Lillqvist
61e0d72982 Move framed.doc.html so that it doesn't get removed by 'make clean' 2018-10-17 23:44:59 +03:00