The input field is already being hidden for mobile. For Tablet and
with the increased amount of UI elements on the top bar best to hide
it also. Renaming the document is a quite rare used action when
compared to any of the other top bar actions (switching tabs, open
sidebar etc). Better to hide the #document-name-input when on tablets
instead of trying to fit everything (and end up obstructing tabs for example)
Tablet user can always:
- Use the integration (already used to do many other file manipulations) to rename the file
- Use the in-app Save as can still be used to save a copy of the current
document with a different name
----
Possible future improvements would be to add the possibility to rename
the file when using a tablet:
- Add menu entry and tabbed view button
- Control.Menubar.js something like {name: _('Rename Document'), id: 'renamedocumentbtn'}
- Control.NotebookbarWriter.js add bigtoolitem Rename Document
- Maybe in Control.UIManager.js add a renameDocumentBtn function that
- Creates a JSDialog with document-name-input element + Cancel btn +
OK btn
- Ideally that input element would re-use the functionality from L.control.documentNameInput() -> Control.DocumentNameInput.js
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I968e806a4a9e0018b38b87fc249a57e5af099c78
- accessibility key features
- focus on tab when press `Alt`.
- move back and forth tab focus by ArrowLeft and ArrowRight
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Id8c8e2a8bcb57c90e0762dd3916b851fff8e0a6f
If we set the initial backgrounds without `!important` then there is
no need to use `!important` for dark-mode (since we are already using
a more specific targe via data-them attribute)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I600629dfc0485edac6ff725f6278de1501e1c9a7
Large Clipboard and document idle modals were being set with tabindex
0 allowing for manual user focus plus were being focused dynamically
for each instance:
- Transfer all that (just once) to showinfomodal instead for the
cases where we have buttons
- This in turn sets the things to the parent (dialog itself)
and not the subcontianer
- Set tabIndex with negative value so, it only allows focus via
code
- This fixes the weird outline (focus) that sometimes would appear
on sub containers of that dialog instances
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If40192e05c4b0e25e2ce71bc612ab64fc54a29ec
With c04c065edc we start to dynamically
set the canvas background. The problem is that for Calc cells do not
have intrinsically a background and thus what we end up to see as the
document background color is actually the canvas color.
- Make sure that when we are in presence of calc we set the
canvas color (clearColor) with the value coming from
documentBackgroundColor
- To make it clear: create a new CSS variable to be used as
background-document
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4c456e4aeea233609ee58684d967984dd8afd63a
Set Minimal width for suggestions list
Added some padding for spell check text box for more readability
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I0fa5bb60ece88e4107408448a17378b526020784
instead of using hardcoded pixel distance...
affects eg. feedback dialog which was impossible to
access in very small windows due to position outside window
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I2a85defcd2aabf1bdb8ec88d70b6e6a873dec75f
problem:
In safari and gnome web when you scroll using scroll bar,
DOM elements on the slidebar and documents would get selected
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I222d246148d5d84a5c0b3cfdb1890350f428e696
So user understands the component is empty.
We cannot add disabled attribute here because we have some cases such
as pivot table where the initial state is empty.
Note:
Ideally we would distinguish from static and dynamic
treeview (static=read only list VS dynamic=list you can remove and add
items). Only after this distinction we can properly add disabled
attribute to the static one
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ide4fb7589b5be611975de4a704b458bb626be0e0
It converts textarea into contenteditable div.
Input is handled by TextInput.js used for document
and already in the past for formulabar. Replaces
usage of keyevents which are not triggered with
eg. Japanese.
Fixes also #6737
Fixes on mobile #6767 requires: https://gerrit.libreoffice.org/c/core/+/153717
New widget consists of text layer with visible content
and cursor layer with selections and cursor. When clicked
it focuses TextInput.js field for typing.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ieb7cf148a5aba80ab790e0b53c3a5ba27f166b73
Before this 8a0c8c44a7 was not being
applied furthermore better to specifically set this to only affect
labels within dialog content (since jsdialog class is also in many
other places such as sidebar and widgets)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic1cb825d6c70858a4c49123243866eaf0a6a8e50
This way they:
- Align to checkbox
- And have additional padding in places such as Format > Paragraph
Line spacing 's dropdown is glued to "of" label
This also fixes one task from https://github.com/CollaboraOnline/online/issues/6647
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I53e66602dffbc96db39449cbda53d433a9dd12d8
added slide hide/show option in presentation bar
rearranged icons to align them with core UI
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ic4b121ab5d9ab21d8f48e68bb07e51a31442586e
this width was set but never used w2ui img rules have been overriding it
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I86a7d8b16313204fcacdabcad8f604ca5c1dce40
Before, we needed this white background.
Now, we don't.
- After HTML and dialog rework the background is inherit from the
wui overlay and the images are set directly to the td elements using
bg img
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic6b802f4fd5bac66e975800b929c53ca571158dd
Better to make it more generic so it not only includes:
Busypopup: c26bed9
About dialog: bed76f1
but also any other similar dialog (warning dialogs, e.g.: copy/paste etc)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If56e36d5429472f255d94bfaa087a32309903257
Before, we needed this white background.
Now, we don't.
- After HTML and dialog rework the background is inherit from the
wui overlay and the images are set directly to the td elements using
bg img
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I30826e17c502b0369fd337699d93f648d41846aa
Add color property for annotation-textarea to get correct font color in comment box.
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I74d5e83641982acc1b0b328c707c09d06d68c56d
Since we have disable the functionality until it works as expected
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0a99680d79ffb44a653c32edb25aafded35c7712
Otherwise they (their contents) will not be scrollable
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idf121b6164dbb43a473e07e2ca70962bedb10ebb
Do not re-use light mode values.
Increase color contrast
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I514d4be5468dd3df50ab5256b64d0a22e659ad97
- Categories (listview with icon) get highlight but not indicator
- So it's understandable that they can be dragged
- Categories: change cursor so user understands that they can be grabbed
- All other treeview (even exapandable) get highlight and indicator
- To help user's orientation
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I8c275c81503787c60c4527a3cee63be8323686ef
This is a follow up on the revert f4f95b2 since the scroll logic depends on the
absolute position
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I5659701c2236dc89f764f45008e6e92c47a3f101
- Tunneled dialog was missing title bar color (was inheriting from
jquery ui library defaults)
- Also use the main background (lighter than bg-darker) for JSDialog containers
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If6db5ee2edad88b2785096eb746f291a07b46d70
Better to move this elsewhere otherwise we get huge save icon
This reverts commit 247bc9192d.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
I have noticed that sometimes the toggle doesn't get assigned with
selected css class. We could just rely on this line and avoid add and
removing css class to the DOM every time the mode changes
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7c19f626d60c761a1ebe2509e7ab7aa8031403ad
now that about dialog is not a vex it is inheriting width from
generic .jsdialog-window.modalpopup. Overwrite that and make it wider.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I830f57cc9fda9bea8e377d53e72af92c4804cf8d
