The issue is: On creating a page break on a empty writer file and
hitting backspace, the deleted page or parts of it is still rendered.
We get a 'status' message containing the document size every time it
changes. So avoid the issue do not draw tiles that are not within the
document area.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I88d1715e861f068326d28d2930d01e3b5355be02
canvasRenderingContext2D.translate() and friends only seem to function
with numbers < 2^24, at least on Chrome 89.
So when the pane being drawn where this limit is hit, lets do the
translation ourselves.
But in the case of zoom-animation more complicated transformations are
needed. Till we implement the manual matrix transformations correctly,
lets not animate overlay objects when the view area has hit this limit.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: Ib48d6029ba1c6f1d7ade35060baf4ebe3e0a5fd3
- Position the number of replies near to the chevron to indicate what
that is supposed to do.
- Reply counter gets the same color as its icon
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idd692f40f5f3420d7577147e8ca7bcf306e59899
The view area after zoom is computed by the following rules:
1. If there are not edit cursors or it is out of view, anchor on the
top left cell.
2. Else, compute the new view area w.r.t top left cell, but if the edit
cursor is not in that resulting area, translate it such that edit cursor
is just inside the closest edge of the final view rectangle.
Notes:
As part of the implementation the default behaviour of view scrolling on
cursor msg was disabled while the new view area is being set.
If there was an active edit cursor to start with, ensure it remains the
same way. This is acheived by replaying the last print twips cursor
messages after the new view area is set.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: Iaada6ec1f4a06f7ad05dec759e702bd37240dff8
by setting a top padding of right amount.
Before the patch the top border of toolbar "appear" white on the part that
intersects with row-headers and it was gray where it intersects with the
document content(tiles). These were due to the background of body and
tile-pane div respectively.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: Ia3b95d41ea150d815469498e3e2044d7e1d36a4d
(cherry picked from commit 66416be43980205dea1a2addefbf5954e013c3cc)
When CellCursor command result arrives we focused
the document what caused annotation closing.
Change-Id: Idf2eb8c5b3b0049dd0aeb7c82cca80083b304698
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Now we hide selection handlers while typing due to
not being able to use them, these tests fail to find
rotation marker. When text is found on mobile selection marker
wraps the found text and they become visible. when not found they
become hidden again. Checking the selection marker for this test cases
should be enough.
Change-Id: I6037450bc17438e4819ae3b724849f74f26910d4
Signed-off-by: mert <mert.tumer@collabora.com>
Dragging is impossible when cursor is active so
displaying them only leads to confusion
Change-Id: Ib0586ce6ac38354b84076972e01be136f7ec66f9
Signed-off-by: mert <mert.tumer@collabora.com>
invokeWSDTest is called in an exception-safe scope
and logs errors before failing tests. No need to
have the same logic here.
Also improve the exception handling and reporting
in the fetchClipboardAssert helper.
Change-Id: I306aedc3f50f93bf8a5448f1d098e5ce884ceb37
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
When loading hasn't completed yet, DocBroker can't
simply send a message to Kit that the session is
disconnected, because there would be no UI or
handlers for events if that were the only session.
Of course letting the document load, only to close
it, is also less than helpful to resource consumption.
Here, we recognize this case and simply terminate the
loading by killing the Kit process altogether to
avoid any potential hangs or resource wastage.
Change-Id: Ia72de715cc6238831c244444bb47b417b9b1e1a4
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Previously a 'click' on 'start download' - also resulted in a pair
of mouse down/up events getting sent to the map, the TileLayer, and
thus the core - resetting the object selection during the download,
and causing nasty issues in the second 'Confirm copy to clipboard'
which had a different & random selection depending what was under
that popup.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I7f6510494500dd36beb232e4720a66f2d9e09f27
scrollIntoView scrolled whole page inside iframe
when selection in the fontwork dialog was changed
Change-Id: I40f59c1821d1327aaf6ce910e07587f0dcb5af31
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
show only .odg and .pdf formats in file tab
Change-Id: If95d871d0ec546569a3ccb0334b9acbd971a9f86
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
- center main div
- set minimum size for children in %
- make sure everything is centered
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iab199dca2a4907ca7292cc8b56cf6535b3013c0d
I saw that happening now and then when experimenting with the Insert >
Comment functionnality in the iOS app. The message in those cases
seemed to be 'jsdialog: { "id": "0", "jsontype": "notebookbar",
"action": "close" }'.
Change-Id: Ia8e07f849f88bb46cedd95f7c38534232c388efe
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Unclear whether it is actually useful or not any longer. Quite
possibly cross-platform changes in the JavaScript since
CollaboraOnlineWebViewKeyboardManager was introduced have fixed the
problems that it was solving.
Fixes https://github.com/CollaboraOnline/online/issues/1432
Change-Id: Ifa000d0a7d0a3dc87527536719063b368266f038
Signed-off-by: Tor Lillqvist <tml@collabora.com>
