Ironically our attempts to double-check message origin against our
parent was blowing a security exception.
Instead send the list of origins we will accept from WSD, and
check them ourselves (as well as the browser check).
Why make it so hard to check that a postMessage comes from an
ancestor frame ?
Change-Id: I1311be3e1d68a31cfdc96b45a5eb5dd7f26e7ea9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86788
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Alexandru Vlăduţu <alexandru.vladutu@1and1.ro>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Without this, we were closing the document, which was very annoying.
Change-Id: I1e841da28c92c0e01284c2d7e2d4dbc6762bfffd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86779
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
- account for moz vs webkit intricacies
- account for newest spreadsheet formula implementation
Change-Id: If5ae4159bf5b5cea82771b085f8e7e90f97e0804
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86760
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
- it was causing improper behaviour when multiselecting
- there is always a cell (svg path) that is been set always with diferent stroke color even when multiple cells are selected and so CSS shouldn't be modified but instead, probably, JS bits
Change-Id: Ie8f11f14f5ffc958f646332c7fe2bc810b34d808
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86755
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
if unwanted, this menu item can be hidden with branding.css
#menu-report-an-issue {
display: none;
}
Change-Id: Ic3fc3a74e8bea0b68ced542423c6068b150f647b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86632
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
- which increases legibility even when there is a checked element underneath
- also decreases its width so the element that is partially under is still interactive without the need to swipe it first
Change-Id: I54fe3e3d0bd699246f76c77e929b3c4a250e0b82
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86691
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
long press event in thumbnail previews in Impress
Change-Id: Ib0661b906882b87d68833c96ce3f535bd3fccbec
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86568
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
It is complicated to debug 5 event listener attached to an element,
let's use one event listener.
Change-Id: I9de1f1707f95f07a49358c8e7580ad232edd4389
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86567
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
Avoid mobile's extraordinary IM work for now; encouraging the core
to tolerate a number of backspace characters is a tad tough for now.
Change-Id: Id3cad6ad12384440ee613e88741c395c2d742683
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86589
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Hopefully it can be re-used for a single-tab view now.
adapt to new panel naming re-using the UNO methods - cf.
related core commit.
Change-Id: I1312d3571ccb7cf3561f1661f73f860c56f002a4
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86572
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Avoid lots of indirection and complexity based on the new,
simplified sidebar JSON hierarchy from the core.
Change-Id: I73d5c6af30d40e9a430e0f3df3b78b620f425e39
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86510
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Possibly a good idea for Android, too? See bug report for description
of what this fixes.
Change-Id: I6b70f431ced09044756c2edc3fcc2542428b62e1
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86484
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
So that they are in-process, which means it's easier to debug when they fail.
Change-Id: Icb3d7a7d0ffa7371eb3056b5de7144137c0acb8a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86463
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
rm -rf of the assets was newly introduced, done after copying the
templates to their place. So missing templates => crash; fixed.
Change-Id: I53d243b4f44c2c38843336e38e603ae0bd4b3c89
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86449
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
It has been added an attribute 'disabled' when permission is
'readonly', otherwise it is removed
Change-Id: I64a4cf9a7a754d66862e55805202358b9f83caf8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86442
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
The mobile and desktop prevents default 'contextmenu' action
Change-Id: I89171c955c153b2fceaad92970e2eaf039cb8527
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86373
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
Insert Shapes dialog opens on the right
side of the screen and can be too
narrow on desktop
Change-Id: I8f9fe8f00989b504d05282fcd5332bf1a1b94ad0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/85747
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
By implementing mobileapp: false in the panel builder.
Change-Id: Id518fb4b02598511403eac4cef53e94317042fd4
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86370
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Also add option to enable/disable on-line spell-checking to the menus too.
Change-Id: I1ba2a68c7d410041b6710f598a7c7fc60511ffee
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86371
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Amazingly more time was spent allocating, wiping and freeing these
vectors on Android than the actual rendering of pixels in a profile.
Change-Id: I49ea093816eba0f4187613ab6c8dc24d8dcba75b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86335
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
- Enable and adjust elements when on mobile so they are visible but discreet (without covering icons)
- Make them not clickable when on mobile (thus avoiding unwanted scrolled due to users mistaps
- Make their parent aware of the ongoing scrolling and call w2ui resize on it (thus making the left and right indicator showing and hiding as we please)
- Test and adjust so this changes do affect affect the click listening on desktop etc
Change-Id: Ic35dadb71e7fd6ae3ff2fad3e52d5219e7520c55
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86364
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Horrible hack, but works for the specific case described in the bug at
least.
Change-Id: I55150d84dc892ece69540fdc0d06bc277891c1fa
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86328
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
