Commit graph

21294 commits

Author SHA1 Message Date
Ashod Nakashian
5e27d0800b wsd: use STATE_ENUM in SocketDisposition
Change-Id: I914557afdbf8f03856214acf2a64d405b8e0e068
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-06-30 21:45:40 +02:00
Ashod Nakashian
56992f0bad wsd: logging
Change-Id: Id82e44f508397affbc828494c766dca7bb97d4dd
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-06-30 21:45:40 +02:00
Ashod Nakashian
e0ea9fc883 wsd: some clang-tidy warning fixes
Change-Id: I5d5cce6bec9b377025640d10e7a0053b9f6ddd91
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-06-30 21:45:40 +02:00
Ashod Nakashian
826451b6cf wsd: http: protect against exceptions from onFinish
Previously, we didn't expect such exceptions,
but increasingly this can happen, as we have
more and more async processing. The main
issue with not catching exceptions is that
we do not properly discard read and
parsed data from the socket. This is a
major issue, of course.

Change-Id: I4490baed7069cd55d103301c1d3be31d9b2d9b2c
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-06-30 21:45:40 +02:00
Attila Szűcs
9b689b3e53 Treeview: fix tree branch collapse
Added collapse event sending to to core
and handle collapsed information received from core

the core part is here:
https://gerrit.libreoffice.org/c/core/+/153771

This patch allow user to have separate view of navigator, other users
will not expand/collapse our navigator.
Our own Expanded/Collapsed status of navigator branches will be
remembered even if we turn off/on navigator.

Signed-off-by: Attila Szűcs <attila.szucs@collabora.com>
Change-Id: Ib0c1beb3ba05932e6a36c2d95a72f3d1d61fd55c
2023-06-30 21:05:14 +02:00
Attila Szűcs
aff495099e treeView: Cursor movement fix in collapsed branches.
Improved _handleKeyEvent for ArrowDown and ArrowUp, to jump
not only one line blindly, but to seek the first entry that is not
hidden, or else focus would stuck on collapsed tree branches.
(Because if a tree branch is collapsed, then its child entries,
that are the following entries, are hidden, so we should skip them)

Signed-off-by: Attila Szűcs <attila.szucs@collabora.com>
Change-Id: Ic7a662964976263f40e18c8a41fe4e9e72f85ea3
2023-06-30 21:05:14 +02:00
Skyler Grey
2ad2ac584b configure.ac: Fix missing space in test command
Omitting this space leads to the error "test: too many arguments"

Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: Id8a83d77adfb484dcc949a10b4b25f6ad81130f8
2023-06-30 21:04:34 +02:00
Caolán McNamara
062219b31b restore using Uint32Array for previous pixel compare
removed in:

commit d859da11b0
Author: Caolán McNamara <caolan.mcnamara@collabora.com>
Date:   Wed Jun 28 11:12:28 2023 +0100

    rawDelta may not be sufficiently aligned for Uint32Array

because it would failed with nonaligned data from the delta
case.

Those tend to be very short, so for that case copy into a suitable
aligned buffer and the lengthy keyframe case which is suitable
aligned already can get the win.

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I8acfcb18c69380c55128c07f1749eb301c1145a1
2023-06-30 17:39:15 +01:00
Andras Timar
12a7be619f Update l10n files for Weblate
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ifc6097800c43b62d95a9b3f0cab63b5364c4b880
2023-06-30 12:10:36 +02:00
Luna Jernberg
81ab139076 Translated using Weblate (Swedish)
Currently translated at 100.0% (463 of 463 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (503 of 503 strings)

Co-authored-by: Luna Jernberg <droidbittin@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/sv/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/sv/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I611fb02d993a87cdedcdda4693903f09f805512d
2023-06-30 12:07:13 +02:00
Darshan-upadhyay1110
8e6acb4128 Mobile: Enable tooltip for copy version button
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Iff50721ef8befd3802967a575e61233540298ced
2023-06-30 11:33:01 +02:00
Darshan-upadhyay1110
e19f29eb98 Fix : Wrong label 'BackColor' on mobile UI
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I264d02b57a5e2c969ac9245cee2fa4be028e1c04
2023-06-30 11:25:14 +02:00
Rash419
5b31e6d5a2 updated k8s readme to use collaboraonline.github.io repo
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I505c0c177a649a5ebed63dcc5232a3cba3e5fbf7
2023-06-30 10:03:29 +05:30
genofire
2b49a9a1ad fix(helm): update appVersion
Change-Id: b37e710c9d964372bb3466626545e5437942a900
Signed-off-by: genofire <geno+dev@fireorbit.de>
2023-06-30 09:30:25 +05:30
genofire
767ab72d2f fix(helm): ci with helm- prefix on tag and release
Change-Id: I67754c5159f80ea721920e888996a894ca4101aa
Signed-off-by: genofire <geno+dev@fireorbit.de>
2023-06-30 08:11:12 +05:30
Henry Castro
e5b4036627 wsd: fix secure cookie Set-Cookie
The browser will block the cookie if it is sent
over an insecure connection

"This attempt to set a cookie via a set-cookie header was
blocked because it had the "Secure" attribute but was not
received over a secure connection."

Change-Id: I36faac0d9d3a73eed463c2580e5405d61a3a18f5
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-06-29 20:47:08 +01:00
Henry Castro
6bd4563a8a browser: admin: fix vex dialog on socket close
The parent class will overwrite the popup vex dialog,
misleading error information.

Change-Id: I29d3d5fe0747903a58b56ae6c70e2e226715cdf4
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-06-29 20:47:08 +01:00
genofire
de74ae830b feat: add helm-repo release ci (with usage of github-pages as helm repo)
Change-Id: 3dde8c5cac91543dc97bd38918de00e7af35d7a7
Signed-off-by: genofire <geno+dev@fireorbit.de>
2023-06-29 22:08:35 +05:30
Rash419
fcce324cbf admin: added retryInterval option in monitor config
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: If0b94bb043a6a4883affac6cf38adcffd3b72b9a
2023-06-29 18:21:33 +02:00
Rash419
9d1741232b admin: added wopiSrcMap command
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I95a7ccec6075848bd18b8899119c720aa303a106
2023-06-29 18:21:33 +02:00
Rash419
d63bca3f8e admin: migrate document after saving
- controller used to send two messages first to save then
  once saving is done migrate the document
- now controller only sends one message, COOL handles
  unsaved document

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Id4afe1f9a04ef99005d7f0dbd6246826ba82442b
2023-06-29 18:21:33 +02:00
Rash419
932f2ad67f admin: don't send the routing_rmdoc if doc is migrating
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ic1391dd509027e794ed005bcf78014afca31ede5
2023-06-29 18:21:33 +02:00
Rash419
164d1d2826 show message that document is migrating
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Id0908f31b578a6f0ff012c212f4ca4468a76038c
2023-06-29 18:21:33 +02:00
Rash419
b717be603e implement document migration
- updated protocol.txt

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I67a0515580979e15223ea084c835f5ed801ceb5e
2023-06-29 18:21:33 +02:00
Rash419
ca5517cc24 indirecton:request again if we get 202 status
- also send 'App_LoadingStatus' postMessage with 'Loading_Progress'
  Status to notify integrator

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ie754955c53d4d361d8dfaf083f7734382954d3f9
2023-06-29 18:21:33 +02:00
Darshan-upadhyay1110
4f779b25e2 Update page state inn statusbar for readonly mode.
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Icb4f9116deb9a79fec3b6fe708625619a80ddb9c
2023-06-29 17:14:53 +02:00
Caolán McNamara
2081d49bcc cid#318937 Array compared against 0
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I8e0e270b0a08e9fe343b591095a001530bc88c02
2023-06-29 08:03:00 -04:00
Caolán McNamara
b30ccb0392 cid#318852 COPY_INSTEAD_OF_MOVE
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I8e5f1f7f837c7d52922f05c8a65b1af583b864b9
2023-06-29 08:03:00 -04:00
Caolán McNamara
52338a50f1 cid#318841 String not null terminated
help coverity see that this is not true

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ie2b72e7c0bcc649509310edc5498ec7adc7ebe72
2023-06-29 08:03:00 -04:00
Caolán McNamara
4730458b97 cid#318835 COPY_INSTEAD_OF_MOVE
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I964fc80c2bb7bddb8391e631ce179bf947fce55e
2023-06-29 08:03:00 -04:00
Marco Cecchetti
226a758594 cypress tests when editing with a11y disabled
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I54ae4515ba1b59711cfbd719db777d02f4735d7a
2023-06-29 13:43:13 +02:00
Marco Cecchetti
2cf2a1e891 cypress: expectTextForClipboard helper function never fails
expectTextForClipboard(expectedText) never fails for any passed
expectedText string
The value returned by the function passed to `then` cypress construct
must not be regarded as an implicit assertion.

I don't see anymore the '\n TEXT" case. It seems that comparing for
equality against the selected plain content is enough.

Fixed some cypress test that was failing after modifying
expectTextForClipboard.

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I64ce31fa2127efcc70bbc3da3ac45fe456e66803
2023-06-29 13:43:13 +02:00
Marco Cecchetti
ef02d909a2 a cypress env var for enable/disable a11y on testing + a a11y tags
Now you can use CYPRESS_A11Y for enable/disable accessibility state on
testing.
Moreover you can use the taga11yenabled tag for tests that should be
run only when accessibility is enabled, and the taga11ydisabled tag
for test that should be run only when accessibility is disabled

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I4c44e78e5394477b64cc17ac6b815d9d70b059f5
2023-06-29 13:43:13 +02:00
Pedro Pinto Silva
261e8cac30 Scripts: Add parser used in forum for monthly leaderboard
Used for translators leader-board in the forum

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I04a557c3beaa109b0ab010ca32ec749b585d07cc
2023-06-29 12:55:35 +02:00
codewithvk
2dcabfd3ca Condense common parameters in Makefile
Change-Id: Ic39a90bf263504bb45b0b933e06893629966e357
Signed-off-by: codewithvk <vivekpatel7202@gmail.com>
2023-06-29 11:39:18 +01:00
Paris Oplopoios
738de114d7 Make writer page background match document color
It used to be that scrolling in dark mode would show a white color while
the tiles were loading - now shows the document background color.

Signed-off-by: Paris Oplopoios <paris.oplopoios@collabora.com>
Change-Id: Id4c3881e728ae18496bf276e8c565a7abc1de7b5
2023-06-29 11:22:04 +01:00
luigiiucci
415f171036 Add new "download as" PDF option
PDF export was avaliable only with a modal "pdf options" window.
It seems a little complicated for some users who'd like to
simply press the button and receive pdf.
Added a new menu item to download pdf directly.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Signed-off-by: luigiiucci <luigi.iucci@collabora.com>
Change-Id: Id824179adeac3b516e58c85a9e2d01838f81c892
2023-06-29 11:22:24 +02:00
Pedro Pinto Silva
dd41f8e12b Mobile: Add "Read-only" label ONLY when it's not possible to edit
The new label added in a13f33b777b0ecc85752f832cd475736206f241e might
be a bit confusing and not necessary if the edit button (pencil) is
already present.

Better to:
* Have only the edit button (that should already be enough to signify
that the user is currently in a read-only transient mode)
* Add Read-only label for the cases were the user is opening a
read-only file (without permission to edit and thus the edit button is
absent)

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I1fc5ca821bfd9feb75f411d2c3260a43d54e16cd
2023-06-29 11:14:48 +02:00
Caolán McNamara
46c2ee5e54 don't call scroll if there is no pos change
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Id3913626e62b241fdeae46fcde5b0a06f7c56ed8
2023-06-29 08:55:39 +01:00
Caolán McNamara
81067dc4ad in calc we end up drawing * 3 for each scroll event
a) The "RowHeader" Header._updateCanvas listens to "move" and redraws everything via CanvasSectionContainer.drawSections
b) the "ColHeader" Header._updateCanvas does the same
c) scrolling then causes a "viewrowcolumnheaders" to be emitted from _updateHeadersGridLines and CanvasTileLayer listens for that too and again redraws everything

pause/resume around scrolling

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ic2bc28df18a633544d26607d3024bdb4dc321ce2
2023-06-29 08:55:39 +01:00
Henry Castro
8803bfa9a4 cypress: fix failing unit test apply_paragraph_props_text_spec.js
The unit test fails by 1 pixel offset, add some tolerance

"'assert expected [ <tspan.TextPosition>, 1 more... ] to have attribute y with the value '7822', but the value was '7823'""
.

Change-Id: Ieb36eedf1a17aadd3ba4872e9c4f94a3b18d0a73
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-06-28 18:15:53 -04:00
Henry Castro
e38bc519ae cypress: fix possible random file duplicates
The failing unit test it is due to a duplicate file
that was modified with new properties.

Change-Id: I02824cfeaf8c496e84dc4e285975e95e79edb9df
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-06-28 18:15:53 -04:00
Henry Castro
91b83bd44d cypress: adjust values for '#copy-paste-container' elements
The element '#copy-paste-container' according to the documentation
it is only to prevent flickering, so check only if has children.

Change-Id: I11ecdf156c6fee8657e5cd42c2c7daf9f206410b
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-06-28 18:15:53 -04:00
Henry Castro
5a25308d42 cypress: no welcome if cypress test running
Change-Id: I1ee96f029baf0e1e80209342895115dedb8ebc7f
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-06-28 18:15:53 -04:00
Henry Castro
1e29c6cb61 browser: use 'reportValidity' to validate number
Prevent to send wrong data to server.

Change-Id: I9d1b584326dd36cfe0a469a1ac77c1afbc16fd73
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-06-28 18:15:53 -04:00
Henry Castro
4466e02d40 browser: use 'checkValidity' for spin field element
Prevent send data to server if not validated.

Change-Id: I3a60ef52c842eab18c1e94063eb1c5769e6929b9
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-06-28 18:15:53 -04:00
Henry Castro
241dbdd819 browser: add method 'setContainer' to JSDialog
In order to query input elements.

Change-Id: I2c4514a278a605edcfe93231417566568c7a87aa
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-06-28 18:15:53 -04:00
Marco Cecchetti
ef51ac31ab A11yTextInput: improve screen reader on unselecting text
When text is unselected by clicking somewhere, selected text innside
the editable area was unselected, selected again, unselected again.
That was causing the screen reader to report such a nonsense sequence.

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Ib9d6628f7ac30fe2cd40ee7823ac67eb6471d1f2
2023-06-28 22:19:28 +02:00
Szymon Kłos
2956201a3d jsdialog: get precision for validation also from value
when we open Writer -> Format -> Footnote field: Thickness
shows an alert about incorrect value. It's caused because
step is set to 1 but value is 0.5 as core uses step only for
increase/decrease but not for valudation. Fix this annoying
error by allowing to use 0.1 step.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I141194ebcd1f100ca9d3e7aeae086ddac2980da6
2023-06-28 16:12:07 +02:00
Rash419
f3166c37e1 show alias tags in contentcontrols
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ib348e46af68ab00819a76f2e9cb1b26732034ad4
2023-06-28 15:17:49 +02:00