With the use of a single flag for both, the
logic is now less ambiguous, as we cannot have
termination flagged without also implying
shutting down.
The assertions are no longer needed.
Now that setting the termination flag
explicitly implies having the shut down flag
as well, the checks are simpler. We only
need to check that the shutdown is not set
to continue running as normal, since having
the termination flag must perfoce mean shut
down is also set, there is no need to check
both.
Change-Id: I99e22f5668385182b0594040a8e3354b55e74642
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Replaced id based checks with uno command ones.
Removed unnecessary function from notebookbaraccessibility. We don't use automatic id assignments any more.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I3ad69916dea72d0e7e37430e629d74763c79005c
Use string based approach to avoid errors.
Eg. 36.37 was a problematic value when multiplied by 100.
This fixed indent spinfield in sidebar.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iae25acbf59cedfd20cbcb0677fd87e08d06c3f6d
sometimes svg generation takes more time it seems
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I0e6ad493cb452a9725235f2c01c6792126b8de9c
this was changed in the core:
commit 0a549b2c9595cd076e3b503b67df93bff380885a
svg: export text decoration for text run not paragraph
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I8906ee07c7ff88c9dcdbebe73d2c620e797a8b3a
This reverts commit 8ce751a3ca.
- Any PR coming from fork fails
- User needs to manually go to:
settings > Actions: General > "Workflow permissions" and allow write permissions
- Right now we have too big of a threshold (26 lines) to be as useful as we would hope
Probably best to remove this action for now and instead use directly
the npm package (https://www.npmjs.com/package/jscpd#usage). Advantages:
- More control over what is analyzed
- It can be add as a step in make check
- User can run it locally using make check; CI can also use that.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I3c112218a83fd6e56e7fb2f47b24315347a74cdd
so the autofill handle in hidpi didn't work
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I718d9a8d3954a441705849eba174fe6b5b2983c4
We need to allow loading media sources from
the web-server URL. This seems to be necessary
at least on iOS.
Change-Id: Ic7b23c4f80b975460de9311a67f3c5cb51758d14
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
use the xml token "use-window-font-color" to toggle auto color on.
https: //github.com/CollaboraOnline/online/issues/6546
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ib14b144ce6f593114a8130f5816f479d5cd4fe85
When we get in one or more tables screen reader reports row and column
count.
When we get out one or more table screen report reports "out of table"
for each table.
When the fosused cell changes screen reader reports new row/col index.
Screen reader reports cell paragraph content, too.
Added also cypress tests for checking that the table/cell description
string is correct.
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I078b29a2f76f91df479f75db76113c80405f7169
configure currently requires a min of c++17
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I613dac6e66c3e77183d46623346969179bccc489
check this one like we check all the others
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Id8379c6873fe7dd6466dc265cea6847d120aa0ce
map is never null so make it a reference
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I9f6ad863d0a1102dd7e26a5668b1c6ba71249580
To avoid confusion with the WOPI access token.
.
Change-Id: Ie38e0f11d0655e89eb1c7f1e20b73a9b8756ba21
Signed-off-by: Henry Castro <hcastro@collabora.com>
- Graph axis text is too small (10px) better to set it to 1em based on
parent div (16px). Good to also set any group within svg to 1em to
avoid any surprises
- Currently tablets from one card is spilling over to the next card
when there is not enough space. Better to allow scrolling.
- The left pane should be hidden even before reaching the mobile
size. This will fix the lack of space for cards and avoid everything
being so small
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I58c88385875469b56542703663e570ab4d63fbdc
Also tilecombine request now uses the canonicalviewid
Signed-off-by: Paris Oplopoios <paris.oplopoios@collabora.com>
Change-Id: Ib386edcf78de17cb4fc3d8c3c6ce65f6b52c8b5f
