JSdialog popups on Impress would have the keydown events not captured.
The events would be handled by the main document.
Now they will be captured by the correct element.
Signed-off-by: Oli <oli.baker@collabora.com>
Change-Id: I543e25ddbcb1766cc677f7fbc6629e8d04a5b394
Given a well-formed utf-8 string 'message' of messageLen bytes and a
desire to truncate to approximately abbrevLen bytes return the shortest
string greater or equal to abbrevLen that does not split a utf-8
sequence.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ie623d8c1027bb4724485cab5b0bb6d3d1cd3d9ab
they sometimes do, and sometimes not, we can't assume that the last
byte is a newline and can be discarded without truncating message
text.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ie5ea00f927a558b43b2ae38e1cac96c805e93fcc
for a short non-abbreviated message if it ended in a newline which the
more common variant would not.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I4105fb8eb67b3a38aebc745dfb1e79aa99f2d878
the std::string variant uses:
Util::getDelimiterPosition(message.data(), std::min<size_t>(message.size(), maxNonAbbreviatedMsgLen + 1),...
while the more commonly used const char* version has
getFirstLine(message, std::min(length, maxNonAbbreviatedMsgLen)
where getFirstLine is...
return Util::getDelimitedInitialSubstring(message, length,...
and getDelimitedInitialSubstring has
const size_t size = getDelimiterPosition(message, length, delim);
return std::string(message, size);
so the std::string variant's condition is one char longer for the same input
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I5b8c4523844501a43731ff3b4a939b76ebe472c3
perf reported 6.58% of time in collaborative multi user test
on 2023-08-24 was spent in TileDesc::parse and much of that
in std::unordered_map.
There are only 12 arguments in the map we care about here so
we can just used a sorted array, look by name on write, and
read by index.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Iadfc2001e298d8f4d46200c8488f0eb4cd8734c2
this is regression from commit:
f8e53bd851
Assign tab ids while defining tabs.
When opened Format -> Page Style dialog in Writer.
There was "123" label next to the tabs.
Also when switching between widgets using tab key
it was moving focus outside window.
Core is sending id as plain number what is easy to duplicate.
Let's add some unique name.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iebf70c7968f336761baf19442101ac98a948218c
Currently translated at 100.0% (463 of 463 strings)
Translated using Weblate (Catalan)
Currently translated at 100.0% (507 of 507 strings)
Co-authored-by: Joan Montané <jmontane@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/ca/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ca/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: If0102cbee5b03a841a0f981f5a058e81a412bc88
Currently translated at 100.0% (463 of 463 strings)
Translated using Weblate (Basque)
Currently translated at 100.0% (507 of 507 strings)
Co-authored-by: Alexander Gabilondo <alexgabi@openmailbox.org>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/eu/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/eu/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I2fd7abb99512784d6a75e3568f0fcb12c0d11b06
Currently translated at 100.0% (507 of 507 strings)
Translated using Weblate (English (New Zealand))
Currently translated at 100.0% (507 of 507 strings)
Co-authored-by: Rob Pearson <rob.dunedin@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_NZ/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_ZA/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I7fa179ebc9393c8b35e8057f9e3610b5d0ffb9d3
silence various of these in tests and utilities
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I4fcc95b1b5d5c95e5ac40782550f95c08a3467bd
we presumably want the current behaviour so silence with
an appropiate explicit cast
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ibed4cb2cc31b26195e407f25f7f0a2ea7172c67d
The newly added button in 24ac74db4f was
only added to writer
Also add css class
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I630640d94884cb5e50559fbbd8298554deb0a651
which isn't available in the current android toolchain
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I5834adb7c6211c7aad38f5977a7e425d9ca257fd
This way we increase status bar discoverability ( fixes#7098 ) and
group both search functionality in one place in the home tab
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia1fa8fe58903088aad37a560edd033a184d35e0e
A regression in change ID I8551242fc2b987f00c67088caa0ed07ee8526a72
caused the manage changes dialog to continue expanding when new elements
were added, no matter how big it got. This would cause you to be unable
to see all the changes when there were a lot of them because you could
not scroll through the list. This patch fixes the scrolling, without
making the list area very small again.
Change-Id: Ib29fb161522773ea9893b7bc21d06aab19b74c52
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
A box would appear when accessing the accessiblity mode.
This was because of the autocomplete feature.
This patch disables it when using the accessibility mode.
Signed-off-by: Oli <oli.baker@collabora.com>
Change-Id: I461956b591271b2d3513bce7f81d136da6ca37a7
Tab pages now hold responsibility for catching the event.
Events were previously assigned to each individual element.
Responsibility is on each page and not the "toolbar-wrapper" element.
This is to allow functionality to also exist in jsdialogs.
Signed-off-by: Oli <oli.baker@collabora.com>
Change-Id: I57681c3573d9931a79856fb8ed43f119bf019535
This was done to avoid using accelerator keys before a tab is selected.
Signed-off-by: Oli <oli.baker@collabora.com>
Change-Id: I4bc8a8cd8d885491624e8c769bcbab123104189b
There was an issue where on first loading a document and pushing the alt
key to bring up the accessibility mode, the up and down arrow keys would
not move focus up or down in the notebook bar. This only occured on
first loading the document.
Signed-off-by: Oli <oli.baker@collabora.com>
Change-Id: I003b74ecbaae80a6baf33709fa16d47261a1ed2e
Previously when focus was inside the notebook bar you could not change
between having focus inside the tab pages or on the tab buttons. Now the
up and down arrow allows entering and escaping from the tab pages from
the tab buttons.
Resolves#6933
Signed-off-by: Oli <oli.baker@collabora.com>
Change-Id: I1cf696223ff5739e6a48095acbdf3fd778af1ffd
