loleaflet: added test-div for horizontal and vertical scrollbar to get position
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I61f5823c26e1dc0a1ec96257bc58cb51bb29024f
here full test URL mean, first you take the URL from the console, open it in the browser, then take the URL from the URL bar, close the existing session, and open a new one with that URL
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I4b4e59721fb1deec709bc778a8e59a52fb466a3a
Profiling points to updateReplyCount() as the bottleneck where it does
O(N^3) work where N is the number of comments. The innermost loop is
used to find the index of a comment-section in an array using its 'id'.
Turns out that flattening this loop to a < log(N) lookup via a js map
from id -> index pretty much cures the perceived 'slowness'. But we need
to ensure the correctness of the map by updating it whenever
'commentList' is mutated.
Time to load the document with 800 comments (arranged in 50 rows x 16
cols table):
Before the patch: 1min 31 sec
After the patch: 3.5 sec
After-load performance (comment popup/hide/scroll) with this patch is
similar to how it feels in co-6-4 which does not have this issue.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I4c47f14767cac4c7e9744344d24f646dd27302a6
Currently translated at 64.1% (293 of 457 strings)
Translated using Weblate (Hebrew)
Currently translated at 63.8% (292 of 457 strings)
Translated using Weblate (Hebrew)
Currently translated at 100.0% (410 of 410 strings)
Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/he/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/he/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I404d5ea303d832bb1f0566929d4b3a26b0d98ec0
Currently translated at 100.0% (410 of 410 strings)
Translated using Weblate (English (United Kingdom))
Currently translated at 100.0% (410 of 410 strings)
Co-authored-by: Rob Pearson <rob.dunedin@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_GB/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_ZA/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I05959e03230dd188a5f30a9272096528ea073233
Socket.js was failing in doc.connect with permission access in
a local debug build otherwise; possibly a JS init. ordering issue.
Change-Id: Iccb68a43ee300ae85498a3652d1a2f51ade3d115
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
- now we switch to minified mode also depending on document size
(not only window size) so when zoom is used we will also switch.
- no longer needed to use minSize property as comments section doesn't
change it's size
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ie9ac822ec6fcac7722035083653dd4e90f970559
When enabled, the /lool/getMetrics endpoint will not require authentication.
By default authentication is required and this setting is set to "false".
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I801130cf552eb14c231fcc0a0bdd39d9ebb6db7f
When a document is reconnecting, it shows an empty dialog.
Change-Id: I00b8d47b2fee67175d2e2936d93e121b10c38389
Signed-off-by: Henry Castro <hcastro@collabora.com>
Instead of using Page as in `Page properties` use
Slide as in `Slide properties` so it's consistent with the other
labels
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib41a2b00a3bb31a148726496aeafda6ad13befde
Replace all instances of `Page` with `Slide` since we
are talking about presentations and so it's consistent with
all the other elements
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I604b3d3fd8194a22d606149d4e5704f0301b1c46
Many elements are too wide (as a group) which breaks the sidebar
layout:
- Spinfields and their labels (example cm) occupy too much width
- Many other elements are getting some with: max-content rules
from the generic jsdialog.css file which is affecting and also
breaking the sidebar
- Make sure these changes do not affect layout from impress sidebar
as in that case it's not needed
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie6c18e829cbe32319e77ce031521c6ccc7c6a5c9
The resulting Trace Event JSON ends up with tons of such async events
for which the viewer in Edge (i.e. Chromium) just says "Did Not
Finish".
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I29ae233bf16086ffd464567660954ac4c171c7fb
Before, when the color is set to black the border color
that was alright — for any other non-black color — but for black
the grayish border around was causing weird contrast artifacts
Fix by setting different border color for that situation
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia660f559f276bc7e9c335d43e57d51a9b1036472
- Before indicators were positioned in such a way that they would
, rightly so, inside of the main parent (visible on hover status)
but it would unfortunately spill over some of the icons (example:
in the font colour goes above "A")
- Use whit outline so we keep the same positioning but creating that
white separator
- Fix radius: Use round corners for these indicators instead of
a harsh rectangle to denote that this element is not a simple
icon detail or a small btn but instead an indicator
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ibee65b832c8f01a185b0461efa3630cbbcceaf37
Color panels do not used .w2ui-tb-caption and thus
Border-radius rule was having not effect on mobile and
instead of affecting Desktop, namely some of the color picker
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I13efd2b04a7e6abfe773f4931f830124e209d72c
This allows people to perturb the etags for now, and in future the
URL sub-path to make it easier to develop with binaries where the
git hash doens't change.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I6082a71cde5d3a34cca29fa5858feaf6fdb7f4d6
Created trace for adding and editing slides and shapes in Impress. Also re-typing and adding bullet points using large Writer file
Signed-off-by: Nnamani Ezinne Martina <nnamani.ezinne@collabora.com>
Change-Id: I3541295fada230338acb934409c2bcb80730354b
Signed-off-by: Nnamani Ezinne Martina <nnamani.ezinne@collabora.com>
By removing those files that are not needed anymore and
thus avoiding extra useless requests
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I8fcbd8053edd0ee00d388117ccd77094fc4594ed
To make it more clear that if you enable this in an existing build tree,
you'll get an outdated loolwsd binary, which is confusing.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Iaf6e747a9d7ac4262732c3df69bb5012bc7dc352
If network provider is used, on some devices download/upload
operations can cause an exception. Creating a new file is already
covered but better to cover saving back operation too.
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: I90ffa890ed864e730c16c68bc777b1d6371fd0a8
We display the edit button on mobile and offer save-as
to allow editing
Except for PDF
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: Iee4590704bb38880b39d00f6973559f68b96b781
the issue is when there's no change in the document, the modification time is
still being updated. The current approach was using the modified status
message but appearently due to it's sent delayed, it caused the changes
being not saved. We already upload the changes on uno callback result
of uno:Save command if it is sucessfull and it should be enough.
No need to copy back the temp file on after killing the document because
it also saves the file thus it updates the original file before the exit.
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: I2a26a3bc6d55ac0a090c4e4d89e47544c545f8d1
for some reason if the input stream of the temp file becomes 0 byte
we should not try to write it back to the original file
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: Id1d2f623d5c7262c06f2c72dc813a8a81c786bc6
This caused an exception which prevented
the WSDServer member from updating after
a saveas operation that ended up on a
different server (in a load-balanced setup).
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
(cherry picked from commit 2b0180c4104ccf1a3e7da94cfc2d2f35c09d0684)
Change-Id: Ibf8f69d53dc3cb14fa004201660e3997ad5c298e
