The "extends": "eslint:recommended" property in a configuration file enables this rule.
In ECMAScript 5.1, Object.create was added, which enables the creation of objects
with a specified [[Prototype]]. Object.create(null) is a common pattern used to create
objects that will be used as a Map. This can lead to errors when it is assumed that
objects will have properties from Object.prototype. This rule prevents calling some
Object.prototype methods directly from an object.
Additionally, objects can have properties that shadow the builtins on Object.prototype,
potentially causing unintended behavior or denial-of-service security vulnerabilities.
For example, it would be unsafe for a webserver to parse JSON input from a client and
call hasOwnProperty directly on the resulting object, because a malicious client could
send a JSON value like {"hasOwnProperty": 1} and cause the server to crash.
To avoid subtle bugs like this, it's better to always call these methods from Object.prototype.
For example, foo.hasOwnProperty("bar") should be replaced with Object.prototype.hasOwnProperty.call(foo, "bar").
See: https://eslint.org/docs/rules/no-prototype-builtins
Change-Id: Id7723f0f0ed81e074f56955f80eda3d70241294e
Signed-off-by: Ayhan Yalçınsoy <ayhanyalcinsoy@pisilinux.org>
When we are not using the CanvasTileLayer, we still have to have a
different CSS pixel size (ie. default the _corePixelsPerCssPixel to 1).
The rest (update of the check whether we are using the canvas) is just
cosmetics.
Change-Id: Ie0e7002ac776ab6b0a7c550cf28473f41c5c5e77
This reverts commit 4410c51b3879c9291b465dea3a59c2e65e94c361.
Reason: this issue should be fixed in the integration that caused the
problem in the first place.
Change-Id: Id41eb66979e4c08dd3b9fd6499e01b4690526541
Currently translated at 93.7% (392 of 418 strings)
Translated using Weblate (Turkish)
Currently translated at 93.5% (391 of 418 strings)
Co-authored-by: PhD. Ayhan YALÇINSOY <ayhanyalcinsoy@pisilinux.org>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/tr/
Translation: Collabora Online/Help
Change-Id: I597df71437b5925cf23d9a020f9769930fe1c284
Currently translated at 100.0% (355 of 355 strings)
Co-authored-by: J. Lavoie <j.lavoie@net-c.ca>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/fr/
Translation: Collabora Online/UI
Change-Id: I7547653b240e4d1086f7751b243242f70606e5a4
Example: Keyboard Shortcuts dialog was getting an getting
an outline every-time it was being opened
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I2be8ffa7678a71ecd51ea7477e70ba2ea4baac36
We got some new exceptions and also we have a start
screen now.
Change-Id: I22288ede30540437e8b0a5d3ce4c607d42a465bc
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Does not fix https://github.com/CollaboraOnline/online/issues/400, but
is one step on the way there.
Additionally, for the iOS app, the handling of the HYPERLINK message
in -[DocumentViewController userContentController:didReceiveScriptMessage:]
in ios/Mobile/DocumentViewController.mm needs work for the case where
the "url" is just a file name. It needs to turn it into a file: URL,
and then open a pop-up WKWebView (or something) showing that document.
Just passing it on to -[UIApplication openURL:options:completionHandler:]
won't work, as Safari (which would be used to show such a URL)
obviously has no access to a HTML file in the Collabora Office app's
bundle.
Change-Id: Id436f7bd2849f765e24fd5ff9e647119afe0dd64
Signed-off-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 9a50f14bcb9829731c11bd018ce4f8c3f67ecfbd)
See https://github.com/CollaboraOnline/online/issues/403
Change-Id: I59012565ac6376d03872fe6e4cd78a5d14be1319
Signed-off-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 3a4169a9ebebea56bcdc467691913cd767af878b)
Signed-off-by: Tor Lillqvist <tml@collabora.com>
In the read only case, there were few pixels gap; kill it.
Change-Id: I2012bcbfa9cc3c5f3e50bee7621780661e0bd8ef
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
... so the spreadsheet-document has to start at 49 to align.
Change-Id: Ib91726e1c804d178e17ae7ef69d43294a5ddb398
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Apparently the readonly-only case was wrong; let's kill it.
Change-Id: I07366cc7cf9a8d421e7b59d9bc50bbb242e2adb3
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
For example in hex value field in color picker.
Before this patch text was always pasted into document.
Change-Id: Ieb9366a6f71cb247e1592f69700796a06d3f8be9
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Without the guard we received unhandled exception
Change-Id: Ib0e9ee0e1e05169ecfc707dbb85ae39d2fa1e4d7
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
