Commit graph

24044 commits

Author SHA1 Message Date
Darshan-upadhyay1110
c25e8d78cc Reset Top/Bottom values of page margin if view section changes
- we are string previous response values of top/bottom margin
- resone is because we need that values to pass after dragEnd.
- but if we change section foucs from Header to Footer or Text area to Shape then we need to reset that old values with the incoming response
- this patch will do that.
- for `table` we will hide the marker as we do not need that. table already have there marker to resize.

- added some edge cases like if start marker goes beyond end marker
- start and end marker should not cross limit beyond page top/bottom

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>

Change-Id: Iffd3cbf08806666b858d9c3da7ca6362085223dd
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
2024-05-24 08:56:03 +02:00
Darshan-upadhyay1110
c3c7caaf0b Set upper and lower margin after drag in vertical ruler
- Send Upeer and Lower space value for header and footer according to drag
- we need to send both values in core.
- even if we drag either upper or lower we will send values accordingly but both values should be updated

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I4ef3287c5afe6e1eef5aac225d3c06ca9d1fd9e5
2024-05-24 08:56:03 +02:00
Darshan-upadhyay1110
4a13987fdd Add markers to vertical ruler.
- As we do for horizontal ruler we need marker that will change margin of Header and Footer of the document
- current patch will have design where user can see markers in vertical ruler
- you can drag and change potition of marker.

Improvments that still need to do:
- user can drag but it will not change size/margin of header/Footer
- next we will pass info to CORE according to corrdinates we got from drag
- it will update text potition on document

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>

Change-Id: I9663a75d5c84eace784266c76be12abd762434bb
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
2024-05-24 08:56:03 +02:00
Darshan-upadhyay1110
d41d73382d Add pageoffset calculation for vertical ruler
- Before this commit vertical ruler stays only in first page
- if we jum to page 2,3 so and so ruler won't change it's possition
- but i have added some calculation based data we recevice from CORE
- calculation:
    - we need to consider pageoffset for vertical ruler
    - check if cursor moves to other page
    - then add total Height of previous pages.
    - for Ex: if we are at page 3 then ruler.marginInlineStart should additionally have total height ( page1Height + page2Height)
    - this will place ruler to exact possition where we want
- next : add Top and Bottom margin drag
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>

Change-Id: Ie2a2d4e5f0cfd627bcafd81230ad33b7aec280a2
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
2024-05-24 08:56:03 +02:00
Darshan-upadhyay1110
d3d7f48225 Add vertical ruler for writer
- add new LOK callback for vertical & horizontal ruler update

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I3c0e26f22072de4612e128d58ac41b629be82807

Add vertical ruler and implement margin calculation

- Added new vertical ruler file to separate it from horizontal ruler calculation
- For vertical ruler we do not need tab stops so removed it.
- next stpe will be to implement add top and bottom margin by drag

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I8186c874ff59571db7a75ec4c31f81fc655ef301
2024-05-24 08:56:03 +02:00
Michael Meeks
69c6739e47 cool#9145 - KitQueue: re-work _tileQueue to use TileDesc.
This stops a huge amount of parsing, re-parsing and conversion
from strings and back, making our few N^2 loops over the tiles
much more efficient.

Retain queue tests with the same strings via using a helper
to convert back to something expected.

Replace TileDesc::getId() with isPreview().

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: If40fc45f1fb474d37371e4b949da5fdfc594fdc8
2024-05-23 19:50:09 +01:00
Michael Meeks
9eae552049 Split tile requests from the main incoming message stream.
Leave them as strings for now; this should be a pure re-factor.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ibad2bc343afe3fe32ea729623f6b03575c7b0121
2024-05-23 19:50:09 +01:00
Michael Meeks
bdc2041797 Remove un-necessary distinction between pop and get.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I2870a646f1e16cc138978dd84251bec1939aba13
2024-05-23 19:50:09 +01:00
Caolán McNamara
8640baba46 "Invalid tilecombine descriptor" seen without explanation
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I0635ce3897866953aec9fbbee35cd04f896e845a
2024-05-23 17:12:26 +02:00
k-dasari
e3f488a09c Updating error message for node check while building cool for iOS.
Signed-off-by: k-dasari <150323657+k-dasari@users.noreply.github.com>
Change-Id: I91162f59e6ebab2e0e111904a16eb60d65d9382f
2024-05-23 16:51:29 +02:00
Caolán McNamara
cf903242a2 fix resquest -> request in coolwsd.xml comment
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ie804baec41b59fe7418bb7057f8110cd04b64b9a
2024-05-23 14:24:37 +01:00
Darshan-upadhyay1110
9bfc60b8fe Improve color contrast in application canvas
- improved color contrast between text area and edge.
- changed --color-canvas for contrast between text and edge area.
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I8dd8296901da6ee5ce59704f7e27d8c37d29e8b1
2024-05-23 14:14:45 +01:00
Andras Timar
9c15cb6931 docker: use 24.04 repos
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: If21db1acb5b8bb254b5c2e1360b732bba1194cc4
2024-05-23 14:17:39 +02:00
Michael Meeks
030895c754 cool#9120 - use a simple hash to avoid most tile: comparisons.
Parsing a string to a TileDesc and then comparing is inefficient
enough, without doing that in an N^2 loop for the SenderQueue.

Still N^2 - and of dubious value in the world of deltas; but in
almost all cases a simple string + integer compare.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ibe8230679e27b98cfa95567fea700e2f7d5ac09c
2024-05-22 19:58:28 +01:00
Hubert Figuière
7a2bcddeb9 readme: Added blurb about the SDK
Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: I7814643089e83da2e45ff7bc83df73244cf2d1d4
2024-05-22 12:10:05 -04:00
Gökay Şatır
b4bc0a71c4 Problem:
* On Calc, when user starts editing a cell and uses zoom, core side sends "cursorvisible: false" message.
* This hides the cursor.
* We also hide the cursor while user is zooming in / out.
* But the core side zoom doesn't set the opacity back.

This commit fixes the input handler's visibility issue.
But the core side will continue sending the cursorvisibility message.

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ibf679c132f96dc3504de17d00958133bd45244fb
2024-05-22 11:53:17 +03:00
Gökay Şatır
e5256c265d User app.file.textCursor.visible instead of _isCursorVisible.
Duplicate functionality removed.

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Id0bc972d20e6974dc2671696830a55dcb35ade7a
2024-05-22 11:53:17 +03:00
Andras Timar
594b605ab7 Bump version to 24.04.3.1
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: If310d2fd7b7da7d1e62639344717e0344ee592af
2024-05-21 16:41:02 +02:00
Caolán McNamara
b85452b35b multiple "EMPTY" invalidations for different parts dropped as dups
since:

commit 6f49f9398e
Date:   Thu May 9 09:19:44 2024 +0100

    Split outbound callback processing from incoming message queueing.

an out by one adjustment

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ie5c2133dd7239aa62c017306c962c26ea6e526bb
2024-05-21 15:18:37 +01:00
Hubert Figuière
2643992f95 Translated using Weblate (French)
Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: Hubert Figuière <hub@figuiere.net>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/fr/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Icc016591763db192e7b4fc9b01700b02593d2426
2024-05-21 16:13:24 +02:00
Pedro Pinto Silva
8eba634231 Translated using Weblate (Portuguese)
Currently translated at 100.0% (588 of 588 strings)

Translated using Weblate (Portuguese (Brazil))

Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Co-authored-by: Pedro Silva <pedro.silva@collabora.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/pt/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/pt_BR/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I9c45a233e479ea10c9de092265afee238a793b75
2024-05-21 16:13:24 +02:00
Ali
e3cb73d1fc Translated using Weblate (Arabic)
Currently translated at 100.0% (110 of 110 strings)

Translated using Weblate (Arabic)

Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: Ali <alimahwer@yahoo.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-app/ar/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ar/
Translation: Collabora Online/Android app
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I8f8cc2a8f27e50d3a60b6a8ba3f8adc9e8dbd6d9
2024-05-21 16:13:24 +02:00
gallegonovato
89cfe8463e Translated using Weblate (Spanish)
Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: gallegonovato <fran-carro@hotmail.es>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/es/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I0ed063594644f5d26c7ad71d7c3c80365adbb690
2024-05-21 16:13:24 +02:00
Matthaiks
f458df9463 Translated using Weblate (Polish)
Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: Matthaiks <kitynska@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/pl/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I632037308291800d990d37ff689add6d37769f6d
2024-05-21 16:13:24 +02:00
Darshan Upadhyay
3a3518b454 Translated using Weblate (Hindi)
Currently translated at 26.5% (156 of 588 strings)

Translated using Weblate (Hindi)

Currently translated at 20.0% (1 of 5 strings)

Co-authored-by: Darshan Upadhyay <darshan.upadhyay1188@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ios-app/hi/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/hi/
Translation: Collabora Online/UI
Translation: Collabora Online/iOS app
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I5cb618bd36c160658d61cf70cb6f6b51d7be628c
2024-05-21 16:13:24 +02:00
Andras Timar
c9cca42137 Translated using Weblate (Hungarian)
Currently translated at 100.0% (588 of 588 strings)

Translated using Weblate (German)

Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: Andras Timar <andras.timar@collabora.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/de/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/hu/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I4a6fe12f0bda8dc1c3aa2c8761f11b8e7adb0d0e
2024-05-21 16:13:24 +02:00
Lily Logua
e2dba9956a Translated using Weblate (German)
Currently translated at 100.0% (588 of 588 strings)

Co-authored-by: Lily Logua <lily.logua@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/de/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I2a4d903f72fefdd474f5daa824b14a0e9ec8ee5c
2024-05-21 16:13:24 +02:00
Pedro Pinto Silva
0ad09fda60 Impress: fix slide preview animation and color
Replace svgs introduced in 3efbfaeccd
- Animation and smiley svg: Use gray
- Don't use a smiley face, use instead something more semantic such as
a checkmark

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I38e341ae393c59e785adff9207f8111d68c341ef
2024-05-21 15:06:45 +01:00
Gülşah Köse
a73991b7f3 Hide Invert Background button until implementation
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I061901d748641ffbb40f60e2fa03fcc31df2cd7e
2024-05-21 13:44:25 +01:00
Gökay Şatır
85b93bfb9d Fix coordinate calculation error of cell selection area.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I5f130924455cd29018baf6fbc14c1ceffd29cf46
2024-05-21 14:10:13 +03:00
Gülşah Köse
2acc5a94c9 Introduce new formula auto complete feature
When we start to type a formula in a cell eg: =S
We will see the possible function names in a popup.
If we move with "ArrowDown and ArrowUp" and enter, or direcly select a
function with mouse, function name will be automatically inserted into
cell. Then we will see the usage details of the selected function in
another dialog.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Ic06ca0d904770e95bb85ccdf9a73f60b7d5c5eb0
2024-05-21 12:09:20 +01:00
Rashesh Padia
a6cf4eb118 zotero: fix: can't select language or store as option in citation style
- problem: in combobox widget we were always passing the
`_defaultCallback` which will send `dialogevent` to server but in
zotero's case the callback is different
- also fixes some `undefined type` errors

Signed-off-by: Rashesh Padia <rashesh.padia@collabora.com>
Change-Id: I7bd7aff6a1a3a9715123c1335ea83ab13fd7b22a
2024-05-21 16:06:27 +05:30
Rashesh Padia
93e9259aaf css: decrease max-width at which filename is hidden
Signed-off-by: Rashesh Padia <rashesh.padia@collabora.com>
Change-Id: Ibbd2aed0739af6627d982db954487ad98159500e
2024-05-21 12:34:29 +02:00
Caolán McNamara
166f12b545 shutdown AsyncDNS before WebServerPoll shutdown
and start it after WebServerPoll start.

AsyncDNS depends on COOLWSD::getWebServerPoll()
existing.

/lib/x86_64-linux-gnu/libc.so.6
	__GI_abort
		/build/glibc-bkR840/glibc-2.27/stdlib/abort.c:81
/lib/x86_64-linux-gnu/libpthread.so.0
	__restore_rt
		??:?
/lib/x86_64-linux-gnu/libpthread.so.0
	__GI___pthread_mutex_lock
		/build/glibc-bkR840/glibc-2.27/nptl/../nptl/pthread_mutex_lock.c:67
/usr/bin/coolwsd
	ConvertToAddressResolver::dispatchNextLookup()::{lambda(std::string const&, std::string const&)#1}::operator()(std::string const&, std::string const&) const
		??:?
/usr/bin/coolwsd
	net::AsyncDNS::resolveDNS()
		??:?
/lib/x86_64-linux-gnu/libpthread.so.0
	start_thread
		/build/glibc-bkR840/glibc-2.27/nptl/pthread_create.c:463

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I372802b872bc899874404e7317ecd9ecb1d0757a
2024-05-21 12:12:55 +02:00
Gökay Şatır
f480e10d75 Fix cursor visibility issue.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I5ba8a44b51592b52ed9bfc378d4461b8fc7dccd6
2024-05-21 12:45:40 +03:00
Ashod Nakashian
f1001cddcc wsd: remove unused (Is)ViewWithCommentsFileExtension(s)
Change-Id: I25158862746ce6a3e4ee16ff9d661ec96810ce24
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2024-05-21 04:52:12 -04:00
Ashod Nakashian
8acded5b25 wsd: fileserver: better compression failure handling
We now always cache the uncompressed file data even
when compressing fails. If no compressed data exists,
we return the uncompressed version.

Change-Id: I885275dac526f4d47ea74d6badcb609390e7c139
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2024-05-21 04:52:12 -04:00
Ashod Nakashian
8a808591ca wsd: simplify file-server caching
This removes explicit file-reading logic
with the existing utility function that
is more robust and avoid the C++ streaming
abstractions altogether.

Change-Id: I170b8497a4f9185f1b29e632da27a3520ca0347a
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2024-05-21 04:52:12 -04:00
Ashod Nakashian
c153d88c65 wsd: generic readFile
Change-Id: I7b4328785399a2601193d71b5d6f5d1c9f933bfb
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2024-05-21 04:52:12 -04:00
Ashod Nakashian
e292041078 wsd: refactored readFile to take buffer
Change-Id: I31a76e25cff150bcf33d503e6ed9b7fae0e0ed42
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2024-05-21 04:52:12 -04:00
Ashod Nakashian
e4f30f38e3 wsd: FileServer cleanup
Change-Id: I4ebdbee733922be312a7a5b9b59bcb6c6329a06b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2024-05-21 04:52:12 -04:00
Miklos Vajna
a161ee30f4 cool#9072 browser: better error handling when navigator.clipboard.write is advertised but fails
In case an integration doesn't allow clipboard interaction via
<https://sdk.collaboraonline.com/docs/advanced_integration.html#allow-the-clipboard-permission-query>,
we end up in a situation where navigator.clipboard.write is not
undefined, but is broken.

By the time navigator.clipboard.write() fails, it's too late to fall
back to the old copy code, as the security context is already gone.

Fix the problem by improving the failure handling: show the popup to try
again copying, remember that navigator.clipboard.write() failed and
prefetch the text selection, so next time a copy is tried (via the
keyboard), the selection doesn't need re-creating. (Normally the
selection change would trigger the prefetch, so select->copy->copy-again
would still fail.)

Note that paste doesn't have a similar problem, since there we always
try the old paste code first, and only use the new paste code if the old
one fails.

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I12ea4810395970421000d213744d1838213c7a07
2024-05-21 09:47:54 +01:00
Michael Meeks
216b14ee39 Send Content-Length and Connection: close to help browsers.
Possibly the combination of "gzip" and us being unhelpful about
lengths could lead to browser hangs; who can say.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I632dfc46afde3883544292d687bdff023bccc8ac
2024-05-21 10:28:25 +02:00
Caolán McNamara
c3a8683f69 use new startThread
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I4cf56d0b2aae394a3e2c4f40cf64f0de4de9f418
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2024-05-21 09:22:43 +01:00
Pedro Pinto Silva
3760e64c6b Toolbar-down: Fix Search input field and other elements alignment
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib1e1b1247dc42e721921c6bf1b68726cf0c916e5
2024-05-21 08:06:50 +01:00
Pedro Pinto Silva
3a749bf0ff Writer: Accessibility Check: Add missing CSS class
Now that accessibility checker has change its command it's best to add
back in the CSS class that was being added automatically (based on the
uno command) for various reasons:
- Main one: the ".unoSidebarDeck.A11yCheckDeck" is less than ideal
class name (it includes a dot in the middle)
- Integrators might have customizations targeting the previous known
css class

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7685d000a2110872cdbe83323136b7a6be604ca3
2024-05-21 06:38:57 +01:00
Andras Timar
890e5c6d06 Update l10n files for Weblate
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I95c712ad7c923a4dc941252d58f17771079b7544
2024-05-21 07:28:42 +02:00
Software In Interlingua
e94798c02b Translated using Weblate (Interlingua)
Currently translated at 4.5% (1 of 22 strings)

Translated using Weblate (Interlingua)

Currently translated at 15.4% (17 of 110 strings)

Co-authored-by: Software In Interlingua <softinterlingua@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-app/ia/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-lib/ia/
Translation: Collabora Online/Android app
Translation: Collabora Online/Android lib
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I1a7fd795b02c7e1632d239789ba0569a0ec59e52
2024-05-21 07:27:15 +02:00
bittin1ddc447d824349b2
623a228502 Translated using Weblate (Swedish)
Currently translated at 100.0% (587 of 587 strings)

Co-authored-by: bittin1ddc447d824349b2 <bittin@reimu.nl>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/sv/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I21de4133a990885939ae2a145680159f781ca2f1
2024-05-21 07:27:15 +02:00
Ali
a1e5880cd7 Translated using Weblate (Arabic)
Currently translated at 82.8% (396 of 478 strings)

Translated using Weblate (Arabic)

Currently translated at 82.8% (396 of 478 strings)

Translated using Weblate (Arabic)

Currently translated at 100.0% (587 of 587 strings)

Co-authored-by: Ali <alimahwer@yahoo.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/ar/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ar/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I357c4d4b539b0331d074d9d3608f0e63c6269527
2024-05-21 07:27:15 +02:00