Commit graph

10313 commits

Author SHA1 Message Date
Jan Holesovsky
265ff8907f mobile: Loading... as the splash instead of Connecting...
Change-Id: I9e813cf257f0cf9c5b50b183fa1d3b265ba3903f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87922
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-02-04 11:40:41 +01:00
Tamás Zolnai
7dda26507a mobile: Merge these two lists of removable items.
Change-Id: If302035e017663d82f4154078c7d516b63410842
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87773
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-04 11:14:12 +01:00
Tamás Zolnai
c3c12e6fdf mobile: Remove linespacing item from mobile wizard.
In a desktop LO, this item opens a drop down list,
which seems to be not implemented in online yet.

Change-Id: Ia9d82cf9a058a43077043dc128dbbc16f18da83a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87772
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-04 11:14:03 +01:00
Tamás Zolnai
3a1cbc8027 mobile: Remove character spacing item from mobile wizard.
This item triggers the character dialog, which we should
avoid on mobile. In a desktop LO, this item opens a drop
down list, which seems to be not implemented in online yet.

Change-Id: I56a584e6665184c4242cddc4e78ba849a150c711
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87771
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-04 11:13:44 +01:00
mert
4122634c9b Added the chrome debugging enablement into the settings
Change-Id: I24c97018b499517637f460ba663737ca781ee975
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87687
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-02-03 23:07:41 +01:00
Michael Meeks
d7eaf756e8 add class to unotoolbar buttons from parent id.
Necessary to add 'parent' member to parsed JSON structures to
allow walking up the hierarchy easily while building.

Change-Id: I52da1ba415e07bb7fef60a1c667e8c46cb0d640a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87902
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-02-03 22:57:14 +01:00
Tor Lillqvist
d532705a85 tdf#128468: Make dragging the tab stops send a UNO command
Still work in progress. The new UNO command is "MoveTabstop" with two
arguments: Tabstop (the index of the tabsetop) and Amount (in twips,
left (negative) or right).

The intent is that moving a tabstop in core will cause a callback that
will redraw the ruler, like moving a paragraph margin does.

Change-Id: Ic6b8b11811d2a7f6510c505fff421e1796300c70
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87868
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-02-03 14:38:02 +01:00
Jan Holesovsky
60ee81afc2 android: Close the app when we fail to load the document.
After user has chosen to close it, of course.

Change-Id: I82fcabdae5b0f0c96b4a1101a5f55856c8dd2c60
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87800
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-02-03 12:24:50 +01:00
Tamás Zolnai
e7d8c7456f cypress: mobile: Use a bigger mobile screen size.
Change-Id: Ica3598dd2f963b46891114a67c76f0d4da205c11
2020-02-03 06:37:36 +01:00
Tamás Zolnai
7a140da9c9 cypress: Make this desktop test case more stable.
Change-Id: I9aeb6a4c87a2a5a8a0ade320e993ad85ca4c9e82
2020-02-03 05:53:22 +01:00
Tamás Zolnai
1cfc1c59e9 cypress: Check the admin console to make sure the test document is closed.
Change-Id: I485e8596a30c7bb1efae140143627078cde66bca
2020-02-03 05:53:22 +01:00
Tamás Zolnai
40cd54320d cypress: mobile: Add tests for bottom toolbar items.
Change-Id: I35aa6231b3a0a16456ce08f1586687b9e73ef50f
2020-02-03 05:53:13 +01:00
Tamás Zolnai
978213a12d cypress: mobile: Add a small wait time for style applying code.
The sidebar / mobile wizard is rerendered randomly sometimes
which caused this test to fail.

Change-Id: I4d95cb783ca92a81ea2f6fcdc4e87efaa6747e0a
2020-02-03 05:53:06 +01:00
Tamás Zolnai
9b64bd3819 Fix font / highlight color dropdown doesn't work
Regression from:
298f4297c2

Change-Id: Ic0001157b3866cbf3293812573c33d6b4a18a9d6
2020-02-03 03:37:39 +01:00
Tamás Zolnai
8ce8a90a37 cypress: mobile: Add some test about styles.
Change-Id: Ie61f5bd2a5203d501db60fc6f75e878c728d3a96
2020-02-02 12:23:18 +01:00
Tamás Zolnai
17803d5713 cypress: README: Add an example for it.only() usage.
Change-Id: I042b0f1bf05942b98bcd255f7bdf0241cfc3bfdd
2020-02-02 12:23:18 +01:00
Jan Holesovsky
02815066c8 android: Add the liblangtag data to the APK.
Without this, the app crashes with exotic locales.

Change-Id: Ia0e4ffe6e8ed512c2a0402819b84d9563d17b0f6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87786
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2020-02-01 09:31:26 +01:00
Tor Lillqvist
56d310636d tdf#129380: Don't show the "shortcut bar" if a hardware keyboard is used
Change-Id: If1138185e52b7240ff6190ddf3f7af01d2a47115
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87769
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2020-01-31 15:52:27 +01:00
Tamás Zolnai
ad0d6c5742 cypress: Update cypress version.
Change-Id: I3873ae24f30f04fa40f758f19ac77a78b63f5c26
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87770
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-01-31 15:33:05 +01:00
Pranam Lashkari
7519d0cf54 Fix: mobile wizard malfunctioning
The mobile wizard would not perform any actions
if opened when the mobile keyboard is visible

Change-Id: Id8722b551ea6c13f3fe22b78c996e2bb4b2db2f8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87712
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-31 00:02:29 +01:00
Henry Castro
40e92f10dd loleaflet: simplify 'contextmenu' prevent default
The document object has already prevented default actions

Change-Id: I4d60ec0c6915ca266f3e2c24f0958127186ca970
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87752
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2020-01-30 22:01:44 +01:00
Henry Castro
d8245a5a99 loleaflet: mobile: remove unused 'long tap' and 'double tap' files
They are no longer used instead of the Hammer recognizer library

Change-Id: Ied076c5731dcaeca37e1a15b6b637cbb62250b20
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87751
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-01-30 22:01:28 +01:00
Henry Castro
ad2391ae46 loleaflet: mobile: use Hammer recognizer events instead of 'contextmenu'
Unfortunately the emulate 'context menu' conflict with the default
horizontal scroll behavior

Change-Id: I3cd45520a6f1e00460031b78e4963db59bc9ae59
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87750
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2020-01-30 22:01:08 +01:00
Pedro Pinto Silva
96cef62d43 Mobile: MobileWizard: modify bottom button on mobile wizard, set special layout for insert table panel and add icons
Change-Id: If137e015930f3918d230a86b6e2940747389ec5d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87746
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-01-30 16:49:45 +01:00
Tamás Zolnai
1a65e4040f cypress: Check JS errors in all test code.
Change-Id: Ifb33b98b5da61ac69cce91b9985e313863764d5c
2020-01-30 15:24:14 +01:00
Tamás Zolnai
43e09d20bb cypress: mobile: Extract after method to close document properly.
Change-Id: Id88aec59546cf1bdb51630405756a4321ecabd6c
2020-01-30 15:17:39 +01:00
Tamás Zolnai
92f93481dd cypress: mobile: Extract copy to clipboard method.
Change-Id: I1c4a74b7e50a1b8dae503c8fd8af04c9a49a07b6
2020-01-30 15:17:39 +01:00
Tamás Zolnai
8d906e4b1a cypress: mobile: Extract selection method.
Change-Id: I0fb69a9f5acf90ce76951a83b4220ac52e550fb2
2020-01-30 15:17:39 +01:00
Tamás Zolnai
d95f76438e cypress: mobile: Remove accidentally pushed it.only()
Change-Id: Ib6d747de11be654a86580993f4576d7c329423c1
2020-01-30 15:17:39 +01:00
Pranam Lashkari
5b75bed324 Menu items renamed for image linking
This renaming will allow the mobile wizard to be able to find the
svg images/icons corresponding to the uno command

affected context menu/Mobile wizard:
Row header
Column header
Sheet tabs

Change-Id: I94198096085ebe1f482a70d84c8399c34f9e0ea0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87713
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-01-30 12:26:05 +01:00
Jan Holesovsky
85574023a6 Mobile Calc: Remove one more pixel to close a gap.
Change-Id: If182d2284285d683b01d4e8ab97ddb967010c957
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87722
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2020-01-30 10:38:21 +01:00
Miklos Vajna
d142508d95 test: increase timeout of UnitLoadTorture
This now failed under sanitizers due to a timeout. Double the limit;
asan typically causes a 2x slowdown.

Change-Id: I943c6f900371ff4c05c760d3d993829d54264941
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87716
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-30 09:49:52 +01:00
Weblate
e7910852b6 update translations
LibreOffice Online/android-app (Galician)
Currently translated at 100.0% (99 of 99 strings)

Change-Id: Ifbc783477f9ee2dd0866e9c017fb5c4374b3d150

update translations

LibreOffice Online/android-lib (Galician)
Currently translated at 100.0% (6 of 6 strings)

Change-Id: Ia58dbe560eec21addcb1a640b86f58d28900f282

update translations

LibreOffice Online/loleaflet-ui (Galician)
Currently translated at 100.0% (283 of 283 strings)

Change-Id: Ie4c00e58157ba2c6fd39e20e47e8cf11b85a9fdb

update translations

LibreOffice Online/android-app (Galician)
Currently translated at 94.9% (94 of 99 strings)

Change-Id: Ibee8409c7c1897f8e72df599139a2695f971b785

update translations

LibreOffice Online/android-app (Galician)
Currently translated at 93.9% (93 of 99 strings)

Change-Id: I251ac3131f0e013e8a3506f26605ab91ae326c5e

update translations

LibreOffice Online/android-app (Galician)
Currently translated at 91.9% (91 of 99 strings)

Change-Id: If6f9c882136b6ee29c9c542a80badc9cb5e3549d

update translations

LibreOffice Online/android-app (Galician)
Currently translated at 90.9% (90 of 99 strings)

Change-Id: I0d81c91956b44d0129d13b877681ef730c248bcc

update translations

LibreOffice Online/android-app (Galician)
Currently translated at 89.9% (89 of 99 strings)

Change-Id: I623dd0e013f67ec828a8078175561654081ec54e

update translations

LibreOffice Online/android-app (Galician)
Currently translated at 87.9% (87 of 99 strings)

Change-Id: I03cc402dc8b047205cd222b694ae8634043391d5

update translations

LibreOffice Online/android-app (Galician)
Currently translated at 3.0% (3 of 99 strings)

Change-Id: Iaa460f896ba7869f626d18bf7e88d0fdc992cae9

update translations

LibreOffice Online/android-lib (Bavarian)
Currently translated at 66.7% (4 of 6 strings)

Change-Id: I20f64d2240406bb88c9ff42fde1ea2f240dbf066

update translations

LibreOffice Online/android-app (Bavarian)
Currently translated at 8.1% (8 of 99 strings)

Change-Id: I54ef58d0472bcdbd6a2ac24c97c62206e797ee4e

update translations

LibreOffice Online/loleaflet-ui (Ukrainian)
Currently translated at 82.0% (232 of 283 strings)

Change-Id: Iaf130e9cedf6a0e50e1b8425725a537de770405e

update translations

LibreOffice Online/loleaflet-ui (Bavarian)
Currently translated at 2.8% (8 of 283 strings)

Change-Id: I037ec09dfa556b505fa34f80fd593a8921105fa5

update translations

LibreOffice Online/android-app (Icelandic)
Currently translated at 13.1% (13 of 99 strings)

Change-Id: I30e2e8707a602744652f67db5048ce187a40691f

update translations

LibreOffice Online/android-lib (Icelandic)
Currently translated at 100.0% (6 of 6 strings)

Change-Id: I5ef093496cabdd063eab44fc49f52d739c666d39

update translations

LibreOffice Online/loleaflet-ui (Indonesian)
Currently translated at 87.3% (247 of 283 strings)

Change-Id: Ia38dcab175579f9715c26bd23e5d17f777d9824c

update translations

LibreOffice Online/loleaflet-ui (Icelandic)
Currently translated at 82.3% (233 of 283 strings)

Change-Id: I758ad43610c7561e8b4bdabbbe47765f11fff1e4

update translations

LibreOffice Online/loleaflet-ui (Icelandic)
Currently translated at 82.0% (232 of 283 strings)

Change-Id: I5d8dd486f72292fbf9b5d0555e71f4c2bb0e49b9

update translations

LibreOffice Online/loleaflet-ui (Indonesian)
Currently translated at 86.6% (245 of 283 strings)

Change-Id: I52af05de380c47d3b1cb09253b3626969a000efe

update translations

LibreOffice Online/loleaflet-ui (Japanese)
Currently translated at 58.0% (164 of 283 strings)

Change-Id: I49f7d0cdf650eddfc8b7311d00ad418305f9daa5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87580
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-01-29 20:32:14 +01:00
Ashod Nakashian
3268a03f4f leaflet: fix inserting comments
regression from 18b3bfeabc

Change-Id: I2bf9c080ed2f1a9b4c0401ab23e75caf4affad62
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87700
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
2020-01-29 18:40:25 +01:00
Ashod Nakashian
cc9add3208 leaflet: fix input-bar now showing keyboard on mobile
Change-Id: Ib81822cae342d5e8bc394fc84e43ec681ecffb8f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87693
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
2020-01-29 18:36:38 +01:00
Tamás Zolnai
5f7239054f cypress: mobile: Add some more insertion tests.
Change-Id: Ie918fa1c386e25b767340afc9ec2fc61d8038ced
2020-01-29 15:33:44 +01:00
Tamás Zolnai
434f89b10c cypress: mobile: Test applying paragraph properties.
Change-Id: Icee81a71dcbdd7888f77e8cd53d7f0b9234ea94c
2020-01-29 15:33:31 +01:00
Tamás Zolnai
fb892794e7 cypress: mobile: Test formatting mark insertion.
Change-Id: Ib3619e6830f25d7c78e369d714e0c4de6a47244b
2020-01-29 15:33:20 +01:00
Tamás Zolnai
d679f93c03 cypress: mobile: Test field insertion.
Change-Id: Ie7618436c57a30ef4282c042ff04262f55e0b17c
2020-01-29 15:33:08 +01:00
Tamás Zolnai
9adc9e33f4 cypress: mobile: Fix cypress tests after recent focus changes.
By now, we only emulate mobile layout, but we are using
simple mouse events (click, rightclick), not touch events.
Later it might worth to investigate, how to emulate touch
events.

Change-Id: Ib7d032933c50221173bbc749f0653d7d777884b1
2020-01-29 15:29:16 +01:00
Tamás Zolnai
ab0ff320c1 cypress: mobile: Update table insertion test.
The HTML structure was changed.

Change-Id: I0b7ada0933ab6d5b13aa6b7f60fa17a07ac84951
2020-01-29 15:29:03 +01:00
Pedro Pinto Silva
fbc1eb8990 Mobile: Calc: visual cleanup after new changes introduced by 87548, 87549 and 87615
- realign plus icon
- readjust top elements' position
- avoiding changing border from #toolbar-wrapper as this would affect readonly mode

Change-Id: I010aaa7b3bd25bce1fe386854c0a7cd0b9c7331e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87675
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2020-01-29 10:27:57 +01:00
Pranam Lashkari
f41cf7c6ba fix: Row/Column header context menu operates incorrectly
select any row/column now try to open the context menu
by right-clicking row/column header and perform some action
Action will be performed on the originally selected row/column
(same goes with the mobile wizard)

Change-Id: I2d2a7f871b1562d4706e9ea1e4382968a4502583
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87658
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-28 22:53:13 +01:00
mert
0c91e66818 mobilewizard: Fix character properties
This patch fixes non-showing character properties
on calc, also a bit improved the related function
in terms of performance.

Change-Id: Iba3f32ec5322225dd0d34bb56173151c52156564
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87610
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-28 22:38:42 +01:00
mert
227b11488a mobilewizard: remove some problematic items
Under Cell Appearance properties, cellbordertype, borderlinestyle,
borderlinecolor items are removed due to not working properly.

Change-Id: I56fd71355051a0b1dc20f6dc86090e2f35520b3a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87608
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-28 22:36:48 +01:00
Pranam Lashkari
2fb7bc633c Added option in context menu/mobile wizard for "Add row below"
Change-Id: Ib650a4aa5175e73a41dbdb6f203fc36e70c860c7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87642
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2020-01-28 18:50:13 +01:00
Pranam Lashkari
c9ee98d4d3 Added option in context menu/mobile wizard for "Add column after"
Change-Id: I4325fbdb14ef7277441e616f854116b8a3a0e0d8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87651
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2020-01-28 18:49:25 +01:00
Aron Budea
db2ae7432d tdf#130223: Revert "Some menubar folding/unfolding cleanups"
This reverts commit 2f861612e9,
which caused the formula bar to be hidden, and rows to get
misaligned on tablets.

Change-Id: I14826fccb23283e3f7462eee7aeb43fb6d2eaeaa
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87568
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-01-28 18:44:26 +01:00
Ashod Nakashian
7c1153d30a leaflet: double-tap to show keyboard on mobile
On mobile, we now do not show the keyboard by default
when the user taps the cell in Calc or a text-area in Impress.
Instead, the user should double-tap. This is especially useful
when the user selects the cell on first tap, then double-tap to edit.
As for Impress, editing-mode is enabled only by double-clicking,
so showing the keyboard on mobile on single tap is not helpful
as the user can't edit just yet. So it makes sense to show
the keyboard only on double-tap, when the slide is in text
editing mode.

On desktop and for other document the behavior is unchanged.

Change-Id: I4206291f60656391d061387f7bbad1b6e3caf80d
2020-01-28 18:10:14 +01:00
Ashod Nakashian
c3d2b1233e leaflet: remove delayed cursor update and simplify
Change-Id: Ifcc165562d1f7aba611bb578688d9c5203681765
2020-01-28 18:10:14 +01:00