As a build of 4.2 has been approved for release in the App Store, we must bump
this before any new build can be uploaded, even just for TestFlight.
Change-Id: I60de542eaf6d10776ad287c8c9c5d36e0feed70c
- Percentage sometimes appears sometimes it doesn't. Removed percentage from values and instead added as suffix (via css)
- Content width changes. Fixed by setting a default minimum width
Change-Id: I4c2017ceaa98c97f06c7bba4dfe0f3aded9d605c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88608
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: Ia617a105cfc3c371edfe2bfd0072a9e85935cca3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88607
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
With this, the test passes under sanitizers as well.
Change-Id: I777e177d4f171328744cf83386276752d51700cc
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88584
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
And add one more trick: If the keyboard is not supposed to be shown, set
the read-only attribute for the textarea before the focus(), and remove
it again after the blur().
Change-Id: I5ff4d0e093cb70737af205c04951d8dd58a35831
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88587
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
This helps us smoothly follow the cursor, and to adapt to less
space available when eg. the wizard or the keyboard pop up.
Ensure we do the right zoom-to-fit on the first call, interestingly
if we do not do that - we get just a single tile at the top left (que?).
Change-Id: Ib26f9b474caa631028e18e790dd50c058cbaef3b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88577
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
The clipboard population is asynchronous and might come too late.
Was missing the Delete item on Android.
Change-Id: I05515f151c8d730e2aa1cb61eceacd0c3b90c455
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88579
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Really TileLayer.js should have a clean on remove that dis-connects
from drag, resize etc. but it doesn't yet.
Change-Id: Ia2c2268875187a2f1115b7d357fd56ab825bb77f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88578
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
So we can see how stable the cypress tests are. Now other unit
tests under tests folder are failing randomly, so it's hard to
monitor the cypress tests.
Enable one unstable unit test, which was disabled for the same
reason.
Change-Id: Ib1646de1647c9a2bdb769bbb6b92a5794dd7a598
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88559
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Namely "WebView.destroy() called while WebView is still attached to window".
Change-Id: I6963a553ac05af6426ffe3c054bdcff28a725e3b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88571
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
if scrolled too fast tiles could not load until auto scrolling stops
and user had to wait for approx 2 sec and wait for tile to load
follow up for: https://gerrit.libreoffice.org/c/online/+/88072
Change-Id: I09541f5400288398ac7680c6d96e224e2ad6ef66
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88485
Tested-by: Henry Castro <hcastro@collabora.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
Change-Id: I2430f8c3732d42b24abc7d2e9b83d71659260573
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88529
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I894bb25a9198a74bf1fa43d6c958e23878e0a0fb
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88525
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
One tap on a shape does not move the focus on the document
since this commit:
9fcd4d3777
Change-Id: I5d176be7c5dd8296c642c41b8d1e2fcf5945ab27
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88521
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
The context menu items are obtained from core. Add a 'Delete'
entry to the context-menu json data just after 'Paste' only if
the selection is graphic and online is in Mobile mode.
Change-Id: Ie5810038bbca5d8ace01b236508b2dd4d31ca2a7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88510
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Without this, it was possible to return to the previous activity without
a proper cleanup which lead to a crash later when restarting the
activity too quickly.
Change-Id: I1003a8eb0ef271d3499b07ff9f111839f48fefac
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88478
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
This happens when the used hits the back button when asked for
the "save as" file location. Request is still sent but the result
code is not OK, and the intent is null.
Change-Id: Id3c483dc0e1e0114ff8a933072892b1f8b7c29f8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88469
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Uses ACTION_CREATE_DOCUMENT activity for the file selection
dialog. Then calls saveAs to a temp file and copies the content
to the outpuStream for the result URI (necessary because URI may
not be a file).
Change-Id: I6df7db5583e546a53c7cfb8c7ea16281ab861926
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88454
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Single taping and double taping now enter
cell-edit mode and show the keyboard.
And improve graphic selection and adding text.
Change-Id: Ib38aac3165078cf143009d9ace530027bf630432
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88034
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Half of the Jenkins build fails beacuse of this test.
Error message, we've got during run:
uncaught exception of type std::exception (or derived).
- error: cmd=storage kind=loadfailed
Change-Id: I42bb502a5aac96218b4ca772c1d0def398144797
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88443
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
They could hide something important in the presentation :-)
At the same time, I believe it will fix the following crash on older
devices, because we did not have the FullScreenStyle for pre-v28:
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: FATAL EXCEPTION: main
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: Process: com.collabora.libreoffice.snapshot, PID: 30480
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: java.lang.RuntimeException: Unable to start activity ComponentInfo{com.collabora.libreoffice.snapshot/org.libreoffice.androidlib.SlideShowActivity}: java.lang.IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity.
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2821)
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2899)
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: at android.app.ActivityThread.-wrap11(Unknown Source:0)
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1625)
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:106)
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: at android.os.Looper.loop(Looper.java:164)
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: at android.app.ActivityThread.main(ActivityThread.java:6558)
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: at java.lang.reflect.Method.invoke(Native Method)
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:469)
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:826)
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: Caused by: java.lang.IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity.
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: at androidx.appcompat.app.AppCompatDelegateImpl.createSubDecor(AppCompatDelegateImpl.java:555)
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: at androidx.appcompat.app.AppCompatDelegateImpl.ensureSubDecor(AppCompatDelegateImpl.java:518)
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: at androidx.appcompat.app.AppCompatDelegateImpl.setContentView(AppCompatDelegateImpl.java:466)
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: at androidx.appcompat.app.AppCompatActivity.setContentView(AppCompatActivity.java:141)
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: at org.libreoffice.androidlib.SlideShowActivity.onCreate(SlideShowActivity.java:36)
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: at android.app.Activity.performCreate(Activity.java:7256)
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: at android.app.Activity.performCreate(Activity.java:7247)
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1215)
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2774)
02-10 23:11:23.179 10189 30480 30480 E AndroidRuntime: ... 9 more
Change-Id: I756cc99658c24573381b48985835db515b930965
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88430
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
This now failed under sanitizers due to a timeout. Make the new limit 2
minutes, sanitizers require 51 seconds for me (so we did not fit into
the 30 seconds default).
Change-Id: Ib8edb002b50e55b605152be5d50574c396964c25
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88424
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
The patch :
-------------------------------------------------
commit ab64d2e0c3
Author: Dennis Francis <dennis.francis@collabora.com>
Date: Wed Jan 29 13:38:16 2020 +0530
Adjust column-header height with zoom-level too
--------------------------------------------------
introduced adjusting of column header height with zoom level.
But that messes up the positions of headers in the below scenario:
1. First zoom-in or out in mobile mode before enabling edit permissions
2. Then enable edit permissions, and now the header positions are all
messed up.
This happens because the formulabar ui is show only while in edit-mode
and the resize() method is not very robust(it adjusts 'top' style attribute
with height deltas) and does not consider the introduction of formula-bar
div into account when one changes the permission of the sheet from
'readonly' to 'edit' in mobile mode.
So lets not do resize() of the column-header container before entering
edit mode and avoid complications of adjusting for the introduction of
the formula-bar.
Change-Id: Ib03f89ad7a34cbd2a3cbfb65af2a9a016b47c125
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88175
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
This makes the on-screen keyboard behaviour more consistent between
phones and tablets.
One effect is that it now requires a double-tap on a cell in a
spreadsheet document also in the iOS app on iPad to get the on-screen
keyboard.
Change-Id: I0dee87b76a1781d6acde1270322a207958cba045
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88178
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
... because we have no working Draw-equivalent on the online side.
Being able to open Draw files (+PDFs) is fine, just don't let them be edited.
Currently mentions I've seen are:
* shipped untitled.odg,
* (+) New Drawing,
* when pressing the filter icon on the toolbar, there's a Drawings option.
Change-Id: I1936dcee1ad145776ae3b1e0cc1d0a435e3417e2
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88407
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
added momentum to scrolling making scolling feel smoother and easier
Change-Id: If760761580aeea57116673b67787f9f5451ab5e2
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88072
Tested-by: Henry Castro <hcastro@collabora.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
