Commit graph

21479 commits

Author SHA1 Message Date
Pedro Pinto Silva
0e22c2a744 refactor: Toolbar down icons: remove unnecessary !important rule
If we set the initial backgrounds without `!important` then there is
no need to use `!important` for dark-mode (since we are already using
a more specific targe via data-them attribute)

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I600629dfc0485edac6ff725f6278de1501e1c9a7
2023-07-19 16:02:12 +02:00
Rash419
c91655a08f fix: failed to play media when using indirection
regresssion from 3c55baf4e2e36c6df43707a7e469dae3fec2c3b0

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I21831ba076140d49a54a56e9c52f7edfca923ef5
2023-07-19 16:45:49 +05:30
Szymon Kłos
96f4120e4f Adjacent tiles prefetching with delay
While scrolling using scrollbar we tried to prefetch
lots of tiles adjacent to the view.

Introduce timer which will protect us from prefetching
tiles we will not need when scrolling is fast.
We will avoid doing it synchronously on every little step.

_update is called a lot in onMouseMove handler:

_update (CanvasTileLayer.js:6220)
...
panBy (Map.PanAnimation.js:51)
scroll (Scroll.js:11)
ScrollSection.scrollVerticalWithOffset (ScrollSection.ts:657)
ScrollSection.onMouseMove (ScrollSection.ts:776)
CanvasSectionContainer.propagateOnMouseMove (CanvasSectionContainer.ts:1097)
CanvasSectionContainer.onMouseMove (CanvasSectionContainer.ts:1403)

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If785fd0c0cc9076043e348b86a09577ad9fa667d
2023-07-19 16:08:48 +05:30
Ashod Nakashian
a82acb6c6e wsd: trim memory on idling
When all users idle their activities
for at least 10 seconds, we take the
opportunity to trim the memory footprint.

We are careful not to issue a subsequent
trimming too soon. A minimum of 30 seconds
needs to pass to trim again. This should
give a decent balance between performance
and reduced memory footprint.

Change-Id: I1c8b2c4a265c9aa0ac5033762695706ad970f11e
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-07-19 11:40:54 +02:00
Szymon Kłos
52627ab635 Prevent view from jumping on pressing alt key
this.accessibilityInputElement.focus();

line in onDocumentKeyUp in browser/src/dom/NotebookbarAccessibility.js
caused view to jump, in result half of the screen was white when
document was very long and had comment inside

To fix this insert accessibility input at the beginning of the DOM
so browser will not try to scroll anything when it is focused.

this is regression introduced in:
commit 3e40f3fbe4
Add functionality for notebookbar accessibility keys.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I68a1371928a5a3c02be32a3a9eab2ba909bb8ba0
2023-07-18 17:34:08 +02:00
Pedro Pinto Silva
cfece73517 Don't add outline to ShowInfoModal that have no buttons
Large Clipboard  and document idle modals were being set with tabindex
0 allowing for manual user focus plus were being focused dynamically
for each instance:
    - Transfer all that (just once) to showinfomodal instead for the
    cases where we have buttons
        - This in turn sets the things to the parent (dialog itself)
	and not the subcontianer
        - Set tabIndex with negative value so, it only allows focus via
    code
    - This fixes the weird outline (focus) that sometimes would appear
    on sub containers of that dialog instances

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If40192e05c4b0e25e2ce71bc612ab64fc54a29ec
2023-07-18 17:32:10 +02:00
genofire
182d4c2734 fix(helm): chart release
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: Ia51b23e9636ffa381aa1041f13487f4d9b632655
2023-07-18 19:47:44 +05:30
genofire
3cd9758564 fix(helm): update to newer code image
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: Ia6810cebfe99c120f8dfff956b67edc1add35178
2023-07-18 19:47:44 +05:30
genofire
87fa136899 fix(helm): allow no additional labels on servicemonitor
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I4dd6434cb6a1a9d121bccce7f4d80b040cf747c0
2023-07-18 19:47:44 +05:30
genofire
a3f784b531 fix(helm): move README to chart for publish on artifacts
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: Ic7308336c7ea635236514d0eeda89e876b1503ab
2023-07-18 19:47:44 +05:30
genofire
39db1377c4 fix(helm): artifactory image annotations
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: Id98830212e16e3ffc1a07b902d7d371f592623f3
2023-07-18 19:47:44 +05:30
genofire
d44630aaa9 chore(helm): yaml lint
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I8b6401624d23660f3b7fc6f244ce633bd0529c6a
2023-07-18 19:47:44 +05:30
genofire
6a64fdbf0b fix(helm): dynamicConfig broken configmap name in yaml
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I07127c2032cc5c684f037dbc058a9581be762488
2023-07-18 19:47:44 +05:30
genofire
2dda61615a fix(helm): statefulset with servicename from helmrelease (multiple install)
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I6f9a098fbbb11522029709c73bf912b884ee3f26
2023-07-18 19:47:44 +05:30
genofire
b86099ddc1 fix(helm): grafana add tags also on overview.json dashboard (like in ha-allocation)
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I6af734feb5cfc3dd8688a45a94e2fca012fcd312
2023-07-18 19:47:44 +05:30
genofire
bcc8ce7ba5 fix(helm): grafana only upload json files (not maybe screenshots)
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I9771caf619e7fd59c98a8029e08cb3a5c88db4b5
2023-07-18 19:47:44 +05:30
genofire
9c822cac18 chore(helm): use with in hpa (instatt of if and path again)
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I1895aff3a622d126e69b3a16ebfa130e1ce96996
2023-07-18 19:47:44 +05:30
genofire
b04cefa57a chore(helm): move dynamicConfig in extra folder
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I99c9c8b3aecc006b399defce5a605221358e04aa
2023-07-18 19:47:44 +05:30
genofire
33b64c0836 fix(grafana): add options to set annotations to dashboards ConfigMap
Change-Id: d9569af164b649863ec05d7b61a362c1ee876f4d
Signed-off-by: genofire <geno+dev@fireorbit.de>
2023-07-18 19:47:44 +05:30
Szymon Kłos
d696fe57f9 jsdialog: don't block uno commands when snackbar is shown
when any dialog is shown we block executing uno commands
don't count snackbar as a dialog and allow full interaction
of the user when snackbar is shown

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Idb1ec1aff9532ba2f1789157982cb25843df0c31
2023-07-18 16:00:52 +02:00
Darshan-upadhyay1110
fd630d427f Fix Spell checker js Dialog
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Idc0800eaa4ab751601bd34bba6c2e9cfef38de4d
2023-07-18 15:42:35 +02:00
Pedro Pinto Silva
7f2e5df037 Calc: fix document background. It should be white.
With c04c065edc we start to dynamically
set the canvas background. The problem is that for Calc cells do not
have intrinsically a background and thus what we end up to see as the
document background color is actually the canvas color.
	 - Make sure that when we are in presence of calc we set the
	 canvas color (clearColor) with the value coming from
	 documentBackgroundColor
	 - To make it clear: create a new CSS variable to be used as
	 background-document

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4c456e4aeea233609ee58684d967984dd8afd63a
2023-07-18 15:01:25 +02:00
Michael Meeks
b700ea08a8 deltas: further increase Kit delta cache to 96 tiles.
Should help for single user with large screens.
Also dump delta cache sizes on USR1.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Id16a287be6b05cee5681abe1d9d2dc0ec61cda2a
2023-07-18 09:43:34 +02:00
Michael Meeks
226dfe83fb deltas: don't clear useful debugging counters when restoring tiles.
Otherwise when we get under pressure re: canvas' we loose useful
statistics around the number of deltas applied.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I44a089e4af2819007b8f400b506292f8d469ff82
2023-07-18 09:43:34 +02:00
Michael Meeks
ccc3d6277c deltas: fix re-consitution of canvas' from rawDeltas under pressure.
When we need to re-constitute a canvas from the cached compressed
tile.rawDeltas, we could re-enter via var ctx = this._ensureContext(tile);
as we had to populate the canvas with the previous content before
applying our new delta.

Its important to ensure that we don't then try to apply the same
delta (or set of deltas) twice - ie. move the context/re-constitution
before we append the new deltas to the tile.rawDeltas.

Previously showing the same delta applied twice:

Applying a raw keyframe of length 7320
Applied keyframe 0 of total size 264270 at stream offset 0 size 262144
Applied chunk 1 of total size 2126 at stream offset 262144 size 53
Applied chunk 2 of total size 2073 at stream offset 262197 size 2073
Applied chunk 0 of total size 2073 at stream offset 0 size 2073

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ib23bb81e6d3534f140ff3472afed1010c6f98cc2
2023-07-18 09:43:34 +02:00
Michael Meeks
e675dec329 deltas: don't garbage-collect keyframes from visible tiles.
We have no obviously good mechanism for re-fetching them, and
this seems a bit extreme - even if they are otherwise old.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ibaa3d5185493de45efb2887d94b0bf1ee7cac245
2023-07-18 09:43:34 +02:00
Michael Meeks
06619df9ef deltas: handle deltas sent to apply to keyframes we garbage-collected.
In the obscure case: we could have garbage collected the keyframe
content in JS but coolwsd still thinks we have it and now we just
have a delta with nothing to apply it to.

+ show a count in tile debug-mode of this case.
+ re-request a full tile ie. with oldwid=0 if we hit this case.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ide95c54086fcc48d0deed1a090b3b9dd4aa49cd5
2023-07-18 09:43:34 +02:00
Michael Meeks
e3c4fee876 delta: simplify the states a tile can be in when cleaning.
+ don't keep a canvas around if we free its rawDeltas.
+ don't keep imgDataCache around if we freed the canvas.

Change-Id: If3e5be642c9e7560bb889881fa62f25031104658
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-07-18 09:43:34 +02:00
Michael Meeks
cfa831ee68 memory: add dump_malloc_stats helper.
gdb seems to really struggle with versioned symbols & types in glibc.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ic59020c2e5c88fbeb7799d3f5c06752097a5ad40
2023-07-18 09:43:34 +02:00
Michael Meeks
f41a8bed3e deltas: more unit tests for wire-id fun.
This should catch the case where one view should get an empty
update delta, and the other should get a new keyframe tile.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I3ad8f564cc45d80186430b463214ffcf092346f3
2023-07-18 09:43:34 +02:00
Pranam Lashkari
807f309264 calc: blur address bar when tapped on sheet
problem:
regression from 919db16
when address input has focus and keyboard is open,
tapping on sheet would not close keyboard and bring focus back to map
only way to close keyboard and focus map was to accept the input

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I2c6f23be9efcbbe8e4d47d11505074a75abc000f
2023-07-17 13:07:19 +02:00
Michael Meeks
4d9070b1da Remove long obsolete ENABLE_DELTAS conditional.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I7f254328ba1be8074d8f1feabd7b89304166281d
2023-07-17 11:35:25 +02:00
Michael Meeks
5ed7c326c6 deltas: improve torture testing options.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Idcb708d2686c6a1f40a1a832bf8c0940f9890c1c
2023-07-17 11:35:25 +02:00
Michael Meeks
d309d7199a deltas: fold the update: command back into an empty delta: command.
Also: address parts of #6897, primarily:

* remove the problematic aspect of bumping the last wid in our
  TileData, when this could trigger a re-send of a previously
  sent delta, causing tile corruption.
    * instead append an empty wid entry.
    * as an optimization - if the last entry is empty update
      the wid - since re-sending an empty delta is of no
      concern.

* simplify a number of code-paths that special-case zero length
  deltas. All deltas now commence with 'D'.

* still track updates in the JS - by detecting empty deltas.

* shares more code and simplifies various paths.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I02af6d4b152524c201b6985b7a3497da7f08a517
2023-07-17 11:35:25 +02:00
Michael Meeks
85152bf953 Typos: wake-up.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I8ae12c8c8390997bbde7af1e203e9075dfa4ea25
2023-07-17 11:35:25 +02:00
Michael Meeks
b7d7c02a3f deltas: allow JS tilecombine to force sending a keyframe to the client.
However, don't force rendering a keyframe, only sending it - other
clients may be happy with deltas. This is to better handle:

window.app.console.debug('Unusual: Delta sent - but we have no keyframe for ' + key);

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I4efff0f6b1d2817e6b8bd567eb3b098383a1ef42
2023-07-17 11:35:25 +02:00
Michael Meeks
e16f627333 deltas: calm down warning debug around keyframes.
It's fine to be a keyframe and have appended deltas too.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I205e44e0b019b3eec0ce266e9a544b060d0bce4d
2023-07-17 11:35:25 +02:00
Andreas-Kainz
b6c26bee91 Mobile sidebar header layout #6861
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
Change-Id: I8c10857b0ca7e166b5f9364db9ea2a01e5acfffa
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
2023-07-17 10:20:52 +02:00
Andreas-Kainz
81c44946d4 Dark Icons: update toggledarktheme to fit other icon styles
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
Change-Id: Iee02515870d48adc2dcdd2f44ff76fb4c2cf05e7
2023-07-17 10:19:33 +02:00
Andreas-Kainz
4e5159e77c Dark Icon - Help tab icons update
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
Change-Id: I50654f4fc82330e50069761a87e50ada23740ec7
2023-07-17 10:05:18 +02:00
Andreas-Kainz
563ae14953 Dark Icon Update - saved icons
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
Change-Id: I966f44bb79ba0252ca662146f1680984a140bc1c
2023-07-17 10:05:18 +02:00
Rash419
55305d0d28 indirection: use Action_Load_Resp to show error msg
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I682973acfe45b9477bb6df9e8a17adf01e3dda65
2023-07-17 12:18:41 +05:30
Rash419
72570b1ea3 fix: media cannot play with indirection server
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I83d39fa4829938e8f217361fec3fbdab79adbac9
2023-07-17 12:18:41 +05:30
Darshan-upadhyay1110
2369bfc0ac Enter shouldn't be a requirement to trigger a tab or a button
No enter key will not be necessary to change tab by accessibility key

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I9ab9e004e9dc883d18b8f750a9a400e1f318240e
2023-07-16 09:16:02 +02:00
Rash419
8c5d822dc9 android: fix: save failed error while parsing save command
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ia6a53184322f403d2b995213700193d5612fd63d
2023-07-15 20:33:18 +05:30
Rash419
371cb21d5d android: after sdk 30 WRITE_EXTERNAL_STORAGE is not required
- android will not even show a popup
- for some reason after sdk 33 checkSelfPermission returns PackageManager.PERMISSION_DENIED for WRITE_EXTERNAL_STORAGE even if it given permission implicitly by android

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: If50df0df0322d0bddf30d5ff5fb13ab9c010ed87
2023-07-15 20:33:18 +05:30
Darshan-upadhyay1110
ddef0ef881 Fixed Spellcheck dialog size
Set Minimal width for suggestions list
Added some padding for spell check text box for more readability

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I0fa5bb60ece88e4107408448a17378b526020784
2023-07-14 14:32:22 +02:00
Szymon Kłos
6124d3abd1 notebookbar: tab focus cycle inside tab page
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I0daf9a068802470a45cfd203577a2b5f01c7cfc5
2023-07-14 10:32:34 +02:00
Szymon Kłos
a58c802d5b Create util for doing tab focus cycle inside container
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I25b44ebd1954301de4be0a4b4d22286f026a62fe
2023-07-14 10:32:34 +02:00
Pedro Pinto Silva
ee592d97bd Compact view: Add missing InsertObjectStarMath (formula object)
Before this commit this option was only available on tabbed view

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6e027f1b84d09e802f7ea6c6fd9e5144cae2eb91
2023-07-14 09:48:20 +02:00