- It exits LOActivity when lokit thread finishes using lokit_main_mutex.
But if we edit document and exit without saving lokit thread gets
finished but COOLWSD is still running to clean up the docBrokers.
It takes some time to clean up this docBrokers.
We need to exit the LOActivity only after COOLWSD is finished
- for that I have added coolwsdRunningMutex again
- it was removed in ad32888d7c
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ic9785f5aa55deafbac98efc4013bd3376d0ba62d
- to show previews we use slide-sorter element
and presentation-controls-wrapper as container
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Iaed0892779d5016a565d556955305317129edea4
Block only close requests from the user clicking on
'X' button. We need to always process close messages
from the server.
Eg. Format -> Theme, click Add:
then close parent dialog using 'x' -> should not work
then close parent using 'cancel' button -> should exit dialog
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I2164f01acf47a67dc1e35b85b37142bc88dfedc4
Full screen feature is not available on iPhone,
only on iPad with iOS 12+ (https://caniuse.com/fullscreen).
Instead open svg directly in the browser as a fallback.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I047051e420a0d786ec084817b8fe19c34e086cf6
When button is inserted using postmessage API
it can have no command property. Prevent us from
TypeError here.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I84f1f94befb57d0e18699052c881b90de55a1239
newRequest is always called with a const Request& already so might as
well make this copy inside the function rather than passing a copy
by value and moving it.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ib572637d29590b8b470a42da3293065ed86d7dd0
When renaming file in writer use the original extension
to save the file if the user doesn't provide one
Signed-off-by: NickWingate <nick.wingate@collabora.com>
Change-Id: I6b6293bb7bf8ede38a8fa63995ad553d1e45ee1e
iss ctor takes a const std::string& and constructs with a copy of str as content
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I2805c869cb034a9b87e6e95cc58419b54a078b63
Document that authentication changes need double amount of care,
compared to other normal functional changes.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Ib1820581f7175957f08f5e080d542c7441a3ffa2
With the use of a single flag for both, the
logic is now less ambiguous, as we cannot have
termination flagged without also implying
shutting down.
The assertions are no longer needed.
Now that setting the termination flag
explicitly implies having the shut down flag
as well, the checks are simpler. We only
need to check that the shutdown is not set
to continue running as normal, since having
the termination flag must perfoce mean shut
down is also set, there is no need to check
both.
Change-Id: I99e22f5668385182b0594040a8e3354b55e74642
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Replaced id based checks with uno command ones.
Removed unnecessary function from notebookbaraccessibility. We don't use automatic id assignments any more.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I3ad69916dea72d0e7e37430e629d74763c79005c
Use string based approach to avoid errors.
Eg. 36.37 was a problematic value when multiplied by 100.
This fixed indent spinfield in sidebar.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iae25acbf59cedfd20cbcb0677fd87e08d06c3f6d
sometimes svg generation takes more time it seems
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I0e6ad493cb452a9725235f2c01c6792126b8de9c
this was changed in the core:
commit 0a549b2c9595cd076e3b503b67df93bff380885a
svg: export text decoration for text run not paragraph
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I8906ee07c7ff88c9dcdbebe73d2c620e797a8b3a
This reverts commit 8ce751a3ca.
- Any PR coming from fork fails
- User needs to manually go to:
settings > Actions: General > "Workflow permissions" and allow write permissions
- Right now we have too big of a threshold (26 lines) to be as useful as we would hope
Probably best to remove this action for now and instead use directly
the npm package (https://www.npmjs.com/package/jscpd#usage). Advantages:
- More control over what is analyzed
- It can be add as a step in make check
- User can run it locally using make check; CI can also use that.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I3c112218a83fd6e56e7fb2f47b24315347a74cdd
so the autofill handle in hidpi didn't work
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I718d9a8d3954a441705849eba174fe6b5b2983c4
We need to allow loading media sources from
the web-server URL. This seems to be necessary
at least on iOS.
Change-Id: Ic7b23c4f80b975460de9311a67f3c5cb51758d14
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
use the xml token "use-window-font-color" to toggle auto color on.
https: //github.com/CollaboraOnline/online/issues/6546
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ib14b144ce6f593114a8130f5816f479d5cd4fe85
When we get in one or more tables screen reader reports row and column
count.
When we get out one or more table screen report reports "out of table"
for each table.
When the fosused cell changes screen reader reports new row/col index.
Screen reader reports cell paragraph content, too.
Added also cypress tests for checking that the table/cell description
string is correct.
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I078b29a2f76f91df479f75db76113c80405f7169
