Commit graph

14851 commits

Author SHA1 Message Date
Ashod Nakashian
c50af5b94c wsd: better and consistent logging of ShutdownRequestFlag setting
Change-Id: Ic9e41d193b6a6a678170ec5ca30bd80bcee04c80
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-27 08:09:49 -04:00
Ashod Nakashian
358b30a682 wsd: test: fully enable loopback testing of http
Change-Id: Ia54f80bd76b2b7188608dd8df7947139564255dd
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-27 08:09:49 -04:00
Ashod Nakashian
838af866d6 wsd: test: killpoco in TileCacheTests
Change-Id: I7f0212e488fada532377a5922a2c48e064530bb8
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-27 08:09:49 -04:00
Ashod Nakashian
ce7ae3f499 wsd: test: killpoco in TileCacheTests again
Change-Id: Ib7a208d69babf3cb004713bd8715659b266aad3b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-27 08:09:49 -04:00
Ashod Nakashian
04640009f4 wsd: test: move SocketPoll to UnitBase
This is the SocketPoll used by async
WebSocket clients.

Change-Id: I2ec3c0ff9984a6a0c457fd3189a3d7833061147e
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-27 08:09:49 -04:00
Ashod Nakashian
497de388af wsd: test: start the test poll thread only during the test
CppUnit creates a unique instance of the test fixture
for each test, up front. But calls the setUp and
tearDown functions only right before and after
executing a given test. By starting the poll thread
only right before each test, and destroying right
after, we reduce the number of polling threads
and avoid noise in the logs.

Change-Id: Ia089579443ef3a1aa27e79e0bb90a359db0da07b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-27 08:09:49 -04:00
Ashod Nakashian
a7b2f14074 wsd: test: single UnitBase ctor with default name
We always want to have some default name so
we can log something relevant. Having
two constructors isn't very helpful,
especially because we must initialize all
members in only one initialization list
(since we call the default-ctor from the
overloaded one).

Having a single constructor with a default
parameter is one of few cases where default
parameters are justified.

Change-Id: Ia2d390be46ea7ad5486248d7ede7a7c95c4352e3
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-27 08:09:49 -04:00
Ashod Nakashian
bb8069c86b wsd: test: remove superfluous object
Change-Id: I5e1e6becc40dc1634eeef177cd9ad9fe4ee0d006
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-27 08:09:49 -04:00
Ashod Nakashian
5b96d59747 wsd: test: log the testname in the test setup and result
Change-Id: I0e0277afc3956783ad26ca57e6e2604d60f75a66
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-27 08:09:49 -04:00
Ashod Nakashian
eb790c7174 wsd: test: set the test name for old-style tests
Change-Id: Iba77f215faba4235351c93453d39b40bed265cfa
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-27 08:09:49 -04:00
Ashod Nakashian
9742f91527 wsd: log the reason for terminating DocumentBroker
Change-Id: Ieef1d30bd4abc18e27cc057ac2374f730b8992c2
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-27 08:09:49 -04:00
Ashod Nakashian
eeda9adb29 wsd: read can return 0 from the socket
Change-Id: If74a46a8649ee422ed12a2e247d316451fc9cd75
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-27 08:09:49 -04:00
Ashod Nakashian
bc38af30dc wsd: safer asyncShutdown in WebSocketSession
Change-Id: I3108a10be7691ed532301dcd42b659bdeb553473
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-27 08:09:49 -04:00
Ashod Nakashian
0f94eb261c wsd: test: killpoco in UnitCopyPaste
Change-Id: I2657a095e0a9d79b678c826db46b9c69d9aac056
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-27 08:09:49 -04:00
Ashod Nakashian
4f9d029bde wsd: test: killpoco web-sockets in httpwstest
Change-Id: Ic0b577693abb10dca0dcc9df75fa28943daa5cdf
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-04-27 08:09:49 -04:00
Rash419
04bb760497 cypress:added image operation for impress and writer
Signed-off-by: Rash419 <rasheshpadia419@gmail.com>
Change-Id: I3db41c146bcab4ec90ae376909db0f50b4174704
2021-04-27 16:15:27 +05:30
Rash419
8a61603f01 loleaflet:desktop: added delete option in context menu on rightclicking the graphic
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ic552217d03d77f93f5c38107d622d8404c122cd7
2021-04-27 16:15:27 +05:30
Pedro Pinto Silva
4535a65b85 Notebookbar: closebutton: Fix size
it seems close button is bigger than it's parent
- Avoid that
- Remove paddings
- Use background position instead

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I9ff86be375be78fc27dddaf5a8d38d4c41590be9
2021-04-27 11:30:55 +02:00
Pedro Pinto Silva
7e12749e55 Text import (csv imports): add missing icon lc_fromrow
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0a82908c5ec3262fe1b0637389c90461a4a87c2b
2021-04-27 11:30:41 +02:00
Dennis Francis
991a5a14c7 fix: header draws with old size after resize + mousemove
Fix: clear the cached "entry" with old size after a drag has ended.

Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I73840e380dc808c5805588947d774984def288d0
2021-04-27 11:57:24 +05:30
Dennis Francis
46781aa313 avoid flicker of header resize handle on resize
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I5c3373fee44b21e40a3b5da7c554fb30b096a342
2021-04-27 11:57:24 +05:30
Dennis Francis
8f5ac693a7 fix: header resize line not updating on scroll
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: If10d884cb7b24289cb1e4c8e8996f526e6fe4cbe
2021-04-27 11:57:24 +05:30
Dennis Francis
1886c8984f gridsection: fix flicker on typing with freeze-panes
When the request is to paint a specific area and pane, do just that and
avoid painting other panes. The calls to onDrawArea() are specfic to a
pane intersecting with a tile from tile-section painting.

Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I3f74e38fe8a1535e980f8b05ee8d6fdd98cf55f5
2021-04-27 11:56:46 +05:30
Dennis Francis
fc1f0aee1a freezepanes: avoid drawing the same tile multiple times
This can happen when a tile is visible in more than one pane. This was
not a problem before we introduced client side background and grid
rendering but now it is.

Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I8dd448f9d89358a71bafd4cffe431a251076a206
2021-04-27 11:56:46 +05:30
Dennis Francis
10665f70ec let the section container do the draw ordering
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: Ifd1bc9e9a3efbab53ff4616d11c405fcc41449b8
2021-04-27 11:56:46 +05:30
Dennis Francis
2a1f4a4baa fix reference/autofill selection redraw on removal
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I8b6c8dc14093125acbbfc362afb52e0c4c865e2c
2021-04-27 11:56:46 +05:30
Pedro Pinto Silva
85b21d715f Notebookbar: Styles preview: Fix inconsistency, less borders
Had too many different border styles (parent with dashed border,
different colors used in different places, and not making use of
css vars)

- Less decorative css styles
- Decrease distinction between Styles preview and whole notebookbar
  (more at home with the surroundings)
- Use shadows to differentiate states
  - add vendor prefix
	- add border-collapse: separate; for ie

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I77188f414b7d539f8ea6631016b5def8dcf90034
2021-04-27 08:22:46 +02:00
Pedro Pinto Silva
a5757282f5 Fix RGB within CSS vars
CSS Var with RGB value goes inside of of `rgb()` and not the other
way around

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I1401309c00d91160e757f4fdca0b00ea74763911
2021-04-27 08:21:56 +02:00
merttumer
68697eba55 Fix Rotation moves the center away on calc
For calc, gridoffset must be taken into account
when calculating the center point of the shape
otherwise the coordinates will not match with
core

Signed-off-by: merttumer <mert.tumer@collabora.com>
Change-Id: Ie1003d52f233a79e5b1640c2cf7a095a7315a749
2021-04-26 20:26:18 -07:00
merttumer
6b3149b022 Fix glitches of shape handlers on show/hide
Wrong positioning etc.

Signed-off-by: merttumer <mert.tumer@collabora.com>
Change-Id: Ie636b4d056faf0cb5204a1a8cda7a98d7ea2e681
2021-04-26 20:19:20 -07:00
merttumer
e609d27a67 android: Request ODF conversion for text files on Android
Also now txt files can be opened and edited.

Signed-off-by: merttumer <mert.tumer@collabora.com>
Change-Id: Id7b57c219a2e8eaa46153cd3ae4b91dcb9352eab
2021-04-26 20:19:02 -07:00
andreas kainz
4023a118c3 Notebookbar Draw Tab update #2007
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I5018bfcf5925ce5026a3d4069cb4bb096921742c
2021-04-27 00:49:52 +02:00
Szymon Kłos
5c6b214725 Show menu with download options in readonly on tablets
When notebookbar is activated but user is in readonly mode
show the simple menubar with download and view options
instead of empty bar on the top

Change-Id: I49ac7f8d7d8691761a15fd767f278e23ea228b50
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-26 18:05:07 +02:00
andreas kainz
23dc1b2aaf Fix insert line and shape icon #2152
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I327dc32c22ee156a967fea3c6012d6bd0b677482
2021-04-26 17:43:41 +02:00
Szymon Kłos
308eb1375d formulabar: send resizewindow only if size changed
On every sidebar refresh the onResize from Map is called
triggering showCalcInputBar. resizewindow message should be
sent only if sidebar changed the size.

Change-Id: I8b5cd9412e886ef7573a8283c7ee79be63c915b4
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-26 17:14:56 +02:00
Szymon Kłos
b50bb64bf7 formulabar: avoid setting width to 0
This prevents us from invisible formulabar on app load

Change-Id: If002208c3704d05c139c75a6dadf2572caeef90b
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-26 17:14:56 +02:00
andreas kainz
b1865b2b59 Colibre icon theme update to correct colors and forms
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ie2dbf0c41760b5f3ec0b94cbd342c3a6dda513d5
2021-04-26 16:26:09 +02:00
Miklos Vajna
a5566baa03 Add version of std::atoi() that needs no extra allocation
std::atoi() assumes a null-terminated string and our strings are not
always null-terminated. So add a version that takes a length parameter,
this way we don't have to copy strings around.

Also switch to this in http::StatusLine::parse().

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I449b356c1b9948c562434618596e8e3b38656088
2021-04-26 16:22:27 +02:00
andreas kainz
8a7278f94b Colibre Icons update insertgraphic #2151
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I065c1f73e53364a0facf7b251631df986698ef89
2021-04-26 15:49:53 +02:00
Jan Holesovsky
3463c2ecad Revert "fix #1285 remove elipsis ... from NB strings"
This reverts commit a41ab8ff35.

Change-Id: I320ef28b2a9672059f1b10ac3f6ba135861cac8f
Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2021-04-26 18:33:06 +05:30
andreas kainz
961b771ecb Notebookbar writer calc remove grow-shrink subgroup
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I0a4ac6ce73856d7f322e9cbf8fa52b7ad4aa81f4
2021-04-26 08:18:03 +02:00
andreas kainz
e6c233769e Notebookbar impress - draw home tab update
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ifccb641a45d985d46c8938d5e0c495ce9a396d2b
2021-04-26 08:15:57 +02:00
andreas kainz
926686b87c Notebookbar Calc sync tab arrangement wit writer/impress
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Iac79dde47846584509637551018fa2eb5630620f
2021-04-25 23:46:01 +02:00
andreas kainz
34b8dee385 update colibre filter icons
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I573ec838432b861e9648fdc169e8ba9e5dba28b2
2021-04-25 08:19:32 +02:00
andreas kainz
4d356ad99c Update Colibre icons
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I3cb2da96c096b69fd1b945398b31c180f3ed6845
2021-04-25 08:18:50 +02:00
Andreas_K
902442d4e7 Notebookbar Writer/Impress Table Contextual Tab update
- Property get the first item
- ParaRightToLeft was removed, already in Home Tab
- Rearranged of NumberFormatDecimal items

Signed-off-by: Andreas_K <andreas_k@abwesend.de>
Change-Id: I78969e46ba94f300d26ab2f6413657a65b537832
2021-04-25 01:50:20 +02:00
Andreas_K
584e139bbd Notebookbar Calc Sheet and Data Tab update #2007
Update the structure of the Insert Notebookbar Tab for all apps.

### general sections:
1. as there are not that much commands and it's very difficult to arrange them into 3 item groups, all commans are bigtoolitems

### Calc Insert Tab
Define and Manage commands moved from Data Sheet to Insert Sheet, section Hyperlink
- Now the group is similar to LibreOffice Insert Tab

### Calc Sheet Tab
Group/UnGroup Hide/Show Details moved to Data Tab
- Now the group is similar to LibreOffice Data Tab
- Commands are at the Menubar also in Data Section

### Calc Data Tab
- Pivot Table + Refresh/Delete Section was removed cause it's already in Insert Tab and Data Tab has a lot of content, so no need for duplicated content at the very left area
- Sort section has the same layout than all other sections
- Autofilter section layout is similar to all other sections
- Group section was moved from sheet tab and as Remove Outline is an command for Group, it was added
- Recalculate, Validity and Goal Seek get into one section. Recalculate and Validity area already into one section in the menubar.
Finaly the Data Tab has a similar command layout with bigtoolitem and toolitems.

Signed-off-by: Andreas_K <andreas_k@abwesend.de>
2021-04-25 00:47:58 +02:00
Andreas_K
d267e7cccb fix
it was late, but therefore there are tests good for

Signed-off-by: Andreas_K <andreas_k@abwesend.de>
2021-04-24 09:41:29 +02:00
Andreas_K
04ddf179be Notebookbar Format Tab update #2007
Update the structure of the Insert Notebookbar Tab for all apps.

### general sections:
1. as there are not that much commands and it's very difficult to arrange them into 3 item groups, all commans are bigtoolitems

### writer:
- writer use the most format commands
- start with tiny and get bigger
- character, paragrapn, page, line / area / position
- as Lists and Bullets and Numbering are related to Paragraph they are next to Paragraph
- As Columns and Sections are related to pages or part of a page, the commands are related to Page Style

### calc
- Character, Format
- Paragraph
- Page
- Cell and Conditionals (calc related only)
- Line / Area / Position

### Impress
- Character
- Paragraph with Bullets
- Page
- Line / Area / Position

Signed-off-by: Andreas_K <andreas_k@abwesend.de>
2021-04-24 09:41:29 +02:00
Andreas_K
17d49e1a31 Notebookbar Writer Reference Tab update #2007
Update the structure of the Writer Reference Notebookbar Tab

Use the JSON Layout from #2007

### Writer:
- Move Bibliography Entry to Cross-Reference / Bookmark section
- Remove commands that are not available
2021-04-24 01:17:33 +02:00