Commit graph

20315 commits

Author SHA1 Message Date
Pedro Pinto Silva
c5b95042b6 GitHub project know has its own workflows bultin
Remove custom actions

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia7f2d776d370310834fd29d38ef25a2566d7d054
2023-04-13 09:54:01 +02:00
Pedro Pinto Silva
58bb4b9380 Sidebar: Remove browser's style padding that comes with <button>
Before this commit buttons were being generated with padding
this is not needed ( we already have safe margins applied to
the parent -> 'unotoolbutton' )

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4f1b4328131550d906cde3328c7de02daffd76a1
2023-04-13 09:18:52 +02:00
Pedro Pinto Silva
00375b61e6 Fix button ration
Before this commit we were setting buttons in places such as
the sidebar with weird ratio (not 1:1) this might lead to problems
when aligning, adjusting gaps. Better to adjust gap or margin if we
need bigger spaces in between

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id60cd6353de2ace2a066c0d1624000a09f0ca98e
2023-04-13 09:18:52 +02:00
Michael Meeks
5a2127003f disable fragile TileCacheTests::testTileBeingRenderedHandling.
Fails intermittently under load, responsible for most unit-tile
failures.

Change-Id: I88de8524b51ee7d97a28e31c001534a506d52f0e
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-04-12 18:01:40 +01:00
Jaume Pujantell
518acd1127 Disable Change Password button for users who don't own the document
Signed-off-by: Jaume Pujantell <jaume.pujantell@collabora.com>
Change-Id: I2e1fc1e5b6e50cd7ec5ad9d78db36e76ce6426c9
2023-04-12 14:33:07 +02:00
Gökay Şatır
2c0df92a2b Update shortcuts for accessibility.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I26cfae75d65fc2588225b22b752a34571d5abc34
2023-04-11 16:43:35 +02:00
Pedro Pinto Silva
557c336d0d Set missing dimensions to sidebar button images
- re-use btn-size variable
- make it clear that this set of rules is intended to sidebar elements
  - Improve selector (more clear and so it doesn't target other
    elements outside of the sidebar)
  - Move it to jssidebar.css file

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib03c412a1e05fd6ed315f58a70486f14eaf5b9ea
2023-04-11 16:13:01 +02:00
Gökay Şatır
f2637b02a9 Open dropdown menu of a content control when space or enter is pressed.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: If1670f9f2153a4578057cb4b5c7073879f08ea8b
2023-04-11 16:21:14 +03:00
Gökay Şatır
3659b47afa Loop focus on the dialogue regardless of the dialogue type.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I9d74adbd8df235d762d5cdd0133c26bbbae7b549
2023-04-11 16:21:14 +03:00
Gökay Şatır
b3cb61bbd4 Avoid duplicate ids.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ia90a0178796ec18e6a167c378a6de294dfb96b32
2023-04-11 14:05:52 +02:00
Ashod Nakashian
3dbfce54d3 wsd: helper to dump the state of an object as a string
Change-Id: Ib49a47be2dc37663ef06ac80be981c9f3c029814
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-04-11 08:03:01 -04:00
Ashod Nakashian
335843f527 wsd: remove unused DocumentBroker::getDeferredLock
Change-Id: I0660b8074227408cb2f9a4009d3de15aac2c11ef
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-04-11 08:03:01 -04:00
Ashod Nakashian
f41ba11bad wsd: test: socket context logging
Change-Id: Ib3675985cf0e2d8864ed544d5e7c615d5fde2331
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-04-11 08:03:01 -04:00
Ashod Nakashian
a24a07b301 wsd: new Stopwatch utility
Similar code is scattered in the code. This
should help clean them up and make usage
easier.

Change-Id: I02f82c9aa169f591c5688c4b2adca257eecf8221
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-04-11 08:03:01 -04:00
Ashod Nakashian
bca82f50ee wsd: better logging of the current socket being handled
Change-Id: Ieca96a685f5cfea24fde7251806746408e0bfbf8
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-04-11 08:03:01 -04:00
Ashod Nakashian
e960e52636 wsd: remove unused Force flag from enums
Change-Id: I752842f56ab4520a624848b6be2724775189ea51
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-04-11 08:03:01 -04:00
Ashod Nakashian
8b2d230c64 wsd: logging and cosmetics
Change-Id: I2c7a2c22e073bebf66d542d5e81b1496b8057319
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-04-11 08:03:01 -04:00
Ashod Nakashian
158e1a125f wsd: avoid using the default port for unit-tests
Change-Id: I4d8681491b0aeedbc349c7644551f51052adf63d
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-04-11 08:03:01 -04:00
Pedro Pinto Silva
8d49e0cff5 CSS refactor: Fix duplicated & outdate px across light/dark modes
Do not place px in light or dark mode css instead use the shared
cool.css :root for that
- This avoid outdated values in the future
  - There was already one like that: --annotation-input-size
  had different values between light and dark mode

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I5cd95a36e160003101f6f92108bb5244bfafcdd4
2023-04-11 13:01:54 +02:00
Pedro Pinto Silva
70a5ec53aa CSS Refactoring: one btn-size to rule them all
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iedac492e206e15a1aad65e07dc8cdc3d95a4a488
2023-04-11 13:01:54 +02:00
Pedro Pinto Silva
c1e02d4a2b Expose Translate option to mobile if feature is enabled
Before this commit was impossible to use the translate button
on mobile phone

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia93e1bf009723f3f7791b63f0b15a74467595ab7
2023-04-11 11:03:38 +02:00
Gökay Şatır
c6fef0d233 Use htmlFor attribute for labels.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I64b8fd378abdedf0e97bcb3075da13799460f01b
2023-04-11 09:06:48 +02:00
Michael Meeks
05ae0ab631 TileCacheTests: re-copy documents when repeating tests.
Attempted blind fix for intermittent failure:

[ kitbroker_004 ] TRC  Document::GlobalCallback LOK_CALLBACK_ERROR
[{ "classification": "error", "cmd": "load", "kind": "io", "code": 770, "message": ""}].
filter/source/config/cache/typedetection.cxx:452: caught exception while querying type of ...
"Could not open stream for <file:///tmp/.../disconnectMultiView_5f47c785_setclientpart.ods>
at filter/source/config/cache/typedetection.cxx:1123"

[ coolwsd ] TST  disconnectMultiView-1  [loadDocAndGetSession] (+22012ms):
ERROR: Assertion failure: Failed to load the document
cool/file%3A%2F%2F%2Ftmp%2FdisconnectMultiView_5f47c785_setclientpart.ods/ws.
Condition: isLoaded| helpers.hpp:531

Change-Id: I91062bf4c136dbd6a4cf6def842ff2ae7687c758
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-04-10 19:46:07 +01:00
Pedro Pinto Silva
52fdec0014 Remove unnecessary flex and sizes for notebookbar-shortcuts-bar
Since we have change the generated HTML and now we have proper buttons
and img inside of them, there is not need to resort to this methods
since the img will automatically be centered aligned within its button

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I944f5c677c6d79f2f28645e4e8d081868f094262
2023-04-10 13:09:47 +02:00
Pedro Pinto Silva
bd03ab04eb Fix notebookbar button sizes and shortcuts bar
After accessibility work we need to change how we target those
and also we need to revert that `height: 100%` and replaced with
24px so we can know for sure how much th element will occupy
and to safeguard for cases when the svg is bigger

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia4102ccc5c58d4807d8b05d360342c1ea7128c3b
2023-04-10 13:09:47 +02:00
Gökay Şatır
5c7c7f24f6 Provide a way to focus on the menu from map.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Id5b99bc43cf908940c55af5b5f004513b5cdd05c
2023-04-09 10:49:37 +03:00
Gökay Şatır
0f41b9cd1d Set focus to last element after a popup window is closed.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I99251c1f35b23a5b1a41bbe1820efcf090353db4
2023-04-07 22:22:00 +03:00
Gökay Şatır
54b9040909 Emphasize underlines for access keys when alt key is down.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Idcbca41fbc998b468eb807f35dcd4deff928fe8e
2023-04-07 19:10:51 +03:00
Gökay Şatır
58d417d152 Activate access keys for tabs and popup windows.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Idfa377bb8afed7afb811f33462c471a1261a32cc
2023-04-07 19:10:51 +03:00
Gökay Şatır
04019a0953 Update cypress tests.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I3d5735bec2162e359c012355781ca70de309ff9b
2023-04-07 17:57:24 +03:00
Gökay Şatır
8cb0c44e1f Update cypress test according to latest changes.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I226abb663edbb15384233a5c2461c1e8f3a36455
2023-04-07 17:57:24 +03:00
Gökay Şatır
be04111173 Turn div elements which has button role into buttons.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I60cebd1b02fdc9dc9e5f8a9b57d40b279b085a99
2023-04-07 17:57:24 +03:00
Szymon Kłos
57ff9a3334 Revert of "a11y: TextInput: switch from <textarea> to content editable <div>"
This reverts commit 1d2607e836.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I6de00182cee32b37c6ced957431c3c21f2734c24
2023-04-07 12:09:53 +02:00
Pedro Pinto Silva
44a945d817 jsdialog: center radiobuttons without using exact units
This is a follow up on f9ad2ea3c3
with Change-Id: I1c200f2208b4f762d01dc6dd85459dbedce7b03e . It
leverages the flex added there to align and justify items.
What it fixes: Radio buttons not being aligned from the "left"
side and behaving slightly different in terms of alignment
if anything else changes around

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I9cb6f24c16603f40acf797c6b68d4305f38cdc58
2023-04-07 11:03:56 +02:00
Szymon Kłos
6f4a3b7206 jsdialog: auto align images
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Idda9b32c0056f637dfb0a304ec26c7db74b09d95
2023-04-07 11:03:56 +02:00
Szymon Kłos
c04be7e069 jsdialog: gap in grid
to make some space between elements in grid

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I5379a1a7fd96cb1fe351cb5b52ce1433eaa7eb53
2023-04-07 11:03:56 +02:00
Szymon Kłos
e7aef3ae03 jsdialog: spinfields and listboxes equal width
they will be aligned to the grid size so look more unified

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I4900e7d4005d172226c23919505702f6926260b7
2023-04-07 11:03:56 +02:00
Michael Meeks
29d7937a46 proxy: get the length right for messages with content outside ASCII.
Interestingly, we've been sending the wrong length, resulting in

[ docbroker_003 ] ERR  #-1: Missing final newline| wsd/ProxyProtocol.cpp:158

type errors, as we read that back in coolwsd.

Change-Id: Iff7d1d38b0ed3e99c1d6903e2663c4335a36aaa3
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-04-06 11:40:18 +02:00
Andras Timar
b0ff00961b handle Uncaught TypeError: Cannot read properties of null
sheets[i].href can be null. Seen with proxy.php.

Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I3d774ace869d141973a92abab8ef9ac83e1e0018
2023-04-05 20:57:16 +02:00
Pedro Pinto Silva
a009c43ee9 Remove unnecessary !important from ui-tab
Target .ui-tab instead of .ui-tab-content

.ui-tab-content doesn't exist anymore, we can safely remove it
from CSS

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I17df0fb9de73ffe8665291d9dded8715bed9963c
2023-04-05 16:12:21 +02:00
Pedro Pinto Silva
37f9453634 Tabs: Don't create button inside of a button when one element suffices
- Don't create empty parent button just to have a another button
inside
- Update CSS so the text rules are applied to the button's text

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7f3a54a131a7a44109789a6612af8047963d8e7b
2023-04-05 16:12:21 +02:00
Szymon Kłos
797a58b523 jsdialog: check if widget exist before use
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I84690e1adbf4d4cf226511a3cc60927c9b37b223
2023-04-04 11:52:14 +02:00
Szymon Kłos
30f86f327a jsdialog: use aria-labelledby attribute
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I91b796b4c803787b2b7b93c3c8761e2809f9a414
2023-04-04 10:45:19 +02:00
Szymon Kłos
30d7543072 jsdialog: use correct property htmlFor in frames
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ib4486ddc979ab791699a89d8114f5b01672f0a1d
2023-04-04 10:45:19 +02:00
Szymon Kłos
e46bdcb1df jsdialog: don't hide non-scrollable content
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ifb5c0dc05683ccf3c34ccf376347299571838902
2023-04-04 10:45:19 +02:00
Szymon Kłos
4e534a71d2 jsdialog: use labelFor property for labels
also convert p elements into labels

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I1c24f14671edf8d5e63c21a8b769c29af22737ae
2023-04-04 10:45:19 +02:00
Szymon Kłos
54844e7acf jsdialog: don't show ... in tool buttons
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I830d340db2b88d635feaab6ed16a923f46230fd2
2023-04-04 10:25:58 +02:00
Szymon Kłos
7eda463577 notebookbar: simplify toggle dark mode
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I858e13461a8083baca5851fac24d7cac155badb5
2023-04-04 10:25:58 +02:00
Szymon Kłos
17ecc99d8d notebookbar: simplify show resolved annotations
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I19b34947ec8dc7695119c9d4cb55ef2ba2678c88
2023-04-04 10:25:58 +02:00
Szymon Kłos
ec3cb9f017 jsdialog: prevent drawingarea from blocking tab key
previously when using tab key we focused drawingarea
it wasn't possible to focus other widgets

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Icf23905dfbf04ff46cf8766212a645b962fba98e
2023-04-04 10:12:20 +02:00