Commit graph

18761 commits

Author SHA1 Message Date
Andras Timar
cf6e22c22c Fix typos in comments
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I813f652b516c79f350b46317e589b91e0ef39a1a
2022-08-23 18:37:44 +02:00
Szymon Kłos
cba04c9570 jsdialog: allow boolean as treeview entry state
after core commit:
https://cgit.freedesktop.org/libreoffice/core/commit/?h=distro/collabora/co-22.05&id=62d5622540c7251bb870a837b5ca6a836fac6f01
DumpAsPropertyTree: use more efficient overloads of JsonWriter::put

we use boolean not string

this also enables test broken by that core commit

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I029463ecf100f31ed567af2c7434b87dbfb84265
2022-08-23 18:10:04 +02:00
Miklos Vajna
3205899a31 libfuzzer: fix clientsession_fuzzer
The fuzzer case doesn't read the configuration. This is similar to
what getConfigValue() already did, now extended to
getConfigValueNonZero().

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I14a838ea9875d81413f22140eeac627520c423ab
2022-08-23 10:50:50 +02:00
Rash419
0dff307695 cypress: temporarily disable autofilter test
problem: when we click on checkbox to filter the data in autofilter dialog the checkbox itself disappear
if that is expected behaviour then cypress test needs to modified if not bug needs to be fixed first before
enabling this test

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I4dbfcf8abebe1c65e27c8c090bfce3ed0c59d086
2022-08-23 13:13:52 +05:30
Pedro Pinto Silva
962cc850d4 Don't add hover states to generated jsdialogbuilder td elements
- This is too generic
- If in the beginning this made sense now we have to many elements
and many should not have hover states (invisible, labels etc)

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ice27ccb41cff73fa34b89453d99e3bb1fbc03edf
2022-08-22 09:30:37 +02:00
Pedro Pinto Silva
184488b953 Remove jump in impress anim sidebar when adding the first anim
Force placeholder to inherit the same rules as ui-treeview-body

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I61ecde9e35812026683c655f6a2f9ead18e10d02
2022-08-22 06:35:32 +02:00
Mike Kaganski
fa19a32b41 Draw separators in IconView
Depends on core commit 5b6fd1bcdb417e73307885f92c31464fe326ec9e

Signed-off-by: Mike Kaganski <mike.kaganski@collabora.com>
Change-Id: I6093df157dd14bd6035dd7135d95810a8ba64227
2022-08-21 10:51:23 +03:00
Mike Kaganski
a8c7382ae6 Use explicitly defined tooltips in IconView
Depends on core commits 0b92cf674cd44bdd2c2cdf8a5d597d4407e34002
and acf2a2f17942c21b5aca4691c738902a3dd9aa6c.

Signed-off-by: Mike Kaganski <mike.kaganski@collabora.com>
Change-Id: I981e1bb0ca76ccc27bfc96a9a0c9dae8991c1a1f
2022-08-21 10:51:23 +03:00
Mike Kaganski
77facf941c Honor "singleclickactivate" in IconView
Depends on core commit 6aa61dc78640113060889ffe69464ef2e8aab5c4

Signed-off-by: Mike Kaganski <mike.kaganski@collabora.com>
Change-Id: I416c2a73e314ac63189ad60eb8541306902fa8d0
2022-08-21 10:51:23 +03:00
Szymon Kłos
d6ad36a1fd jsdialog: don't create duplicated container for tabcontrol
to avoid duplicated id and focus issues

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Id9791d92838b65b235cf901af8e4c5464133dfd2
2022-08-19 06:59:23 +02:00
Pedro Pinto Silva
1e3d3243f2 Fix jsdialog title background and re-use CSS var
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I393ec7865c8df4123a6fc7f5ac566d02a3ce534f
2022-08-19 06:59:23 +02:00
Pedro Pinto Silva
5896d80ba5 Increase jsdialog tab btn text contrast
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I1a6ac35593c945b832c92af275b759e8be0b8225
2022-08-19 06:59:23 +02:00
Pedro Pinto Silva
f42c7a0297 Increase jsdialog tab btn contrast
And make sure first tab get extra padding when selected so to keep
some need space for the edge and to respect same alignment

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I96d8a1d5540336632fe75acb8eeef25bd5c4819f
2022-08-19 06:59:23 +02:00
Pedro Pinto Silva
5538f10560 Remove gray block bellow JSDialog tabs
It seems we have inline-block within inline-flex when we could
just have regular block inside of flex

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia242c36ced9908aa07ef09580d3c812f36d437e2
2022-08-19 06:59:23 +02:00
Skyler Grey
fdc8ef970d Adjust scroll test coordinates
- The test contains coordinate ranges for where the scrollbar must be
- As PR #5131 moves the scrollbars, we need to adjust these coordinates
  so the test passes

Signed-off-by: Skyler Grey <skyler3665@gmail.com>
Change-Id: I6d037a304cc86553c47e81acbc63643742db2f66
2022-08-18 11:25:27 +02:00
Skyler Grey
c75dc751af Let the scrollbar go to the top of the railway
- Previously the scrollbar was limited so that it couldn't go right to
  the top, this commit removes that limit

Signed-off-by: Skyler Grey <skyler3665@gmail.com>
Change-Id: I7fec85ba013a924ca8880c54fc214dfa32387dd1
2022-08-18 11:25:27 +02:00
Pedro Pinto Silva
6e79ab2402 Decrease scrollbar thickness while retaining clickable area
Better to use a thiner scrollbar as default state.
If needed, increasing it on mouseover could be a worth follow-up

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ifb5a5f50c5d81140e5c6523061941b56e9a0b169
2022-08-18 11:25:27 +02:00
Pedro Pinto Silva
743d596124 Use darker color for scrollbarrailway
This affects greatly spreadsheet (in the other doctypes we use opacity
for that railway so, it's less evident)

Better to use a color other than white on calc for railway. Otherwise,
the document's content seems being abruptly cutoff into to white space.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I3ed0cf0be9a0228c7862c191d8d9f09c9c8b1f25
2022-08-18 11:25:27 +02:00
Skyler Grey
5d25ce9a1d Stop the scrollbar railways overflowing bounds
- Previously the scrollbar railways started at the start of the drawable
  section, this made them draw over other elements such as the
  spreadsheet numbering in calc
- Offsetting the scrollbar railway and reducing its width lets us avoid
  drawing over anything we shouldn't

Signed-off-by: Skyler Grey <skyler3665@gmail.com>
Change-Id: I8f670c5f6c76fa849ea657b1ceb065f1a91dd087
2022-08-18 11:25:27 +02:00
Skyler Grey
d9f1425f7f Fix scrollbar color
- Before the opacity for one of the scrollbars was being overwritten
  before the scrollbar was drawn. That is now fixed

Signed-off-by: Skyler Grey <skyler3665@gmail.com>
Change-Id: I0aa648c60f59bcc8a997a9176b0075831043c297
2022-08-18 11:25:27 +02:00
Skyler Grey
e50a1ed47f Stop the scrollbar being offset from the edge
- This looks better with the new scrollbar railway, as for example on
  calc this stops the spreadsheet displaying beyond the scrollbars

Signed-off-by: Skyler Grey <skyler3665@gmail.com>
Change-Id: Ic99d0f173ba4a2480cd4dc1acb04797dafd1bdcf
2022-08-18 11:25:27 +02:00
Skyler Grey
340896da97 Make the scrollbar railway more transparent
- The scrollbar railway should only have 50% opacity unless we're using
  a spreadsheet, in which case it should stay at the default 100%

Signed-off-by: Skyler Grey <skyler3665@gmail.com>
Change-Id: Ia2a22bc13fa8b4f7dd9fb7d86ef81fb39b89f32c
2022-08-18 11:25:27 +02:00
Skyler Grey
f0068feeca Improve the horizontal scrollbar
- Draw the railway for the horizontal scrollbar

Signed-off-by: Skyler Grey <skyler3665@gmail.com>
Change-Id: I64a8a612f7164e30c4cc086634a3b0ae43aeab1f
2022-08-18 11:25:27 +02:00
Skyler Grey
4bc5a01887 Improve the vertical scrollbar
- Draw the railway for the vertical scrollbar

Signed-off-by: Skyler Grey <skyler3665@gmail.com>
Change-Id: I57975e52700f3b91782f9be40ad9864fc8c3baf2
2022-08-18 11:25:27 +02:00
Szymon Kłos
9664627cab Revert "cypress: skip file properties for now"
Now it is merged on core side.
This reverts commit 4e3b34d6dd.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ie8f7e8f3e8d269af186e0a3d82aed73f63577789
2022-08-18 08:36:20 +02:00
Szymon Kłos
8b10055a48 comment bubbles: don't use undefined container on comment remove
- Show error instead of throwing an TypeError exception.
- Prevent us from showing empty popup when removed comment.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I55adfde01514de559eb3aeedd8c5af2bf88a2ab1
2022-08-18 08:36:01 +02:00
Ashod Nakashian
e31d4023e7 wsd: log unmount errors only when mounting is enabled
When bind-mounting is disabled, we do a best-effort
to unmount any lingering mount-points. This is a
cleanup that helps with leftovers. Here, we
do a debug log level in case the unmounting fails,
and error, otherwise, when bind-mounting is enabled.

Change-Id: I199d6234aebfd84e6be812e5b7d3758273086815
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-08-17 21:27:30 +02:00
Ashod Nakashian
7ae1c9152a wsd: test: print failed assertion code
Change-Id: Iceeafd3e399da7a20f06d8ad6d4e5adffd989d93
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-08-17 08:55:12 -04:00
Ashod Nakashian
ca60752515 wsd: test: print correct binary name on failure
Change-Id: I93ebe0c0e39928717e1b53becc010a334ce7bf09
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-08-17 08:55:12 -04:00
Ashod Nakashian
81399bff64 fuzzers: fixup HttpEcho
This improves the performance of fuzzing
and removes the checks that can't be guaranteed.

And fixes a test failure.

Change-Id: I987fe15b098c00d9a3d60077f0581d2ef35e306c
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-08-17 08:55:12 -04:00
Ashod Nakashian
82a5c3173d wsd: fuzzer: fix build
Change-Id: Ib52e32de04e7af230ed21eed11e0855050e97c74
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-08-17 08:55:12 -04:00
Ashod Nakashian
9419b7ef0d make: minimize fuzzer dependency duplication
Change-Id: I6ff335ab6e4ddeb950cd03ddb08a793790327579
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-08-17 08:55:12 -04:00
Ashod Nakashian
41ea9d4930 fuzzers: add httpecho fuzzer script
Change-Id: Iab296461ac47d0ee23c23bf3629f7a08f77e238a
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-08-17 08:55:12 -04:00
Ashod Nakashian
94a884ad0f fuzzers: add http corpus and dictionary
Change-Id: I1a59fd31cc8ddfd90a7e9d4d62455310e410cb88
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-08-17 08:55:12 -04:00
Ashod Nakashian
6fa5be7ecb fuzzers: more aggressive http::Response fuzzing
Change-Id: I5b714bddd6edc90ef0c8efdad42d5f78f3d74886
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-08-17 08:55:12 -04:00
Ashod Nakashian
eca9b0bb4e wsd: http: check for timeout in sync requests
This should cap the loop either when we timeout
or when termination is flagged.

Change-Id: I78a6b05df99d6bac5286e4b1e4957829ea91c500
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-08-17 08:55:12 -04:00
Ashod Nakashian
a87d1ae54f wsd: add HttpEcho fuzzer
This is a full round-trip http fuzzer.
It can achieve >1000 iterations per second
on a single 2 Ghz core, even while going
through the network loopback layer.
The advantage is that more networking code
is fuzzed this way, including not just
the http code, but also the sockets.

Change-Id: I75d21bd0e25221ee6621097a2605d62c4bb2ae4d
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-08-17 08:55:12 -04:00
Miklos Vajna
c9cb1f4e01 wsd: fix uninitialized DocumentBroker::_savingTimeout
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Id004b635cfd8e77de85f932a3035870300ba1c47
2022-08-17 13:30:07 +02:00
Pedro Pinto Silva
cbf5f1ad71 NB: Convert group_download_as to bigmenutoolitem
- Avoid using random UNO command (InsertGraphic) for download action
- Centralize download option (re-use bigmenubartoolitem)

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie9cb8564acee8611221e0ff6f841de7b31b777e4
2022-08-17 13:22:06 +02:00
Pedro Pinto Silva
e55812033d Remove sidebar's hardcoded :hover states for unotoolbutton parents
These should not be targeted
- ids can change (e.g. FormatPaintbrush2 ,etc)
- Also unotoolbutton is already inheriting :hover rules

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7149cebfd52b4049a27bd3989fc88d254440df6d
2022-08-17 10:21:26 +02:00
Pedro Pinto Silva
f3c7b59265 Fix sidebar's clear direct formatting hover state
No need to specifically mention unotoolbutton's parent and apply :hover
, unotoolbutton is already been targeted

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iaa92d50f35f63dea4d10cd0906d9dadb700c25f1
2022-08-17 10:21:26 +02:00
Szymon Kłos
9dea7201b2 jsdialog: unify clear formatting icon
There is no reason for custom handler.
Thanks to that we don't need special css.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I9b576d4a6ef5668ec281c4e1348335d3b93bbac0
2022-08-17 10:21:26 +02:00
Szymon Kłos
4e3b34d6dd cypress: skip file properties for now
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I1be203229599912e3099f9a3e904e0562479ed3d
2022-08-16 16:04:22 +02:00
Szymon Kłos
2abff9a572 jsdialog: grid is a special container
don't create wrapper parent for it so we don't duplicate ids

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I2e90744bc23141ff153331a7f5bffe634f93e6f1
2022-08-16 16:04:22 +02:00
NickWingate
a70415fe7b cypress: add tests for file properties
- test document description
- write test for custom properties
    - text, duration, yes/no types
    - disabled until core implements custom props

Signed-off-by: NickWingate <nick.wingate@collabora.com>
Change-Id: If0205b90d899772ac8f7f98d4eda2cbc23117d0f
2022-08-16 16:04:22 +02:00
NickWingate
23f6a66c8c Fix incorrect tab being selected
Previous implementation depended on internal IDs of tab
pages which caused problems when IDs were non-sequential.

New implemention uses the index of each tab page in the
locally stored contentDivs to change tabs.

Signed-off-by: NickWingate <nick.wingate@collabora.com>
Change-Id: I3117698e27ca5f4c90fcbc59ce0c3fe35b351be4
2022-08-16 16:04:22 +02:00
NickWingate
ed2a5ce833 Fix empty grid bug
Signed-off-by: NickWingate <nick.wingate@collabora.com>
Change-Id: I0f0882df4c44f05de67e07881237db212591cf33
2022-08-16 16:04:22 +02:00
NickWingate
d3c730f9f9 Expose file properties dialog
Signed-off-by: NickWingate <nick.wingate@collabora.com>
Change-Id: I33e5bccf63fea5352c559b868d6842ea3873333b
2022-08-16 16:04:22 +02:00
Bayram Çiçek
336f7c1664 Add outline to color indicator for classic mode
- In classic mode, toolbar color indicators weren't visible when no
  text is selected. The reason is that color indicators didn't have
  border(outline) color.
- In fact, color indicators were just a box-shadow property. So,
  it was not possible(?) to add properties like border and
  border-radius.
- No need to use box-shadow property. A <div> tag can represent
  color indicators.
- Removed box-shadow property.
- Added <div> tag that has class="selected-color-classic".
- Added UI specifications for mobile. (#toolbar-down)

Signed-off-by: Bayram Çiçek <bayram.cicek@libreoffice.org>
Change-Id: I1b1b68fdc015fd3719d1c59ef7f782036a5934a5
2022-08-16 15:49:49 +02:00
Pedro Pinto Silva
23715f72cd Mobile: fix missing icon on hamburger menu top level
Follow up on the changes introduced in
4e07514

Make sure the explorable list runs iconURLAliases first before
insert image url

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I9295fad934f000acdd27cac64b0c70284c0bbd2f
2022-08-12 19:04:12 +02:00