When tests are run in parallel, they will all
compete to update and set up the systemplate
directory, which has a handful of files that
need to be up-to-date. This is a source of errors.
Normally, these files are linked (hard- or soft-
link, whichever succeeds). With linking, we
only need to worry about the initial setup,
as the files will never be out-of-date from
then on. However, when linking fails, we need
to copy the files, and update them (by copying
over fresh versions of the files, if necessary)
every time a new kit is forked. Copying over
is tricky, as it's not atomic. To make it
atomic, we copy the files to the destination
directory under a temporary (random) name,
and then rename to the final name (which is
atomic, including replacing the target file,
if it exists).
No such race exists in production, where there
is (or should be) but one instance of loolwsd
(which does the initial setup) and forkit
(which updates systemplate before forking
new kit instances).
This is an issue with parallel tests only.
Change-Id: I6ba1514d00a84da7397d28efeb6378619711d52f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97785
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Since we are manually changing the CSS class names when
orientation changes, this is only valid for main custom scrollbar
because the mobile wizard scrollbar is always in portrait mode.
Change-Id: I0b9e7156dac0e33a6e793c7f6caae2021068f252
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97900
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
The preview thumbnail in mobile wizard are not visible yet,
so assume the map container rectangle bounds to properly
calculate the aspect ratio of the image
Change-Id: Iacc387b92e326965c86fb60d1acfde5b49365ad3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97899
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
We are manually changing the orientation CSS class name for
preview thumbnails, so it requires to destroy and create again
the custom scroll with the new axis to show a vertical or
horizontal scroll bar
Change-Id: Ib341025da66db05f6feddbbb32a286da107cd8df
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97898
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
This prevents an assertion failure when you quickly open the same
document again after closing it.
Change-Id: I26b8c53d57bd1d33f0473a3c5a332ec02c37455d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98263
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
The unit test checks the aspect ratio of the preview thumbnails,
this happens when the document size changes (i.e changing paper format)
Change-Id: I0267e797327b73d714947258e004fe64cce9d1dd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97775
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
When copy is disabled don't put stub message about
download button in the clipboard.
Allow internal copy & paste when copy is disabled
- so disable only external interaction.
Change-Id: Ie7864abc8a239aa068880545cf09a48155ebbaea
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98237
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
In some browsers with strange settings localStorage is
not available.
Change-Id: If9e5ebeb9701cc0a2b19c5946bcbc23f76a8c577
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98238
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
the cell-area selection. Improbable, but can happen in a cypress test.
Change-Id: I112ef88d11818c6e0abc91a8de37c329666dcdbc
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98216
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
See commit: "Replay print-twips messages for a couple of reasons..."
for context on replay.
Change-Id: I8a834fef08685d0ee713f64abed1696e56987241
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98158
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
All graphic-selection messages from core are in print-twips if
sc_print_twips_msgs is set in SAL_LOK_OPTIONS. So do all the necessary
conversions on intercepting the message.
In addition, in this mode the core expects the parameters of the command
'.uno:TransformDialog' to be in print-twips. This is also done in this
patch.
Change-Id: Ief8a0d4677f83f26b135ce47b68c27bff5aaf5c9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98157
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
own: invalidatecursor, textselectionstart, textselectionend
view: invalidateviewcursor
See commit: "Replay print-twips messages for a couple of reasons..."
for context on replay.
Change-Id: I7d7cfd62202ac46b3410ad3e08bc04f0e2cdab00
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98156
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
and reuse this to parse all rectangles in text-selection (own/view) message.
Change-Id: Ic6946b2f10d9f642232d540b5974d53edbb774d7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98153
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
Print twips coordinates for chart/draw edit-cursor is not there yet in
core (needs more work).
Change-Id: If8cd9431fa43351340c74e989ee837f4b1b859dd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98152
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
until we have a better solution. It messes up the positioning of headers
w.r.t the map at certain zooms.
Change-Id: I32422a5f5076f83631f28a90db6a543e830ccf0e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98150
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
and reuse them where we need to parse points/rectangles strings from
core and avoid writing the same parsing code everywhere.
Change-Id: I029ba97eaa1062eef404eeb8f35d1c6897315d80
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98149
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
like we have for L.Point.
Change-Id: Ic7d1bf7d41f8d3e2cec2dab05ba0742342840775
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98147
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
when zooming close to bottom/right of a sheet. The bug is due to the
view centering logic on zoom without the knowledge of sheet area
hard-limits and is present in online master without the calc-coordinates
cleanup work.
Change-Id: Ic3b9f2873c4a22365a87a08a2ff89d8584a16581
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98145
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
The new utility is safer and more readable.
Change-Id: I3a86675378d458cb004e5534dbf2b401936d0e57
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98183
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Since this file is only created manually,
it shouldn't be removed automatically.
Change-Id: I8d26b7bfc7f7cd899318b2edd3e5ef9bd462cc99
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98184
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Instead, set brandProductName from the MOBILEAPPNAME. Now the mobile
app name shows up in the progress bar.
This reverts commit 24a0c7c3dc.
Change-Id: I91c7ea3d21f5362fc6a4d777b041089413e921ee
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98205
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Newly jails folder is cleaned up after a run.
Change-Id: Ia4f3eb26f61c5f14304e9ae6a3d5b5f60a0ee592
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98204
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
If L.CalcTileLayer.options.printTwipsMsgsEnabled is set, we will not get
some messages (with coordinates) from core when zoom changes because
print-twips coordinates are zoom-invariant. So we need to remember the
last version of each of them and replay, when zoom is changed. We also
need to replay the messages, when sheet-geometry changes. This is
because it is possible for the updated print-twips messages to arrive
before the sheet-geometry update message arrives.
Change-Id: Icd77ad77c7642aae24e68fb0b7f229c7ec62484a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98114
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
