Commit graph

322 commits

Author SHA1 Message Date
Tamás Zolnai
d96ca09ced cypress: update version 4.3.0 -> 4.5.0
Change-Id: I87432005dc9c9cb264c0cae260e5adad84e4ef14
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94665
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-22 14:58:29 +02:00
Tamás Zolnai
af3691ea51 cypress: this test is failing lately.
Change-Id: Iddadf16895947b2a236e2075118ba822f74eeecb
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94666
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-22 14:11:01 +02:00
Tamás Zolnai
e180fff4b2 cypress: add some basic tests for insertion wizard in impress.
Change-Id: Ia391337aab70f3c6208358d1695f4649edfca7eb
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94638
Tested-by: Jenkins
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-22 14:02:23 +02:00
Henry Castro
6e230e4ba6 cypress: enable logging browser side
This time the logs come from the browser

Change-Id: If9b66a140b0174d0e3ef1e1e492ceeb49953d563
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94468
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-05-21 19:53:43 +02:00
Henry Castro
5acffe2af9 cypress: remove logging UNO command states
This is no longer usable when running interactive unit test

Change-Id: I0e44dca7d6c0ec513da08a0d4521ef9d15b27a94
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94430
Tested-by: Jenkins
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-05-21 16:49:48 +02:00
Tamás Zolnai
20ae90f748 cypress: fix closing method of bottom toolbar test (calc)
Change-Id: Ie241720312f58d2be0c3c5f1f4a154246ed84bfd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94597
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-20 21:42:17 +02:00
Tamás Zolnai
09dec12811 cypress: improve the output in case of error.
Mention also the command for the interactive test runner.

Change-Id: Ia013ea589229542d571d9a587ec85ae05ed6b4da
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94590
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-20 21:41:54 +02:00
Tamás Zolnai
f1296cdf19 cypress: extract selectFirstRow() method (calc)
Change-Id: I1e7c9769249169986f411a7d5139ff6b0e9f751c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94572
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-20 15:07:22 +02:00
Tamás Zolnai
5de4f98424 cypress: deduplicate clickOnFirstCell() method.
Change-Id: I359d2f5a12ae83e598e1d61dfd2c4b943ef31f0e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94568
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-20 15:07:14 +02:00
Tamás Zolnai
194bc60bb6 Revert "cypress: this test seems to be stable now."
This reverts commit d07db7d74d.

Change-Id: I6d220701082fedcfbc0e00f5c6e0f0092bb4032b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94458
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-20 00:28:35 +02:00
Tamás Zolnai
129d89a9f4 cypress: add tests for bottom toolbar in calc.
Change-Id: I033800eadf5d3b1a454e31549b5adc1fd5d5ebd6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94532
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-19 21:10:02 +02:00
Tamás Zolnai
f43b7e01bf cypress: remove some false comments.
Change-Id: Ibdd0a27c78feeffe09b0b3fdd91ac2d0a444178b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94531
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-19 21:09:18 +02:00
Tamás Zolnai
d07db7d74d cypress: this test seems to be stable now.
Change-Id: Iaa2799bfa489fd04acc4d42452915bde0c9f6528
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94530
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-19 21:09:03 +02:00
Tamás Zolnai
336184e1e4 cypress: this is unstable.
Change-Id: I7cc737278120df8f4d7a8a27770a4929b5d48660
2020-05-19 13:03:05 +02:00
Tamás Zolnai
dd5ce7df94 cypress: make zooming more stable in form field tests.
Change-Id: Ie897b256f13f06e7fc66bd0fac25376b849e5429
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94421
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-18 18:42:14 +02:00
Tamás Zolnai
18325d8889 MSForms: make list items's font size relative to the button size.
Change-Id: I05149e704ca248584ba190f2e637e69082ca33fa
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94420
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-18 18:41:48 +02:00
Tamás Zolnai
43d1567b9d MSForms: stop listening on zoom events after button is removed.
Change-Id: I96e484b5fa7309b7d1a6f0a3ec4269f21bb93496
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94410
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-18 18:41:37 +02:00
Tamás Zolnai
f1262f7b31 cypress: this is unstable.
Change-Id: Ifb492aa60594a98f7274e09682e3042797431ce8
2020-05-18 14:15:26 +02:00
Tamás Zolnai
82f96b40f8 cypress: add zooming test for form fields.
Make sure the text cursor is inside the form field
button's frame.

Change-Id: Ib8a6fe50c14d01b5d3864f04e9668b9b1844b50e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94408
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-18 12:45:05 +02:00
Tamás Zolnai
29b08b31d7 Revert "cypress: enable some more tests."
This reverts commit 53e887d193.

Change-Id: I184e9e44975596e3b05a7beb45a16e79ea22f282
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94280
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-18 10:36:36 +02:00
Tamás Zolnai
53e887d193 cypress: enable some more tests.
Change-Id: I9e6e03e8fb082cfbb942b5af9a33e5b0a0037770
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94311
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-15 16:13:15 +02:00
Tamás Zolnai
262e9f9475 cypress: simplify clickFormulaBar() method.
It's always called without arguments.

Change-Id: I3f825b23c4e8b0079019dc916a8357ba94cda4f1
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94289
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-15 15:27:58 +02:00
Tamás Zolnai
2598417df7 cypress: reenable checkboxes related tests.
This reverts commit e07a94abc1.

Change-Id: I9b1cd05f8ad6acc065c941cd17d886ead75f12be
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94290
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-15 15:27:47 +02:00
Tamás Zolnai
ef2304b8e0 cypress: reenable fixed test cases.
Change-Id: I5820c8ea314b1c9292e69bab3c147fe2e9e77945
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94252
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-15 11:05:01 +02:00
Tamás Zolnai
e07a94abc1 cypress: it seems checkboxes on mobile wizard does not work anymore.
Change-Id: I08f8ba69e37b0c396d0a995d633bcf58de7096f5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94238
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-14 18:04:55 +02:00
Henry Castro
42f8336757 cypress: enable skipped unit test for "writer/shape_properties_spec.js"
Enable unit test related to Spin button controls changes

Change-Id: Ib2f0098d5d0b9f8b6eae28a4cce8680c6378e623
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94124
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-05-13 17:44:22 +02:00
Henry Castro
580f06a21e cypress: logging the command state changes
So when unit test fails, we can inspect the response
from server some UNO command states

Change-Id: Ic652918a8e57cadfd1cd58a89d7a1c9905abcfc9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94081
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-05-13 17:24:38 +02:00
Henry Castro
e6f5917812 cypress: fix error running single unit test
builddir != srcdir

Change-Id: I2521c3e11f05f0c91bf0e8f5667a5466493acac0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94080
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-05-13 16:51:29 +02:00
Tamás Zolnai
f7bf4d5cdd MSForms: display placeholder text, when there is no items.
Change-Id: I8acd29d734820f6ddc36871c7777fefd2956c213
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93962
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-11 20:14:13 +02:00
Tamás Zolnai
84f46074f9 cypress: start Xvfb with screen argument.
It fixes an error during cypress verify:
https://github.com/cypress-io/cypress/issues/6184

Change-Id: I993bf6cda5f8018d394ee6ee506f99d07b1e6e56
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93793
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-10 12:45:28 +02:00
Tamás Zolnai
50d4451c21 cypress: catch also "Command failed:" as an error.
Change-Id: Ie5649886eabf3994ba003dc9e7b9b28790c1a58b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93925
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-10 12:15:46 +02:00
Tamás Zolnai
76c4d79ffb cypress: add tests for form field button.
Change-Id: Ie297d9f10edebd857af2e2c4f9f09acd5c1519d8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93770
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-10 01:47:26 +02:00
Tamás Zolnai
e0a82365f3 cypress: fix shape operations test.
Change-Id: Ibdca536bc8fb2a5b16d6ed085a65c25d1bc854b4
2020-05-09 09:54:09 +02:00
Tamás Zolnai
619ae03f36 cypress: formula bar editing is working again.
Change-Id: I8131ed29f5617d2debe9200111e88e42f9969096
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93555
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-06 10:58:06 +02:00
Tamás Zolnai
d03aa27ea7 cypress: formula bar editing is now broken on mobile.
Change-Id: I6fe1ec312ef9f25dd4b6a92edb9151ccc6b12d2a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93487
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-05 16:13:52 +02:00
Tamás Zolnai
a86ddbb3ab cypress: mobile: fix-up this focus related test.
It's not an actual regression, but using clickFormulaBar()
method to move the cursor to a specific position is not
stable it seems.

Change-Id: I9abd470fd1f0f753181f3550df3b41384fa166dc
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93258
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-01 12:56:25 +02:00
Tamás Zolnai
39b00d3b84 cypress: disable various regressed test cases.
Change-Id: I316021a57e9bd3288138c1ac2e85af73d8efcf46
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93224
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-30 18:55:41 +02:00
Tamás Zolnai
4008c7120d cypress: don't run mobile and desktop tests in parallel.
With the recent mobile detection related changes having
mobile and dekstop tests running in parallel make the build
fail.

A related commit:
255d24ba8f

Change-Id: I69929b5dbd37298e27409d247a651c79f6dbe33f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93222
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-30 18:26:34 +02:00
Tamás Zolnai
91bcea3195 cypress: add eslint plugin files as a dependency of NPM installation.
So the build will update the plugin package after every change.

Change-Id: I687def1d29fe3acdd364b61c69ac1a7d3cf7cb84
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93115
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-29 06:58:14 +02:00
Tamás Zolnai
af76b48460 cypress: add a custom ESLint rule against cy.get().contains() usage.
Since cypress retries only the last command, it's better to use
the compact cy.contains(selector, content) version, instead of
cy.get(selector).contains(content) call.

Change-Id: Ie1f4c17bbf736058ecf6bd996b46384fdff19446
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93081
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-28 18:42:56 +02:00
Tamás Zolnai
0d5edfeb22 cypress: recently these two tests are failing randomly.
Change-Id: Ie45b10050ae6d985eb457096fb6bf7b3fcde34e7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93046
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-28 12:36:22 +02:00
Tamás Zolnai
fdf31909c9 cypress: remove some cy.wait() calls.
The helper functions were improved in the meantime.

Change-Id: Ie8ae8caf5b33567681010a7a0cfc45d2da061f8b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92973
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-04-27 15:33:17 +02:00
Tamás Zolnai
2732f33238 cypress: mobile: fix random failure in shape properties tests.
Change-Id: Icb531d97429c8f7abfc73ef01e31e09822faba43
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92964
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-27 11:13:17 +02:00
Ashod Nakashian
b6c9b3e20d cypress: Calc Formula-Bar tests
New tests to exercise the Formula-Bar in
both desktop and mobile modes.

Change-Id: Ibc174232f7b614132913c1d66af0051b51151a29
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91537
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-27 10:53:44 +02:00
Andras Timar
33000dfded typo fixes in comments and code
Change-Id: I6f31e050aab701e31064e1abc9429dce0a50c279
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92953
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-04-26 23:19:52 +02:00
Tamás Zolnai
3a13984b6b cypress: remove cypress-wait-until package.
We can use should method everywhere with a callback function
parameter. When there is no a specific item, which this should
is connected to we can use 'body' or any other existing item.

Change-Id: I3e1c5ca930b28304e886971ee50201d93a086b45
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92931
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-26 17:13:24 +02:00
Tamás Zolnai
9becac31e9 cypress: then(callbackFn) -> should(callbackFn)
It's better to use should, when we need an indicator.

Change-Id: I0f08c8862411e3c7627302bbda7b632b0bc0e15c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92930
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-26 14:44:29 +02:00
Tamás Zolnai
8a8a00b3a0 cypress: mobile: then(callbackFn) -> should(callbackFn)
It's better to use should, when we need an indicator.

Change-Id: I5d1fe825fdd6b20f98ce179c7cb6260ec0966928
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92918
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-26 12:07:38 +02:00
Tamás Zolnai
6f54cf0a28 cypress: mobile: cy.waitUntil() -> should(callbackFn)
We don't actually need cy.waitUntil() extension here,
becasue we can do that same check with should()'s special
usage.

Change-Id: I2b14afe84d2fa70f493aae873e3f1534540e96ea
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92917
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-26 11:09:11 +02:00
Tamás Zolnai
98e3994e6a cypress: add an own eslint config for the test code.
This parserOptions was added for cypress test so
move that into the tests' own config:
b2ec95dcfd

Change-Id: I3c565d212409cc01621eca97cd59ae7869d852cc
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92857
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-04-24 14:41:31 +02:00