After:
11b7270acd
Default zoom changed -> shape is insert to different
position -> geometry changed.
Change-Id: Ibeed3a57b3b64962951f11054f6aa3410a0e673d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89345
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Focus is not consistent around double taping.
Enable this check again when something is improved here.
Change-Id: I448d57a9fd053d1680352b6d6175f38f3dda33d9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89331
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
For incremental builds, it's not enough to check the node_modules
folder, we also need to check whether all used binaries are in
place.
Change-Id: I9c5f380f3845195bfa2dbfb03ab269ce4659c4ae
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89233
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
When we open a new panel in the mobile wizard the new
content appears after a short animation.
I suspect that this animation makes tests to fail sometimes
with 'detached from DOM' error. Waiting the end of the animation
seems help on this issue.
Change-Id: Ie9cc322ff9bd9a6287b4d57126e6afab91a98713
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89107
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
First issue was rendering the mobile wizard twice by
opening. I added a workaround for this issue:
20b5825ce5
The second issue was with the animation when moving
one level down in the mobile wizard. Checking the next
level content makes these tests more stable.
Change-Id: I3f3c90e5975747f833e9560140cabb6c310dfe57
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89087
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
pkill uses SIGTERM signal by default, which is good because
using that makes loolwsd to clean up things before shut down.
For example it removes the pid file.
However, when loolwsd stuck for any reason, then SIGTERM might
not be effective. In this case use SIGKILL.
Change-Id: I3ed4bd24d6e73169b4d04dd7c9b4ac03bee8fdd1
Without waiting for the mobile wizard to be opened
the not exist check will allways pass no matter
whether the items are actually hidden or not.
First we need an indicator that the mobile wizard
is opened and then we can check whether the removed
styles items are not there.
Change-Id: I00c1aaf6e11351cf8714be3ed6d5b9d2ff000324
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89074
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Also hide calc style panel for now: incomplete.
Change-Id: I46fee97f5d029860a12e5f7215d830091c5f9bf0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89068
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
There is no an obvious reason for this issue and also
I can't reproduce this issue locally.
Change-Id: I6860fa878ebafd9deab92b2662c352a99ab85b52
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89071
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
There is no focus any more after selecting the
table, so we need to use a different method for
moving the cursor in the first cell.
Change-Id: I9d03337d7cb710224a892472f0989896d2e03024
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88971
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Use en-US locale. In the tests of date / time fields
the date format contains the locale, which was set to en-US
originally.
Change-Id: Ida56dd8a3e64b0c81d70d010f3aabf40da7d73a0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88620
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
My browser is Spanish by default
Change-Id: I2f3a2aaf7a6b0856c778dc9b943e23f8c168a394
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88568
Tested-by: Henry Castro <hcastro@collabora.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
One tap on a shape does not move the focus on the document
since this commit:
9fcd4d3777
Change-Id: I5d176be7c5dd8296c642c41b8d1e2fcf5945ab27
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88521
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
To achive a better test covarage.
Now, the simple click() method is recognized
as 'tap' by hummerjs. For long press we need
to use low level events.
I expect that we can emulate other mobile events too
on a similar way.
Change-Id: I5f43afafe087133e707eed6ff8a43765324d5e24
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88161
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
And disable some failing tests for core/master.
No idea why these items are missing from paragraph
panel with core/master. Seems a regression from cp-6-2
to master.
Change-Id: Ia91f38cbcf74d0b45730c8643559c298376ae153
It opens a tunneled dialog, what we try to avoid on mobile.
Also after the recent focus related changes this dialog
can't get the focus, so can't add the name of the new style.
Even if I workround this focus issue and I manage to add a new
style, then that style won't be part of the style list displayed
on the mobile wizard.
All in all adding new style does not work now, so better to hide
this item.
Change-Id: I35c3686129621656f3f63914c9590248f320c15d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87965
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
In a desktop LO, this item opens a drop down list,
which seems to be not implemented in online yet.
Change-Id: Ia9d82cf9a058a43077043dc128dbbc16f18da83a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87772
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
This item triggers the character dialog, which we should
avoid on mobile. In a desktop LO, this item opens a drop
down list, which seems to be not implemented in online yet.
Change-Id: I56a584e6665184c4242cddc4e78ba849a150c711
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87771
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Use the clipboard code to generate the HTML of
the selected text, so we can check the font properties
in the document.
Change-Id: I43e5325b7fe0a9fda073c43335231e014374d6c2
Removing the cypress_test subdir from top level
folder made the packaging process to fail.
So better to use a flag to enable cypress tests.
Change-Id: Iead4b7cbbea5c6aaba18c0b85f23d67a4fbe920b
Mobile wizard was changed in the meantime.
Change-Id: Ic4813b10f946e58878bbc2dd926570e2e712606a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87212
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
This checks whether all statements end with a semicolon.
We already use this rule in the code, so I enable to check
this rule by eslint to keep the code consistent.
Change-Id: I5ea46376d2b6fb488224d4d69e4d117139763a8c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87154
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Use the wait-on npm module for this.
Change-Id: I602f95aa79d46cf7b55bcc598e612bbc5342c52b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87150
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Use loleaflet's config file to have the same
conventions under cypress_test folder too.
Update test code to pass esling check.
Change-Id: Iade932e6d3cd8941b5fc0897c56c68d2493f0dce
