Fix some issues it found and disable the following checks for now. Some
of them needs module support to work and some of them needs project
compilation using tsc rather than per file compilation.
cypress_test/ extends loleaflet's eslintrc so, its package.json needs to
have the typescript lint plugin as well.
Disabled checks:
@typescript-eslint/no-unused-vars // This can be enabled after fixing
all places it finds.
@typescript-eslint/no-inferrable-types // Lets do explicit typing
whenever we can.
no-var // This needs a lot of conversion of var to let.
@typescript-eslint/no-explicit-any
@typescript-eslint/no-namespace // ES5 has no module support
no-inner-declarations // ,,
no-constant-condition // This is sometimes useful
@typescript-eslint/triple-slash-reference // ES5 no module support.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: Ib4fd8b4fcee42216d4322fd043a1873302db375a
- split helper method for loading document into 2 pieces
because in case of interactive dialogs on doucment load
we need to perform some action before we can check if document
is already loaded
Change-Id: If6caf2168498a6d185c4a5199cf4b10b32ca23b7
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Now we hide selection handlers while typing due to
not being able to use them, these tests fail to find
rotation marker. When text is found on mobile selection marker
wraps the found text and they become visible. when not found they
become hidden again. Checking the selection marker for this test cases
should be enough.
Change-Id: I6037450bc17438e4819ae3b724849f74f26910d4
Signed-off-by: mert <mert.tumer@collabora.com>
For calc we have 5 svg nodes inside the overlay pane (fixed, top-left,
top-right, bottom-left, bottom-right). The shape selections will be in
all panes except the 'fixed' pane. The 'fixed' was used to contain the
split/freeze lines but that got moved to canvas. Before this patch the
'fixed' svg was getting selected by the selector...
'.leaflet-pane.leaflet-overlay-pane svg'
...which is empty in this case. Lets always select the bottom-right one
which is covers the whole view area when there aren't any active freezes.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: Iea2bbeff3c492a82e75ecdeb1aa70fa3c33f3426
but in a dedicated div inside the canvas container div, covering the
canvas.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: Ie43a4cb98c9cdb7e3ca81faa78bcc2419fa90a32
Some tests were relying the cursor position for checking the document
dimensions. Those code lines are removed from the tests.
Document size is not able to checked from html elements. Instead, a unit
test may be prepared for that task.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Idd4fd52656b2969bf0bfa9534a807a7a8bd3f987
php-proxy slows down things and make it visible, that
cellA1Bounds and cellC3Bounds can be initialized to the same
value. So let's wait fo the cell cursor to be updated before
we set the cellC3Bounds value. Changed the toString() function
to exactly match with the json in the overlay items' text attribute.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Idde0f516ff568cb14b5d53224fd75ebc6167abe9
In the cypress.json we configure retries for headless mode only,
however when we run 'cypress run' with 'headed' flag we still have
retries, that we would like to avoid for consistency.
Cypress differentiate modes based on the command: e.g. 'cypress open' or
'cypress run'. We however differentiate based on headless or headed mode,
whether we run the test in an opened browser or in the background.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ib34ac3de105dfe410116019e3c3c2afe253636f2
We always have a cell selected, so we can move the cell
cursor left and right anyway.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I11c255bd38fb927652c9afd2f111ce9e2acce103
Using autofill marker as an indicator is not that reliable,
because it's missing by document load. The cell cursor overlay
however is always there.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I87e92efe78d492b3c66fb04e3b2ca25d4f122584
cypress video recoring does not work when we have two cypress
instances at the same time.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ib807a001aa497ec9c7ef98df4f8f40236890879c
Currently only the cell-cursor and document selections are part of the
canvas overlay. The others are still part of svg layer.
For now only the bounds of the canvas-overlay items are asserted. The
canvas overlay items update their bounds data as JSON text on cypress
only divs inside the overlay section div every time there is any change.
Unlike cell cursors, the selections need not be always a single
rectangle. To add tests for the more general cases, the json format of
test data is helpful.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I70e6328116c44317f31deb9c8bea62e781d8c421
Workdir folder is for the build system, and for copies
of data files. cypress folder it for output of tests, like
videos, screenshots, cypress logs. So let's put wsd related
logs here too.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Icdb757d50d3c2bfef6013b92055b49ba222193e2
To make workdir structure easier to understand.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I1d0d8a16bd12cf9fc9abf9d350509f20ad322a7a
It can be confusing to have the same error message twice.
This reverts commit 6786f563f8.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I66f0495262fc5e5c0a228fdfc417e2e3301ad03e
This assertion is triggered by interference testing:
make check-interfer-desktop spec=calc/tunneled_dialog_spec.js
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ib16c97d7c45192a493720d028f38eb5efba4346f
To avoid issues coming from the delayed autosave.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ib98b35396efb4fdfdf84846dd23619c666accbdb
