So we have separate canvasShouldBeFullWhite() and
canvasShouldNotBeFullWhite() methods, which might make
the code more readable, then having it controlled by
a bool parameter.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I0932a7615c84c35293c2cc8dade0db6468de8224
So we have separate imageShouldBeFullWhite() and
imageShouldNotBeFullWhite() methods, which might make
the code more readable, then having it controlled by
a bool parameter.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I2ada6b9e6f6d93b8a48e9ddd3c851ef3e6fcd632
By now, we don't run the same online branch against more
core branches, so this code is obsolete.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I90768d16628e735129880cc4cf823bf0b7d9ad1e
We use this method in various contexts, where it's not
necessary that we have the cursor of the focus. Focus can
be tested in focus related tests.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ic27de45917657d4ac1734565d81d5bbf190ad333
It does not work when two cypress instances running at the
same time.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Iae7fe4c4dcc4bb0a970763001e4f966b60f988f2
It's not necessary to have any text in the first cell, so
double click won't work for every test document. However the
spreadsheet is always there so we can move the cursor through
the different cells.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Icea63a971fb77d915e027569a80c9a8a8b855a01
This reverts commit 129ae61684.
This is actually undefined, whether the cell cursor would be there
or not. We get cell cursor messages after loading the document,
so if we step into editing mode before these messages, then we
will have the cell cursor, but if we wait some seconds after
opening the document, then the cell cursor won't be displayed.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I7a4e9e5adbbbe312f21789fe872726bbf67565e6
There is no more span inside the HTML representation
of a text field. After this commit:
b982d0e6f94ca70765231ff4242c829f5bec5def
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ic64a20dcb0534876af062a1fb40cb0e39fd27f10
CanvasSectionContainer has now capability of creating divs below sections, for testing.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ia735758ce27af558718da50935502723112e838e
It causes an issue for calc to use cypress's dblclick() method
and it will select the wrong cell. In the log, I see only a
double click when we simulate user events with cypress, however
when I do double click manually, first I see a single click and
then a double click in the log. So let's do the same with cypress
simulation too.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I18e92fc354558e09bb5cb3a12e45cbb669ac97bc
Visibility of the blinking cursor is not good enough
on dekstop, beacuse it changes position after it is
displayed. So let's wait some time to step cell editing
mode.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I86fe7fd5be68f36126ba3d390b29740b33cf3d8e
So we can specify which cursor we need here. The default is
the document cursor, but this methods can be used for
formulabar cursor or dialog cursor too. More cursors might
exists at the same time, that's why simple '.blinking-cursor'
selector does not work.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I1fd04e188ab53e70d0e8303fd7502f183c18bef3
We have a dummy spreadsheet document with a column of cells each in a
different font size. The font size of the current cell is displayed in
the sidebar.
In the test we step through the cells first downwards and then back.
Thus the sidebar image that contains the font size will be updated as
we step through the cells. At first nothing will be found in cache,
but when returning, the images should be found in the cache. If the
cache in the JS client is not consistent with that in the server we
will throw an exception.
Change-Id: I439263c7923d985679fafa0125cd2d7f635e0995
Signed-off-by: Tor Lillqvist <tml@collabora.com>
It's a useful option to create a video during headless run.
It's much closer to the headless build wrt. timing, than
interactive test runner.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ic9889209ac07b9fe0a9b6e326e60513412950780
In master view, the 'Master Slide' list should be empty and so it's
not shown on mobile wizard. No, I disable this test, because
it needs the core code to be updated.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I12562c453673ac85e050303ebb5803fee6f1892a
It fixes a hang related to retries. It might be useful
in our case too. I've seen hangs on Jenkins, which might be
related.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I8320f9b38c59074d2b5dd3d7b0cad0c5828b0849
It crashes if the mobile wizard is closed before exiting
chart editing mode.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I47143543220aaebf474e1d1aa560c7df2c2a14f5
We had an issue with loading two views to the same document
at the same time.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I8b1ba92eca5e59bfa50cbcd637f1076d5e15c664
This reverts commit f6bf6f49ed. I did not
consider that this makes it harder to do a local developer setup with
reverse proxy + make run; also that if you don't read the doc to set up
a reverse proxy, then the default now serves http content and advertises
https, which is not helping sysadmins.
This needs more thinking how to improve one scenario without hurting
others.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Ic789faa2dc5bb19a79d651dc81d4eaaf0b48607a
Before this commit failure logs were gathered inside an error log
file and they were displayed after all tests are finsihed.
After this commit we print this failures logs when the error occurs
and also at the end of the test run. Sometimes Jenkins does not finish
the whole build because of timeout abortion. In this case, it would
be helpful to see some failure logs.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ibe7cb6aa2c9f99912d604c4b642cda363352ffcd
cy.click() will grab the focus to the textarea.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I20f0df2fd8a31d3ff4b85ba38fdc503c10987dbb
The intention is to have defaults which are close to how people
typically use Online in production.
However, keep using ssl for 'make run', so that the https environment in
the browser is unchanged.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I7fd725a83b0e9ca1012f2c0e0c3bf038e5fa0059
Now we have it in the general calc helper file.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Id7f12441b9612a630f6b348a9e6db6235f4b6c45
By now 'make check-mobile' and 'make check-desktop' commands
are not supposed to run in parallel. So 'make check-mobile -j3'
won't run mobile tests in parallel (three tests at once).
However, before this commit running these make rules with more
jobs, led to build failure. With this commit the build does not
fail, but still ignores the jobs and run the tests on a single job.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I13e13fdefcfb393ae5a42b4e065bbfe00278236a
It's a bug in the application. Let's workaround it,
until it is fixed.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I213a75816b5ba71e526d7b3fc616a454b7968e27
View also jumps with cursor movement, so we can't be
sure that the vertical/horizontal pozition actually
increase / decrease. Better to test only that the position
was changed.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I2358348c3f6d4f2278eff4e2db4a8409bc86b25a
Test code needs an update because .should('not.be.visible')
does not pass on non existing elements anymore.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: If8a89d2996d154d287672dacb3668ec5399d99f2
Now we handle support file better for parallel test run too:
a13b1a93bc
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I4a88f815ddb1c4d79042134cc07e0c418d4ea10f
So we can catch crashes / debug messages of core code.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ib11426e7fdd8f219be4715b3f1e2983ad33d7f2b
When we run cypress tests in parallel (e.g. make check -j4), the
tests randomly fail with an uncaught error. The issue might be
because the same support file is shared between the different threads,
and they might access it at the same time. We try to create different
instances of the support file via preprocessing. Let's see whether it
makes the issue go away.
Issue's error message was:
"An uncaught error was detected outside of a test:
SyntaxError: The following error originated from your test code, not from Cypress.
Unexpected end of input"
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I7b256cd686fb2b0e79ab602e95d197388a5aadca
I see some random test failures:
"An uncaught error was detected outside of a test:
SyntaxError: The following error originated from your test code, not from Cypress.
> Invalid or unexpected token"
There is no backtrace or code pointer or anything to find out
what is the actual problem, but it might be related the missing
import of 3rd-party code.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ia2243852e825eee18c226d89fd17e92960daa129
We get syntax error from outside cypress test code.
It might be one of the 3rd-party packages. Revert wait-on
package to a previous version and let's see whether the
issue goes away or not.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I902536fd7124ebaca58a3491400606c89e5e7483
It works now, to run the same test twice.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I0e288049aad42b9534ce3743c6d5a8d4a22bf926
We need to wait until the layout change changes also
the cursor position, and then we can select the
table.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Id66606e0992f3b298f656567d38753263ef29ab5
moveCursor follows the event-indicator rule,
which makes it more stable.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ief6e6c4d3a058c95652113229fd0ecbb65fb3e48
Add a modifier parameter, so we can easily extend this
code with 'shift' modifier later.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I820c2c89838ba2a367d561e362d3c04f8487022e
I've seen some inconsistencies related to cursor
movements in the existing cypress tests. I added
these tests which checks cursor behavior directly,
which might help to find out the issue with cursor
handling.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: If158ccef359bb28ade8d7336594fdafdd46868f4
